Re: [PATCH wayland] cursor: add wl_cursor_frame_and_duration

2015-03-04 Thread Pekka Paalanen
On Wed, 4 Mar 2015 14:30:41 -0600 Derek Foreman wrote: > It's useful to know how long the current cursor frame should be displayed > so we can wait that long to change it. > > Signed-off-by: Derek Foreman > --- > differences from v1: > Add comment about 0 durations > document return of 0 dur

Re: [PATCH] weston: Add weston rendering performance log

2015-03-04 Thread Pekka Paalanen
On Fri, 6 Feb 2015 17:52:06 +0800 Quanxian Wang wrote: > With PERF_DEBUG is enabled, the performance log will be recorded > for every key rendering path. > > At the same time, with a tool provided, performance chart of weston apps > could be generated. > > This patch provides following changes

[PATCH libinput 1/2] tablet: copy distance axis for the mouse/lens cursor devices

2015-03-04 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 8c11409..3e3924c 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -639,6 +639,7 @@ tool_set_bits_from_libwacom(const struct tablet_disp

[PATCH libinput 2/2] doc: document recommended handling of fake proximity events in the caller

2015-03-04 Thread Peter Hutterer
Fake proximity events are context dependent and libinput doesn't have access to the context. For example, fake proximity on the Wacom mouse is only required in relative mode - but whether to use relative or absolute events is decided in the caller. Document what the recommended approach is since i

Re: [RFC : xdg_surface_present() - take 2

2015-03-04 Thread Bill Spitzak
On 03/03/2015 04:25 PM, Manuel Bachmann wrote: Hi Bill, and thanks a lot for your comments, "What about "raise"?" I think the issue with "raise" was the same that with "set_unminimized" or "activate" ; it gives the false impression that the surface will consistently be brought to the foregrou

Re: [PATCH libinput] Extend the touchpad gesture API with zoom/rotate gestures

2015-03-04 Thread Peter Hutterer
On Wed, Mar 04, 2015 at 03:26:30PM +0100, Hans de Goede wrote: > Extend the touchpad gesture API with zoom/rotate gestures. Note that this > new API offers a single event stream for both zoom and rotate data, this > is deliberate as some applications may be interested in getting both at > the same

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-04 Thread Peter Hutterer
On Tue, Mar 03, 2015 at 12:29:28PM -0500, Benjamin Tissoires wrote: > On Mon, Mar 2, 2015 at 10:29 PM, Benjamin Tissoires > wrote: > > On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer > > wrote: > >> If a tool is in proximity when we init, send a proximity event immediately. > >> > >> This is only

[PATCH weston] window: Fix crash in input_set_pointer_image when cursor is special

2015-03-04 Thread Derek Foreman
Certain circumstances may lead to the "force" clause in input_set_pointer_image() being reached when the current cursor is blank or unset. These are special cursors that don't have images, and they need to be handled differently than image cursors. This patch puts the special cursor handling in i

[PATCH wayland] cursor: add wl_cursor_frame_and_duration

2015-03-04 Thread Derek Foreman
It's useful to know how long the current cursor frame should be displayed so we can wait that long to change it. Signed-off-by: Derek Foreman --- differences from v1: Add comment about 0 durations document return of 0 duration as unchanging image make sure duration calculation doesn't wrap aro

[PATCH v2 wayland] cursor: add wl_cursor_frame_and_duration

2015-03-04 Thread Derek Foreman
It's useful to know how long the current cursor frame should be displayed so we can wait that long to change it. Signed-off-by: Derek Foreman --- differences from v1: Add comment about 0 durations document return of 0 duration as unchanging image make sure duration calculation doesn't wrap aro

Re: [PATCH wayland] cursor: add wl_cursor_frame_and_duration

2015-03-04 Thread Derek Foreman
On 04/03/15 01:50 AM, Pekka Paalanen wrote: > On Tue, 3 Mar 2015 15:24:13 -0600 > Derek Foreman wrote: > >> It's useful to know how long the current cursor frame should be displayed >> so we can wait that long to change it. >> >> Signed-off-by: Derek Foreman >> --- >> >> In a follow up weston p

Re: [PATCH weston 2/4] compositor: add weston_view_set_mask() API and state

2015-03-04 Thread Pekka Paalanen
On Wed, 04 Mar 2015 08:23:07 -0600 Derek Foreman wrote: > On 04/03/15 03:52 AM, Pekka Paalanen wrote: > > On Tue, 03 Mar 2015 16:50:47 -0600 > > Derek Foreman wrote: > > > >> Minor pedantry below. > >> > >> On 02/03/15 09:15 AM, Pekka Paalanen wrote: > > > > Are you happy with the explanations

[PATCH libinput] Extend the touchpad gesture API with zoom/rotate gestures

2015-03-04 Thread Hans de Goede
Extend the touchpad gesture API with zoom/rotate gestures. Note that this new API offers a single event stream for both zoom and rotate data, this is deliberate as some applications may be interested in getting both at the same time. Applications which are only interested in one or the other can si

Re: [PATCH weston 2/4] compositor: add weston_view_set_mask() API and state

2015-03-04 Thread Derek Foreman
On 04/03/15 03:52 AM, Pekka Paalanen wrote: > On Tue, 03 Mar 2015 16:50:47 -0600 > Derek Foreman wrote: > >> Minor pedantry below. >> >> On 02/03/15 09:15 AM, Pekka Paalanen wrote: > > Are you happy with the explanations? > I fixed all the typos, and will push if you are. :-) Sure, feel free to

Re: [PATCH libinput 1/7] test: disable tapping for pure motion tests

2015-03-04 Thread Hans de Goede
Hi, On 04-03-15 05:18, Peter Hutterer wrote: No effect, all devices currently have tapping disabled. Signed-off-by: Peter Hutterer Then entire series looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans --- test/touchpad.c | 6 ++ 1 file changed, 6 insertions(+) di

Re: [PATCH weston 4/4] gl-renderer: implement view scissor

2015-03-04 Thread Pekka Paalanen
On Tue, 03 Mar 2015 17:02:29 -0600 Derek Foreman wrote: > Some minor pedantry below as well, but otherwise the whole series is > > Reviewed-By: Derek Foreman > > On 02/03/15 09:16 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Implement support for weston_view_set_mask(). > > >

Re: [PATCH weston 2/4] compositor: add weston_view_set_mask() API and state

2015-03-04 Thread Pekka Paalanen
On Tue, 03 Mar 2015 16:50:47 -0600 Derek Foreman wrote: > Minor pedantry below. > > On 02/03/15 09:15 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Add API for setting a clip ('scissor' in the code) rectangle per view, > > in surface coordinates. Ivi-shell requires this feature to

Re: [PATCH weston] window: use wl_cursor_frame_and_duration() for mouse cursor updates

2015-03-04 Thread Pekka Paalanen
On Tue, 3 Mar 2015 15:26:30 -0600 Derek Foreman wrote: > Instead of a frame callback we can now use a timerfd and the time > left in the current cursor frame. This saves us from setting > the cursor at 60hz even when no updates are required. > > Signed-off-by: Derek Foreman > --- > NOTE: this