Re: [PATCH wayland] protocol: Change wording of subsurface placement scheduling

2015-03-03 Thread Jonas Ådahl
On Wed, Mar 04, 2015 at 09:33:45AM +0200, Pekka Paalanen wrote: > On Tue, 3 Mar 2015 15:55:37 +0800 > Jonas Ådahl wrote: > > > Change wording to be more consistent with other parts of the subsurface > > protocol. Before this change, wl_subsurface.set_position explicitly > > stated that the new s

Re: [PATCH wayland] cursor: add wl_cursor_frame_and_duration

2015-03-03 Thread Pekka Paalanen
On Tue, 3 Mar 2015 15:24:13 -0600 Derek Foreman wrote: > It's useful to know how long the current cursor frame should be displayed > so we can wait that long to change it. > > Signed-off-by: Derek Foreman > --- > > In a follow up weston patch I use this to let toytoolkit set the cursor > with

Re: [PATCH wayland] protocol: Change wording of subsurface placement scheduling

2015-03-03 Thread Pekka Paalanen
On Tue, 3 Mar 2015 15:55:37 +0800 Jonas Ådahl wrote: > Change wording to be more consistent with other parts of the subsurface > protocol. Before this change, wl_subsurface.set_position explicitly > stated that the new state was to be applied on the parents > wl_surface.commit and wl_subsurface.

[PATCH libinput 7/7] touchpad: enable tapping by default on buttonless touchpads

2015-03-03 Thread Peter Hutterer
This affects the touch device on graphics tablets. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-tap.c | 18 +- test/touchpad.c | 20 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/evdev-mt-touchpad-tap.c b/src/evdev

[PATCH libinput 5/7] test: add a Wacom Intuos 5 Finger test device

2015-03-03 Thread Peter Hutterer
Works as a touchpad but has no buttons. Minor change to one of the touchpad tests: because the touch area is so big the slow-scrolling trigger needs to be adjusted. And because the device is an external device, the "disable on external mouse" test needs to be adjusted. Signed-off-by: Peter Hutte

[PATCH libinput 1/7] test: disable tapping for pure motion tests

2015-03-03 Thread Peter Hutterer
No effect, all devices currently have tapping disabled. Signed-off-by: Peter Hutterer --- test/touchpad.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index b70d373..d1f1257 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -38,6 +38,9 @@ START_

[PATCH libinput 2/7] test: split 3-finger tap-and-drag test

2015-03-03 Thread Peter Hutterer
Split out into a btntool test and a true three-finger test. For consistency, check the number of slots on all those tests rather than having litest-device-specific exclusions. Signed-off-by: Peter Hutterer --- test/touchpad.c | 67 + 1 file

[PATCH libinput 6/7] touchpad: don't warn about clickpads without left buttons

2015-03-03 Thread Peter Hutterer
Clickpads have BTN_LEFT but no BTN_RIGHT, non-clickpads must have both. Tablet touch devices don't have any buttons, so skip the warning for those. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev-

[PATCH libinput 3/7] test: add a button requirement to a couple of touchpad tests

2015-03-03 Thread Peter Hutterer
If we send BTN_LEFT or similar, we need the LITEST_BUTTON capability on the device. Signed-off-by: Peter Hutterer --- test/touchpad.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 627d64a..246d07a 100644 --- a/test/touchpad

[PATCH libinput 4/7] test: enable tapping before verifying correct tap events

2015-03-03 Thread Peter Hutterer
These tests make sure we don't get tapping events in certain situations (finger movement, timeouts, ...). Tapping must be enabled for that to be a valid test. The tests can't work on semi-mt devices because we can't end slots independently. Disable the tests there. Signed-off-by: Peter Hutterer

Re: [RFC : xdg_surface_present() - take 2

2015-03-03 Thread Manuel Bachmann
Hi Bill, and thanks a lot for your comments, "What about "raise"?" I think the issue with "raise" was the same that with "set_unminimized" or "activate" ; it gives the false impression that the surface will consistently be brought to the foreground (whereas it depends on many things, and will in

Re: [PATCH weston 4/4] gl-renderer: implement view scissor

2015-03-03 Thread Derek Foreman
Some minor pedantry below as well, but otherwise the whole series is Reviewed-By: Derek Foreman On 02/03/15 09:16 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Implement support for weston_view_set_mask(). > > Signed-off-by: Pekka Paalanen > Reviewed-by: Nobuhiko Tanibata > Tested-by

Re: [PATCH weston 2/4] compositor: add weston_view_set_mask() API and state

2015-03-03 Thread Derek Foreman
Minor pedantry below. On 02/03/15 09:15 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Add API for setting a clip ('scissor' in the code) rectangle per view, > in surface coordinates. Ivi-shell requires this feature to be able to > implement the IVI Layer Manager API, which includes clippi

[PATCH weston] window: use wl_cursor_frame_and_duration() for mouse cursor updates

2015-03-03 Thread Derek Foreman
Instead of a frame callback we can now use a timerfd and the time left in the current cursor frame. This saves us from setting the cursor at 60hz even when no updates are required. Signed-off-by: Derek Foreman --- NOTE: this requires a wayland change I just posted... clients/window.c | 124 +++

[PATCH wayland] cursor: add wl_cursor_frame_and_duration

2015-03-03 Thread Derek Foreman
It's useful to know how long the current cursor frame should be displayed so we can wait that long to change it. Signed-off-by: Derek Foreman --- In a follow up weston patch I use this to let toytoolkit set the cursor with a timerfd instead of using a frame callback. cursor/wayland-cursor.c |

Re: [RFC : xdg_surface_present() - take 2

2015-03-03 Thread Bill Spitzak
- Pekka Paalanen pointed out the request name was unclear and suggested to use "xdg_surface_needs/wants_attention()" instead. Jasper St. Pierre pointed out that "_NET_WM_STATE_DEMANDS_ATTENTION" already existed in X11 and does not do the same thing. We discussed that again yesterday and thought

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Bill Spitzak
This is my suggested alteration of the patch to allow 3 arguments, there is a * in front of my changed or added lines: - if (argc != 2) * +if (argc < 2 || argc > 4) usage(EXIT_FAILURE); else if (strcmp(argv[1], "help") == 0 || strcmp(argv[1], "--help") == 0)

Re: [PATCH weston] compositor: don't have the backend libraries switch vt

2015-03-03 Thread Giulio Camuffo
Duh, ignore this one. I sent it by mistake, it depends on libweston. 2015-03-03 21:21 GMT+02:00 Giulio Camuffo : > A compositor may want to handle the vt switches itself, for example > to ensure to have a lock screen before switching. To enable that move > the key bindings for the vt switch in the

[PATCH weston] compositor: don't have the backend libraries switch vt

2015-03-03 Thread Giulio Camuffo
A compositor may want to handle the vt switches itself, for example to ensure to have a lock screen before switching. To enable that move the key bindings for the vt switch in the common weston code and add a generic API in libweston to switch vt. --- Makefile.am| 2 +- src/compositor

Re: [PATCH v2 libinput] tablet: sync tools already in proximity at startup

2015-03-03 Thread Benjamin Tissoires
On Mon, Mar 2, 2015 at 10:29 PM, Benjamin Tissoires wrote: > On Mon, Mar 2, 2015 at 7:59 PM, Peter Hutterer > wrote: >> If a tool is in proximity when we init, send a proximity event immediately. >> >> This is only partially reliable due to the current kernel behavior: >> * if the tool comes int

Re: weston build on older linuxes, where CLOCK_BOOTTIME is not available. trivial patch attached.

2015-03-03 Thread Daniel Stone
Hi, On 3 March 2015 at 14:02, Pekka Paalanen wrote: > On Thu, 26 Feb 2015 00:12:32 + > Volker Eckert wrote: >> i can successfully build weston on debian 7 (kernel 3.2.0-4, glibc 2.13-38), >> if i make the use of CLOCK_BOOTTIME conditional on its availabilty (see >> patch). this might also

Re: weston build on older linuxes, where CLOCK_BOOTTIME is not available. trivial patch attached.

2015-03-03 Thread Pekka Paalanen
On Thu, 26 Feb 2015 00:12:32 + Volker Eckert wrote: > hi all, > > i can successfully build weston on debian 7 (kernel 3.2.0-4, glibc 2.13-38), > if i make the use of CLOCK_BOOTTIME conditional on its availabilty (see > patch). this might also apply on other older systems (certainly centos

Re: [PATCH weston 1/3] compositor,shell: move debug key code to core

2015-03-03 Thread Pekka Paalanen
On Mon, 2 Mar 2015 08:46:51 + Daniel Stone wrote: > Hi, > > On 2 March 2015 at 08:33, Pekka Paalanen wrote: > > The code for the key binding that triggers debug key bindings, that is, > > the code that makes mod+SHIFT+SPACE work, used to live in shell.c. I > > want to make the debug key bin

Re: Possibilities for a VR compositor

2015-03-03 Thread Pekka Paalanen
On Sun, 1 Mar 2015 08:12:07 +0100 Max Jensen wrote: > Hi, > > With the Oculus Rift and Valve also likely showing its own VR-headset next > week at GDC I expect VR to be a big thing in the coming years. Fortunately > Wayland seems to be quite suitable for creating a VR desktop, there is > already

weston build on older linuxes, where CLOCK_BOOTTIME is not available. trivial patch attached.

2015-03-03 Thread Volker Eckert
hi all, i can successfully build weston on debian 7 (kernel 3.2.0-4, glibc 2.13-38), if i make the use of CLOCK_BOOTTIME conditional on its availabilty (see patch). this might also apply on other older systems (certainly centos 6.5 is affected) and in terms of portability it probably makes sens

Possibilities for a VR compositor

2015-03-03 Thread Max Jensen
Hi, With the Oculus Rift and Valve also likely showing its own VR-headset next week at GDC I expect VR to be a big thing in the coming years. Fortunately Wayland seems to be quite suitable for creating a VR desktop, there is already this: https://www.youtube.com/watch?v=Dgtba_GpG-U However, I thi

[PATCH 3/3] Introduce WAYLAND_SERVER_SOCKET_DIR to change socket directory without changing XDG_RUNTIME_DIR. This might be useful to change socket directory in case wl_display_add_socket_auto is used.

2015-03-03 Thread Davide Bettio
Signed-off-by: Davide Bettio --- src/wayland-server.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 05e9c07..2922e41 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1093,9 +1093,12 @@ wl_so

[PATCH 1/3] Extend WAYLAND_DISPLAY and name parameter semantics to support absolute paths. For example WAYLAND_DISPLAY="/my/path/wayland-2" or connect_to_socket("/my/path/wayland-2").

2015-03-03 Thread Davide Bettio
Signed-off-by: Davide Bettio --- doc/man/wl_display_connect.xml | 8 src/wayland-client.c | 22 +- src/wayland-server.c | 23 ++- 3 files changed, 39 insertions(+), 14 deletions(-) diff --git a/doc/man/wl_display_connect.xml b

[PATCH 2/3] Introduce WAYLAND_SERVER_SOCKET to change the path where the server will create the socket. It will be possible for a nested compositor to offer a socket located on WAYLAND_SERVER_SOCKET p

2015-03-03 Thread Davide Bettio
Signed-off-by: Davide Bettio --- src/wayland-server.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index eefbe35..05e9c07 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1216,9 +1216,9 @@ wl_display_add_so

Re: [PATCH 2/2] Fix trivial memory leaks

2015-03-03 Thread Pekka Paalanen
On Sat, 21 Feb 2015 01:07:38 +0900 Ryo Munakata wrote: > Signed-off-by: Ryo Munakata > --- > desktop-shell/shell.c | 2 ++ > src/compositor-x11.c | 2 ++ > xwayland/launcher.c | 2 ++ > 3 files changed, 6 insertions(+) Huh, I wonder why this didn't appear in Patchwork. > > diff --git a/de

Re: [PATCH 1/2] compositor: fix a memory leak of struct process_info

2015-03-03 Thread Pekka Paalanen
On Sat, 21 Feb 2015 01:07:37 +0900 Ryo Munakata wrote: > Cleanup functions of weston clients are never called > after wl_display_run(), so that some of process_info of clients will not be > freed. > > Signed-off-by: Ryo Munakata > --- > src/compositor.c | 24 +--- > src/co

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Hardening
Le 03/03/2015 09:11, Pekka Paalanen a écrit : > On Mon, 2 Mar 2015 16:08:00 +0200 > Jussi Pakkanen wrote: > >> Add support for direct file reading and writing in wayland-scanner. >> >> Signed-off-by: Jussi Pakkanen >> >> --- >> src/scanner.c | 26 +- >> 1 file changed,

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Pekka Paalanen
On Mon, 2 Mar 2015 16:08:00 +0200 Jussi Pakkanen wrote: > Add support for direct file reading and writing in wayland-scanner. > > Signed-off-by: Jussi Pakkanen > > --- > src/scanner.c | 26 +- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/src/sc