On Wed, 25 Feb 2015 13:03:46 -0800
Bryce Harrington wrote:
> > --- a/src/compositor.c
> > +++ b/src/compositor.c
> > @@ -1078,22 +1078,21 @@ weston_view_assign_output(struct weston_view *ev)
> > }
> >
> > static void
> > -view_compute_bbox(struct weston_view *view, int32_t sx, int32_t sy,
> >
We don't have real support for them yet but they have the ID_INPUT_TABLET tag
set. Ignore them explicitly before someone thinks they're already working.
Signed-off-by: Peter Hutterer
---
src/evdev.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/src/evdev.c
Require a tool to be moved into proximity before we handle any events from it.
This requires the user to lift the tool for first use but a tool that's
already on the tablet on init is likely to send garbage anyway and interfere.
This way users can leave the mouse/pen on the tablet overnight and the
Signed-off-by: Peter Hutterer
---
Changes to v2:
- delta was stored in tablet->axes[a], causing a wrong axis_value and a
wrong axis_delta. which the test didn' catch because it didn't trigger.
fixed now, store the wheel value in deltas and leave axes at 0
src/evdev-tablet.c | 56 +++
Providing a relative axis in the axis_get_value() is inconsistent with the
other axes, this will be fixed in a follow-up commit.
Signed-off-by: Peter Hutterer
Reviewed-by: Benjamin Tissoires
---
Changes to v1:
- s/break/continue/ in tablet_check_notify_axes
- move the mouse wheel test into a sep
Signed-off-by: Peter Hutterer
---
New patch, I had to re-do the test because it never actually triggered. So
rather than complicated rebasing, this is the final test with everything
including discrete values.
New test sends more than one wheel event and then a couple of axis events
after to make
On Wed, Feb 25, 2015 at 05:30:21PM -0800, Jason Gerecke wrote:
>
> On 2/23/2015 10:21 PM, Peter Hutterer wrote:
> >Signed-off-by: Peter Hutterer
> >---
> > src/evdev-tablet.c | 35 +++-
> > src/evdev-tablet.h | 6
> > src/libinput.h | 3 +-
> > test/tablet.c | 95
On Wed, Feb 25, 2015 at 05:31:00PM -0800, Jason Gerecke wrote:
>
> On 2/23/2015 10:21 PM, Peter Hutterer wrote:
> >This doesn't really have an effect, since we don't set the per-tool axes
> >correctly yet.
> >
> >Signed-off-by: Peter Hutterer
> >---
> > tools/event-debug.c | 106
> > +++
On 2/23/2015 10:21 PM, Peter Hutterer wrote:
This is a v2 of the patchset here
http://lists.freedesktop.org/archives/wayland-devel/2015-February/020036.html
but reshuffled, rebased and a couple of things merged in. Notable:
libinput now uses libwacom to get tool/tablet information. This is compl
On Wed, Feb 25, 2015 at 05:29:49PM -0800, Jason Gerecke wrote:
>
> On 2/23/2015 10:21 PM, Peter Hutterer wrote:
> >ABS_THROTTLE:
> > Tablets still advertise this axis but the mouse itself isn't available
> > anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a
> > task
On 2/23/2015 10:21 PM, Peter Hutterer wrote:
This doesn't really have an effect, since we don't set the per-tool axes
correctly yet.
Signed-off-by: Peter Hutterer
---
tools/event-debug.c | 106 +++-
1 file changed, 56 insertions(+), 50 deletio
On 2/23/2015 10:21 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
---
src/evdev-tablet.c | 35 +++-
src/evdev-tablet.h | 6
src/libinput.h | 3 +-
test/tablet.c | 95 ++
4 files changed, 130 inser
On 2/23/2015 10:21 PM, Peter Hutterer wrote:
Needs to be calculated from the x/y tilt values, the mouse has a fixed offset
of 175 degrees counterclockwise.
Signed-off-by: Peter Hutterer
---
src/evdev-tablet.c | 88 +-
src/libinput-private.
On 2/23/2015 10:21 PM, Peter Hutterer wrote:
ABS_THROTTLE:
Tablets still advertise this axis but the mouse itself isn't available
anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a
task for the buttonset interface. Explanation of what the throttle
On Wed, Feb 25, 2015 at 03:48:55PM +0200, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> These are independent tiny patches I have accumulated in my
> development tree, all stemming from trying to understand how
> Weston's region tracking works.
>
> Pekka Paalanen (6):
> compositor: document
On Wed, Feb 25, 2015 at 03:49:00PM +0200, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> There are two call sites, one is already having a pixman_box32_t it
> needs to call view_compute_bbox() with. The other call site will have a
> box32_t when view clipping gets implemented.
>
> Change view_
On Wed, Feb 25, 2015 at 03:03:33PM +0100, David FORT wrote:
> From: Hardening
>
> ---
> protocol/wayland.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Pushed this trivial fix.
f3a5ca9..99d2775 master -> master
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> in
Hi,
On 25 February 2015 at 12:42, Jonny Lamb wrote:
> +/** Checks whether a client extension or fallbacks are supported
> + *
> + * \param ec The weston compositor
> + * \param extension_suffix The EGL client extension suffix
> + * \return Negative if not supported, otherwise positive
> + *
> + *
Series looks good to me now.
Reviewed-by: Derek Foreman
On 25/02/15 06:42 AM, Jonny Lamb wrote:
> ---
> src/compositor-drm.c | 13 +-
> src/compositor-fbdev.c | 2 +-
> src/compositor-wayland.c | 20 +++--
> src/compositor-x11.c | 11 -
> src/gl-renderer.c| 10
This serie of patches tries to address the problem of removing a seat and
really deleting
it server-side. First I have added the corresponding method in the protocol
definition.
Second I have modified the scanner to emit some code to create inert objects:
objects
with requests that do nothing, a
As stated in the very good blog post[1] of Pekka Paalanen, server-side we can
have
sometime troubles with object that the server has deleted but that the client
is still requesting. This patch complements the scanner to create some code
that will return inert objects, ie objects that will do nothi
This is required if we want to correctly remove a wl_seat server-side.
---
protocol/wayland.xml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 4fb8035..8f63ebf 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -1400,6 +1400
From: Hardening
---
protocol/wayland.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 2a49805..4fb8035 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -1389,7 +1389,7 @@
-
+
From: Pekka Paalanen
All things everywhere, except this one case, assume weston_plane::damage
is in global coordinates. Document it.
view_accumulate_damage() is wrong in converting damage to plane
coordinates (similar to global coordinate except translated). Fix this
by removing the unwanted tra
From: Pekka Paalanen
The fix is not trivial, so I want to document the problem before I
forget about it again.
Signed-off-by: Pekka Paalanen
---
src/compositor.c | 10 ++
src/compositor.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/src/compositor.c b/src/compositor.c
inde
From: Pekka Paalanen
There are two call sites, one is already having a pixman_box32_t it
needs to call view_compute_bbox() with. The other call site will have a
box32_t when view clipping gets implemented.
Change view_compute_bbox() to take a pixman_box32_t as the input
argument, and convert cal
From: Pekka Paalanen
Also fixes a theoretical memory leak as the region was never fini'd.
Signed-off-by: Pekka Paalanen
---
src/compositor.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
index b1970cd..abc42e8 100644
--- a/src/compositor.c
+++ b/src
From: Pekka Paalanen
Add a comment saying it is. I'm not aware of misuses of it.
Signed-off-by: Pekka Paalanen
---
src/compositor.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/compositor.h b/src/compositor.h
index 76af451..57b671d 100644
--- a/src/compositor.h
+++ b/src/composit
From: Pekka Paalanen
Signed-off-by: Pekka Paalanen
---
src/compositor.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/compositor.h b/src/compositor.h
index 2d70ad1..c942365 100644
--- a/src/compositor.h
+++ b/src/compositor.h
@@ -802,6 +802,12 @@ struct weston_view {
str
From: Pekka Paalanen
These are independent tiny patches I have accumulated in my
development tree, all stemming from trying to understand how
Weston's region tracking works.
Pekka Paalanen (6):
compositor: document view->transform.* regions
compositor: note, weston_surface_damage does it wro
On Wed, 25 Feb 2015 11:58:43 +
Daniel Stone wrote:
> Hi,
>
> On 25 February 2015 at 11:11, Pekka Paalanen
> wrote:
> > this series is also available at:
> > http://cgit.collabora.com/git/user/pq/weston.git/log/?h=surface-shot-2
> >
> > The main change since v1 is removing the stride and pix
---
clients/nested-client.c | 36 +++-
clients/simple-egl.c | 30 +-
clients/subsurfaces.c | 35 ++-
clients/window.c | 34 +-
tests/buffer-count-test.c |
---
src/compositor-drm.c | 3 ++-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 1 +
src/compositor-x11.c | 5 +
src/gl-renderer.c| 42 +-
src/gl-renderer.h| 3 ++-
6 files changed, 48 insertions(+), 8 deletions
---
src/compositor-drm.c | 13 +-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 20 +++--
src/compositor-x11.c | 11 -
src/gl-renderer.c| 109 +--
src/gl-renderer.h| 6 ++-
6 files changed, 151 ins
---
clients/nested-client.c | 22 ++
clients/simple-egl.c | 22 ++
clients/subsurfaces.c | 22 +++---
clients/window.c | 22 ++
tests/buffer-count-test.c | 25 -
5 files changed,
Hi,
On 25 February 2015 at 11:11, Pekka Paalanen
wrote:
> this series is also available at:
> http://cgit.collabora.com/git/user/pq/weston.git/log/?h=surface-shot-2
>
> The main change since v1 is removing the stride and pixel format
> arguments from the copy_content API. These are now documented
On Wed, 25 Feb 2015 13:06:03 +0200
Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Changes in v2:
> - remove stride and format arguments from the API
>
> Signed-off-by: Pekka Paalanen
> v1 Tested-by: Nobuhiko Tanibata
> ---
> src/pixman-renderer.c | 52
> ++
From: Pekka Paalanen
For easy creation of unique new files. I'm looking at you,
screenshooter.
This code is based on timeline.c weston_timeline_do_open().
Signed-off-by: Pekka Paalanen
Tested-by: Nobuhiko Tanibata
Reviewed-by: Daniel Stone
---
Makefile.am| 2 +
shared/file-util.c
From: Pekka Paalanen
This is an optional API that will be implemented by the renderers. It
allows to fetch the current contents of a surface, essentially the
buffer contents from a client buffer, converted to an RGBA format.
This is meant as a debugging API. The implementations may be heavy and
From: Pekka Paalanen
Taking the easy way, always do a rendering pass when copying any real
buffer or texture. Will handle YUV formats, and makes it easy to always
return data the right y-direction up.
All the FBO GL state is created and torn down on every invocation, so this
is a pretty naive im
From: Pekka Paalanen
Changes in v2:
- remove stride and format arguments from the API
Signed-off-by: Pekka Paalanen
v1 Tested-by: Nobuhiko Tanibata
---
src/pixman-renderer.c | 52 +++
1 file changed, 52 insertions(+)
diff --git a/src/pixman-ren
From: Pekka Paalanen
Add a new buffer type identifying the solid color contents which do not
have a real buffer.
Solid color surfaces now pretend to have 1x1 pixel content data.
This helps the future surface_get_data_size() implementation.
Signed-off-by: Pekka Paalanen
Tested-by: Nobuhiko Tan
From: Pekka Paalanen
Add a new Weston plugin under tests/ for manual testing of the
surface-shooting API.
The debug key binding 'h' triggers a surface shot from the surface that
currently has the pointer focus. The shot is written in PAM format into
a file. PAM format was chosen because it is de
From: Pekka Paalanen
Use shared code for this kind of stuff.
Signed-off-by: Pekka Paalanen
Tested-by: Nobuhiko Tanibata
Reviewed-by: Daniel Stone
---
src/timeline.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/src/timeline.c b/sr
Il 23/02/2015 18:44, Derek Foreman ha scritto:
- if (gl_renderer->create(&compositor->base, EGL_DEFAULT_DISPLAY,
+ if (gl_renderer->create(&compositor->base, 0,
EGL_DEFAULT_DISPLAY,
gl_renderer->opaque_attribs,
45 matches
Mail list logo
