Re: [PATCH libinput v2 6/8] tablet: Include starting values of axes in proximity events

On Wed, Feb 18, 2015 at 01:42:27AM -0500, Stephen Chandler Paul wrote: > Having a motion event that's sent right after the original proximity event > just > to give the values of each axis is somewhat redundant. Since we already > include > the values of each axis with each type of event, we may

Re: [PATCH libinput 00/15] tablet: support the remaining tools

On Wed, Feb 18, 2015 at 10:18:59AM -0500, Benjamin Tissoires wrote: > Hi Peter, > > On Wed, Feb 18, 2015 at 12:45 AM, Peter Hutterer > wrote: > > > > This patchset adds the remaining tools to the tablet branch (at least for > > Wacom tools). The notable additions are: > > * rotation support for m

Weston 1.7 memleaks

Just checking mem leaks. Is this normal or are we shooting for zero leaks? [21:32:52.432] weston 1.7.0 http://wayland.freedesktop.org Bug reports to: https://bugs.freedesktop.org/enter_bug.cgi?product=Wayland&component=weston&version=1.7.0 Build: 1.6.

Re: [PATCH libinput v2 8/8] tablet: Add tests for axes on proximity events

On Wed, Feb 18, 2015 at 01:43:21AM -0500, Stephen Chandler Paul wrote: > --- > test/tablet.c | 134 > ++ > 1 file changed, 134 insertions(+) merged, thanks Cheers, Peter > > Changes > - Check that t

Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

On Wed, Feb 18, 2015 at 01:57:17PM -0800, Jason Gerecke wrote: > > On 2/16/2015 9:11 PM, Peter Hutterer wrote: > >On Mon, Feb 16, 2015 at 08:13:01AM +0100, Hans de Goede wrote: > >>Hi, > >> > >>On 16-02-15 04:50, Peter Hutterer wrote: > >> > >> > >> > >>>ok, I've played around with the ideas in th

Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

Hey :), On Mon, Feb 16, 2015 at 4:50 AM, Peter Hutterer wrote: > ok, I've played around with the ideas in this thread and discussed it with > Benjamin this morning. Short summary: I think we should go with the original > patch, with an optional extension for numbered axes later. > > I tried the e

[PATCH v2 libinput 10/15] tools: only print the tablet axes we have on the tool

This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Signed-off-by: Peter Hutterer --- Changes to v1: - factor out into print_tablet_axes() so we can use the logic from proximity and axes events - only print tilt if the tool supports it tools/event-debug.c |

Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

On 2/16/2015 9:11 PM, Peter Hutterer wrote: On Mon, Feb 16, 2015 at 08:13:01AM +0100, Hans de Goede wrote: Hi, On 16-02-15 04:50, Peter Hutterer wrote: ok, I've played around with the ideas in this thread and discussed it with Benjamin this morning. Short summary: I think we should go with

[PATCH libinput] test: fix Coverity complaints

seat_button_count seat_key_count ... uninitialized variable t = zalloc s = zalloc ... dereferencing potential NULL-pointer d->ntouches_down... side-effect in assertion Coverity run against the 0.10.0 tag, see https://scan.coverity.com/projects/4298 Signed-off-by: Peter Hutterer --- test/keybo

Re: libinput in Coverity

On Wed, Feb 18, 2015 at 10:06:25AM +1000, Peter Hutterer wrote: > On Tue, Feb 17, 2015 at 11:19:58PM +0100, Carlos Olmedo Escobar wrote: > > I was trying to check libinput in Coverity but it seems it's not there yet. > > Is there anybody who is supposed to register libinput there? > > fwiw, I ran

Re: weston rdp crash on arm

Hi Raphael, You are using a rather old version of Weston (1.7.0 was just released). Considered upgrading the software ? Anyways, I remember pretty well that when 1.5.0 was around, latest FreeRDP master did not work. Here is the git commit that we were using in Tizen back then : 2604ff20bd12e810c

Re: [PATCH libinput 01/11] Add an API for touchpad gesture events

On 02/18/2015 04:26 AM, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget the touches are over is important context to know t

Re: [PATCH libinput 00/15] tablet: support the remaining tools

Hi Peter, On Wed, Feb 18, 2015 at 12:45 AM, Peter Hutterer wrote: > > This patchset adds the remaining tools to the tablet branch (at least for > Wacom tools). The notable additions are: > * rotation support for mouse/lens cursor > * rotation support for the artpen > * 'wheel' support for the air

[PATCH libinput 07/11] touchpad: Gesture support preparation

Handle everything which is not handeld by the tap, (soft)button or edge-scroll code/statemachines in a unified way. Everything is treated as a X-finger gesture now, and the action to take on finger movement is decided by the gesture.finger_mode setting. Pointer control now simply is seen as a 1 fin

[PATCH libinput 08/11] touchpad: Move gesture handling code to evdev-mt-touchpad-gestures.c

Just moving some code around, no functional changes. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 94 +++- src/evdev-mt-touchpad.c | 92 --- src/evdev-mt-touchpad.h | 9 3 files

[PATCH libinput 10/11] touchpad: Refactor tp_get_*_touches_delta

The two tp_get_*_touches_delta functions are almost identical, refactor them into one function. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 29 + 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/src/evdev-mt-touchpad-gestures.c b/

[PATCH libinput 09/11] touchpad: Do not use fake touches when getting the average touches delta

Only look at real touches when getting the average touches delta, otherwise the touch used to populate the fake touches gets an unfair weighing factor. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/

[PATCH libinput 05/11] touchpad: Also stop edge scrolling when the trackpoint becomes active

Not only stop 2fg scrolling, but also edge scrolling when the trackpoint becomes active. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index a6de661..a4c3fb9 1006

[PATCH libinput 11/11] touchpad: Add support for swipe gestures

Add support for swipe gestures. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad-gestures.c | 36 1 file changed, 36 insertions(+) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c index e429efe..faf5824 100644 --- a/src/

[PATCH libinput 00/11] Add touchpad gesture support

Hi All, Here is a series actually implementing the touchpad gesture support API I've been proposing. The 1st patch is unchanged from its last posting other then fixing a single type. This series only adds swipe support. I've a bunch of backlight, uas and misc. other bugs which I need to look into

[PATCH libinput 04/11] touchpad: Change how we deal with scroll methods

With the upcoming gesture support 2fg scrolling will be handled as part of the main gesture state machine, where as edge scrolling has its own state machine, our current way of dispatching scroll "actions" does not play well with this. Change the scroll method handling to treat edge and 2fg scroll

[PATCH libinput 02/11] Add a gesture capability flag

Add a new LIBINPUT_DEVICE_CAP_GESTURE device capability, Signed-off-by: Hans de Goede --- src/evdev.c | 3 +++ src/evdev.h | 3 ++- src/libinput.h | 3 ++- tools/event-debug.c | 3 +++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c

[PATCH libinput 06/11] touchpad: Add tp_get_average_touches_delta helper function

Add a tp_get_average_touches_delta helper function, and rename tp_get_active_touches_delta to tp_get_combined_touches_delta to better differentiate the two. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-)

[PATCH libinput 01/11] Add an API for touchpad gesture events

For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget the touches are over is important context to know to interpret gestures. On touchpads however we ne

[PATCH libinput 03/11] event-debug: Add support for gesture events

Add support for gesture events to the event-debug tool. Signed-off-by: Hans de Goede --- tools/event-debug.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index 055f3cc..d76c127 100644 --- a/tools/event-

Re: [PATCH libinput] Add an API for touchpad gesture events

Hi, On 17-02-15 22:55, Peter Hutterer wrote: On Thu, Feb 12, 2015 at 12:27:49PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which wind

Re: [PATCH libinput] udev: fix a race condition if a device disappears before we get a handle

Hi, On 18-02-15 04:36, Peter Hutterer wrote: If the device disappears too quickly, the device is NULL, the sysname is NULL and that causes a segfault in strcmp. Signed-off-by: Peter Hutterer Looks good / simple: Reviewed-by: Hans de Goede Regards, Hans --- src/udev-seat.c | 2 ++ 1

Re: [PATCH weston] configure.ac: make use of wayland-scanner.pc

On 17/02/15 15:13, Emil Velikov wrote: > Currently we use the wayland-scanner executable as found with > AC_PATH_PROG, and then check the presence of wayland-scanner.pc > > Currently the latter is unused even if AC_PATH_PROG fails to find the > binary. Rework things to use the pkg-config variable

Re: [PATCH weston 4/5] compositor: add repaint delay timer

On Thu, 12 Feb 2015 15:30:16 +0200 Pekka Paalanen wrote: > From: Pekka Paalanen > > This timer delays the output_repaint towards the end of the refresh > period, reducing the time from repaint to present. > > The length of the repaint window can be set in weston.ini. > > Signed-off-by: Pekka

Re: [PATCH weston] compositor: document weston_view_damage_below()

On Tue, 17 Feb 2015 04:35:03 -0800 Jason Ekstrand wrote: > Just spent a little time crawling through things to remind myself of how it > all works. Your comment seems correct. Not sure if it's really sufficient > documentation for view.clip though. > > Reviewed-by: Jason Ekstrand > > On Tue,