[PATCH libinput v2 8/8] tablet: Add tests for axes on proximity events

--- test/tablet.c | 134 ++ 1 file changed, 134 insertions(+) Changes - Check that the axes are still present on the proximity out events, and make sure that they haven't changed - Don't use a loop when

[PATCH libinput v2 6/8] tablet: Include starting values of axes in proximity events

Having a motion event that's sent right after the original proximity event just to give the values of each axis is somewhat redundant. Since we already include the values of each axis with each type of event, we may as well use the proximity event to give the client the starting values for each axi

[PATCH libinput 03/15] test: replace a while loop with a litest helper

Signed-off-by: Peter Hutterer --- test/tablet.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/test/tablet.c b/test/tablet.c index 1e5947a..746f643 100644 --- a/test/tablet.c +++ b/test/tablet.c @@ -799,15 +799,10 @@ START_TEST(tool_ref) litest_event(dev

[PATCH libinput 00/15] tablet: support the remaining tools

This patchset adds the remaining tools to the tablet branch (at least for Wacom tools). The notable additions are: * rotation support for mouse/lens cursor * rotation support for the artpen * 'wheel' support for the airbrush * correct per-tool capabilities (including buttons) If you have one of t

[PATCH libinput 04/15] test: fix double comparison macros

args needs to be within () to ensure correct calculation Signed-off-by: Peter Hutterer --- test/litest.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/litest.h b/test/litest.h index 4553c87..dd1ad9a 100644 --- a/test/litest.h +++ b/test/litest.h @@ -195,22

[PATCH libinput 06/15] Keep the tablet APIs in a separate symbol version block

I keep having to move them around after merging from master and often I'm late with it too. It's a lot easier to just have to update the dependency in a single line, and causes less conflicts too. Signed-off-by: Peter Hutterer --- src/libinput.sym | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH libinput 13/15] tablet: set the axis bits correctly for each tool

Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 46eb665..dcf1716 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -417,6 +417,18 @@ tool_set_bits(const

[PATCH libinput 09/15] tablet: support airbrush wheel as slider

The little wheel isn't a full wheel, it has a ~90 degree rotation angle with a range of 1024 values. To avoid confusion with "wheel" elsewhere in the API name it slider. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 12 +-- src/evdev-tablet.h | 6 src/libinput-private.

[PATCH libinput 02/15] test: fix two tablet tests

The serial test was broken, it succeeded even if we never got an event. The second test was fine, but complicated. Make it use some of the newer litest features. Signed-off-by: Peter Hutterer --- test/tablet.c | 42 -- 1 file changed, 16 insertions(+), 26

[PATCH libinput 05/15] tablet: fix two coding style issues

Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 0de4bcd..9f55946 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tablet.c @@ -130,7 +130,8 @@ tablet_update_tool(struct tabl

[PATCH libinput 11/15] tablet: support artpen rotation

Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 33 + src/evdev-tablet.h | 6 +++ src/libinput.h | 3 +- test/tablet.c | 105 + 4 files changed, 131 insertions(+), 16 deletions(-) diff --git a/src/evdev-tabl

[PATCH libinput 14/15] tablet: add support for libinput_tool_has_button

The mouse like devices have LMR, SIDE and EXTRA. PENCIL (which is the Wacom Inking) and the eraser have no buttons. AIRBRUSH has only one button, all other pens have two. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 41 + src/libinput-private

[PATCH libinput 01/15] tablet: explicitly ignore ABS_THROTTLE, ABS_RX, ABS_RY, and ABS_RZ

ABS_THROTTLE: Tablets still advertise this axis but the mouse itself isn't available anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a task for the buttonset interface. Explanation of what the throttle did on page http://101.wacom.com/prod

[PATCH libinput 10/15] tools: only print the tablet axes we have on the tool

This doesn't really have an effect, since we don't set the per-tool axes correctly yet. Signed-off-by: Peter Hutterer --- tools/event-debug.c | 49 + 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/tools/event-debug.c b/tools/event-

[PATCH libinput 08/15] tablet: support z-rotation for the mouse/lens tool

Needs to be calculated from the x/y tilt values, the mouse has a fixed offset of 175 degrees counterclockwise. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 95 -- src/libinput-private.h | 2 +- src/libinput.c | 1 + src/libinput.

[PATCH libinput 07/15] tablet: factor out checking a device for axes

This gets more complicated for axes that aren't a 1:1 relationship with event codes. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 9f55946..8b8573a 10064

[PATCH libinput 15/15] tools: print tool capabilities on proximity

Signed-off-by: Peter Hutterer --- tools/event-debug.c | 32 1 file changed, 32 insertions(+) diff --git a/tools/event-debug.c b/tools/event-debug.c index dcf1dae..37d344c 100644 --- a/tools/event-debug.c +++ b/tools/event-debug.c @@ -439,6 +439,38 @@ print_proxim

[PATCH libinput 12/15] tablet: factor out setting axis bits on a tool

No functional changes. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 100 + 1 file changed, 48 insertions(+), 52 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 81cb99e..46eb665 100644 --- a/src/evdev-tablet.c

[PATCH libinput] udev: fix a race condition if a device disappears before we get a handle

If the device disappears too quickly, the device is NULL, the sysname is NULL and that causes a segfault in strcmp. Signed-off-by: Peter Hutterer --- src/udev-seat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/udev-seat.c b/src/udev-seat.c index 3d05733..6615f20 100644 --- a/src/ud

Re: libinput in Coverity

On Tue, Feb 17, 2015 at 11:19:58PM +0100, Carlos Olmedo Escobar wrote: > I was trying to check libinput in Coverity but it seems it's not there yet. > Is there anybody who is supposed to register libinput there? fwiw, I ran irregular coverity checks on Red Hat's internal Coverity instance. last ti

Re: [PATCH libinput 8/8] tablet: Add tests for axes on proximity events

On Mon, Feb 16, 2015 at 10:48:46PM -0500, Stephen Chandler Paul wrote: > --- > test/tablet.c | 77 > +++ > 1 file changed, 77 insertions(+) > > diff --git a/test/tablet.c b/test/tablet.c > index 8074e4e..bf78e12 100644 > --- a/test/tablet.c

Re: [PATCH libinput 6/8] tablet: Include starting values of axes in proximity events

On Mon, Feb 16, 2015 at 10:48:44PM -0500, Stephen Chandler Paul wrote: > Having a motion event that's sent right after the original proximity event > just > to give the values of each axis is somewhat redundant. Since we already > include > the values of each axis with each type of event, we may

Re: libinput in Coverity

On 02/17/2015 02:19 PM, Carlos Olmedo Escobar wrote: > Hi, > > I was trying to check libinput in Coverity but it seems it's not there yet. > Is there anybody who is supposed to register libinput there? > I very much appreciate being able to leverage Coverity. Please keep me in the loop. --

Re: [PATCH libinput 4/8] tablet: Merge PROXIMITY_IN and PROXIMITY_OUT into a single event

On Mon, Feb 16, 2015 at 10:48:42PM -0500, Stephen Chandler Paul wrote: > There isn't much purpose in having proximity in and out as different events, > combining them into one single event is more consistent with the rest of the > API, and means less code for clients to have to work with. > > Sign

Re: [PATCH libinput 2/8 v2] tablet: Add a left handed mode and tests

On Mon, Feb 16, 2015 at 10:48:40PM -0500, Stephen Chandler Paul wrote: > On the majority of Wacom tablets, the buttons are on the left side, opposite > of > the side where the palm is meant to rest. Because of this, it's impossible to > use the tablet with your left hand (comfortably, anyway) unle

Re: [PATCH libinput] evdev: check the first parent of the event node for ID_INPUT tags

On Thu, Feb 12, 2015 at 8:51 PM, Peter Hutterer wrote: > Bluetooth tablet devices' rules can't tag the event node directly, they can > only tag the first parent (the /sys/class/input/input1234 node). Check that > parent for tags too, lest we miss something important. > > Signed-off-by: Peter Hutte

libinput in Coverity

Hi, I was trying to check libinput in Coverity but it seems it's not there yet. Is there anybody who is supposed to register libinput there? Regards, ~Carlos. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.or

Re: [PATCH libinput] Add an API for touchpad gesture events

On Thu, Feb 12, 2015 at 12:27:49PM +0100, Hans de Goede wrote: > For touchscreens we always send raw touch events to the compositor, and the > compositor or application toolkits do gesture recognition. This makes sense > because on a touchscreen which window / widget the touches are over is > impor

Re: [ANNOUNCE] wayland 1.7.0

On 02/17/2015 01:29 AM, Pekka Paalanen wrote: On Mon, 16 Feb 2015 12:52:27 -0800 Bill Spitzak wrote: On 02/14/2015 01:18 AM, Bryce Harrington wrote: You can check out this spiffed up documentation at: http://wayland.freedesktop.org/docs/html/ It looks like these pages have not been up

[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

--- src/compositor-drm.c | 3 ++- src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 1 + src/compositor-x11.c | 5 + src/gl-renderer.c| 38 +- src/gl-renderer.h| 3 ++- 6 files changed, 44 insertions(+), 8 deletions(-)

[PATCH weston 2/4] clients & tests: use eglGetPlatformDisplayEXT when supported

--- clients/nested-client.c | 29 - clients/simple-egl.c | 23 ++- clients/subsurfaces.c | 26 +- clients/window.c | 27 ++- tests/buffer-count-test.c | 30 ++

[PATCH weston 1/4] gl-renderer: use eglGetPlatformDisplayEXT to get an EGLDisplay

--- src/compositor-drm.c | 14 - src/compositor-fbdev.c | 2 +- src/compositor-wayland.c | 21 +++-- src/compositor-x11.c | 14 - src/gl-renderer.c| 79 ++-- src/gl-renderer.h| 6 +++- 6 files changed,

[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

--- clients/nested-client.c | 18 ++ clients/simple-egl.c | 18 ++ clients/subsurfaces.c | 18 +++--- clients/window.c | 17 + tests/buffer-count-test.c | 21 - 5 files changed, 72 insertions(+), 20

[PATCH weston] configure.ac: make use of wayland-scanner.pc

Currently we use the wayland-scanner executable as found with AC_PATH_PROG, and then check the presence of wayland-scanner.pc Currently the latter is unused even if AC_PATH_PROG fails to find the binary. Rework things to use the pkg-config variable as a fall-back. Cc: Andrew Oakley Cc: Bill Spit

Re: [PATCH weston] configure.ac: honour the wayland-scanner.pc

On 16 February 2015 at 13:04, Andrew Oakley wrote: > On 10/02/15 14:42, Emil Velikov wrote: >> Currently we use the wayland-scanner executable as found with >> AC_PATH_PROG, and after that check the presence of wayland-scanner.pc >> >> Even if the latter is pointing to another wayland-scanner we s

Fwd: [PATCH] protocol: Add DnD actions

Resending from the right address... Hi Bill, On Mon, Feb 16, 2015 at 10:17 PM, Bill Spitzak wrote: > I would think the drop target client can figure out what action to perform, > there is no need to communicate it's set of actions to the compositor or for > the compositor to have any of this log

Re: [PATCH weston] compositor: document weston_view_damage_below()

On Tue, 17 Feb 2015 04:35:03 -0800 Jason Ekstrand wrote: > Just spent a little time crawling through things to remind myself of how it > all works. Your comment seems correct. Not sure if it's really sufficient > documentation for view.clip though. > > Reviewed-by: Jason Ekstrand Thanks! Be

Re: [PATCH weston] compositor: document weston_view_damage_below()

Just spent a little time crawling through things to remind myself of how it all works. Your comment seems correct. Not sure if it's really sufficient documentation for view.clip though. Reviewed-by: Jason Ekstrand On Tue, Feb 17, 2015 at 4:19 AM, Pekka Paalanen wrote: > From: Pekka Paalanen

[PATCH weston] compositor: document weston_view_damage_below()

From: Pekka Paalanen Explains what weston_view::clip is. Signed-off-by: Pekka Paalanen --- src/compositor.c | 16 src/compositor.h | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 9e2bd80..d408ccb 100644 --- a/sr

Re: [PATCH] protocol: Add DnD actions

Hi Bill, On Mon, Feb 16, 2015 at 10:17 PM, Bill Spitzak wrote: > I would think the drop target client can figure out what action to perform, > there is no need to communicate it's set of actions to the compositor or for > the compositor to have any of this logic to "determine the action both part

Re: [PATCH weston] configure.ac: honour the wayland-scanner.pc

On 16/02/15 22:07, Daniel Stone wrote: > Hi, > > On 16 February 2015 at 20:46, Bill Spitzak wrote: >> I'm pretty certain there was an old version that looked in the PATH, but >> this has the really unfortunate effect that the build does not work, you >> have to manually create the wayland_scanner

Re: [ANNOUNCE] wayland 1.7.0

On Mon, 16 Feb 2015 12:52:27 -0800 Bill Spitzak wrote: > On 02/14/2015 01:18 AM, Bryce Harrington wrote: > > > You can check out this spiffed up documentation at: > > > >http://wayland.freedesktop.org/docs/html/ > > It looks like these pages have not been updated to the newest output, > in