Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

2015-02-12 Thread Peter Hutterer
On 13/02/2015 14:32 , Peter Hutterer wrote: > On Thu, Feb 12, 2015 at 12:37:12PM +0100, Hans de Goede wrote: >> Hi, >> >> On 12-02-15 08:33, Peter Hutterer wrote: >>> A generic interface for devices that provide buttons and axes, but don't >>> control the pointer. This caters for the Pad part of Wa

Nomination Period for the X.Org Foundation BoD Election ENDS

2015-02-12 Thread Egbert Eich
Just as a reminder, the nomination period for the X.Org Foundation Board of Directors election ends on Monday, Feb 16 2015, 23:59 UTC (12:59 PM UTC). If you would like to nominate yourself, please send email to electi...@x.org. Please note that to be a candidate in this election your have to b

Re: [PATCH weston 00/10] Rebase of Jasper's xdg-shell unstable v5

2015-02-12 Thread Jonas Ådahl
Please ignore this one, it a early unfinished version of 00/00. Jonas On Fri, Feb 13, 2015 at 02:01:52PM +0800, Jonas Ådahl wrote: > Hi, > > This is a rebase of the improvements Jasper did to the xdg-shell protocol > specification. No major changes were made, check each commit for details > abou

[PATCH weston 08/10] xdg-shell: Add a simple destructor request

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" --- desktop-shell/shell.c | 10 +- protocol/xdg-shell.xml | 5 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 57f7335..0ae2ad3 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shel

[PATCH weston 09/10] xdg-shell: Rewrite documentation

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" This rewrites basically all of the text inside xdg-shell to be up to date, clearer, and rid of wl_shell and X11 terminology. [jadahl: Added paragraph about popup surface mapping order.] --- protocol/xdg-shell.xml | 262 +

[PATCH weston 07/10] xdg-shell: Add invalid_parent error to xdg_popup

2015-02-12 Thread Jonas Ådahl
Send an invalid_parent error when the client tries to create a popup with a paren that is neither a xdg_surface nor a xdg_popup. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 11 ++- protocol/xdg-shell.xml | 3 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH weston 02/10] desktop-shell: Fix coding style of add_popup_grab

2015-02-12 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index db0c5a9..1242f93 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -

[PATCH weston 00/10] Rebase of Jasper's xdg-shell unstable v5

2015-02-12 Thread Jonas Ådahl
Hi, This is a rebase of the improvements Jasper did to the xdg-shell protocol specification. No major changes were made, check each commit for details about that. Note that this series don't tend to solve all the pending issues that has been discussed regarding the current state of xdg-shell, and

[PATCH weston 00/10] xdg-shell unstable v5 revisited and beyond

2015-02-12 Thread Jonas Ådahl
Hi, This emails contains two slightly disconnected parts; the first part is regarding patch series improving the xdg-shell protocol. The second part is regarding xdg-shell and desktop shell - client integration in general. Part 1 == This series is a rebase of the xdg-shell improvements made

[PATCH weston 01/10] desktop-shell: Simplify popup_end_grab popup_done sending loop

2015-02-12 Thread Jonas Ådahl
Can just use wl_list_for_each_safe instead of dealing with pointers ourself. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index f28fc10

[PATCH weston 03/10] xdg-shell: Take a xdg_surface as the parent surface

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" There is no other valid surface that we should be using here. --- clients/window.c | 14 +++--- desktop-shell/shell.c | 12 ++-- protocol/xdg-shell.xml | 2 +- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/clients/window.c b/cl

[PATCH weston 06/10] xdg-shell: Send an error when the client uses the not-topmost popup

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" Either in destroy or get_xdg_popup. [jadahl: Verify that the new popup is the top most when mapping instead of creating. Some renaming.] --- desktop-shell/shell.c | 58 +- protocol/xdg-shell.xml | 7 ++ 2 files chan

[PATCH weston 04/10] xdg-shell: Remove the serial from popup_done

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" It doesn't serve any purpose, as it's a serial that the client gave to the server when starting the popup, which the client already has. --- clients/window.c | 2 +- desktop-shell/shell.c | 3 +-- protocol/xdg-shell.xml | 1 - 3 files changed, 2 insertions(+), 4

[PATCH weston 05/10] xdg-shell: Remove the flags from get_xdg_popup

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" There haven't been any ideas for flags, so we don't need a useless, unused parameter hanging around. Any future ideas should be done with a new request entirely. --- clients/window.c | 3 +-- desktop-shell/shell.c | 2 +- protocol/xdg-shell.xml | 1 - 3 files cha

[PATCH weston 10/10] xdg-shell: Bump unstable version

2015-02-12 Thread Jonas Ådahl
From: "Jasper St. Pierre" --- clients/simple-damage.c | 2 +- clients/simple-egl.c| 2 +- clients/simple-shm.c| 2 +- clients/window.c| 2 +- desktop-shell/shell.c | 2 +- protocol/xdg-shell.xml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/clients/sim

[PATCH libinput] Add libinput_device_pointer_has_button over the plain has_button

2015-02-12 Thread Peter Hutterer
If a device has multiple capabilities, has_button is imprecise. A device with tablet and pointer capability for example may have BTN_LEFT on the pointer interface but not on the tablet interface. Signed-off-by: Peter Hutterer --- src/libinput.c | 10 -- src/libinput.h | 10 +-

Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

2015-02-12 Thread Peter Hutterer
On Thu, Feb 12, 2015 at 12:37:12PM +0100, Hans de Goede wrote: > Hi, > > On 12-02-15 08:33, Peter Hutterer wrote: > >A generic interface for devices that provide buttons and axes, but don't > >control the pointer. This caters for the Pad part of Wacom graphics tablets > >but could eventually also

Re: [PATCH weston 2/2] weston-egl-ext: Define EGL tokens harder for old Mesa

2015-02-12 Thread Bryce Harrington
On Thu, Feb 12, 2015 at 03:55:42PM +0200, Pekka Paalanen wrote: > On Wed, 11 Feb 2015 18:15:18 + > Daniel Stone wrote: > > > Older versions of Mesa provided header definitions for the > > EGL_WL_bind_wayland_display extension, but an earlier version of the > > extension which only provided th

[PATCH libinput] evdev: check the first parent of the event node for ID_INPUT tags

2015-02-12 Thread Peter Hutterer
Bluetooth tablet devices' rules can't tag the event node directly, they can only tag the first parent (the /sys/class/input/input1234 node). Check that parent for tags too, lest we miss something important. Signed-off-by: Peter Hutterer --- src/evdev.c | 19 +-- 1 file changed, 1

Re: [PATCH libinput v4 1/2] add simple symbols leak checker

2015-02-12 Thread Peter Hutterer
On Thu, Feb 12, 2015 at 09:25:36AM -0500, Marek Chalupa wrote: > This patch adds simple script that compares libinput.sym file to the > functions that are marked by LIBINPUT_EXPORT. This script is added > to make check target. > > v2. use noinst_SCRIPTS instead of dummy target > drop .sh suffi

[PATCH v3 libinput 2/3] Add udev bits to assign LIBINPUT_DEVICE_GROUP

2015-02-12 Thread Peter Hutterer
The easiest way to get a device group is by looking at the phys path of the input device (which looks like usb-:00:14.0-1/input1) and dropping the /inputX bit. The rest is the same for devices that belong together (except on the Cintiq 22HD Touch). Ideally we could just take ATTRS{phys} but we

Re: [PATCH v2 libinput 2/3] Add a udev bits to assign LIBINPUT_DEVICE_GROUP

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 8:31 PM, Peter Hutterer wrote: > The easiest way to get a device group is by looking at the phys path of the > input device (which looks like usb-:00:14.0-1/input1) and dropping the > /inputX bit. The rest is the same for devices that belong together. > > Ideally we cou

Re: [PATCH libinput 3/3] Use LIBINPUT_DEVICE_GROUP from udev as group identifier

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer wrote: > From: Benjamin Tissoires > > Store it as identifier in the device group, any two devices that have a > the same non-NULL identifier share the group. > > Signed-off-by: Peter Hutterer > --- This one diverged quite a lot from my first patch

Re: [PATCH libinput 1/3] tools: print the device group in event-debug

2015-02-12 Thread Benjamin Tissoires
On Tue, Feb 10, 2015 at 1:50 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- Reviewed-by: Benjamin Tissoires > tools/event-debug.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tools/event-debug.c b/tools/event-debug.c > index 297e47

Re: [PATCH libinput] tablet: drop LIBINPUT_TABLET_AXIS_NONE from the API

2015-02-12 Thread Benjamin Tissoires
On Mon, Feb 9, 2015 at 8:29 PM, Peter Hutterer wrote: > This constant isn't used in the public API, let's drop it. To make it easier > to use it internally and avoid accidental boolean comparisions with axes, bump > all real axes up to start at 1. > > Internally that means we drop the AXIS_CNT sin

[PATCH libinput v4 2/2] update .gitignore

2015-02-12 Thread Marek Chalupa
We added symbols-leak-test that is not covered by .gitignore (and should be) Signed-off-by: Marek Chalupa --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 3ea8576..2253d45 100644 --- a/.gitignore +++ b/.gitignore @@ -27,4 +27,5 @@ doc/libinput.doxy

[PATCH libinput v4 1/2] add simple symbols leak checker

2015-02-12 Thread Marek Chalupa
This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. v2. use noinst_SCRIPTS instead of dummy target drop .sh suffix generate the script from .in file use -u swich when running diff

Re: [PATCH weston 2/2] weston-egl-ext: Define EGL tokens harder for old Mesa

2015-02-12 Thread Pekka Paalanen
On Wed, 11 Feb 2015 18:15:18 + Daniel Stone wrote: > Older versions of Mesa provided header definitions for the > EGL_WL_bind_wayland_display extension, but an earlier version of the > extension which only provided the (un)bind entrypoints, and not > QueryWaylandBuffer. Detect this half-provi

[PATCH weston 1/5] headless: fix the output refresh rate

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen 60 millihertz is a bit low, let's make it 60 Hz as it was supposed to be. When the new repaint scheduling algorithm gets implemented, this fixes 'make check' taking almost 3 minutes instead of the normal 3 seconds, when running with 7 millisecond repaint window. Signed-off-

[PATCH weston 5/5] compositor: delay also exiting the continuous repaint loop

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen If we exit the continuous repaint loop (set output->repaint_scheduled to false) in finish_frame, we may call start_repaint_loop() unnecessarily. This was observed with two outputs on the DRM backend at 60 Hz, and 7 ms repaint-window. During a window move, one output was cons

[PATCH weston 4/5] compositor: add repaint delay timer

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen This timer delays the output_repaint towards the end of the refresh period, reducing the time from repaint to present. The length of the repaint window can be set in weston.ini. Signed-off-by: Pekka Paalanen --- man/weston.ini.man | 10 ++ src/compositor.c | 49

[PATCH weston 0/5] New repaint scheduling algorithm

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen Hi, Weston's repaint causes an additional frame of latency for client output. This patch series reduces the latency by adding a delay in the compositor's repaint cycle. All the details and analysis can be found in http://ppaalanen.blogspot.fi/2015/02/weston-repaint-schedulin

[PATCH weston 2/5] presentation-shm: put run mode in window title

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen This way JSON timeline logs will contain the information about in which mode the program runs. Signed-off-by: Pekka Paalanen --- clients/presentation-shm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/clients/presentation-shm.c b/clients

[PATCH weston 3/5] compositor: refactor to weston_output_schedule_repaint_reset()

2015-02-12 Thread Pekka Paalanen
From: Pekka Paalanen No functional changes. Signed-off-by: Pekka Paalanen --- src/compositor.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index c2c975d..b0bca24 100644 --- a/src/compositor.c +++

Re: [RFC libinput 1/2] Add a "buttonset" interface for button-only devices

2015-02-12 Thread Hans de Goede
Hi, On 12-02-15 08:33, Peter Hutterer wrote: A generic interface for devices that provide buttons and axes, but don't control the pointer. This caters for the Pad part of Wacom graphics tablets but could eventually also deal with remote controls, 3D mice and other devices. This patch adds a new

[PATCH libinput 0/1] Add an API for touchpad gesture events

2015-02-12 Thread Hans de Goede
Hi All, Here is a non RFC version of my touchpad gesture API, this supports swipes only for now, it will be extended for zoom/rotate (as a single combined gesture) in the future. New since the last RFC posting is the removal of the abs coordinates for swipes, these just needlessly complicate thin

[PATCH libinput] Add an API for touchpad gesture events

2015-02-12 Thread Hans de Goede
For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget the touches are over is important context to know to interpret gestures. On touchpads however we ne

Re: [PATCH weston 1/2] configure.ac: Don't look for Xwayland in the weston install destination

2015-02-12 Thread Pekka Paalanen
On Tue, 10 Feb 2015 10:03:04 -0600 Derek Foreman wrote: > On 10/02/15 09:22 AM, sardemff7+wayl...@sardemff7.net wrote: > > On 2015-02-10 03:15, Bryce Harrington wrote: > >> Turns out the issue I've run into is that the --with-xserver-path > >> setting doesn't get passed down into distcheck, which

Re: [PATCH weston 2/2] weston-egl-ext: Define EGL tokens harder for old Mesa

2015-02-12 Thread Daniel Stone
Hi, On Thursday, February 12, 2015, Bryce Harrington wrote: > On Wed, Feb 11, 2015 at 06:15:18PM +, Daniel Stone wrote: > > Older versions of Mesa provided header definitions for the > > EGL_WL_bind_wayland_display extension, but an earlier version of the > > extension which only provided th

Re: [PATCH weston 1/2] tests: Include weston-egl-ext from weston-test

2015-02-12 Thread Daniel Stone
Hi, On Thursday, February 12, 2015, Bryce Harrington wrote: > On Wed, Feb 11, 2015 at 06:15:17PM +, Daniel Stone wrote: > > weston-test uses eglBindWaylandDisplayWL and friends, which are defined > > either by the EGL implementation, or weston-egl-ext.h as a fallback. > > Include weston-egl-