Re: [PATCH V4] configure.ac: Fallback to older detection code if pkg-config can't find expat

2015-02-04 Thread Bryce Harrington
On Tue, Feb 03, 2015 at 02:26:58PM -0800, Bill Spitzak wrote: > This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. > > On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config > file, so fall back to a test for the header and library. In addition the > sourc

Re: [PATCH wayland-web] Update ubuntu12.04 instructions to build expat from source

2015-02-04 Thread Bryce Harrington
On Thu, Feb 05, 2015 at 03:14:00PM +1000, Peter Hutterer wrote: > On Tue, Feb 03, 2015 at 02:58:57PM -0800, Bill Spitzak wrote: > > This git repository was the best one I found. Even then the instructions > > seem to be wrong, there was no buildconf script and the execute bit was > > not turned on

Re: [PATCH wayland v2] doc: Fill in high level description for Surfaces

2015-02-04 Thread Bryce Harrington
On Thu, Jan 29, 2015 at 04:28:39PM -0800, Jon A. Cruz wrote: > Looks good. > > > Reviewed-by: Jon A. Cruz Thanks, applied. Minor tweak to get it to apply on top of Bill's change. 8094426..310fea4 master -> master > On 01/27/2015 04:32 PM, Bryce Harrington wrote: > > Signed-off-by: Bryc

Re: [PATCH wayland-web] Update ubuntu12.04 instructions to build expat from source

2015-02-04 Thread Peter Hutterer
On Tue, Feb 03, 2015 at 02:58:57PM -0800, Bill Spitzak wrote: > This git repository was the best one I found. Even then the instructions > seem to be wrong, there was no buildconf script and the execute bit was > not turned on for configure. > > This seems to work and I confirmed that the output o

[PATCH] touchpad: if no touches assume left click under clickfinger method

2015-02-04 Thread Bobby Powers
On the 3rd gen x1 carbons, if your finger is at the very bottom of the touchpad, you can click the touchpad without it registering your finger as a touch down. Treat this case the same as a single-finger left click, which matches my intention. Signed-off-by: Bobby Powers --- src/evdev-mt-touchp

[PATCH libinput] Introduce device groups to group logical devices together

2015-02-04 Thread Peter Hutterer
Devices like Wacom tablets have multiple event nodes (touch, pad and stylus). This requires some logical grouping, e.g. setting an Intuos 5 tablet left-handed effectively turns it upside down. That then applies to both the stylus and the touch device. Merging the devices into one struct libinput_d

Re: [PATCH weston] compositor-x11: Move the x11 window close to an idle handler

2015-02-04 Thread Bryce Harrington
On Tue, Feb 03, 2015 at 02:01:31PM +, Daniel Stone wrote: > On 27 January 2015 at 22:26, Derek Foreman wrote: > > The input loop is actually dispatched in the middle of the frame repaint. > > When the X11 event results in closing the compositor, this can cause the > > current output to be dest

Re: [PATCH weston v2] Fix "Back", "Forward", and other special mouse buttons in the X11 compositor.

2015-02-04 Thread Bryce Harrington
On Thu, Feb 05, 2015 at 07:32:51AM +1000, Peter Hutterer wrote: > On Wed, Feb 04, 2015 at 01:51:57AM -0800, Dima Ryazanov wrote: > > They're off by 4 because of the scroll buttons. > > > > > Signed-off-by: Dima Ryazanov > > Reviewed-by: Peter Hutterer Thanks, applied. 90d1ac8..3e4d4bd ma

Re: [PATCH wayland] test-runner: wait for concrete pid

2015-02-04 Thread Bryce Harrington
On Tue, Feb 03, 2015 at 10:48:40AM +, Daniel Stone wrote: > On 2 February 2015 at 09:40, Marek Chalupa wrote: > > After running a test in fork, we were waiting for any child to terminate. > > It is OK unless the child forks again. If the child calls fork, the waitid > > can > > catch the chil

Re: [PATCH weston v2 2/2] libinput: Only forward first and last press and release for a key

2015-02-04 Thread Bryce Harrington
On Tue, Feb 03, 2015 at 05:01:30PM -0600, Derek Foreman wrote: > fwiw, > > Reviewed-by: Derek Foreman > > for both. > > On 29/01/15 10:23 PM, Jonas Ådahl wrote: > > Keyboard key events will be received from a device where a key has > > been pressed, even though an equivalent key has been presse

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Peter Hutterer
On Wed, Feb 04, 2015 at 04:45:37PM -0500, Olivier Fourdan wrote: > Hi Peter, > > Just to clarify, evdev_accel_config_set_speed() calls filter_set_speed() > which calls accelerator_set_speed() which reaches the assert(). > > My patch basically removes the assert() and replaces it by a return false

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
Hi Peter, Just to clarify, evdev_accel_config_set_speed() calls filter_set_speed() which calls accelerator_set_speed() which reaches the assert(). My patch basically removes the assert() and replaces it by a return false so that it fails gracefully. Cheers, Olivier - Original Message

Re: [PATCH weston v2] Fix "Back", "Forward", and other special mouse buttons in the X11 compositor.

2015-02-04 Thread Peter Hutterer
On Wed, Feb 04, 2015 at 01:51:57AM -0800, Dima Ryazanov wrote: > They're off by 4 because of the scroll buttons. > > Signed-off-by: Dima Ryazanov Reviewed-by: Peter Hutterer Cheers, Peter > --- > src/compositor-x11.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > dif

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
Hi Peter, Weird, that occurs with xf86-drv-libinput and libinput both from git as of today. I don't think this is an uninitialized variable, it's really the Xorg client (read, my code) that sends values out of range and that takes the whole X server down because of the assert()... Cheers, Oli

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Peter Hutterer
On Wed, Feb 04, 2015 at 10:34:25AM +0100, Olivier Fourdan wrote: > Libinput's accelerator_set_speed() asserts the given speed value is > within the [-1.0, 1.0] range. > > When using xf86-input-libinput, a client may try to set an invalid speed > which will cause the entire Xserver to abort. > > I

Re: [PATCH] RDP compositor: fixes for multiple connections and mstsc

2015-02-04 Thread John Obaterspok
2015-02-04 18:42 GMT+01:00 Hardening : > > Hum I don't know what's wrong withe the version of FreeRdp shipped with > fedora 21, as nsc_context_reset() is there from a really long time. I'll > try to workaround that but without promise (got to install a fedora 21 > to see what's going no). Using Fre

[PATCH] RDP compositor: v2 fixes for multiple connections and mstsc

2015-02-04 Thread Hardening
This patch fixes the problem reported on the mailing list (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html). All certificate and key paths were not copied when given to FreeRDP, so they were freed when the peer was disconnecting. And so the next connection was failing.

Re: [PATCH] RDP compositor: fixes for multiple connections and mstsc

2015-02-04 Thread Hardening
Le 02/02/2015 21:03, John Obaterspok a écrit : > Hello, > > I had a bit problem to apply the patch. I tried both 1.6.0 and weston git. > Finally I went to patch the 1.6.0 version I have in Fedora 21. > > I needed to comment out the cmd->skipCompression = FALSE; I have a patch for this. > > fr

[PATCH weston v2] Fix "Back", "Forward", and other special mouse buttons in the X11 compositor.

2015-02-04 Thread Dima Ryazanov
They're off by 4 because of the scroll buttons. Signed-off-by: Dima Ryazanov --- src/compositor-x11.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 5863446..2792251 100644 --- a/src/compositor-x11.c +++ b/src/composit

Re: [PATCH weston] Fix "Back", "Forward", and other special mouse buttons in the X11 compositor.

2015-02-04 Thread Dima Ryazanov
I actually feel the same way - but kept the old style just in case. I'll update it. On Tue, Feb 3, 2015 at 2:36 PM, Peter Hutterer wrote: > On Mon, Dec 22, 2014 at 11:51:05AM -0800, Dima Ryazanov wrote: > > They're off by 4 because of the scroll buttons. > > > > (However, if you test them in XWa

[PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
Libinput's accelerator_set_speed() asserts the given speed value is within the [-1.0, 1.0] range. When using xf86-input-libinput, a client may try to set an invalid speed which will cause the entire Xserver to abort. Instead of aborting on invalid speed values, simply return a failure (and log a