[PATCH libinput] Add a libinput_device_get_udev_devices() call for merged devices

2015-01-29 Thread Peter Hutterer
Merged devices may comprise of multiple event nodes. To get those we need to return all udev devices we have. This patch still leaves the backend where it is (one evdev device per libinput device) and merely introduces the new API. Signed-off-by: Peter Hutterer --- This is preparation work for t

[ANNOUNCE] libinput 0.9.0

2015-01-29 Thread Peter Hutterer
A new release of libinput, 0.9, is available. This release is ABI-compatible with libinput 0.8, but a set of new functions has been added. Main changes: * Support for hovering fingers on touchpads. Some touchpads detect fingers before actually touching the surface causing unexpected motion ev

[PATCH weston v2 2/2] libinput: Only forward first and last press and release for a key

2015-01-29 Thread Jonas Ådahl
Keyboard key events will be received from a device where a key has been pressed, even though an equivalent key has been pressed (same key code) on a device connected to the same seat. notify_key() expects to only be called as if there was only one keyboard device associated with the given seat, so

[PATCH weston v2 1/2] libinput: Only forward first and last press and release for a button

2015-01-29 Thread Jonas Ådahl
Pointer button events will be received from a device where a button has been pressed, even though an equivalent button has been pressed (same button code) on a device connected to the same seat. notify_button() expects to only be called as if there was only one pointer device associated with the gi

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-29 Thread Bill Spitzak
On 01/29/2015 03:09 AM, Carlos Garnacho wrote: On mié, 2015-01-28 at 13:09 -0800, Bill Spitzak wrote: I would greatly prefer to get an event when this happens. The user expects something to happen when they push a button. You cannot just throw it away. I think it is perfectly safe to send mul

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-29 Thread Bill Spitzak
On 01/28/2015 07:21 PM, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 01:09:09PM -0800, Bill Spitzak wrote: I would greatly prefer to get an event when this happens. The user expects something to happen when they push a button. You cannot just throw it away. the alternative is leave button/

Re: [PATCH weston] xwayland-test: Replace the xwayland-test

2015-01-29 Thread Bryce Harrington
On Thu, Jan 29, 2015 at 04:44:55PM -0600, Derek Foreman wrote: > The old xwayland-test hasn't worked in a while... > > This new test checks that the wayland specific WL_SURFACE_ID atom exists, > checks that the window manager name is "Weston WM" and then maps a window > and waits for an exposure e

Re: [PATCH weston] xwm: fix use after free

2015-01-29 Thread Bryce Harrington
On Thu, Jan 29, 2015 at 07:17:31PM +0200, Giulio Camuffo wrote: > 2015-01-28 5:29 GMT+02:00 Bryce Harrington : > > On Fri, Dec 26, 2014 at 06:10:35PM +0200, Giulio Camuffo wrote: > >> Calling wl_event_source_remove() will free the event source later, so > >> reset the pointer to avoid calling it tw

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Peter Hutterer
On Thu, Jan 29, 2015 at 06:42:54PM +0100, Hans de Goede wrote: > Hi, > > On 29-01-15 16:23, Carlos Garnacho wrote: > >Hey Peter, > > > >On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: > > > > >>Isn't this mostly a UI issue than the gesture itself? Most gestures you > >>"undo" by doing

Re: [PATCH wayland v2] doc: Fill in high level description for Surfaces

2015-01-29 Thread Jon A. Cruz
Looks good. Reviewed-by: Jon A. Cruz On 01/27/2015 04:32 PM, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > doc/publican/sources/Protocol.xml | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/doc/publican/sources/Protocol.xml > b/doc/

Re: [PATCH weston] input: Don't test keyboard/pointer/touch pointers

2015-01-29 Thread Hardening
Le 29/01/2015 18:39, Derek Foreman a écrit : > Keyboards and pointers aren't freed when devices are removed, > so we should really be testing keyboard_device_count and > pointer_device_count in most cases, not the actual pointers. > Otherwise we end up with different behaviour after removing a > de

Re: [PATCH V3] doc: Intro text for doxygen output in it's own file

2015-01-29 Thread Jon A. Cruz
Looks good as far as I can tell. I especially like that the content was moved out of the xsl and into data files. Reviewed-by: Jon A. Cruz Tested-by: Jon A. Cruz On 01/28/2015 06:44 PM, Bill Spitzak wrote: > (This patch has been modified to apply atop current master) > > This makes it consider

[PATCH weston] xwayland-test: Replace the xwayland-test

2015-01-29 Thread Derek Foreman
The old xwayland-test hasn't worked in a while... This new test checks that the wayland specific WL_SURFACE_ID atom exists, checks that the window manager name is "Weston WM" and then maps a window and waits for an exposure event. Signed-off-by: Derek Foreman --- configure.ac | 2 +-

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 29-01-15 16:23, Carlos Garnacho wrote: Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: Isn't this mostly a UI issue than the gesture itself? Most gestures you "undo" by doing the reverse. when you start pinching, expanding the fingers restores you back to the ori

[PATCH weston] input: Don't test keyboard/pointer/touch pointers

2015-01-29 Thread Derek Foreman
Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers. Otherwise we end up with different behaviour after removing a device than we had before it was inserted. There are som

Re: [PATCH weston] xwm: fix use after free

2015-01-29 Thread Giulio Camuffo
2015-01-28 5:29 GMT+02:00 Bryce Harrington : > On Fri, Dec 26, 2014 at 06:10:35PM +0200, Giulio Camuffo wrote: >> Calling wl_event_source_remove() will free the event source later, so >> reset the pointer to avoid calling it two times on the same pointer. >> Fix a compositor crash when copying some

[PATCH weston v4] xwm: support maximizing xwayland windows

2015-01-29 Thread Giulio Camuffo
This patch adds the maximize button to the window frame for the windows which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell via a new method in weston_shell_interface. Additionally, it also listens for the wm hints coming from the client, but it doesn't support maximizing a window

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
Hey Peter, On jue, 2015-01-29 at 21:54 +1000, Peter Hutterer wrote: > On 29/01/2015 20:58 , Carlos Garnacho wrote: > > On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: > >> On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > >>> Hey, > >>> > >>> On mié, 2015-01-28 at 15:51 +

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-29 Thread Daniel Stone
Hi, On 28 January 2015 at 04:18, Jonas Ådahl wrote: > Pointer button events will be received from a device where a button has > been pressed, even though an equivalent button has been pressed (same > button code) on a device connected to the same seat. notify_button() > expects to only be called

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Peter Hutterer
On 29/01/2015 20:58 , Carlos Garnacho wrote: > On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: >> On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: >>> Hey, >>> >>> On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-29 Thread Carlos Garnacho
On mié, 2015-01-28 at 13:09 -0800, Bill Spitzak wrote: > I would greatly prefer to get an event when this happens. The user > expects something to happen when they push a button. You cannot just > throw it away. > > I think it is perfectly safe to send multiple press and release events. > No pr

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Carlos Garnacho
On jue, 2015-01-29 at 16:26 +1000, Peter Hutterer wrote: > On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > > Hey, > > > > On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 28-01-15 13:59, Carlos Garnacho wrote: > > > > Hey Hans!, > > > > > > > > (

Re: [PATCH libinput 0/4] Lenovo X1 Carbon 3rd support

2015-01-29 Thread Hans de Goede
Hi, On 29-01-15 05:55, Peter Hutterer wrote: Lenovo is back with a new generation hardware, the trackpoint's physical buttons are back, and our headache is back too. Lenovo decided to wire the buttons to the touchpad so they show up as BTN_0, 1, 2. Which means we have to re-route them through t

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 29-01-15 07:11, Peter Hutterer wrote: On Wed, Jan 28, 2015 at 04:02:20PM +0100, Hans de Goede wrote: Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: Ok, I'll change this to mm for v3 then (just send v2 addressing the

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-29 Thread Hans de Goede
Hi, On 28-01-15 19:18, Carlos Garnacho wrote: Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: +