Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 06:18:44PM +, Carlos Garnacho wrote: > Hey, > > On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > > Hi, > > > > On 28-01-15 13:59, Carlos Garnacho wrote: > > > Hey Hans!, > > > > > > (sorry for chiming in late, things got busy around Fosdem...) > > > > > > On j

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 04:02:20PM +0100, Hans de Goede wrote: > Hi, > > On 28-01-15 14:02, Carlos Garnacho wrote: > >Hey Hans, > > > >On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: > > > > >>>Ok, I'll change this to mm for v3 then (just send v2 addressing the other > >>>review comment

Re: [PATCH 1/1] configure.ac: use pkg-config to find expat

2015-01-28 Thread Bryce Harrington
On Tue, Jan 27, 2015 at 05:32:33PM +0100, sardemff7+wayl...@sardemff7.net wrote: > Once the two things below are fixed: > > Reviewed-by: Quentin Glidic Thanks, applied. cd0cf5a..a4afd90 master -> master P.S. Andrew, we're adopting the practice of putting weston or wayland in the subject li

[PATCH libinput 2/4] test: add a test device for the Lenovo X1 Carbon 3rd

2015-01-28 Thread Peter Hutterer
Notable: sends BTN_0/1/2 instead of the trackpoint This device currently has the INPUT_PROP_TOPBUTTONPAD property set, kernel patches [1] and [2] are pending to remove this. This test device already lacks the property. [1] https://patchwork.kernel.org/patch/5730371/ [2] https://patchwork.kernel.o

[PATCH libinput 1/4] test: set the input_id->version as well in litest devices

2015-01-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/litest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/litest.c b/test/litest.c index 7d48278..b5ce0a8 100644 --- a/test/litest.c +++ b/test/litest.c @@ -1048,6 +1048,7 @@ litest_create_uinput_device_from_description(const char *name,

[PATCH libinput 3/4] touchpad: re-route trackpoint buttons on the *50 Lenovo series

2015-01-28 Thread Peter Hutterer
The laptops on this series have the physical trackpoint buttons back but wired them up to the touchpad instead of the trackpoint device and they appear as BTN_0, BTN_1 and BTN_2 for left, right, middle. The udev hwdb marks these for us with the TOUCHPAD_HAS_TRACKPOINT_BUTTONS tag [1]. Use that tag

[PATCH libinput 0/4] Lenovo X1 Carbon 3rd support

2015-01-28 Thread Peter Hutterer
Lenovo is back with a new generation hardware, the trackpoint's physical buttons are back, and our headache is back too. Lenovo decided to wire the buttons to the touchpad so they show up as BTN_0, 1, 2. Which means we have to re-route them through the trackpoint device, much like we already do fo

[PATCH libinput 4/4] test: add tests for new lenovo touchpads

2015-01-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 6 + test/litest-synaptics-x1-carbon-3rd.c | 1 + test/touchpad.c | 291 ++ 3 files changed, 298 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-t

[PATCH V3] doc: Intro text for doxygen output in it's own file

2015-01-28 Thread Bill Spitzak
(This patch has been modified to apply atop current master) This makes it considerably easier to edit the text and make it different for each library. To address previous concerns with this patch, I wrote some more complete introductory text. This is based on my understanding of these libraries,

RE: [PATCH weston] ivi-shell-transition: check create_layout_transition() return value.

2015-01-28 Thread Tanibata, Nobuhiko (ADITJ/SWG)
Hi, Sorry for delay. I agree with your point. Thank you for good update. BR, Nobuhiko Tanibata > -Original Message- > From: wayland-devel > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Bryce > Harrington > Sent: Thursday, January 29, 2015 11:55 AM > To: Carlos Olmedo

Re: [PATCH] doc/publican/Makefile.am: Add a missing order-only prerequisite

2015-01-28 Thread Bill Spitzak
I have been using this patch for a while and it looks good, I think somebody should push it. On Tue, Jan 6, 2015 at 10:44 AM, Jon A. Cruz wrote: > On 01/06/2015 08:35 AM, Rui Matos wrote: > > Otherwise a parallel make invocation could fail due to the directory > > not existing. > > > > Signed-o

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-28 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 01:09:09PM -0800, Bill Spitzak wrote: > I would greatly prefer to get an event when this happens. The user expects > something to happen when they push a button. You cannot just throw it away. X does this, OS X does this too. I suspect Windows does as well because quite fra

Re: [PATCH v3 3/3] doc: update diagrams for compatibility.

2015-01-28 Thread Bill Spitzak
This works with the slightly dated doxygen and graphviz installed on my machine here that did not work with the libinput diagrams. On 01/28/2015 05:59 PM, Bryce Harrington wrote: On Wed, Jan 28, 2015 at 05:54:57PM -0800, Bryce Harrington wrote: On Wed, Jan 28, 2015 at 05:24:06PM -0800, Jon A.

Re: [PATCH weston 6/6] compositor-headless: Add test mode

2015-01-28 Thread Bryce Harrington
On Tue, Jan 27, 2015 at 12:38:46PM +, Daniel Stone wrote: > Hi, > > On 19 December 2014 at 18:45, Derek Foreman wrote: > > static int > > headless_output_repaint(struct weston_output *output_base, > >pixman_region32_t *damage) > > { > > struct headless_outpu

Re: [PATCH] doc/publican/Makefile.am: Add a missing order-only prerequisite

2015-01-28 Thread Bryce Harrington
On Tue, Jan 06, 2015 at 10:44:25AM -0800, Jon A. Cruz wrote: > On 01/06/2015 08:35 AM, Rui Matos wrote: > > Otherwise a parallel make invocation could fail due to the directory > > not existing. > > > > Signed-off-by: Rui Matos > > Looks good. > > Reviewed-by: Jon A. Cruz Thanks, applied:

Re: [PATCH weston] ivi-shell-transition: check create_layout_transition() return value.

2015-01-28 Thread Bryce Harrington
On Sat, Jan 17, 2015 at 07:43:02PM +0100, Carlos Olmedo Escobar wrote: > Signed-off-by: Carlos Olmedo Escobar Reviewed-by: Bryce Harrington This patch simply does null pointer checks for several malloc calls. Entirely safe and appropriate to do here. Looks like Nobuhiko Tanibata also agreed wit

Re: [PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 06:16:16PM +0200, Giulio Camuffo wrote: > Forgot the > > Reviewed-by: Giulio Camuffo Thanks, applied. 7575e2e..5ec8062 master -> master I think this is one of those things that'll be easier to prove right in practice rather than on paper, so let's put this through b

Re: [PATCH v3 3/3] doc: update diagrams for compatibility.

2015-01-28 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 05:54:57PM -0800, Bryce Harrington wrote: > On Wed, Jan 28, 2015 at 05:24:06PM -0800, Jon A. Cruz wrote: > > Change attribute separators for compatiblity with graphviz older than 2.30. > > > > Signed-off-by: Jon A. Cruz > > Changes look good, and I verified the output com

Re: [PATCH v3 3/3] doc: update diagrams for compatibility.

2015-01-28 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 05:24:06PM -0800, Jon A. Cruz wrote: > Change attribute separators for compatiblity with graphviz older than 2.30. > > Signed-off-by: Jon A. Cruz Changes look good, and I verified the output comes up fine in firefox, and actually looks a bit nicer than the current image.

[PATCH v3 3/3] doc: update diagrams for compatibility.

2015-01-28 Thread Jon A. Cruz
Change attribute separators for compatiblity with graphviz older than 2.30. Signed-off-by: Jon A. Cruz --- doc/doxygen/dot/wayland-architecture.gv | 44 ++--- doc/doxygen/dot/x-architecture.gv | 50 - 2 files changed, 47 insertions(+)

[PATCH v3 1/3] doc: Switch from static image files to generated diagrams.

2015-01-28 Thread Jon A. Cruz
Switches diagrams from using static PNG images to instead generate them via simple graphviz DOT markup files. Signed-off-by: Jon A. Cruz --- configure.ac | 13 + doc/doxygen/Makefile.am| 15 +- doc/doxygen/dot/wayland-ar

[PATCH v3 2/3] doc: Create hot-linked areas in documents.

2015-01-28 Thread Jon A. Cruz
Added xslt processing to give DocBook output diagram image maps/hot-linked areas consistent with those automatically generated by Doxygen. Signed-off-by: Jon A. Cruz --- doc/doxygen/Makefile.am | 10 - doc/publican/Makefile.am | 21 -- doc/publican/merge-ma

[PATCH v3 0/3] doc: Switch to generated diagrams with hot-linked areas.

2015-01-28 Thread Jon A. Cruz
Third round patch tuned for working with older graphviz versions. These changes switch from static png images for diagrams to generated diagrams with hot-linked areas. It adds xslt to do the 'heavy lifting' of adding useful diagrams and automate linking with graphviz output consistent with the wa

Re: [PATCH weston] tests: Rename wayland-test to weston-test

2015-01-28 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 03:11:29PM -0600, Derek Foreman wrote: > wayland-test isn't and will never be wayland protocol, it's weston internal. > > Renamed wayland-test to weston-test, and wl_test to weston_test. > > Also added a Big Fat Warning to the description of weston_test to try to > keep pe

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-28 Thread Jonas Ådahl
On Wed, Jan 28, 2015 at 01:09:09PM -0800, Bill Spitzak wrote: > I would greatly prefer to get an event when this happens. The user expects > something to happen when they push a button. You cannot just throw it away. > > I think it is perfectly safe to send multiple press and release events. No >

Re: [PATCH weston 1/2] shell: fix positioning of maximized surfaces with a custom geometry

2015-01-28 Thread Bryce Harrington
On Fri, Jan 09, 2015 at 08:10:45PM +0200, Giulio Camuffo wrote: > --- > desktop-shell/shell.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Applied this first patch to trunk. 237a684..7a8d67d master -> master The second one adds a warning to the build, but otherwise looks

[PATCH weston] tests: Rename wayland-test to weston-test

2015-01-28 Thread Derek Foreman
wayland-test isn't and will never be wayland protocol, it's weston internal. Renamed wayland-test to weston-test, and wl_test to weston_test. Also added a Big Fat Warning to the description of weston_test to try to keep people from thinking it's a good idea to use some of these functions outside

Re: [PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-28 Thread Bill Spitzak
I would greatly prefer to get an event when this happens. The user expects something to happen when they push a button. You cannot just throw it away. I think it is perfectly safe to send multiple press and release events. No program is going to fail because of this. And as this demonstrates,

[PATCH weston v2 2/2] text-input: Replace model with input

2015-01-28 Thread Derek Foreman
commit 78d00e45cc renamed text_model to text_input This cleans up remaining uses of the word "model" Signed-off-by: Derek Foreman --- Same as seen previously, just rebased. protocol/input-method.xml | 18 ++-- src/text-backend.c| 70 +++-

[PATCH weston v2 1/2] text: Fix text-input for multi-seat

2015-01-28 Thread Derek Foreman
Multi-seat configurations currently break the text-backend, crashing weston. This is an attempt to clean up any crashes and have somewhat sensible input panel behavior with multi-seat. Store a link to the manager that created a text_input, use this to ensure that only a single panel gets popped u

Re: [weston,v1,17/17] tests: add interactive tests

2015-01-28 Thread Bryce Harrington
On Wed, Jan 28, 2015 at 03:48:16PM +0100, Marek Chalupa wrote: > On 27 January 2015 at 21:49, Bryce Harrington wrote: > > > On Fri, Dec 05, 2014 at 02:36:50PM +0100, Marek Chalupa wrote: > > > These tests are using pointer and keyboard simulated events > > > to interact with client. > > > > > > S

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey, On mié, 2015-01-28 at 15:51 +0100, Hans de Goede wrote: > Hi, > > On 28-01-15 13:59, Carlos Garnacho wrote: > > Hey Hans!, > > > > (sorry for chiming in late, things got busy around Fosdem...) > > > > On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: > >> + LIBINPUT_EVENT_GESTURE_SWIP

Re: [PATCH wayland 2/8] test-compositor: extend leak checks into clients

2015-01-28 Thread Daniel Stone
Hi, On 28 January 2015 at 16:38, Marek Chalupa wrote: > On Tue, Jan 27, 2015 at 1:24 PM, Daniel Stone wrote: >> I really like this series, but this bit seems a bit fragile. How about >> something like the two attached patches, which seems to work for me? >> The first one can be squashed into thi

Re: [PATCH libinput 2/2] remove libinput_event_pointer_get_axis from symbols

2015-01-28 Thread Marek Chalupa
On Thu, Jan 22, 2015 at 3:01 AM, Peter Hutterer wrote: > On Wed, Jan 21, 2015 at 12:11:22PM +0100, Marek Chalupa wrote: > > This function was removed in 1baf109b40 > > > > Signed-off-by: Marek Chalupa > > --- > > src/libinput.sym | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/src

Re: [PATCH wayland 2/8] test-compositor: extend leak checks into clients

2015-01-28 Thread Marek Chalupa
On Tue, Jan 27, 2015 at 1:24 PM, Daniel Stone wrote: > Hi, > > On 19 December 2014 at 13:53, Marek Chalupa wrote: > > diff --git a/tests/test-compositor.h b/tests/test-compositor.h > > index c41b17b..f77a5db 100644 > > --- a/tests/test-compositor.h > > +++ b/tests/test-compositor.h > > @@ -95,3

Re: [PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Giulio Camuffo
Forgot the Reviewed-by: Giulio Camuffo 2015-01-28 17:58 GMT+02:00 Giulio Camuffo : > 2015-01-28 17:49 GMT+02:00 Derek Foreman : >> On 28/01/15 09:39 AM, Giulio Camuffo wrote: >>> 2015-01-28 17:25 GMT+02:00 Derek Foreman : To fix a shutdown crash in weston's x11 compositor I want to move th

Re: [PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Giulio Camuffo
2015-01-28 17:49 GMT+02:00 Derek Foreman : > On 28/01/15 09:39 AM, Giulio Camuffo wrote: >> 2015-01-28 17:25 GMT+02:00 Derek Foreman : >>> To fix a shutdown crash in weston's x11 compositor I want to move the >>> weston X window close to an idle handler. >>> >>> Since idle handlers are processed at

Re: [PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Derek Foreman
On 28/01/15 09:39 AM, Giulio Camuffo wrote: > 2015-01-28 17:25 GMT+02:00 Derek Foreman : >> To fix a shutdown crash in weston's x11 compositor I want to move the >> weston X window close to an idle handler. >> >> Since idle handlers are processed at the start of an event loop, the >> handler that d

Re: [PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Giulio Camuffo
2015-01-28 17:25 GMT+02:00 Derek Foreman : > To fix a shutdown crash in weston's x11 compositor I want to move the > weston X window close to an idle handler. > > Since idle handlers are processed at the start of an event loop, the > handler that deals with window close will run at the start of the

[PATCH wayland v2] event-loop: Dispatch idle callbacks twice

2015-01-28 Thread Derek Foreman
To fix a shutdown crash in weston's x11 compositor I want to move the weston X window close to an idle handler. Since idle handlers are processed at the start of an event loop, the handler that deals with window close will run at the start of the next input_loop dispatch, after which the dispatche

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Hans de Goede
Hi, On 28-01-15 14:02, Carlos Garnacho wrote: Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: Ok, I'll change this to mm for v3 then (just send v2 addressing the other review comments and adding a core implementation). So I've been thinking more about this and I'm still

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Hans de Goede
Hi, On 28-01-15 13:59, Carlos Garnacho wrote: Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, + LIBINPUT_EVENT_GESTURE_SWIPE, + LIBINPUT_EVENT_GESTURE

Re: [weston,v1,17/17] tests: add interactive tests

2015-01-28 Thread Marek Chalupa
On 27 January 2015 at 21:49, Bryce Harrington wrote: > On Fri, Dec 05, 2014 at 02:36:50PM +0100, Marek Chalupa wrote: > > These tests are using pointer and keyboard simulated events > > to interact with client. > > > > Signed-off-by: Marek Chalupa > > Hi Marek, > > This patch series has a number

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Hans, On mié, 2015-01-28 at 08:38 +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 14:57, Hans de Goede wrote: > > Hi, > > > > On 23-01-15 14:53, Jonas Ådahl wrote: > >> On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 23-01-15 05:21, Peter Hutterer wro

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hi Jonas, On mar, 2015-01-27 at 15:17 +0800, Jonas Ådahl wrote: > > more the former than the latter. we don't really provide a way to associate > > the two event sequences with each other, so a caller would have to track > > whether we're currently scrolling or gesturing and discard the > > gestur

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Jonas, On mar, 2015-01-27 at 13:49 +0800, Jonas Ådahl wrote: > > > > anyway, the other escape hatch we have is: we don't _have_ to support all > > gestures. 2fg scrolling and swiping are incompatible, so short of changing > > all scrolling to swiping and letting the caller deal with the di

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-28 Thread Carlos Garnacho
Hey Hans!, (sorry for chiming in late, things got busy around Fosdem...) On jue, 2015-01-22 at 16:52 +0100, Hans de Goede wrote: > + LIBINPUT_EVENT_GESTURE_SWIPE_START = 600, > + LIBINPUT_EVENT_GESTURE_SWIPE, > + LIBINPUT_EVENT_GESTURE_SWIPE_END, > }; > One thing I'm unsure about

Re: [weston, v2, 17/17] configure: add an option to allow building only the libraries

2015-01-28 Thread Giulio Camuffo
2015-01-27 22:43 GMT+02:00 Bryce Harrington : > On Thu, Dec 04, 2014 at 11:01:23PM +0200, Giulio Camuffo wrote: >> the --enable/disable-weston-binaries emable or disable the creation >> of the 'weston', 'weston-launch' and all the binaries that are >> installed in $prefix/lib/libexec. This allows,