Re: Error making docs for libinput

2015-01-23 Thread Jon A. Cruz
On 01/23/2015 06:34 PM, Bill Spitzak wrote: > When I run make on libinput I get these errors: > > GENhtml/index.html > Warning: ignoring unsupported tag `ALLOW_UNICODE_NAMES=' at line 79, > file - > Warning: ignoring unsupported tag `MAN_SUBDIR =' at line > 1787, file - > War

Re: [PATCH] doc: Correct missing file warnings from files explicitly moved during build.

2015-01-23 Thread Jon A. Cruz
Yes, that sounds better. On 01/23/2015 08:18 PM, Bill Spitzak wrote: > It looks like the _8h files can be left as-is, I have posted two > alternative patches, the first keeps the _8h files and the second extracts > some documentation that was left in them. > > > On Thu, Jan 8, 2015 at 3:15 PM, B

Re: [PATCH wayland 1/3] protocol: Fix typo in wl_data_offer

2015-01-23 Thread Bill Spitzak
Looks good to me On Fri, Jan 23, 2015 at 12:21 AM, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > > Hi, > > This small series is a couple of trivial patches I had laying around and > a clarification of some existing heuristic (patch 2) that are already in > praxis. > > > Jonas > > pro

Re: [PATCH wayland 2/3] protocol: Clarify selection data offer destruction requirement

2015-01-23 Thread Bill Spitzak
Looks correct to me. On Fri, Jan 23, 2015 at 12:21 AM, Jonas Ådahl wrote: > Clarify that a client receiving a wl_data_device.selection event must > destroy the data_offer of the previous wl_data_device.selection event, > if any. > > Signed-off-by: Jonas Ådahl > --- > protocol/wayland.xml | 4 +

Re: [PATCH] doc: Correct missing file warnings from files explicitly moved during build.

2015-01-23 Thread Bill Spitzak
It looks like the _8h files can be left as-is, I have posted two alternative patches, the first keeps the _8h files and the second extracts some documentation that was left in them. On Thu, Jan 8, 2015 at 3:15 PM, Bill Spitzak wrote: > Yea this was annoying. > > I think it may be possible to ma

Re: [PATCH 8/8] doc: remove redundant subtitles

2015-01-23 Thread Bryce Harrington
On Fri, Jan 02, 2015 at 06:29:22PM -0800, Bill Spitzak wrote: > Put the argument lists next to the event/message title, which I > think makes it a lot easier to understand, and remove redudant > "values" title from enumerations. > --- > doc/publican/protocol-to-docbook.xsl | 38 > ++

Error making docs for libinput

2015-01-23 Thread Bill Spitzak
When I run make on libinput I get these errors: GENhtml/index.html Warning: ignoring unsupported tag `ALLOW_UNICODE_NAMES=' at line 79, file - Warning: ignoring unsupported tag `MAN_SUBDIR =' at line 1787, file - Warning: ignoring unsupported tag `DOCBOOK_PROGRAMLISTING ='

Re: [PATCH weston] xwm: don't set inactive surfaces as top level

2015-01-23 Thread Bryce Harrington
On Mon, Jan 19, 2015 at 05:57:43PM -0800, Bill Spitzak wrote: > > > On 01/12/2015 09:14 AM, Giulio Camuffo wrote: > > >+static bool > >+weston_wm_window_inactive(struct weston_wm_window *window) > >+{ > >+struct weston_wm *wm = window->wm; > >+ > >+return window->type == wm->atom.net_wm_

Re: [PATCH wayland 3/3] server: Use existing id variable when inserting created object

2015-01-23 Thread Bryce Harrington
On Fri, Jan 23, 2015 at 04:21:15PM +0800, Jonas Ådahl wrote: > We already have the id variable there and it makes it slightly easier to > read. > > Signed-off-by: Jonas Ådahl Thanks, applied all three. b7f9925..ab3ee6f master -> master > --- > src/wayland-server.c | 5 ++--- > 1 file cha

Re: [PATCH v2 weston] tests: Skip buffer count test if wl_drm isn't present

2015-01-23 Thread Bryce Harrington
On Fri, Jan 23, 2015 at 12:12:36PM -0600, Derek Foreman wrote: > This skips the test when running on the headless backend. > > Signed-off-by: Derek Foreman Derek says Daniel is good with this solution, and it LGTM, so applied, thanks. 194ca2b..9bb1339 master -> master > --- > tests/buffe

[ANNOUNCE] weston 1.6.1

2015-01-23 Thread Bryce Harrington
A bugfix release for the weston 1.6 series. This cherrypicks a number of safe fixes and user documentation improvements from the 1.7 tree. This stabilizes the recently integrated libinput and updates us to its latest API. Since this library has proven itself by now, we're making it a hard requir

[PATCH 2/3] doc: Add macros and typedefs to the documentation

2015-01-23 Thread Bill Spitzak
If somebody bothered to put a doxygen comment in for a macro or typedef, make it appear in the pages. This produces documentation for wl_container_of and wl_dispatcher_func_t from the _8h files. --- doc/publican/doxygen-to-publican.xsl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCH 3/3] doc: Put a dash between type/enum value and description

2015-01-23 Thread Bill Spitzak
This was suggested by Derek Foreman, I think it looks better --- doc/publican/protocol-to-docbook.xsl | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/publican/protocol-to-docbook.xsl b/doc/publican/protocol-to-docbook.xsl index a886b7f..7b45969 100644 --- a/do

[PATCH] doc: more improvements to docs

2015-01-23 Thread Bill Spitzak
These are additional patches added after my previous set. The main thing they do is remove that problematic step of hiding the "8h" files, and restoring some doxygen comments that were lost in those files. I also made a tiny change to the Protocol docs suggested by Derek. _

[PATCH 1/3] doc: there is no need to move the _8h files

2015-01-23 Thread Bill Spitzak
The current xslt skips all the data that is in them, so it is ok if they are included. --- doc/publican/Makefile.am |8 1 file changed, 8 deletions(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index ed2a645..4020a7c 100644 --- a/doc/publican/Makefile.am +++ b/d

[ANNOUNCE] wayland 1.6.1

2015-01-23 Thread Bryce Harrington
This is a maintenance release for Wayland 1.6, with a handful of fixes pulled from the 1.7 tree that improve handling of several error situations between server and clients. Bill Spitzak (1): doc: fixed a typo Bryce Harrington (1): configure.ac: bump version to 1.6.1 for stable releas

[PATCH 2/2] libinput: Check if axis value is available in debugging GUI

2015-01-23 Thread code
From: Friedrich Schöller libinput complained with lots of "client bug" messages because the GUI tool did not check which axis values were available. Signed-off-by: Friedrich Schöller --- tools/event-gui.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff

[PATCH 1/2] libinput: Use correct event axis in debugging GUI

2015-01-23 Thread code
From: Friedrich Schöller Vertical axis values were used for the horizontal axis as well. Signed-off-by: Friedrich Schöller --- tools/event-gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/event-gui.c b/tools/event-gui.c index 4f9d7e6..e574bf7 100644 --- a/tools/e

Re: [PATCH v2 weston] tests: Skip buffer count test if wl_drm isn't present

2015-01-23 Thread Bryce Harrington
On Fri, Jan 23, 2015 at 12:12:36PM -0600, Derek Foreman wrote: > This skips the test when running on the headless backend. > > Signed-off-by: Derek Foreman Nice, looks like a cleaner solution. Reviewed-by: Bryce Harrington > --- > tests/buffer-count-test.c | 3 +++ > tests/weston-tes

[PATCH v2 weston] tests: Skip buffer count test if wl_drm isn't present

2015-01-23 Thread Derek Foreman
This skips the test when running on the headless backend. Signed-off-by: Derek Foreman --- tests/buffer-count-test.c | 3 +++ tests/weston-test-client-helper.c | 2 ++ tests/weston-test-client-helper.h | 2 ++ 3 files changed, 7 insertions(+) diff --git a/tests/buffer-count-test.c b/tes

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-23 Thread Derek Foreman
On 23/01/15 11:16 AM, Bryce Harrington wrote: > On Tue, Jan 20, 2015 at 01:16:26PM -0600, Derek Foreman wrote: >> This also skips the test when running on the headless backend. >> >> Signed-off-by: Derek Foreman > > Reviewed-by: Bryce Harrington > > (But waiting for resolution on daniels' comme

Re: [PATCH wayland 3/3] server: Use existing id variable when inserting created object

2015-01-23 Thread Bryce Harrington
On Fri, Jan 23, 2015 at 04:21:15PM +0800, Jonas Ådahl wrote: > We already have the id variable there and it makes it slightly easier to > read. > > Signed-off-by: Jonas Ådahl > --- > src/wayland-server.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/wayland-s

Re: [PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

2015-01-23 Thread Bryce Harrington
On Tue, Jan 20, 2015 at 01:16:26PM -0600, Derek Foreman wrote: > This also skips the test when running on the headless backend. > > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington (But waiting for resolution on daniels' comments to pull.) > --- > tests/buffer-count-test.c | 5

Re: [RFC libinput v2] Add an API for touchpad gesture events

2015-01-23 Thread Derek Foreman
On 23/01/15 07:46 AM, Hans de Goede wrote: > For touchscreens we always send raw touch events to the compositor, and the > compositor or application toolkits do gesture recognition. This makes sense > because on a touchscreen which window / widget the touches are over is > important context to know

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 14:53, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: Hi, On 23-01-15 05:21, Peter Hutterer wrote: +double +libinput_event_gesture_get_absolute_x(struct libinput_event_gesture *event); this is a bit inconsistent with the other API where

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Jonas Ådahl
On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 05:21, Peter Hutterer wrote: > >CC-ing Carlos too, I'd like to get his input here. > > > >On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: > >>For touchscreens we always send raw touch events to the

[RFC libinput v2] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition. This makes sense because on a touchscreen which window / widget the touches are over is important context to know to interpret gestures. On touchpads however we ne

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 09:51, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: Hi, On 23-01-15 07:18, Jonas Ådahl wrote: As for 2 finger swipe at least: isn't that covered by scrolling? with the caller deciding when a scroll event event is a swipe and when it is

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 05:21, Peter Hutterer wrote: CC-ing Carlos too, I'd like to get his input here. On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the compositor, and the compositor or application toolkits do gesture recognition.

How to auto-start "gtk3-demo" under weston from console?

2015-01-23 Thread Jeff Chua
I can use weston-laucher to start weston. But it won't start any program. I wanto to auto-start "gtk3-demo" under weston from console. Is that possible? This is a scan client so upon power on, it'll start weston and the scan program automatically. Thanks, Jeff,

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Jonas Ådahl
On Fri, Jan 23, 2015 at 09:38:06AM +0100, Hans de Goede wrote: > Hi, > > On 23-01-15 07:18, Jonas Ådahl wrote: > >On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: > >>On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: > >>>On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-23 Thread Hans de Goede
Hi, On 23-01-15 07:18, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 03:11:31PM +1000, Peter Hutterer wrote: On Fri, Jan 23, 2015 at 10:11:09AM +0800, Jonas Ådahl wrote: On Thu, Jan 22, 2015 at 04:52:50PM +0100, Hans de Goede wrote: For touchscreens we always send raw touch events to the composi

[PATCH wayland 2/3] protocol: Clarify selection data offer destruction requirement

2015-01-23 Thread Jonas Ådahl
Clarify that a client receiving a wl_data_device.selection event must destroy the data_offer of the previous wl_data_device.selection event, if any. Signed-off-by: Jonas Ådahl --- protocol/wayland.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/p

[PATCH wayland 3/3] server: Use existing id variable when inserting created object

2015-01-23 Thread Jonas Ådahl
We already have the id variable there and it makes it slightly easier to read. Signed-off-by: Jonas Ådahl --- src/wayland-server.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index c845dd6..cde1eef 100644 --- a/src/wayland-

[PATCH wayland 1/3] protocol: Fix typo in wl_data_offer

2015-01-23 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- Hi, This small series is a couple of trivial patches I had laying around and a clarification of some existing heuristic (patch 2) that are already in praxis. Jonas protocol/wayland.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protoco