Re: [PATCH 6/8] doc: compress the lists in the protocol docs some

2015-01-21 Thread Bill Spitzak
On 01/21/2015 08:17 AM, Derek Foreman wrote: I generally like the end result of this, but I don't really like the way summary is jammed up against type (when summary exists): name uint unique name for the object I think it might be better with a - or with summary in (). However, I think tha

Re: [PATCH 3/8] doc: Remove wl_map from documentation

2015-01-21 Thread Bill Spitzak
Both of \cond changes these are because the current doxygen config turns on documentation for all objects whether or not they have doxygen comments. You are right they probably could be removed if this was switched and comments were added to everything that was wanted. However a previous patch

Re: Failed to load module: /usr/way/lib/weston/rpi-backend.so: undefined symbol: eglTerminate

2015-01-21 Thread Jeff Chua
On Wed, Jan 21, 2015 at 5:30 PM, Jeff Chua wrote: > On Fri, Jan 2, 2015 at 7:52 PM, Pekka Paalanen > wrote: >> On Wed, 24 Dec 2014 12:49:23 +0800 >> Jeff Chua wrote: >> >>> I recompiled Tomeu's userland git and weston with EGL enabled. >>> Compiled ok, but starting weston gives the following err

Re: [PATCH libinput] evdev: Be more careful about what we consider a joystick

2015-01-21 Thread Peter Hutterer
On Wed, Jan 21, 2015 at 12:25:39PM +0100, Michael Schellenberger Costa wrote: > Hi, > > is there an acutal reason, why joysticks and/or gamepads are ignored > inside libinput. Is it just, that they are not yet implemented, or are > there some real reasons? > > If the answer is that nobody has yet

Re: [PATCH libinput] evdev: Be more careful about what we consider a joystick

2015-01-21 Thread Peter Hutterer
On Wed, Jan 21, 2015 at 12:04:48PM +0100, Hans de Goede wrote: > After switching my main workstation over to using xf86-input-libinput, I > noticed that the multi-media keys like play/pause on my keyboard no longer > worked. > > It turns out that the second hid interface on my keyboard which has t

Re: [PATCH libinput 2/2] remove libinput_event_pointer_get_axis from symbols

2015-01-21 Thread Peter Hutterer
On Wed, Jan 21, 2015 at 12:11:22PM +0100, Marek Chalupa wrote: > This function was removed in 1baf109b40 > > Signed-off-by: Marek Chalupa > --- > src/libinput.sym | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libinput.sym b/src/libinput.sym > index cfbeabd..77fccb8 100644 > --- a/

Re: [PATCH libinput 1/2] add simple symbols leak checker

2015-01-21 Thread Peter Hutterer
On Wed, Jan 21, 2015 at 12:11:21PM +0100, Marek Chalupa wrote: > This patch adds simple script that compares libinput.sym file to the > functions that are marked by LIBINPUT_EXPORT. This script is added > to make check target. good idea, thanks > Signed-off-by: Marek Chalupa > --- > test/Makefi

Re: [PATCH weston] build: install a login manager session entry

2015-01-21 Thread Bryce Harrington
On Wed, Jan 21, 2015 at 12:53:23PM +0100, sardemff7+wayl...@sardemff7.net wrote: > On 2015-01-21 04:46, Bryce Harrington wrote: > >On Sun, Dec 28, 2014 at 02:20:49PM +0100, Lubomir Rintel wrote: > >>This makes it possible to run Weston session from GDM (and possibly > >>other login managers). > >>-

Re: [PATCH 3/4] config-parser: Enable updating an already-loaded config

2015-01-21 Thread Bryce Harrington
On Wed, Jan 21, 2015 at 01:08:21PM -0600, Derek Foreman wrote: > On 20/01/15 05:30 PM, Bryce Harrington wrote: > > From: "Bryce Harrington" > > > > Adds weston_config_update(), which parses a condensed string of > > comma-delimited key/value pairs and adds or changes the corresponding > > paramet

Re: GTK hardware scancodes for wayland / detecting XWayland

2015-01-21 Thread Jasper St. Pierre
On Wed, Jan 21, 2015 at 7:03 AM, Daniel P. Berrange wrote: > I'm trying to port GTK-VNC to work correctly under Wayland, both as > a native client and as an Xwayland client. The only place we have > any code that is specific to particular display servers is the keyboard > handling. We can't use t

Re: [PATCH 1/4] config-parser: Document config_section_get_entry()

2015-01-21 Thread Bryce Harrington
On Wed, Jan 21, 2015 at 12:37:51PM -0600, Derek Foreman wrote: > On 20/01/15 05:30 PM, Bryce Harrington wrote: > > From: "Bryce Harrington" > > > > Signed-off-by: Bryce Harrington (http://osg.samsung.com) > > > > Signed-off-by: Bryce Harrington > > --- > > shared/config-parser.c | 21

Re: [PATCH 3/4] config-parser: Enable updating an already-loaded config

2015-01-21 Thread Derek Foreman
On 20/01/15 05:30 PM, Bryce Harrington wrote: > From: "Bryce Harrington" > > Adds weston_config_update(), which parses a condensed string of > comma-delimited key/value pairs and adds or changes the corresponding > parameters in the weston_config structure. > > Signed-off-by: Bryce Harrington (h

Re: [PATCH 2/4] config-parser: Allow server-side modification of loaded configs

2015-01-21 Thread Derek Foreman
Looks good to me. Reviewed-by: Derek Foreman On 20/01/15 05:30 PM, Bryce Harrington wrote: > From: "Bryce Harrington" > > Adds a setter, weston_config_section_set(), for changing key values in > the loaded copy of the weston.ini configuration. This functionality is > not exposed to clients.

Re: [PATCH 1/4] config-parser: Document config_section_get_entry()

2015-01-21 Thread Derek Foreman
On 20/01/15 05:30 PM, Bryce Harrington wrote: > From: "Bryce Harrington" > > Signed-off-by: Bryce Harrington (http://osg.samsung.com) > > Signed-off-by: Bryce Harrington > --- > shared/config-parser.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/shared/conf

Re: [PATCH 8/8] doc: remove redundant subtitles

2015-01-21 Thread Derek Foreman
On 02/01/15 08:29 PM, Bill Spitzak wrote: > Put the argument lists next to the event/message title, which I > think makes it a lot easier to understand, and remove redudant > "values" title from enumerations. Spelling error in the commit log: redudant Otherwise, I agree that this is much nicer to

Re: [PATCH 7/8] doc: Add object types and links to arguments int protocol documentation

2015-01-21 Thread Derek Foreman
This seems like a big win to me. Reviewed-by: Derek Foreman On 02/01/15 08:29 PM, Bill Spitzak wrote: > This makes it a lot easier to figure out what is going on! > --- > doc/publican/protocol-to-docbook.xsl | 35 > ++ > 1 file changed, 35 insertions(+) > > d

Re: [PATCH 6/8] doc: compress the lists in the protocol docs some

2015-01-21 Thread Derek Foreman
On 02/01/15 08:29 PM, Bill Spitzak wrote: > Use simpara to remove the blank lines, and put the type/value and > the comment into the same line. > --- > doc/publican/protocol-to-docbook.xsl | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) > > diff --git a/d

Re: [PATCH 4/8] doc: made functions taking wl_event_queue arg belong to wl_event_queue

2015-01-21 Thread Derek Foreman
This looks good to me, though I suppose arguments could be made either way. I think it makes more sense this way. Reviewed-by: Derek Foreman On 02/01/15 08:29 PM, Bill Spitzak wrote: > The fact that these functions take both a display and queue argument is > I think historical, and they really

Re: [PATCH 1/7] protocol: add linux_dmabuf extension RFCv1

2015-01-21 Thread Daniel Vetter
On Tue, Jan 20, 2015 at 10:31:52AM +0200, Pekka Paalanen wrote: > On Tue, 20 Jan 2015 07:41:52 +0100 > Daniel Vetter wrote: > > > On Thu, Jan 08, 2015 at 02:26:00PM +0200, Pekka Paalanen wrote: > > > On Mon, 5 Jan 2015 11:44:49 +0100 > > > Daniel Vetter wrote: > > > > > > > > But as long as yo

Re: [PATCH 3/8] doc: Remove wl_map from documentation

2015-01-21 Thread Derek Foreman
On 02/01/15 08:29 PM, Bill Spitzak wrote: > This object is only in wayland-private.h so it's methods should not > be in the documentation. > --- > src/wayland-util.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/src/wayland-util.c b/src/wayland-util.c > index b099882..db51ebb 10

Re: [PATCH 2/8] doc: Remove deprecated functions from documentation

2015-01-21 Thread Derek Foreman
Hmm, if I understand what this is doing... it disables doxygen parsing for a block that has no doxygen comments in it anyway. In the future if we deprecate stuff that actually has doxygen comments, I suppose this will result in nicer documentation, and I see no harm in it... Reviewed-by: Derek Fo

Re: [PATCH 1/8] doc: add missing \memberof to wl_display_get_protocol_error

2015-01-21 Thread Derek Foreman
Looks good to me. Reviewed-by: Derek Foreman On 02/01/15 08:29 PM, Bill Spitzak wrote: > --- > src/wayland-client.c |7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/src/wayland-client.c b/src/wayland-client.c > index 9e8bdfe..d1d21ca 100644 > --- a/src/wayland

GTK hardware scancodes for wayland / detecting XWayland

2015-01-21 Thread Daniel P. Berrange
I'm trying to port GTK-VNC to work correctly under Wayland, both as a native client and as an Xwayland client. The only place we have any code that is specific to particular display servers is the keyboard handling. We can't use the GdkEventKey keyval directly because that results in having todo lo

Re: [PATCH weston] build: install a login manager session entry

2015-01-21 Thread sardemff7+wayland
On 2015-01-21 04:46, Bryce Harrington wrote: On Sun, Dec 28, 2014 at 02:20:49PM +0100, Lubomir Rintel wrote: This makes it possible to run Weston session from GDM (and possibly other login managers). --- Makefile.am| 5 + src/weston.desktop | 5 + 2 files changed, 10 insertio

Re: [PATCH libinput] evdev: Be more careful about what we consider a joystick

2015-01-21 Thread Michael Schellenberger Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, is there an acutal reason, why joysticks and/or gamepads are ignored inside libinput. Is it just, that they are not yet implemented, or are there some real reasons? If the answer is that nobody has yet written the code, would someone of the more

[PATCH libinput 1/2] add simple symbols leak checker

2015-01-21 Thread Marek Chalupa
This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. Signed-off-by: Marek Chalupa --- test/Makefile.am | 7 ++- test/symbols-leak-test.sh | 17 + 2 files changed

[PATCH libinput 2/2] remove libinput_event_pointer_get_axis from symbols

2015-01-21 Thread Marek Chalupa
This function was removed in 1baf109b40 Signed-off-by: Marek Chalupa --- src/libinput.sym | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libinput.sym b/src/libinput.sym index cfbeabd..77fccb8 100644 --- a/src/libinput.sym +++ b/src/libinput.sym @@ -70,7 +70,6 @@ global: libinput_

[PATCH libinput] evdev: Be more careful about what we consider a joystick

2015-01-21 Thread Hans de Goede
After switching my main workstation over to using xf86-input-libinput, I noticed that the multi-media keys like play/pause on my keyboard no longer worked. It turns out that the second hid interface on my keyboard which has the multimedia-keys, also declares having: BTN_BASE6 and BTN_MODE which bo

Re: Failed to load module: /usr/way/lib/weston/rpi-backend.so: undefined symbol: eglTerminate

2015-01-21 Thread Jeff Chua
On Fri, Jan 2, 2015 at 7:52 PM, Pekka Paalanen wrote: > On Wed, 24 Dec 2014 12:49:23 +0800 > Jeff Chua wrote: > >> I recompiled Tomeu's userland git and weston with EGL enabled. >> Compiled ok, but starting weston gives the following error .. > > does this mean you don't have the .pc files? > See