Re: [PATCH weston] desktop-shell: Don't crash on zoom without a pointer in the seat

2015-01-06 Thread Peter Hutterer
On Tue, Jan 06, 2015 at 07:49:50PM -0600, Derek Foreman wrote: > On 06/01/15 04:04 PM, Peter Hutterer wrote: > > On Tue, Jan 06, 2015 at 02:28:13PM -0600, Derek Foreman wrote: > >> The zoom effect zooms at the seat's current pointer location. When no > >> pointer is present the zoom key bindings c

Re: [PATCH libinput 2/2] Dropped an extra 'the'

2015-01-06 Thread Peter Hutterer
On Wed, Jan 07, 2015 at 12:11:22PM +0800, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > src/libinput.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libinput.h b/src/libinput.h > index 6cb3a9e..27c5868 100644 > --- a/src/libinput.h > +++ b/src/libinput.h

[PATCH libinput 2/2] Dropped an extra 'the'

2015-01-06 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index 6cb3a9e..27c5868 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -638,7 +638,7 @@ libinput_event_pointer_get_button_state(struct libinput_ev

[PATCH libinput 1/2] s/discreet/discrete/

2015-01-06 Thread Jonas Ådahl
Discreet means to not draw attention. Discrete means non-continuous. Signed-off-by: Jonas Ådahl --- src/libinput.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index 56b77c2..6cb3a9e 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -

Re: [PATCH weston 4/4] logind: fix PropertiesChanged parser

2015-01-06 Thread nerdopolis
On Tuesday, December 30, 2014 02:33:23 PM David Herrmann wrote: > The current parser directly reads a BOOLEAN on the PropertiesChanged > signal for 'Active' properties. However, all property-values are packed in > a VARIANT, otherwise, we wouldn't know the type. Fix the parser to recurse > into the

Re: [PATCH weston] desktop-shell: Don't crash on zoom without a pointer in the seat

2015-01-06 Thread Jonas Ådahl
On Tue, Jan 06, 2015 at 02:28:13PM -0600, Derek Foreman wrote: > The zoom effect zooms at the seat's current pointer location. When no > pointer is present the zoom key bindings cause a crash. > > Instead, check for the absence of a pointer and log a warning. > > Signed-off-by: Derek Foreman >

Re: [PATCH weston] input: Destroy the pointer when the last device is unplugged

2015-01-06 Thread Jonas Ådahl
On Tue, Jan 06, 2015 at 07:51:43PM -0600, Derek Foreman wrote: > Removing the last device that provides a pointer now destroys the > pointer struct and sets it to NULL (so things like zoom don't use > the old co-ordinates) The fact that the pointer is not destroyed was delibaret, as some pointer r

Re: [PATCH v3 libinput 2/2] Rename functions for left handed device configurations

2015-01-06 Thread Peter Hutterer
On Tue, Jan 06, 2015 at 09:20:22PM -0500, Stephen Chandler Paul wrote: > Some devices require more than just flipping around the buttons, such as > tablets. > When it comes to devices like tablets, because the position of the palm rest > is > on the right, the entire tablet has to be flipped aroun

[PATCH v3 libinput 2/2] Rename functions for left handed device configurations

2015-01-06 Thread Stephen Chandler Paul
Some devices require more than just flipping around the buttons, such as tablets. When it comes to devices like tablets, because the position of the palm rest is on the right, the entire tablet has to be flipped around in order to be usable by lefties. As such, this requires that we reverse the coo

[PATCH weston] input: Destroy the pointer when the last device is unplugged

2015-01-06 Thread Derek Foreman
Removing the last device that provides a pointer now destroys the pointer struct and sets it to NULL (so things like zoom don't use the old co-ordinates) Signed-off-by: Derek Foreman --- src/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/input.c b/src/input

Re: [PATCH weston] desktop-shell: Don't crash on zoom without a pointer in the seat

2015-01-06 Thread Derek Foreman
On 06/01/15 04:04 PM, Peter Hutterer wrote: > On Tue, Jan 06, 2015 at 02:28:13PM -0600, Derek Foreman wrote: >> The zoom effect zooms at the seat's current pointer location. When no >> pointer is present the zoom key bindings cause a crash. >> >> Instead, check for the absence of a pointer and log

[PATCH v2 libinput] Change axis events to carry all directions

2015-01-06 Thread Peter Hutterer
Sending separate axis events instead of one unified events is limiting, especially when simultaneously scrolling in both directions and the caller tries to implement kinetic scrolling. Take a page from the tablet-support branch and instead implement the axis event as a generic event that can conta

[PATCH wayland 1/2] tests: Typo

2015-01-06 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- tests/test-runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index 753617f..9abf22f 100644 --- a/tests/test-runner.c +++ b/tests/test-runner.c @@ -50,7 +50,7 @@ int leak_check_enabled; /* w

[PATCH wayland 2/2] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-01-06 Thread Bryce Harrington
This fixes a regression in the testsuite since c3653f7f, where four of the timeout tests fail with "Timeouts suppressed" messages. The timeouts are being suppressed because the testsuite is erroneously detecting that a debugger is attached. This detection mechanism (adopted from libinput) uses pt

Re: [PATCH libinput 2/5] touchpad: hook up click method configuration

2015-01-06 Thread Peter Hutterer
On Mon, Jan 05, 2015 at 11:28:32AM +0100, Hans de Goede wrote: > Hi Peter, > > First of all the rest of this series (1/5 [3-5]/5) look good and are: > > Reviewed-by: Hans de Goede > > I've some remarks on this one though. > > On 10-12-14 05:15, Peter Hutterer wrote: > >Allow switching between

[PATCH libinput] test: add another hover test

2015-01-06 Thread Peter Hutterer
Release one touch point at the same time as a fake touch. Signed-off-by: Peter Hutterer --- I'll squash it in with the other tests before merging but for easier review it's separate here. This tests for the scenario Hans pointed out with one touch ending as we switch to hover. test/touchpad.c |

[PATCH v2 libinput 3/6] touchpad: add a TOUCH_HOVERING state

2015-01-06 Thread Peter Hutterer
Some touchpads provide touch information while the finger hovers over the touchpad, i.e. before BTN_TOUCH. Add a touch state for those touchpads so we can ignore the touches until they actually start. The approach is now: instead of BEGIN we mark a new touch as HOVERING. Use the BTN_TOOL_FINGER, B

Re: [PATCH 2/2] releasing: Add example commands to release directions

2015-01-06 Thread Peter Hutterer
On Tue, Jan 06, 2015 at 02:08:39PM -0800, Bryce Harrington wrote: > Note that for weston, configure.ac needs version numbers updated in > several places. `make distcheck` for weston no longer triggers the test > suite to run, so update the directions to account for this. Detail the > commands to

[PATCH 1/2] releasing: Typo

2015-01-06 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- releasing.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releasing.txt b/releasing.txt index 2db84d5..2debcd0 100644 --- a/releasing.txt +++ b/releasing.txt @@ -26,7 +26,7 @@ To make a release follow these steps. 10. Update topic in

[PATCH 2/2] releasing: Add example commands to release directions

2015-01-06 Thread Bryce Harrington
Note that for weston, configure.ac needs version numbers updated in several places. `make distcheck` for weston no longer triggers the test suite to run, so update the directions to account for this. Detail the commands to run for each step. Signed-off-by: Bryce Harrington --- releasing.txt |

Re: [PATCH weston] desktop-shell: Don't crash on zoom without a pointer in the seat

2015-01-06 Thread Peter Hutterer
On Tue, Jan 06, 2015 at 02:28:13PM -0600, Derek Foreman wrote: > The zoom effect zooms at the seat's current pointer location. When no > pointer is present the zoom key bindings cause a crash. > > Instead, check for the absence of a pointer and log a warning. > > Signed-off-by: Derek Foreman i

[PATCH v2 libinput 2/2] Rename functions for left handed device configurations

2015-01-06 Thread Stephen Chandler Paul
Some devices require more than just flipping around the buttons, such as tablets. When it comes to devices like tablets, because the position of the palm rest is on the right, the entire tablet has to be flipped around in order to be usable by lefties. As such, this requires that we reverse the coo

[PATCH weston] desktop-shell: Don't crash on zoom without a pointer in the seat

2015-01-06 Thread Derek Foreman
The zoom effect zooms at the seat's current pointer location. When no pointer is present the zoom key bindings cause a crash. Instead, check for the absence of a pointer and log a warning. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 5 + 1 file changed, 5 insertions(+) diff -

Re: [PATCH] doc/publican/Makefile.am: Add a missing order-only prerequisite

2015-01-06 Thread Jon A. Cruz
On 01/06/2015 08:35 AM, Rui Matos wrote: > Otherwise a parallel make invocation could fail due to the directory > not existing. > > Signed-off-by: Rui Matos Looks good. Reviewed-by: Jon A. Cruz > --- > doc/publican/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH] doc/publican/Makefile.am: Add a missing order-only prerequisite

2015-01-06 Thread Rui Matos
Otherwise a parallel make invocation could fail due to the directory not existing. Signed-off-by: Rui Matos --- doc/publican/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index 278da12..50a6188 100644 --- a/doc