Re: [PATCH libinput 2/2] Rename functions for left handed device configurations

2015-01-05 Thread Peter Hutterer
On Mon, Jan 05, 2015 at 05:44:38PM -0500, Stephen Chandler Paul wrote: > Some devices require more then just flipping around the buttons, such as > tablets. typo: then -> than and pls sign off your patches. pls also add a sentence to explain what is necessary, in this particular case we need to t

Re: [PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

2015-01-05 Thread Peter Hutterer
On Tue, Jan 06, 2015 at 01:39:24PM +0800, Jonas Ådahl wrote: > On Tue, Jan 06, 2015 at 01:00:08PM +1000, Peter Hutterer wrote: > > On Mon, Jan 05, 2015 at 04:29:48PM -0800, Thiago Macieira wrote: > > > On Monday 05 January 2015 12:00:24 Hans de Goede wrote: > > > > > + return __builtin_ffs(tp->

Re: [PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

2015-01-05 Thread Jonas Ådahl
On Tue, Jan 06, 2015 at 01:00:08PM +1000, Peter Hutterer wrote: > On Mon, Jan 05, 2015 at 04:29:48PM -0800, Thiago Macieira wrote: > > On Monday 05 January 2015 12:00:24 Hans de Goede wrote: > > > > + return __builtin_ffs(tp->fake_touches >> 1); > > > > Why the builtin instead of ffs from ?

Re: [PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

2015-01-05 Thread Peter Hutterer
On Mon, Jan 05, 2015 at 04:29:48PM -0800, Thiago Macieira wrote: > On Monday 05 January 2015 12:00:24 Hans de Goede wrote: > > > + return __builtin_ffs(tp->fake_touches >> 1); > > Why the builtin instead of ffs from ? simple answer: was the first one that google came up with. does it matter much

Re: [PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

2015-01-05 Thread Thiago Macieira
On Monday 05 January 2015 12:00:24 Hans de Goede wrote: > > + return __builtin_ffs(tp->fake_touches >> 1); Why the builtin instead of ffs from ? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF

[PATCH libinput 0/2] Patches to prepare for left-handed tablet mode

2015-01-05 Thread Stephen Chandler Paul
Hi! It's nice to finally have some patches back on this mailing list. Anyway, the first patch is just a fix for some incorrect line-wrapping I noticed, the second patch is to prepare for adding a left-handed mode for tablets. Since left-handed mode on tablets involves reversing the coordinates as

[PATCH libinput 2/2] Rename functions for left handed device configurations

2015-01-05 Thread Stephen Chandler Paul
Some devices require more then just flipping around the buttons, such as tablets. --- src/evdev-mt-touchpad.c | 4 ++-- src/evdev.c | 34 +++--- src/evdev.h | 12 +-- src/libinput.c | 14 ++--- src/libinput.h | 55 +

[PATCH libinput 1/2] libinput.h: Fix some line wrapping in documentation

2015-01-05 Thread Stephen Chandler Paul
--- src/libinput.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index 56b77c2..7719b8c 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -2141,8 +2141,8 @@ libinput_device_config_buttons_get_left_handed(struct libinput_device *device);

RE: Where should project Weston go?

2015-01-05 Thread Eoff, Ullysses A
> -Original Message- > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On > Behalf Of Pekka Paalanen > Sent: Wednesday, December 10, 2014 8:32 AM > To: wayland-devel@lists.freedesktop.org > Cc: Samuele Disegna; Bryce Harrington; Jason Ekstrand > Subject: Re: Where

Re: [PATCH libinput 2/2] Add libinput_event_pointer_has_axis to scroll events

2015-01-05 Thread Hans de Goede
Hi, On 05-01-15 06:20, Peter Hutterer wrote: Right now we only have two (scroll) axes and we could easily just check both for non-zero values. If we want to allow further axes in the future, we need a check whether an axis is set in an event. We also need the mask to notify of a scroll stop eve

Re: [PATCH libinput 1/2] Change axis events to carry all directions

2015-01-05 Thread Hans de Goede
Hi, On 05-01-15 06:20, Peter Hutterer wrote: Sending separate axis events instead of one unified events is limiting, especially when simultaneously scrolling in both directions and the caller tries to implement kinetic scrolling. Take a page from the tablet-support branch and instead implement

Re: [PATCH libinput 6/6] test: add touchpad hover finger test

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- test/touchpad.c | 322 +++- 1 file changed, 321 insertions(+), 1 deletion(-) diff --git a/test/tou

Re: [PATCH libinput 4/6] test: move semi-mt special tracking into the shared litest.c

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: An upcoming synaptics semi-mt device needs the same code. Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- test/litest-alps-semi-mt.c | 146 +++-- test/litest.c

Re: [PATCH libinput 5/6] test: add a semi-mt + hover synaptics touchpad

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: This device sends touch information before BTN_TOUCH https://bugs.freedesktop.org/show_bug.cgi?id=87197 Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- test/Makefile.am | 1 + test/l

RE: [weston1.5]Question about HardKey input monitor with wayland/weston

2015-01-05 Thread Yang Andy
Hi Pekka Thank you very much for your reply. > If you're interested in that, you can >dig the wayland-devel mailing list archives, or if you can't find it, >someone else probably can. This discussion was about any normal app >that just wants to register for a global hotkey. I have searched for th

[weston-ivi-shell]Qestion about caller of [bind_shell] and [shell_get_shell_surface ]

2015-01-05 Thread Yang Andy
Hi everyone I am testing QT/EFL application launch time from ICO-HomeScreen at tizenIVI platform,but the launch time is about 4 seconds. I analyze the NG log,and find result as below: (a) When QT application is laundch by AUL module,until the function [bind_shell] of weston-ivi-shell modul

Re: [PATCH libinput 3/6] touchpad: add a TOUCH_HOVERING state

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: Some touchpads provide touch information while the finger hovers over the touchpad, i.e. before BTN_TOUCH. Add a touch state for those touchpads so we can ignore the touches until they actually start. The approach is now: instead of BEGIN we mark a n

Re: [PATCH libinput 2/6] touchpad: use __builtin_ffs instead of a manual count

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: BTN_TOOL_FINGER, DOUBLETAP, etc. are mutually exclusive in the kernel, so we can use ffs here instead of manually counting. Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-touchpad.c | 11

Re: [PATCH libinput 1/6] touchpad: factor out fake finger handling

2015-01-05 Thread Hans de Goede
Hi, On 16-12-14 04:14, Peter Hutterer wrote: We need this for determining hovering touches on some semi-mt touchpads. This makes the fake_touches mask use bit 1 for BTN_TOUCH, I believe you mean bit 0 here (per the usual bit numbering conventions). Other then that this looks good and is: Re

Re: [PATCH 1/7] protocol: add linux_dmabuf extension RFCv1

2015-01-05 Thread Daniel Vetter
On Thu, Dec 18, 2014 at 01:45:22PM +0200, Pekka Paalanen wrote: > On Thu, 18 Dec 2014 10:25:09 +0100 > Daniel Vetter wrote: > > > On Fri, Dec 12, 2014 at 04:51:02PM -0500, Louis-Francis > > Ratté-Boulianne wrote: > > > From: Pekka Paalanen > > > > > > An experimental (hence the 'z' prefix) linu

Re: [PATCH libinput 2/5] touchpad: hook up click method configuration

2015-01-05 Thread Hans de Goede
Hi Peter, First of all the rest of this series (1/5 [3-5]/5) look good and are: Reviewed-by: Hans de Goede I've some remarks on this one though. On 10-12-14 05:15, Peter Hutterer wrote: Allow switching between softbuttons and clickfinger on any mt-capable clickpad. This disables top sof