Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

On Mon, Nov 24, 2014 at 01:01:29PM +0200, Pekka Paalanen wrote: > could we use a wl_shm-based wl_buffer instead of a file, please? > > That way we can simply relay the pixels as is to the test client, which > can then compare without compressing and decompressing from PNG first. > > For an exampl

[PATCH wayland] doc: Fill in high level description for Surfaces

Signed-off-by: Bryce Harrington --- doc/publican/sources/Protocol.xml | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/doc/publican/sources/Protocol.xml b/doc/publican/sources/Protocol.xml index b79b6be..2e48a7c 100644 --- a/doc/publican/sources/Protoc

Re: [PATCH] doc: Reduce the validation errors of the docbook input

On 12/10/2014 04:53 PM, Bryce Harrington wrote: I had to look up what a was. Still not entirely certain what the point of it vs. , but if it gets rid of validation errors, +1 to that. I suppose it must solve some layout issues. Sounds like places where we are using for regular text we shoul

Re: [PATCH libinput 6/6] doc: put some extra warning in for libinput_event_destroy()

On Thu, Dec 11, 2014 at 09:07:12AM +1000, Peter Hutterer wrote: > On Wed, Dec 10, 2014 at 06:01:13PM +0800, Jonas Ådahl wrote: > > Hi, > > > > Comment inline. > > > > On Wed, Dec 10, 2014 at 10:34:04AM +1000, Peter Hutterer wrote: > > > Unlike all other structs, events aren't refcounted and will

Re: [PATCH] doc: Reduce the validation errors of the docbook input

On Tue, Dec 09, 2014 at 07:33:51PM -0800, Bill Spitzak wrote: > This removes all the validation errors except for missing link > targets. You can test this by removing the --skip-validation > from doc/publican/Makefile.am. > > Main changes are to add to lists, remove some extra > commands, and p

Re: Where should project Weston go?

Hi, On 10 December 2014 at 23:21, Bryce Harrington wrote: > One thing I've observed as a contributor and reviewer is that while we > think of wayland as a "review + gatekeeper" model, many times the > gatekeeper is the only one to give the review. I think strengthening on > the review side migh

Re: Where should project Weston go?

On Wed, Dec 10, 2014 at 04:00:43PM +, Daniel Stone wrote: > Hmm. I think our biggest problem with review is that the one-reviewer model > doesn't scale. We currently have Patchwork to address that in an ad-hoc > manner, but could we do better with more tooling? Something like Gerrit > perhaps?

Re: [PATCH libinput 6/6] doc: put some extra warning in for libinput_event_destroy()

On Wed, Dec 10, 2014 at 06:01:13PM +0800, Jonas Ådahl wrote: > Hi, > > Comment inline. > > On Wed, Dec 10, 2014 at 10:34:04AM +1000, Peter Hutterer wrote: > > Unlike all other structs, events aren't refcounted and will get destroyed > > immediately. > > > > Signed-off-by: Peter Hutterer > > ---

Re: [PATCH libinput 5/6] doc: document the base structures so they show up in doxygen

On Wed, Dec 10, 2014 at 05:54:12PM +0800, Jonas Ådahl wrote: > Hi, > > A couple of comments inline: > > > On Wed, Dec 10, 2014 at 10:34:03AM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > src/libinput.h | 34 ++ > > 1 file changed, 34

Re: Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

Hey Peter, > > already done, please look at the two patches here > http://lists.freedesktop.org/archives/wayland-devel/2014-December/018916.html Yeah... I only noticed there was a 2/2 patch after I hit send. Thanks for taking care! > had to modify your original patch too with the libevdev sync p

Re: Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

On Wed, Dec 10, 2014 at 01:17:30PM +0100, Carlos Garnacho wrote: > Doh, resending to list from the subscribed account... > > > Hey Peter :), > > On Wed, Dec 10, 2014 at 1:40 AM, Peter Hutterer > wrote: > > > > On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote: > > > Otherwise, inp

Re: Where should project Weston go?

On Wed, Dec 10, 2014 at 04:00:43PM +, Daniel Stone wrote: > A platform that people can develop > desktop environments on? Sure! I guess a lot of those would be fine as > Weston plugins, though ultimately we'd need something like libweston to > make that workable. My biggest problem with libwest

Re: Where should project Weston go?

on Wednesday 10 December 2014 16:30:19，Jussi Laako wrote： > Regardless of the "massive design flaws" it works just fine IRL... X11 also works fine. Just work fine is not acceptable. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http

Re: Where should project Weston go?

On Tue, 9 Dec 2014 11:36:42 -0800 Jason Ekstrand wrote: > Bryce, > Thanks for your thoughts. I've got a few of my own, but I decided to > reply to your e-mail as it seemed the best branch-point for the > actual discussion without replying to everything. Yes, very nice, I think I'm starting to s

Re: [PATCH weston v1 07/17] tests-helper: distil the functionality from handlers

On 10/12/14 06:08 AM, Marek Chalupa wrote: > > > On 9 December 2014 at 21:36, Derek Foreman > wrote: > > Distill has 2 ls... > > On 05/12/14 07:36 AM, Marek Chalupa wrote: > > Split out the real code from event handlers (like pointer_handle_motion, >

Re: Where should project Weston go?

Hi, As others said - thanks for kicking this off. I think it's pretty long overdue. The 'release roadmap' mails I guess were meant to do this in a way, but never really got anywhere ... On 8 December 2014 at 12:01, Pekka Paalanen wrote: > To reiterate the main points: > - the reference implement

Re: Where should project Weston go?

On 10.12.2014 14:36, Daniel Stone wrote: understandable, but this is not a failure of upstream. If you redesigned your patches to avoid the (IMO massive) design flaws and resubmitted, or communicated with us earlier on so your original design was more suitable, this could've been avoided. Regar

Re: [PATCH weston v1 11/17] add get_geometry & geometry request/event

On 9 December 2014 at 21:39, Derek Foreman wrote: > On 05/12/14 07:36 AM, Marek Chalupa wrote: > > --- > > protocol/wayland-test.xml | 11 +++ > > tests/weston-test-client-helper.c | 18 ++ > > tests/weston-test-client-helper.h | 6 ++ > > tests/weston-test.c

Re: Where should project Weston go?

Hi, On 10 December 2014 at 10:18, Jussi Laako wrote: > On 9.12.2014 11:46, Bryce Harrington wrote: > >> Perhaps the situation could be improved via some patches from you? >> > > We tried for the multi-seat, but it wasn't so much welcomed. We'll > probably just maintain our fork for what we need.

Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

Doh, resending to list from the subscribed account... Hey Peter :), On Wed, Dec 10, 2014 at 1:40 AM, Peter Hutterer wrote: > > On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote: > > Otherwise, input_events will be attempted to read from the wrong place, > > which also leaves the r

Re: [PATCH weston v1 07/17] tests-helper: distil the functionality from handlers

On 9 December 2014 at 21:36, Derek Foreman wrote: > Distill has 2 ls... > > On 05/12/14 07:36 AM, Marek Chalupa wrote: > > Split out the real code from event handlers (like pointer_handle_motion, > > etc.) and put it into standalone function. We'll use it in follow-up > > patch where we will regi

Re: [PATCH weston v1 05/17] clients: add missing getters for input objects

On 9 December 2014 at 21:33, Derek Foreman wrote: > On 05/12/14 07:36 AM, Marek Chalupa wrote: > > We need get wayland objects from toytoolkit display > > (there already are display_get_output, input_get_seat, ...), > > so that we can use them in the tests. This patch adds: > > > > display_get_

Re: [PATCH weston v1 02/17] tests: link tests against libtoytoolkit

On 9 December 2014 at 20:33, Derek Foreman wrote: > On 05/12/14 07:36 AM, Marek Chalupa wrote: > > We want to use toytoolkit in tests. This patch also > > removes collisions of symbols defined in libtoytoolkit > > with symbols defined in tests (i. e. shm_listener) > > This patch introduces a comp

[PATCH weston v2] clipboard: set fd member of clipboard_source

The fd member of clipboard_source structure was not set but was used in close(). v2. don't do unnecessary changes Signed-off-by: Marek Chalupa --- src/clipboard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/clipboard.c b/src/clipboard.c index dbd8c9b..c1091a9 100644 --- a/src/clipbo

[PATCH weston v2] screenshooter: fix various memory handling

There were unchecked malloc and no free for this memory. Also simplify error handling in one function. v2. remove check if memory is NULL, according to man pages, free(NULL) is a no-op Signed-off-by: Marek Chalupa --- src/screenshooter.c | 25 + 1 file changed, 17 in

Re: [PATCH weston 2/3] screenshooter: fix various memory handling

On 9 December 2014 at 17:49, Derek Foreman wrote: > On 05/12/14 06:49 AM, Marek Chalupa wrote: > > There were unchecked malloc and free of conditionally allocated > > memory without checking if the memory was really allocated. > > Also simplify error handling in one function. > > > > Signed-off-b

Re: [PATCH wayland v2 1/2] client: update obsolete comments

On 9 December 2014 at 17:08, Pekka Paalanen wrote: > On Wed, 3 Dec 2014 13:05:16 +0100 > Marek Chalupa wrote: > > > On 28 November 2014 at 14:30, Pekka Paalanen > wrote: > > > > > On Fri, 28 Nov 2014 12:18:55 +0100 > > > Marek Chalupa wrote: > > > > > > > 1) there is nothing like main thread s

Re: Where should project Weston go?

On 9.12.2014 11:46, Bryce Harrington wrote: Perhaps the situation could be improved via some patches from you? We tried for the multi-seat, but it wasn't so much welcomed. We'll probably just maintain our fork for what we need. ___ wayland-devel ma

Re: [PATCH libinput 1/6] Drop deprecated symbols

On Wed, Dec 10, 2014 at 10:33:59AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer This series, except 5 and 6 which has some comments can be considered Reviewed-by: Jonas Ådahl Jonas > --- > src/evdev.c| 7 --- > src/libinput.c | 16 > src/libinput.h |

Re: [PATCH libinput 6/6] doc: put some extra warning in for libinput_event_destroy()

Hi, Comment inline. On Wed, Dec 10, 2014 at 10:34:04AM +1000, Peter Hutterer wrote: > Unlike all other structs, events aren't refcounted and will get destroyed > immediately. > > Signed-off-by: Peter Hutterer > --- > src/libinput.h | 10 +- > 1 file changed, 9 insertions(+), 1 deletion

Re: [PATCH libinput 5/6] doc: document the base structures so they show up in doxygen

Hi, A couple of comments inline: On Wed, Dec 10, 2014 at 10:34:03AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/libinput.h | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/src/libinput.h b/src/libinput.h > index d6e0446.