[PATCH] doc: Add config check for doxygen 1.8.0+.

2014-12-02 Thread Jon A. Cruz
Add a config time check for a new enough (1.8.0+) version of doxygen. Signed-off-by: Jon A. Cruz --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6f8220b..317cdae 100644 --- a/configure.ac +++ b/configure.ac @@ -109,6 +109,14 @@ if te

[no subject]

2014-12-02 Thread nerdopolis
I had to resend, because in the first patch I sent I accidentally removed an empty line ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] Weston: fbdev: Remove uneeded semicolon

2014-12-02 Thread nerdopolis
--- 0001-weston-fbdev-remove-uneeded-semicolon.patch | 33 +++ fd | 116 +++ src/compositor-fbdev.c | 2 +- 3 files changed, 150 insertions(+), 1 deletion(-) create mode 100644 0001-weston-fbdev-rem

[PATCH] weston: fbdev: remove uneeded semicolon

2014-12-02 Thread nerdopolis
--- src/compositor-fbdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compositor-fbdev.c b/src/compositor-fbdev.c index 138aaab..eb238a2 100644 --- a/src/compositor-fbdev.c +++ b/src/compositor-fbdev.c @@ -811,7 +811,6 @@ session_notify(struct wl_listener *listener,

Re: [PATCH 4/4] doc: Remove duplicated descriptions of wayland objects

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:36PM -0800, Bill Spitzak wrote: > This text is a duplicate of the text in the protocol documentation, but > the converter mangled it by removing the paragraph breaks and some other > errors. Instead replace it with a list of links to the protocol docs. Reviewed-by: Pe

Re: [PATCH 3/4] doc: removed redundant dependency

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:35PM -0800, Bill Spitzak wrote: > The .tmp file dependency depends on the index.xml file so it does not need to > be repeated. Reviewed-by: Peter Hutterer Cheers, Peter > --- > doc/publican/Makefile.am |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:34PM -0800, Bill Spitzak wrote: > These warnings are a duplicate of the first set > --- > doc/doxygen/Makefile.am |1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am > index 83622af..fe6f300 100644 > --- a/doc

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: > This requires doxygen 1.8 or newer. > I could not figure out how to make configure.ac test the doxygen > version number. It appears to be really complex. So it will run with > any version of doxygen and the doc output is somewhat mangl

Re: [PATCH] doc: Invoke doxygen via the defined make variable.

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 05:54:07PM -0800, Jon A. Cruz wrote: > Invoke doxygen via the autoconf-defined make variable instead of directly. > This brings it in line with standard makefile practices. > > Signed-off-by: Jon A. Cruz Reviewed-by: Peter Hutterer Cheers, Peter > --- > doc/doxyge

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-02 Thread Jon A. Cruz
On 12/02/2014 06:29 PM, Bill Spitzak wrote: > This requires doxygen 1.8 or newer. FYI this will cut off support for RHEL6 and corresponding distros such as CentOS and Scientific Linux (I had to track this for my prior day job). On the other hand, RHEL7 is up to Doxygen 1.8.5 so we're good in that

[PATCH libinput] Document relative motion normalization

2014-12-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/libinput.h | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index db56da7..5608eaa 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -124,6 +124,10 @@ extern "C"

[PATCH 3/4] doc: removed redundant dependency

2014-12-02 Thread Bill Spitzak
The .tmp file dependency depends on the index.xml file so it does not need to be repeated. --- doc/publican/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index 9fc4e0b..0b2cd09 100644 --- a/doc/publican/Ma

[PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-02 Thread Bill Spitzak
These warnings are a duplicate of the first set --- doc/doxygen/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am index 83622af..fe6f300 100644 --- a/doc/doxygen/Makefile.am +++ b/doc/doxygen/Makefile.am @@ -42,6 +42,7 @@ man/man3/

[PATCH 4/4] doc: Remove duplicated descriptions of wayland objects

2014-12-02 Thread Bill Spitzak
This text is a duplicate of the text in the protocol documentation, but the converter mangled it by removing the paragraph breaks and some other errors. Instead replace it with a list of links to the protocol docs. --- doc/publican/protocol-interfaces-to-docbook.xsl | 16 +--- 1 file

[PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-02 Thread Bill Spitzak
This requires doxygen 1.8 or newer. I could not figure out how to make configure.ac test the doxygen version number. It appears to be really complex. So it will run with any version of doxygen and the doc output is somewhat mangled. --- src/wayland-client.c | 14 +++--- src/wayland-serve

[PATCH] doc: Invoke doxygen via the defined make variable.

2014-12-02 Thread Jon A. Cruz
Invoke doxygen via the autoconf-defined make variable instead of directly. This brings it in line with standard makefile practices. Signed-off-by: Jon A. Cruz --- doc/doxygen/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/doxygen/Makefile.am b/doc/doxyg

Re: [PATCH libinput] Introduce non-accelerated motion event vectors

2014-12-02 Thread Peter Hutterer
On Tue, Dec 02, 2014 at 09:44:16PM +0800, Jonas Ådahl wrote: > For certain applications (such as FPS games) it is necessary to use > non-accelerated motion events (the motion vector that is passed to the > acceleration filter) to get a more natural feeling. Supply this > information by passing both

Re: [PATCH weston 14/17] Introduce pointer locking and confinement protocol

2014-12-02 Thread Bill Spitzak
On 12/02/2014 05:49 AM, Jonas Ådahl wrote: + + +The lock_pointer request lets the client disable absolute pointer +movements, locking the pointer to a position. + +There may not be another lock of any kind active when requesting a lock, +and if there is

Re: [PATCH v1] Added string conversion utility functions

2014-12-02 Thread Bill Spitzak
I think the desired function was to fail if there was text after the number, fail on blank strings, and fail on overflow. All of these are somewhat cryptic with strtol. However, writing a helper function whose benefit over a direct call to strto*() is only the handling of errno, it might not b

Re: [PATCH weston v2 2/2] compositor: Implement JSON-timeline logging

2014-12-02 Thread Bill Spitzak
On 12/02/2014 05:45 AM, Pekka Paalanen wrote: From: Pekka Paalanen + if (!s->get_label || s->get_label(s, d, sizeof(d)) < 0) { + d[0] = '\0'; + q = ""; + } + + fprintf(ctx->out, "{ \"id\":%u, " + "\"type\":\"weston_surface\", " +

Re: [PATCH weston 00/17] Relative pointer motions, locking and confinement

2014-12-02 Thread Jason Ekstrand
On Tue, Dec 2, 2014 at 5:49 AM, Jonas Ådahl wrote: > Hi again, > > At XDC2014 some of us sat down and talked through how pointer locking > and related protocols should look like, and this series is more or less > work-in-progress result of that discussion. > > The series contains two parts (and o

Re: [PATCH weston 14/17] Introduce pointer locking and confinement protocol

2014-12-02 Thread Jason Ekstrand
A couple of doc comments below, but the protocol otherwise looks pretty good. Again, I've only glanced at the implementation. On Tue, Dec 2, 2014 at 5:49 AM, Jonas Ådahl wrote: > This patch introduces a new protocol for locking and confining a > pointer. It consists of a new global object with

Re: Patch: fix weston crash (inline patch)

2014-12-02 Thread Andrew Engelbrecht
On 12/02/2014 12:18 PM, Andrew Engelbrecht wrote: > I've attached a patch which fixes the crashing. I mimicked the code in > the block above it without knowing the overall impact, so it needs > review from a knowledgeable contributor. here's the patch in non-attachment form: diff --git a/xwayland

Re: [PATCH weston 13/17] Introduce wl_relative_pointer interface

2014-12-02 Thread Jason Ekstrand
Haven't looked at the weston implementation but the protocol bits look pretty good to me. Sounds like what we discussed. --Jason On Tue, Dec 2, 2014 at 5:49 AM, Jonas Ådahl wrote: > A wl_relative_pointer object is an extension to the wl_pointer interface > only used for emitting relative pointe

Patch: fix weston crash

2014-12-02 Thread Andrew Engelbrecht
To produce the bug, build and run: (you don't need the game data to test) https://github.com/clintbellanger/flare-engine/ $ mv ~/.config/flare ~/.config/flare.bak $ ./flare # click 'configure', set full screen mode then click 'ok' # weston will crash and dump core. I've attached a p

Re: [PATCH v1] Added string conversion utility functions

2014-12-02 Thread Pekka Paalanen
On Tue, 2 Dec 2014 15:45:40 +0200 Imran Zaman wrote: > Interesting read.. have some arguments about the raised points.. but > lets not go in that direction.. > Can you guys suggest to do some changes or shall i drop the patch > altogether? if you are happy with current implementation lets live >

Re: [PATCH weston 00/17] Relative pointer motions, locking and confinement

2014-12-02 Thread Steven Newbury
On Tue, 2014-12-02 at 21:49 +0800, Jonas Ådahl wrote: > Hi again, > > At XDC2014 some of us sat down and talked through how pointer locking > and related protocols should look like, and this series is more or > less > work-in-progress result of that discussion. > > The series contains two parts

Re: [PATCH weston 00/17] Relative pointer motions, locking and confinement

2014-12-02 Thread Jonas Ådahl
On Tue, Dec 02, 2014 at 02:44:55PM +, Steven Newbury wrote: > > On Tue, 2014-12-02 at 21:49 +0800, Jonas Ådahl wrote: > > Hi again, > > > > At XDC2014 some of us sat down and talked through how pointer locking > > and related protocols should look like, and this series is more or > > less >

[PATCH weston 16/17] clients/resizor: Use pointer locking for resizing window

2014-12-02 Thread Jonas Ådahl
Resizes the window using pointer locking when holding the left pointer button down. The pointer lock cursor position hint is used to warp the pointer to the same position relative to the bottom right corner. Signed-off-by: Jonas Ådahl --- clients/resizor.c | 159 +

[PATCH weston 14/17] Introduce pointer locking and confinement protocol

2014-12-02 Thread Jonas Ådahl
This patch introduces a new protocol for locking and confining a pointer. It consists of a new global object with two requests; one for locking the surface to a position, one for confining the pointer to a given region. See pointer-lock.xml for details of the protocol. In this patch, only the loc

[PATCH weston 15/17] clients: Add API for pointer locking and pointer confinement

2014-12-02 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- Makefile.am | 6 +- clients/window.c | 294 +++ clients/window.h | 62 3 files changed, 361 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8adc343..b32d61e 100644 --

[PATCH weston 17/17] clients/clickdot: Use pointer confinement to confine drawed line

2014-12-02 Thread Jonas Ådahl
Use pointer confinement to make the line drawing not go outside the drawing area. It is toggled with the right pointer button. Signed-off-by: Jonas Ådahl --- clients/clickdot.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/clients/clickdot.

[PATCH weston 13/17] Introduce wl_relative_pointer interface

2014-12-02 Thread Jonas Ådahl
A wl_relative_pointer object is an extension to the wl_pointer interface only used for emitting relative pointer events. It will only emit events when the parent pointer has focus. To get a relative pointer object, use the get_relative_pointer request of the global wl_relative_pointer_manager obje

[PATCH weston 02/17] input: Pass axis events through pointer grab interfaces

2014-12-02 Thread Jonas Ådahl
Don't only send motions and buttons but also axis events through the pointer grab interface. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c | 7 +++ desktop-shell/shell.c | 24 src/compositor.h| 2 ++ src/data-device.c | 7 +++ src/inpu

[PATCH weston 08/17] desktop-shell: Change switcher to track views

2014-12-02 Thread Jonas Ådahl
Preparation for future refactorings. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 7ce951d..aa9c333 100644 --- a/desktop-shell/shell.c +++ b/desktop-s

[PATCH weston 05/17] desktop-shell: Clean up set_minimized a bit

2014-12-02 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 2e416e9..4a0cb99 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -2612,8 +26

[PATCH weston 10/17] desktop-shell: Pass a flag bitmask instead of bool to activate()

2014-12-02 Thread Jonas Ådahl
Although it currently only has one available flag, but that'll change. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c | 9 ++--- desktop-shell/shell.c | 36 desktop-shell/shell.h | 2 +- src/compositor.h| 5 + 4 files changed, 3

[PATCH weston 07/17] desktop-shell: Track the black surface by its view

2014-12-02 Thread Jonas Ådahl
In preparation for further refactoring. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 4b8724c..7ce951d 100644 --- a/desktop-shell/shell.c +++ b

[PATCH weston 11/17] compositor: Keep track of what views were activated by clicking

2014-12-02 Thread Jonas Ådahl
Adds a weston_view_activate() that can be passed an additional active flag WESTON_ACTIVATE_CLICKED, that the shell passes when a view was activated by clicking. This allows shell independent components implement heuristics depending on how a view was activated. Signed-off-by: Jonas Ådahl --- de

[PATCH weston 12/17] libinput: Expose unaccelerated motion deltas in motion event struct

2014-12-02 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/compositor.h | 3 +++ src/libinput-device.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compositor.h b/src/compositor.h index 6bcddf5..b622c97 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -239,6 +239,7 @@ struct

[PATCH weston 03/17] input: Make pointer grab motion callbacks take an event struct

2014-12-02 Thread Jonas Ådahl
Instead of only passing absolute pointer coordinates, effectively loosing motion event data, pass a struct that can potentially contain different types of motion events, currently being absolute and relative. A helper function to get resulting absolute coordinates was added for when previous callb

[PATCH weston 01/17] protocol: Improve formatting of input method and text protocols

2014-12-02 Thread Jonas Ådahl
To make it more readable, add an empty line between each request and event. Also comes with a bonus indentation fix. Signed-off-by: Jonas Ådahl --- protocol/input-method.xml | 28 protocol/text.xml | 30 ++ 2 files changed, 54 ins

[PATCH weston 06/17] desktop-shell: Make activate_binding take a view instead of surface

2014-12-02 Thread Jonas Ådahl
In preparation for further refactoring. Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 4a0cb99..4b8724c 100644 --- a/desktop-shell/shell.c +++ b/desktop-she

[PATCH weston 04/17] desktop-shell: Add unset_keyboard_focus_for_surface helper

2014-12-02 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- desktop-shell/shell.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index b03dbaf..2e416e9 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1

[PATCH weston 00/17] Relative pointer motions, locking and confinement

2014-12-02 Thread Jonas Ådahl
Hi again, At XDC2014 some of us sat down and talked through how pointer locking and related protocols should look like, and this series is more or less work-in-progress result of that discussion. The series contains two parts (and one bonus patch). The bonus patch is the initial white space only

[PATCH weston 09/17] desktop-shell: Make activate() take a view instead of surface

2014-12-02 Thread Jonas Ådahl
In preparation for further refactorings. Signed-off-by: Jonas Ådahl --- desktop-shell/exposay.c | 6 +++--- desktop-shell/shell.c | 22 -- desktop-shell/shell.h | 2 +- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/desktop-shell/exposay.c b/desktop-sh

Re: [PATCH v1] Added string conversion utility functions

2014-12-02 Thread Imran Zaman
Interesting read.. have some arguments about the raised points.. but lets not go in that direction.. Can you guys suggest to do some changes or shall i drop the patch altogether? if you are happy with current implementation lets live with it.. I noticed bug when weston was not working properly due

[PATCH weston v2 1/2] compositor: add weston_surface_set_label_func()

2014-12-02 Thread Pekka Paalanen
From: Pekka Paalanen When printing out logs from Weston's actions, mainly for debugging, it can be very difficult to identify the different surfaces. Inspecting the configure function pointer is not useful, as the configure functions may live in modules. Add vfunc get_label to weston_surface, w

[PATCH weston v2 2/2] compositor: Implement JSON-timeline logging

2014-12-02 Thread Pekka Paalanen
From: Pekka Paalanen Logging is activated and deactivated with the debug key binding 't'. When activated, it creates a new log file, where it records the events. The log file contains events and detailed object information entries in JSON format, and is meant to be parsed in sequence from beginni

[PATCH libinput] Introduce non-accelerated motion event vectors

2014-12-02 Thread Jonas Ådahl
For certain applications (such as FPS games) it is necessary to use non-accelerated motion events (the motion vector that is passed to the acceleration filter) to get a more natural feeling. Supply this information by passing both accelerated and non-accelerated motion vectors to the existing motio

Re: [PATCH weston 5/6] xdg-shell: Rewrite documentation

2014-12-02 Thread Michael Forney
On Sat, Nov 22, 2014 at 12:28:29PM -0800, Jasper St. Pierre wrote: > This rewrites basically all of the text inside xdg-shell to be up to > date, clearer, and rid of wl_shell and X11 terminology. Thanks for updating this, Jasper! > --- > protocol/xdg-shell.xml | 256 > ++

Re: [PATCH libinput] Add libinput_device_get_context/libinput_seat_get_context

2014-12-02 Thread Hans de Goede
Hi, On 12/02/2014 12:45 AM, Peter Hutterer wrote: Allow retrieval of the libinput context from the seat and the device. Signed-off-by: Peter Hutterer Looks good. Reviewed-by: Hans de Goede Regards, Hans --- src/libinput.c | 12 src/libinput.h | 22 ++