Re: [PATCH 3/4] tests: Move ARRAY_LENGTH to a shared header for reuse

On Fri, Nov 28, 2014 at 12:41:21PM +0100, Marek Chalupa wrote: > IMO it'd be good to add guards (#ifndef ARRAY_LENGTH) around this macro, > because it is used extensively in wayland/weston and in the future it may > happen that > it'll be redefined by some included header. Right, I'll send a follo

[PATCH wayland v2] tests: detect if debugger is attached

Copy function from libinput/test/litest.c is_debugger_detached() and use it in our test-runner. If debugger is attached, turn off leak checks and timeouts automatically. Revision of libinput: 028513a0a723e97941c39c4aeb17433198723913 v2. rebased to master Signed-off-by: Marek Chalupa --- tests/

Re: [PATCH 3/3] Use zalloc instead of calloc(1, ...)

On Wed, 26 Nov 2014 15:22:45 +0100 Marek Chalupa wrote: > $ git grep calloc\(1, > > reveals that there are quite few more places where calloc(1, ...) is used. > However, this patch is a good starter. > > Reviewed-by: Marek Chalupa > > On 21 November 2014 at 07:21, Bryce Harrington > wrote: >

Re: [PATCH weston] clients: Use xmalloc in a few more places

On Thu, 20 Nov 2014 14:44:02 -0800 Bryce Harrington wrote: > Reviewed-by: Bryce Harrington > > On Thu, Nov 20, 2014 at 03:42:35PM -0600, Derek Foreman wrote: > > Just changes some places where a malloc failure is unhandled > > to our xmalloc function that exit()s a little more gracefully. > >

Re: [PATCH 4/4] tests: Use one shared xzalloc implementation

On Fri, 28 Nov 2014 12:47:21 +0100 Marek Chalupa wrote: > I've had patch doing exactly the same in my wip branch locally for some > time now, so just: > > Reviewed-by: Marek Chalupa > > On 20 November 2014 at 02:18, Bryce Harrington > wrote: > > > Since this is an inlined function, move it t

Re: [PATCH wayland v2] tests: use color when printing on terminal

On Fri, 28 Nov 2014 13:18:20 +0100 Marek Chalupa wrote: > Colorize output of the tests when prinitng on terminal. > > Signed-off-by: Marek Chalupa > --- > tests/test-runner.c | 52 +--- > 1 file changed, 45 insertions(+), 7 deletions(-) Pushed.

Re: [PATCH wayland v2 2/2] client: update documentation about threading

On Fri, 28 Nov 2014 12:18:56 +0100 Marek Chalupa wrote: > Remove out-dated documentation and add few more words > about this topic. > > v2. replace a paragraph by better explanation from Pekka Paalanen > fix other notes from reviewing > > Signed-off-by: Marek Chalupa > --- > src/wayland-c

Re: [PATCH wayland v2 1/2] client: update obsolete comments

On Fri, 28 Nov 2014 12:18:55 +0100 Marek Chalupa wrote: > 1) there is nothing like main thread since >3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore, so remove >it from documentation and update the doc accordingly. > > 2) use calling 'default queue' instead of 'main queue'. In the code

[PATCH wayland v2] tests: use color when printing on terminal

Colorize output of the tests when prinitng on terminal. Signed-off-by: Marek Chalupa --- tests/test-runner.c | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index b6ea098..431511a

Re: [PATCH wayland 2/2] tests: use color when printing on terminal

On 28 November 2014 at 13:08, Pekka Paalanen wrote: > On Fri, 21 Nov 2014 11:34:08 +0100 > Marek Chalupa wrote: > > > Colorize output of the tests when prinitng on terminal. > > > > Signed-off-by: Marek Chalupa > > --- > > tests/test-runner.c | 52 >

Re: [PATCH 2 wayland] tests: detect if debugger is attached

On Fri, 28 Nov 2014 13:09:59 +0100 Marek Chalupa wrote: > Hi, > > Here it is used to suppress the timeout, which just kills the client during > debugging if you forget to turn it off. > Since it is just a way how to workaround forgetting of humans (read: me xD) > I think that I don't care about

Re: [PATCH 2 wayland] tests: detect if debugger is attached

Hi, Here it is used to suppress the timeout, which just kills the client during debugging if you forget to turn it off. Since it is just a way how to workaround forgetting of humans (read: me xD) I think that I don't care about this patch much. If no-one else want this, I'm OK with rejecting this

Re: [PATCH wayland 2/2] tests: use color when printing on terminal

On Fri, 21 Nov 2014 11:34:08 +0100 Marek Chalupa wrote: > Colorize output of the tests when prinitng on terminal. > > Signed-off-by: Marek Chalupa > --- > tests/test-runner.c | 52 +--- > 1 file changed, 45 insertions(+), 7 deletions(-) > > diff

Re: [PATCH 2 wayland] tests: detect if debugger is attached

On Wed, 19 Nov 2014 12:20:31 +0100 Marek Chalupa wrote: > Copy function from libinput/test/litest.c is_debugger_detached() > and use it in our test-runner. If debugger is attached, turn off > leak checks and timeouts automatically. > > Revision of libinput: 028513a0a723e97941c39c4aeb174331987239

Re: [PATCH 4/4] tests: Use one shared xzalloc implementation

I've had patch doing exactly the same in my wip branch locally for some time now, so just: Reviewed-by: Marek Chalupa On 20 November 2014 at 02:18, Bryce Harrington wrote: > Since this is an inlined function, move it to a common header file. > > Signed-off-by: Bryce Harrington > --- > tests/

Re: [PATCH 3/4] tests: Move ARRAY_LENGTH to a shared header for reuse

IMO it'd be good to add guards (#ifndef ARRAY_LENGTH) around this macro, because it is used extensively in wayland/weston and in the future it may happen that it'll be redefined by some included header. Reviewed-by: Marek Chalupa On 20 November 2014 at 02:18, Bryce Harrington wrote: > Signed-o

Re: [PATCH 2/4] tests: Cleanup superfluous headers

Didn't break anything here and looks ok. Acked-by: Marek Chalupa On 20 November 2014 at 02:18, Bryce Harrington wrote: > Mostly remove headers that aren't actually needed for anything. > Add stdint.h to permit dropping xf86drm.h, which is otherwise unneeded. > > Signed-off-by: Bryce Harrington

Re: [PATCH wayland v2] tests: rename env vars for tests

On Fri, 28 Nov 2014 09:41:50 +0100 Marek Chalupa wrote: > Rename WAYLAND_TESTS_NO_TIMEOUTS to WAYLAND_TEST_NO_TIMEOUTS. > Further rename NO_ASSERT_LEAK_CHECK to WAYLAND_TEST_NO_LEAK_CHECK. > Now the naming is consistent not only here, in Wayland, but even with > naming of weston env varibles rela

[PATCH wayland v2 1/2] client: update obsolete comments

1) there is nothing like main thread since 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore, so remove it from documentation and update the doc accordingly. 2) use calling 'default queue' instead of 'main queue'. In the code we use display->default_queue, so it'll be easier the understand

[PATCH wayland v2 2/2] client: update documentation about threading

Remove out-dated documentation and add few more words about this topic. v2. replace a paragraph by better explanation from Pekka Paalanen fix other notes from reviewing Signed-off-by: Marek Chalupa --- src/wayland-client.c | 106 +++ 1 file ch

Re: [PATCH weston 1/2] compositor: add weston_surface_set_description()

2014-11-27 12:42 GMT+02:00 Pekka Paalanen : > On Thu, 27 Nov 2014 10:17:21 +0200 > Giulio Camuffo wrote: > >> Just a quick comment below, I haven't looked at it carefully yet. >> >> -- >> Giulio >> >> 2014-11-27 9:07 GMT+02:00 Pekka Paalanen : >> > From: Pekka Paalanen >> > >> > When printing out

Re: [PATCH wayland] client: update documentation about threading

On 26 November 2014 at 13:48, Pekka Paalanen wrote: > On Fri, 21 Nov 2014 11:12:35 +0100 > Marek Chalupa wrote: > > > Remove out-dated documentation and add few more words > > about this topic. > > > > Signed-off-by: Marek Chalupa > > --- > > src/wayland-client.c | 106 > ++

Re: [PATCH weston v2] dnd: Fix some mouse cursor issues

On Thu, 20 Nov 2014 15:32:40 -0600 Derek Foreman wrote: > When ending a drag in the window the cursor will be wrong until the mouse > is moved again. This is because the item being dragged isn't added > until after the enter event. > > Also, when picking up an item while moving the mouse the cu

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

On Thu, 27 Nov 2014 13:00:07 -0800 Bill Spitzak wrote: > More experiments, this time with Doxygen 1.8.6. Apparently the ~~~ > markers (called "Markdown support" or "Fenced code blocks") were > introduced in 1.8. Maybe config needs to check for this? Indeed ~~~ > produces code samples now. > >

Re: [PATCH wayland]scanner.c: Use WL_PRINTF instead of __attribute__((format(printf)))

On Thu, 27 Nov 2014 20:50:14 +0530 Seedo Eldho Paul wrote: > Signed-off-by: Seedo Eldho Paul > --- > src/scanner.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/scanner.c b/src/scanner.c > index fa8e0c0..ca03c57 100644 > --- a/src/scanner.c > +++ b/src/scanner.c

Re: [PATCH 2/6] Attach input profiles and build corresponding LUTs

On Thu, 27 Nov 2014 15:58:51 +0100 Niels Ole Salscheider wrote: > Hi, > > > first a general question, since I'm at loss here on the big picture: > > How does all this relate to the cms-static and cms-colord modules > > already in Weston? > > > > Are those modules only about configuring the outp

[PATCH wayland v2] tests: rename env vars for tests

Rename WAYLAND_TESTS_NO_TIMEOUTS to WAYLAND_TEST_NO_TIMEOUTS. Further rename NO_ASSERT_LEAK_CHECK to WAYLAND_TEST_NO_LEAK_CHECK. Now the naming is consistent not only here, in Wayland, but even with naming of weston env varibles related to testing. This is version 2 of the patch. The first version