Re: [PATCH] doc: Removed redundant xslt output elements.

2014-11-27 Thread Peter Hutterer
On Thu, Nov 27, 2014 at 12:30:52PM -0800, Jon A. Cruz wrote: > Removed elements that were duplicated but with attributes in > a different order. Standard tools are required to ignore the order of > attributes in an element. > > Signed-off-by: Jon A. Cruz Reviewed-by: Peter Hutterer Cheers,

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-27 Thread Bill Spitzak
More experiments, this time with Doxygen 1.8.6. Apparently the ~~~ markers (called "Markdown support" or "Fenced code blocks") were introduced in 1.8. Maybe config needs to check for this? Indeed ~~~ produces code samples now. It appears aliases (but not other commands) work inside ~~~. They d

[PATCH] doc: Removed redundant xslt output elements.

2014-11-27 Thread Jon A. Cruz
Removed elements that were duplicated but with attributes in a different order. Standard tools are required to ignore the order of attributes in an element. Signed-off-by: Jon A. Cruz --- doc/publican/protocol-interfaces-to-docbook.xsl | 1 - doc/publican/protocol-to-docbook.xsl| 1

Re: [PATCH 2/6] Attach input profiles and build corresponding LUTs

2014-11-27 Thread Kai-Uwe Behrmann
Am 27.11.2014 um 15:58 schrieb Niels Ole Salscheider: > #define WL_HIDE_DEPRECATED > #include > > @@ -40,6 +41,10 @@ extern "C" { > > #include "config-parser.h" > #include "zalloc.h" > > +#ifdef HAVE_LCMS > +#include > +#endif > + > > #

[PATCH wayland]scanner.c: Use WL_PRINTF instead of __attribute__((format(printf)))

2014-11-27 Thread Seedo Eldho Paul
Signed-off-by: Seedo Eldho Paul --- src/scanner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index fa8e0c0..ca03c57 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -199,7 +199,7 @@ static const char *indent(int n) } static void -desc_du

Re: [PATCH 2/6] Attach input profiles and build corresponding LUTs

2014-11-27 Thread Niels Ole Salscheider
Hi, > first a general question, since I'm at loss here on the big picture: > How does all this relate to the cms-static and cms-colord modules > already in Weston? > > Are those modules only about configuring the output's color space? > And then this work simply leverages that to have some output

Re: [PATCH wayland] doc: fixed grammar and a typo

2014-11-27 Thread Pekka Paalanen
On Mon, 17 Nov 2014 14:59:14 -0600 Derek Foreman wrote: > Signed-off-by: Derek Foreman > --- > src/wayland-client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/wayland-client.c b/src/wayland-client.c > index 01629e0..4067cfd 100644 > --- a/src/wayland-clien

Re: [PATCH weston v2] input: Use slightly less obscure logic in evdev_notify_keyboard_focus()

2014-11-27 Thread Pekka Paalanen
On Wed, 19 Nov 2014 11:04:12 -0600 Derek Foreman wrote: > While the test is actually correct (for non-negative numbers), it's not > at all clear and seems to be an accidental order of operations mistake. > > Also, add an assert() to make sure this number is never negative. > > Closes bug 86346

Re: [PATCH 2/6] Attach input profiles and build corresponding LUTs

2014-11-27 Thread Pekka Paalanen
Hi, first a general question, since I'm at loss here on the big picture: How does all this relate to the cms-static and cms-colord modules already in Weston? Are those modules only about configuring the output's color space? And then this work simply leverages that to have some output color space

Re: [PATCH 1/6] Add cms protocol

2014-11-27 Thread Pekka Paalanen
Hi, I had a quick look of our previous discussion to refresh my mind. It is very good that you moved to using a protocol object for a color profile, and fd passing for the profile data. Here's some comments. On Mon, 13 Oct 2014 19:40:46 +0200 Niels Ole Salscheider wrote: > The cms protocol all

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-27 Thread Pekka Paalanen
On Wed, 26 Nov 2014 11:24:28 -0800 "Jon A. Cruz" wrote: > > > On 11/26/2014 10:22 AM, Bill Spitzak wrote: > > On 11/25/2014 11:52 PM, Pekka Paalanen wrote: > > > >> Or are duplicates perhaps due to us having, say, struct wl_display a > >> different thing on server vs. client? > > > > The dupl

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-27 Thread Pekka Paalanen
On Wed, 26 Nov 2014 10:32:56 -0800 Bill Spitzak wrote: > On 11/25/2014 11:51 PM, Pekka Paalanen wrote: > > > What \comment-line command are you looking for? > > > > I see you reformatted > > > - * wl_list_insert(&foo_list, &item1.link); \comment{Pushes item1 at > the head} > > > > b

Re: [PATCH weston 1/2] compositor: add weston_surface_set_description()

2014-11-27 Thread Pekka Paalanen
On Thu, 27 Nov 2014 10:17:21 +0200 Giulio Camuffo wrote: > Just a quick comment below, I haven't looked at it carefully yet. > > -- > Giulio > > 2014-11-27 9:07 GMT+02:00 Pekka Paalanen : > > From: Pekka Paalanen > > > > When printing out logs from Weston's actions, mainly for debugging, it >

Re: [PATCH weston 1/2] compositor: add weston_surface_set_description()

2014-11-27 Thread Giulio Camuffo
Just a quick comment below, I haven't looked at it carefully yet. -- Giulio 2014-11-27 9:07 GMT+02:00 Pekka Paalanen : > From: Pekka Paalanen > > When printing out logs from Weston's actions, mainly for debugging, it > can be very difficult to identify the different surfaces. Inspecting > the c