Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:44:02 -0800 Bill Spitzak wrote: > On 11/25/2014 06:46 AM, Pekka Paalanen wrote: > > On Tue, 11 Nov 2014 18:42:56 -0800 > > Bill Spitzak wrote: > > > >> These links are pretty useful for navigation, though sometimes excessive > >> (you can turn them off by putting % before

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:46:17 -0800 Bill Spitzak wrote: > On 11/25/2014 06:47 AM, Pekka Paalanen wrote: > > On Tue, 11 Nov 2014 18:42:59 -0800 > > Bill Spitzak wrote: > > > >> Also removed \comment and used C++ comments. There does not appear > >> to be any other way to put comments into code sam

[PATCH] doc: Removed extra indentation from wl_list code sample

2014-11-25 Thread Bill Spitzak
This is a minor documentation fix. I did not see any asterisks in the output as reported by Pekka Paalanen. Using doxygen 1.7.6.1. --- src/wayland-util.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-util.h b/src/wayland-util.h index 46f9a81..a4b22b5 10

Re: [PATCH libinput] evdev: Fix uninitialized variable warning

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 11:53:23AM -0600, Derek Foreman wrote: > The early exit path in evdev_device_compare_syspath() expects > udev_device_new to be initialized to NULL, but it wasn't. > > Signed-off-by: Derek Foreman merged, thanks Cheers, Peter > --- > src/evdev.c | 2 +- > 1 file chan

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bryce Harrington
On Tue, Nov 25, 2014 at 11:46:05AM -0800, Bill Spitzak wrote: > On 11/25/2014 07:11 AM, Derek Foreman wrote: > > >What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color > >component and still be a match? a fuzz of 256 would match everything? > > The cairo project has done some wor

[PATCH v3 libinput] evdev: Query mouse DPI from udev

2014-11-25 Thread Peter Hutterer
From: Derek Foreman Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman Signed-off-by: Peter Hutterer --- sorry, clearly didn't have the right caffeine/blood ratio ye

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 10:41:50AM -0600, Derek Foreman wrote: > On 25/11/14 04:32 AM, Peter Hutterer wrote: > > On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: > >> This patch allows libinput to ignore devices that have joystick buttons. > >> > >> Signed-off-by: Krzysztof So

[PATCH weston] Drop legacy backends in favor of libinput

2014-11-25 Thread Peter Hutterer
--- Makefile.am| 15 +- configure.ac | 10 +- src/compositor-drm.c | 2 +- src/compositor-fbdev.c | 2 +- src/compositor-rpi.c | 2 +- src/evdev-touchpad.c | 800 - src/evdev.c| 755

Re: [PATCH v1] Added string conversion utility functions

2014-11-25 Thread Imran Zaman
Thanks Bill for your comments. Plz see my comments inline. On Tue, Nov 25, 2014 at 9:26 PM, Bill Spitzak wrote: > > > On 11/24/2014 11:12 PM, Imran Zaman wrote: >> >> On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak wrote: >>> >>> >>> >>> On 11/24/2014 11:32 AM, Imran Zaman wrote: >>> [IZ2] Th

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bill Spitzak
On 11/25/2014 07:11 AM, Derek Foreman wrote: What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color component and still be a match? a fuzz of 256 would match everything? The cairo project has done some work on a fuzzy comparison for their tests, may be able to reuse that. ___

Re: [PATCH weston] simple-shm: explain two initial roundtrips

2014-11-25 Thread Bill Spitzak
Can you add what wl_shm events it must get before continuing? (I guess it is the list of supported formats). This is not clear from this comment, which reads more like "bind won't work unless you do sync afterwards". On 11/24/2014 11:58 PM, Pekka Paalanen wrote: From: Pekka Paalanen Explain

Re: [PATCH v1] Added string conversion utility functions

2014-11-25 Thread Bill Spitzak
On 11/24/2014 11:12 PM, Imran Zaman wrote: On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak wrote: On 11/24/2014 11:32 AM, Imran Zaman wrote: [IZ2] This is the case where endptr is used in patch. I can remove endptr but it seems its used so i have to keep the existing functionality in place.

[PATCH libinput] evdev: Fix uninitialized variable warning

2014-11-25 Thread Derek Foreman
The early exit path in evdev_device_compare_syspath() expects udev_device_new to be initialized to NULL, but it wasn't. Signed-off-by: Derek Foreman --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 908a8ba..3782ac4 100644 --- a/s

[PATCH v2 libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-25 Thread Derek Foreman
Signed-off-by: Derek Foreman --- test/misc.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/test/misc.c b/test/misc.c index 4ed9dce..c8ac51f 100644 --- a/test/misc.c +++ b/test/misc.c @@ -548,6 +548,43 @@ START_TEST(ratelimit_helpers) } END_TEST +s

[PATCH v2 libinput 1/2] evdev: Query mouse DPI from udev

2014-11-25 Thread Derek Foreman
Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman --- src/evdev.c | 20 +++ src/libinput-util.c | 55 +

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Bill Spitzak
On 11/25/2014 06:47 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:59 -0800 Bill Spitzak wrote: Also removed \comment and used C++ comments. There does not appear to be any other way to put comments into code samples. --- src/wayland-client.c | 25 ++--- src/wayla

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-25 Thread Bill Spitzak
On 11/25/2014 06:46 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:56 -0800 Bill Spitzak wrote: These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation because it failed on

Re: [PATCH 2/9] doc: Preserve spaces

2014-11-25 Thread Bill Spitzak
On 11/25/2014 06:47 AM, Pekka Paalanen wrote: On Tue, 11 Nov 2014 18:42:55 -0800 Bill Spitzak wrote: Slight variation on Pekka's patch. It seems harmless to put this anywhere. I assume you refer to http://cgit.freedesktop.org/wayland/wayland/commit/?id=4a661c5b0c9c66102a142cd8d327dcad8007f1d

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Jasper St. Pierre
Well, SDL already opens your gamepad evdev device manually. libinput is designed for compositors and Wayland, and I don't see any reason to introduce a gamepad protocol into Wayland if SDL already just uses evdev. On Tue, Nov 25, 2014 at 8:41 AM, Derek Foreman wrote: > On 25/11/14 04:32 AM, Pete

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Derek Foreman
On 25/11/14 04:32 AM, Peter Hutterer wrote: > On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: >> This patch allows libinput to ignore devices that have joystick buttons. >> >> Signed-off-by: Krzysztof Sobiecki >> --- >> src/evdev.c | 9 + >> 1 file changed, 9 insert

Re: [PATCH libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-25 Thread Derek Foreman
On 25/11/14 01:35 AM, Peter Hutterer wrote: > On Mon, Nov 24, 2014 at 03:53:37PM -0600, Derek Foreman wrote: >> Signed-off-by: Derek Foreman >> --- >> test/Makefile.am| 7 - >> test/mouse_dpi_parser.c | 69 >> + >> 2 files changed, 75

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-25 Thread Derek Foreman
On 25/11/14 04:11 AM, Pekka Paalanen wrote: > On Mon, 24 Nov 2014 18:48:51 -0800 > Bryce Harrington wrote: > >> On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote: >>> On Wed, 19 Nov 2014 15:06:22 -0800 >>> Bryce Harrington wrote: >>> This also serves as a proof of concept of th

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Derek Foreman
On 25/11/14 03:53 AM, Pekka Paalanen wrote: > On Mon, 24 Nov 2014 15:20:35 -0800 > Bryce Harrington wrote: > >> On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: >>> On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington wrote:

Re: [PATCH 2/9] doc: Preserve spaces

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:55 -0800 Bill Spitzak wrote: > Slight variation on Pekka's patch. It seems harmless to put this anywhere. I assume you refer to http://cgit.freedesktop.org/wayland/wayland/commit/?id=4a661c5b0c9c66102a142cd8d327dcad8007f1d7 Unfortunately every generation of the html do

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:59 -0800 Bill Spitzak wrote: > Also removed \comment and used C++ comments. There does not appear > to be any other way to put comments into code samples. > --- > src/wayland-client.c | 25 ++--- > src/wayland-server.h |8 > src/waylan

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-25 Thread Pekka Paalanen
On Tue, 11 Nov 2014 18:42:56 -0800 Bill Spitzak wrote: > These links are pretty useful for navigation, though sometimes excessive > (you can turn them off by putting % before the word in the comment). > > I had to turn off validation because it failed on missing and duplicate > target id's, whic

Re: [PATCH v2] doc: Fixes to doxygen output

2014-11-25 Thread Pekka Paalanen
On Thu, 13 Nov 2014 12:06:00 -0800 Bryce Harrington wrote: > On Tue, Nov 11, 2014 at 06:42:53PM -0800, Bill Spitzak wrote: > > This supersedes the previous 8 patches. The primary change is to > > not use % to remove links. Also some further typos in both the > > docs and commit messages have been

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-25 Thread Jussi Laako
On 25.11.2014 15:01, Pekka Paalanen wrote: However, all upstream cases will use XDG_RUNTIME_DIR, which probably is not appropriate for your use case, depending on how you actually start things. That's why I thought providing an alternative could be useful. It still supports XDG_RUNTIME_DIR too

Let env var override socket directory in libwayland-client?

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:22:47 +0200 Jussi Laako wrote: > On 19.11.2014 16:22, Pekka Paalanen wrote: > > When a session compositor is started, you can already use > > WAYLAND_SOCKET environment variable to pass an opened connection to it. > > If your system compositor forks session compositors, no

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:02:22 +0200 Jussi Laako wrote: > On 19.11.2014 12:56, Pekka Paalanen wrote: > > I have very hard time deciding if we should allow the environment to > > overwrite the server and client assumptions on where the socket is. It > > would be easier for me to accept new API funct

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 02:33:53AM +0100, Krzysztof A. Sobiecki wrote: > This patch allows libinput to ignore devices that have joystick buttons. > > Signed-off-by: Krzysztof Sobiecki > --- > src/evdev.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/evdev.c b/src/evdev.c

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Peter Hutterer
On Tue, Nov 25, 2014 at 12:16:18PM +0200, Pekka Paalanen wrote: > On Tue, 25 Nov 2014 02:33:53 +0100 > sob...@gmail.com (Krzysztof A. Sobiecki) wrote: > > > This patch allows libinput to ignore devices that have joystick buttons. > > > > Signed-off-by: Krzysztof Sobiecki > > --- > > src/evdev.c

Re: FreeBSD libinput

2014-11-25 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 12:37:47PM -0700, Ales Katona wrote: > Hey, > > as far as I know epoll is only available on freeBSD via the linux > compatibility kernel + libraries layer, which is not installed by default. > There is kqueue which is an arguably better event handling mechanism. > There's a

Re: [PATCH] Ignore devices that have joystick buttons

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 02:33:53 +0100 sob...@gmail.com (Krzysztof A. Sobiecki) wrote: > This patch allows libinput to ignore devices that have joystick buttons. > > Signed-off-by: Krzysztof Sobiecki > --- > src/evdev.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/evdev.c

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-25 Thread Pekka Paalanen
On Mon, 24 Nov 2014 18:48:51 -0800 Bryce Harrington wrote: > On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote: > > On Wed, 19 Nov 2014 15:06:22 -0800 > > Bryce Harrington wrote: > > > > > This also serves as a proof of concept of the screen capture > > > functionality and as a dem

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Pekka Paalanen
On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington wrote: > On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: > > On 24/11/14 05:01 AM, Pekka Paalanen wrote: > > > On Wed, 19 Nov 2014 15:06:21 -0800 > > > Bryce Harrington wrote: > > > > > >> From: Derek Foreman > > >> > > >> Adds

Re: vc_dispmanx_set_wl_buffer_in_use not found

2014-11-25 Thread Pekka Paalanen
On Tue, 25 Nov 2014 14:22:26 +0800 Jeff Chua wrote: > On Tue, Nov 18, 2014 at 3:45 PM, Pekka Paalanen > wrote: > > > well, with so little information, all I can ask is: are you sure you > > had Wayland-enabled version of a player, and the player is using GLESv2 > > instead of anything else like