From: Pekka Paalanen
Explain carefully why we need two roundtrips, not just one, not just
dispatch and roundtrip, but two roundtrips after creating the
wl_registry object.
Signed-off-by: Pekka Paalanen
---
clients/simple-shm.c | 30 ++
1 file changed, 30 insertions(
On Mon, Nov 24, 2014 at 03:53:37PM -0600, Derek Foreman wrote:
> Signed-off-by: Derek Foreman
> ---
> test/Makefile.am| 7 -
> test/mouse_dpi_parser.c | 69
> +
> 2 files changed, 75 insertions(+), 1 deletion(-)
> create mode 100644 t
On Mon, Nov 24, 2014 at 03:53:36PM -0600, Derek Foreman wrote:
> Instead of using a hard coded mouse DPI value, we query it from udev.
> If it's not present or the property is obviously broken we fall back
> to default.
for the archives: the thing we're struggling with on high-DPI mice is that
our
On 19.11.2014 16:22, Pekka Paalanen wrote:
When a session compositor is started, you can already use
WAYLAND_SOCKET environment variable to pass an opened connection to it.
If your system compositor forks session compositors, no problem. If
something else starts your session compositors, you need
On Mon, Nov 24, 2014 at 12:16:05PM +0100, Hans de Goede wrote:
> This is useful to know in some cases, it is e.g. necessary to figure out
> which percentage of a touchpads range to use as edge for edge-scrolling.
>
> Note this is a slightly cleaned up copy of the same code in
> xf86-input-synaptic
On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak wrote:
>
>
> On 11/24/2014 11:32 AM, Imran Zaman wrote:
>
>> [IZ2] This is the case where endptr is used in patch. I can remove
>> endptr but it seems its used so i have to keep the existing
>> functionality in place.
>> + if (!weston_strtoi(pid, &end,
On 19.11.2014 12:56, Pekka Paalanen wrote:
I have very hard time deciding if we should allow the environment to
overwrite the server and client assumptions on where the socket is. It
would be easier for me to accept new API functions that operate with
absolute paths or existing fds explicitly, bu
On Tue, Nov 18, 2014 at 3:45 PM, Pekka Paalanen
wrote:
> well, with so little information, all I can ask is: are you sure you
> had Wayland-enabled version of a player, and the player is using GLESv2
> instead of anything else like desktop OpenGL?
# ldd mplayer
libGLESv2.so.2 => /opt/vc
On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote:
> On Wed, 19 Nov 2014 15:06:22 -0800
> Bryce Harrington wrote:
>
> > This also serves as a proof of concept of the screen capture
> > functionality and as a demo for snapshot-based rendering verification.
> >
> > Signed-off-by: Bryc
This patch allows libinput to ignore devices that have joystick buttons.
Signed-off-by: Krzysztof Sobiecki
---
src/evdev.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/evdev.c b/src/evdev.c
index 36c6859..5f6cc32 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1274,6 +1274,15
On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote:
> On 24/11/14 05:01 AM, Pekka Paalanen wrote:
> > On Wed, 19 Nov 2014 15:06:21 -0800
> > Bryce Harrington wrote:
> >
> >> From: Derek Foreman
> >>
> >> Adds wl_test_record_screenshot() to weston test. This commit also
> >> adds a de
On 11/24/2014 11:32 AM, Imran Zaman wrote:
[IZ2] This is the case where endptr is used in patch. I can remove
endptr but it seems its used so i have to keep the existing
functionality in place.
+ if (!weston_strtoi(pid, &end, 0, &other) || end != pid + 10)
Use strlen(pid) != 10 instead.
[I
On 24/11/14 05:01 AM, Pekka Paalanen wrote:
> On Wed, 19 Nov 2014 15:06:21 -0800
> Bryce Harrington wrote:
>
>> From: Derek Foreman
>>
>> Adds wl_test_record_screenshot() to weston test. This commit also
>> adds a dependency on cairo to weston-test to use it for writing PNG
>> files.
>>
>> Fixe
Signed-off-by: Derek Foreman
---
test/Makefile.am| 7 -
test/mouse_dpi_parser.c | 69 +
2 files changed, 75 insertions(+), 1 deletion(-)
create mode 100644 test/mouse_dpi_parser.c
diff --git a/test/Makefile.am b/test/Makefile.am
index
Instead of using a hard coded mouse DPI value, we query it from udev.
If it's not present or the property is obviously broken we fall back
to default.
Signed-off-by: Derek Foreman
---
src/evdev.c | 18 ++
src/libinput-util.c | 41 +
Hey,
as far as I know epoll is only available on freeBSD via the linux
compatibility kernel + libraries layer, which is not installed by default.
There is kqueue which is an arguably better event handling mechanism.
There's an existing patch for such a rewrite here:
http://lists.freedesktop.org/ar
Hi
Please see the comments below.
BR
imran
On Mon, Nov 24, 2014 at 8:58 PM, Bill Spitzak wrote:
>
>
> On 11/24/2014 05:08 AM, Imran Zaman wrote:
>>
>> Thanks Bill for your comments. Please see my comments inline.
>>
>> On Fri, Nov 21, 2014 at 9:31 PM, Bill Spitzak wrote:
>>>
>>> There is no ne
On 11/22/2014 12:28 PM, Jasper St. Pierre wrote:
+ xdg_shell allows clients to turn a wl_surface into a "real window"
+ which can be dragged, resized, stacked, and moved around by the
+ user. Everything about this interface is suited towards traditional
+ desktop en
Are you sure this supports a client replacing the top popup with a
different one? It seems to set the top to null rather than the next one
down when one is removed. I would also be concerned that it may be
difficult for a client to insure that the previous popup is destroyed
before the new one
On 11/24/2014 05:08 AM, Imran Zaman wrote:
Thanks Bill for your comments. Please see my comments inline.
On Fri, Nov 21, 2014 at 9:31 PM, Bill Spitzak wrote:
There is no need to pass endptr, because your functions will always fail if
it is not set to point to the terminating null.
[IZ] end
On Mon, 24 Nov 2014 16:10:49 +0200
Imran Zaman wrote:
> This will allow more than 1 simultaneous client connections to the server
> without the possibility of connection refused error.
>
> Signed-off-by: Imran Zaman
> ---
> src/wayland-server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 delet
On Mon, 24 Nov 2014 15:59:31 +0200
Imran Zaman wrote:
> Exactly git send-email did ask for utf-8 and i guess i entered y.. shall I
> not?
> and no idea why git is making it multipart..
>
> Shall i try to resend the patch with utf-8 question as 'no'?
Actually you should just hit enter, so that
This will allow more than 1 simultaneous client connections to the server
without the possibility of connection refused error.
Signed-off-by: Imran Zaman
---
src/wayland-server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wayland-server.c b/src/wayland-server.c
index
On Fri, 21 Nov 2014 18:34:32 +
Daniel Stone wrote:
> Hi,
>
> On 21 November 2014 08:57, Pekka Paalanen wrote:
>
> > > > I agree 100%. Again, think of nesting compositors: why should our
> > compositor
> > > > behave completely different if it's nested? The more difficult we make
> > it to
Exactly git send-email did ask for utf-8 and i guess i entered y.. shall I not?
and no idea why git is making it multipart..
Shall i try to resend the patch with utf-8 question as 'no'?
BR
imran
On Mon, Nov 24, 2014 at 3:50 PM, Pekka Paalanen wrote:
> On Mon, 24 Nov 2014 15:33:51 +0200
> Imran
Actually we were connecting multiple simultaneous child/session
westons to system weston and sometime it didn't succeed. Nevertheless
we are not sure that this can be one of the reasons and we couldnt
spot the problem precisely (we were testing it in Tizen with kernel
version: 3.14.19-10.4)
We tho
On Mon, 24 Nov 2014 15:33:51 +0200
Imran Zaman wrote:
> Hi
>
> Somehow I dont see the patch below in patch work:
> http://lists.freedesktop.org/archives/wayland-devel/2014-November/018410.html
>
> Any idea what is wrong with it or there is some sort of filtering or ?
Hi, yeah, I tried to ask y
On Sat, 22 Nov 2014 12:28:24 -0800
"Jasper St. Pierre" wrote:
> This is the last round of fixups I'm going to to the existing
> xdg-shell interface. We'll be adding on other APIs before it
> goes fully stable, but before that, let's focus on making
> sure what we already have is good enough.
>
>
Hi
Somehow I dont see the patch below in patch work:
http://lists.freedesktop.org/archives/wayland-devel/2014-November/018410.html
Any idea what is wrong with it or there is some sort of filtering or ?
BR
imran
On Thu, Nov 20, 2014 at 12:47 AM, Bill Spitzak wrote:
> On 11/19/2014 07:30 AM, Dan
On Sat, 22 Nov 2014 12:28:29 -0800
"Jasper St. Pierre" wrote:
> This rewrites basically all of the text inside xdg-shell to be up to
> date, clearer, and rid of wl_shell and X11 terminology.
> ---
> protocol/xdg-shell.xml | 256
> ++---
> 1 file chang
Thanks Bill for your comments. Please see my comments inline.
On Fri, Nov 21, 2014 at 9:31 PM, Bill Spitzak wrote:
> There is no need to pass endptr, because your functions will always fail if
> it is not set to point to the terminating null.
>
[IZ] endptr is passed other than null; please see th
On Sat, 22 Nov 2014 12:28:28 -0800
"Jasper St. Pierre" wrote:
> Either in destroy or get_xdg_popup.
> ---
> desktop-shell/shell.c | 21 -
> protocol/xdg-shell.xml | 7 +++
> 2 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/desktop-shell/shell.c b/deskt
On Thu, 20 Nov 2014 10:25:17 +0200
Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> If a keyboard exists but it has no current focus, yet something asks the
> input-panel to come up, we would crash here. Check that there is a focus
> before attempting to use it.
>
> Maybe there should not even
On Fri, 21 Nov 2014 13:45:04 +
Daniel Stone wrote:
> Yep, this is correct.
>
> (I'll get back to the other thread shortly.)
>
> -d
>
> On Thursday, November 20, 2014, Giulio Camuffo
> wrote:
>
> > When getting the focus we get the list of pressed keys, but we are
> > not supposed to run
On Wed, 19 Nov 2014 15:06:15 -0800
Bryce Harrington wrote:
> This set of patches by Derek and I implement functionality to do
> screenshot-based testing of wayland.
>
> The idea is to allow tests to render the desktop to memory using Pixman,
> apply an optional clipping mask via Cairo, and store
On Wed, 19 Nov 2014 15:06:26 -0800
Bryce Harrington wrote:
> We need to use the output filename when we do a comparison with the
> appropriate reference image, so move the filename construction to the
> caller of record_screenshot() instead.
>
> Doing this also requires externalizing the output
On Wed, 19 Nov 2014 15:06:24 -0800
Bryce Harrington wrote:
> Steal Cairo's files_equal() routine to do byte comparison of the rendered
> files. Note that since the clock time will change run to run we can
> only compare against the first frame (which will be black).
Not even the first frame is
On Wed, 19 Nov 2014 15:06:22 -0800
Bryce Harrington wrote:
> This also serves as a proof of concept of the screen capture
> functionality and as a demo for snapshot-based rendering verification.
>
> Signed-off-by: Bryce Harrington
> ---
> Makefile.am | 7 +-
> tests/fadein-test.c
Hi,
On 11/21/2014 01:29 AM, Peter Hutterer wrote:
On Thu, Nov 20, 2014 at 10:34:51AM +0100, Hans de Goede wrote:
[...]
+int
+tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device)
+{
+ struct tp_touch *t;
+ int width, height;
+ int edge_width, edge_height;
+
Add edge-scrolling support for non multi-touch touchpads as well as for
users who prefer edge-scrolling (as long as they don't have a clickpad).
Note the percentage to use of the width / height as scroll-edge differs from
one manufacturer to the next, the various per model percentages were taken
f
This is useful to know in some cases, it is e.g. necessary to figure out
which percentage of a touchpads range to use as edge for edge-scrolling.
Note this is a slightly cleaned up copy of the same code in
xf86-input-synaptics.
Signed-off-by: Hans de Goede
---
src/evdev-mt-touchpad.c | 36 +
This is purely a code move, this is a preparation patch for adding edge
scrolling support.
Signed-off-by: Hans de Goede
---
src/evdev-mt-touchpad.c | 118
1 file changed, 59 insertions(+), 59 deletions(-)
diff --git a/src/evdev-mt-touchpad.c b/sr
On Wed, 19 Nov 2014 15:06:21 -0800
Bryce Harrington wrote:
> From: Derek Foreman
>
> Adds wl_test_record_screenshot() to weston test. This commit also
> adds a dependency on cairo to weston-test to use it for writing PNG
> files.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=83981
>
Hi,
On 11/20/2014 07:19 AM, Peter Hutterer wrote:
On Wed, Nov 19, 2014 at 11:50:13AM +0100, Hans de Goede wrote:
[...]
+
+ switch (tp->model) {
+ case MODEL_SYNAPTICS:
+ edge_width = width * .07;
+ edge_height = height * .07;
+ break;
+
On Fri, 21 Nov 2014 12:38:35 -0800
Bryce Harrington wrote:
> On Fri, Nov 21, 2014 at 04:56:03PM +0200, Pekka Paalanen wrote:
> > On Wed, 19 Nov 2014 15:06:20 -0800
> > Bryce Harrington wrote:
> >
> > > From: Derek Foreman
> > >
> > > Tests will now return the extra command line parameters the
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer
Looks good:
Reviewed-by: Hans de Goede
Regards,
Hans
---
test/path.c | 71 ++-
test/udev.c | 78
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
The seat of a device is currently immutable, but a device may (in a
multi-pointer case) move between different logical seats. Moving it between
seats is akin to removing it and re-plugging it, so let's do exactly that.
The physical seat name sta
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Prep work for changing seat names on devices. No functional changes.
Signed-off-by: Peter Hutterer
Looks good:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/path.c | 30 ++
1 file changed, 22 insertions
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Prep work for changing seat names on devices. No functional changes.
Signed-off-by: Peter Hutterer
Looks good:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/udev-seat.c | 13 -
1 file changed, 8 insertions(+), 5 deleti
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Potential race condition:
- udev notifies us that a udev_device became available
- we go for a coffee and chat to the neighbours on the way
- the device is unplugged
- a new device is plugged in, gets the same devnode
- we finish our coffee and c
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Using a udev_device instead of the various bits separately safes us
re-initializing udev contexts whenever we need to compare the device. And
having the actual udev device makes it a bit easier to ensure that we're not
re-initializing a different
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
Long-term plan to use more of udev_device here is to better protect us against
re-opening a different device that happens to have the same devnode.
This now also prints an error message for invalid devices, the log tests are
adjusted.
Signed-of
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
No functional changes
Signed-off-by: Peter Hutterer
Looks good:
Reviewed-by: Hans de Goede
Regards,
Hans
---
src/path.c | 57 -
1 file changed, 32 insertions(+), 25 deletions(-)
Hi,
On 11/24/2014 01:46 AM, Peter Hutterer wrote:
We need it for each device anyway, keep the ref around. Makes error handling a
bit easier, we don't need to handle failing udev_new() and reduce the danger
of mis-refcounting it.
Signed-off-by: Peter Hutterer
Looks good:
Reviewed-by: Hans de
54 matches
Mail list logo
