FreeBSD libinput

2014-11-21 Thread Ales Katona
Hello, I wanted to try and compile libinput under freeBSD seeing how epoll has been patched into kqueue on the platform, but I'm getting stopped by configure saying it can't find EPOLL_CLOEXEC. Is this just a configure block or is the code still linux specific? Thanks, Ales -- Feel the power o

[PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Daniel Stone
Hi, On 21 November 2014 21:11, Bill Spitzak > wrote: > On 11/21/2014 10:59 AM, Daniel Stone wrote: > >> Which you respond to by ceasing _all_ actions related to your current >> keyboard state, such as cancelling key repeat. So, also not useless. >> > > You are right, it is the "stop repeating key

Re: [PATCH weston] rpi-renderer: don't pass a box to pixman_region32_contains_point()

2014-11-21 Thread Bryce Harrington
On Fri, Nov 21, 2014 at 12:31:04PM -0600, Derek Foreman wrote: > We don't care which box contained the point, so don't pass one in. > > Signed-off-by: Derek Foreman > --- > > Had thought I'd already sent this one up a while back, but can't find > it in patchwork or on the list... > > src/rpi-r

Re: [PATCH weston] input: send the pressed keys to the focused client when running a key binding

2014-11-21 Thread Bill Spitzak
On 11/21/2014 12:01 PM, Giulio Camuffo wrote: --- src/bindings.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/bindings.c b/src/bindings.c index 5e24725..0beca6d 100644 --- a/src/bindings.c +++ b/src/bindings.c @@ -262,6 +262,7 @@ weston_compositor_run_key_binding(struc

Re: [PATCH v1] Added string conversion utility functions

2014-11-21 Thread Bill Spitzak
On 11/21/2014 11:48 AM, Daniel Stone wrote: On 21 November 2014 19:31, Bill Spitzak mailto:spit...@gmail.com>> wrote: It is useful to pass -1 for strtoul and this should continue to work. It is the only easily-recognized value for "largest number possible". Other than ~0UL, ~0ULL

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Bill Spitzak
On 11/21/2014 10:59 AM, Daniel Stone wrote: And the other is "a useless event that must be sent before the key map changed event". Which you respond to by ceasing _all_ actions related to your current keyboard state, such as cancelling key repeat. So, also not useless. You are right,

Re: [PATCH v1 weston 05/11] tests: Allow tests to use customized command line parameters

2014-11-21 Thread Bryce Harrington
On Fri, Nov 21, 2014 at 04:56:03PM +0200, Pekka Paalanen wrote: > On Wed, 19 Nov 2014 15:06:20 -0800 > Bryce Harrington wrote: > > > From: Derek Foreman > > > > Tests will now return the extra command line parameters they need > > when run with --params > > > > Signed-off-by: Bryce Harrington

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Bill Spitzak
On 11/21/2014 10:30 AM, Daniel Stone wrote: As in the first quoted section, I think it's not really reasonable to guard against the possibility of Mod+S taking a screenshot in the compositor, but the client having a shortcut for Mod+S+X. So I think we can take the easy way out of saying: - fo

[PATCH weston] input: send the pressed keys to the focused client when running a key binding

2014-11-21 Thread Giulio Camuffo
--- src/bindings.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/bindings.c b/src/bindings.c index 5e24725..0beca6d 100644 --- a/src/bindings.c +++ b/src/bindings.c @@ -262,6 +262,7 @@ weston_compositor_run_key_binding(struct weston_compositor *compositor,

Re: [PATCH v1] Added string conversion utility functions

2014-11-21 Thread Daniel Stone
On 21 November 2014 19:31, Bill Spitzak wrote: > It is useful to pass -1 for strtoul and this should continue to work. It > is the only easily-recognized value for "largest number possible". Other than ~0UL, ~0ULL, ULONG_MAX, etc ... ___ wayland-devel

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Bill Spitzak
On 11/21/2014 10:30 AM, Daniel Stone wrote: As in the first quoted section, I think it's not really reasonable to guard against the possibility of Mod+S taking a screenshot in the compositor, but the client having a shortcut for Mod+S+X. So I think we can take the easy way out of saying: - fo

Re: [PATCH v1] Added string conversion utility functions

2014-11-21 Thread Bill Spitzak
There is no need to pass endptr, because your functions will always fail if it is not set to point to the terminating null. I also suspect that the base is never used. In addition a possible future fix would be to accept 0x for hex but a leading zero is decimal, not octal, which means this fun

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Daniel Stone
Right. On 20 November 2014 20:37, Bill Spitzak wrote: > On 11/20/2014 12:05 AM, Daniel Stone wrote: > >> As far as I can tell from what the others are saying - which I'd totally >> agree with - is that wl_keyboard's focus would be much more transient >> than it is now, reflecting where keyboard

[PATCH weston] rpi-renderer: don't pass a box to pixman_region32_contains_point()

2014-11-21 Thread Derek Foreman
We don't care which box contained the point, so don't pass one in. Signed-off-by: Derek Foreman --- Had thought I'd already sent this one up a while back, but can't find it in patchwork or on the list... src/rpi-renderer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/s

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Daniel Stone
Hi, On 21 November 2014 08:57, Pekka Paalanen wrote: > On Thu, 20 Nov 2014 10:31:18 +0200 > Giulio Camuffo wrote: > > 2014-11-20 10:05 GMT+02:00 Daniel Stone : > > > On 19 November 2014 21:05, Bill Spitzak wrote: > > >> You also mentioned an "enter debug mode" shortcut. That must NOT send a >

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Daniel Stone
Hi, On 20 November 2014 08:31, Giulio Camuffo wrote: > 2014-11-20 10:05 GMT+02:00 Daniel Stone : > > On 19 November 2014 21:05, Bill Spitzak wrote: > >> No! Users do NOT want this. Keys take action when you push them. > Otherwise > >> the interface looks slow and drives users crazy. > > > > > >

[PATCH v1] Added string conversion utility functions

2014-11-21 Thread Imran Zaman
Change-Id: I50900852311604a8c31313bbfb1d137c495d2269 Signed-off-by: Imran Zaman --- Makefile.am | 14 +- clients/multi-resource.c| 8 +- clients/terminal.c | 8 +- clients/wscreensaver-glue.c | 6 +- shared/config-parser.c | 10 +- shared/option-parser.c

Re: [PATCH v1 weston 05/11] tests: Allow tests to use customized command line parameters

2014-11-21 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:20 -0800 Bryce Harrington wrote: > From: Derek Foreman > > Tests will now return the extra command line parameters they need > when run with --params > > Signed-off-by: Bryce Harrington > --- > tests/weston-test-runner.c | 8 > tests/weston-tests-env |

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

2014-11-21 Thread Derek Foreman
On 21/11/14 04:32 AM, Pekka Paalanen wrote: > On Wed, 19 Nov 2014 09:03:31 -0800 > "Jasper St. Pierre" wrote: > >> On Wed, Nov 19, 2014 at 7:22 AM, Daniel Stone wrote: >> >>> Hi, >>> >>> On 19 November 2014 14:58, Derek Foreman wrote: >>> Since we're sort of on the topic, is there anywhere

Re: [PATCH weston v2 1/1] compositor: Add idle timeout option to weston.ini

2014-11-21 Thread Pekka Paalanen
On Thu, 30 Oct 2014 15:06:34 -0400 Frederic Plourde wrote: > Weston's idle timeout can already be set via the '-i' command-line > option, but this patch lets users specify it also via weston.ini. > Note that the command-line option takes precedence over the .ini, > should the option be set by bot

Re: [PATCH weston] input: don't run the key bindings on focus in

2014-11-21 Thread Daniel Stone
Yep, this is correct. (I'll get back to the other thread shortly.) -d On Thursday, November 20, 2014, Giulio Camuffo wrote: > When getting the focus we get the list of pressed keys, but we are > not supposed to run the key binding on them. > --- > src/input.c | 6 -- > 1 file changed, 6 d

Re: [PATCH weston] xwayland: fix fullscreening

2014-11-21 Thread Pekka Paalanen
On Thu, 30 Oct 2014 23:14:30 +0900 Ryo Munakata wrote: > On Wed, 29 Oct 2014 13:44:44 +0100 > Marek Chalupa wrote: > > > set_fullscreen has been sending configure before changing the state > > and xwayland windows added border to the fullscreen size. > > > > This fixes the bug: > > https://bug

Re: [weston] Makefile.am: Link weston_multi_resource against rt library

2014-11-21 Thread Pekka Paalanen
On Wed, 29 Oct 2014 12:10:49 -0700 Bryce Harrington wrote: > On Mon, Oct 27, 2014 at 03:13:19PM +, Javier Jardón wrote: > > This fixes this build failure: > > > > /usr/lib/gcc/x86_64-unknown-linux-gnu/4.7.3/../../../../x86_64-unknown-linux-gnu/bin/ld: > > clients/weston_multi_resource-multi-

Re: [weston V2 1/2] Check for math (m) and real time (rt) libraries

2014-11-21 Thread Pekka Paalanen
On Fri, 31 Oct 2014 16:43:02 +0100 sardemff7+wayl...@sardemff7.net wrote: > On 2014-10-30 15:23, Javier Jardón wrote: > > --- > > Makefile.am | 19 +-- > > configure.ac | 6 ++ > > 2 files changed, 15 insertions(+), 10 deletions(-) > > > > diff --git a/configure.ac b/conf

Re: [PATCH wayland] client: read_events should return -1 after an error

2014-11-21 Thread Pekka Paalanen
On Mon, 27 Oct 2014 09:19:46 +0100 Marek Chalupa wrote: > When a thread is sleeping, waiting until another thread read > from the display, it always returns 0. Even when an error > occured. In documentation stands: > > "return 0 on success or -1 on error. In case of error errno will >be s

Re: [PATCH wayland 2/2] server: use next serial in display_sync

2014-11-21 Thread Pekka Paalanen
On Mon, 27 Oct 2014 09:14:41 +0100 Marek Chalupa wrote: > Display sync sends always the same serial (if nothing intervenes > and increases the serial for the sync). > > Signed-off-by: Marek Chalupa > --- > src/wayland-server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

2014-11-21 Thread Pekka Paalanen
On Wed, 19 Nov 2014 08:58:14 -0600 Derek Foreman wrote: > On 19/11/14 08:33 AM, Pekka Paalanen wrote: > > On Thu, 16 Oct 2014 16:37:02 -0500 > > Derek Foreman wrote: > > > >> Pixman uses y-x banded rectangles to represent regions. We use these > >> y-x banded rectangles to generate triangle fa

[PATCH wayland 2/2] tests: use color when printing on terminal

2014-11-21 Thread Marek Chalupa
Colorize output of the tests when prinitng on terminal. Signed-off-by: Marek Chalupa --- tests/test-runner.c | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index 2ecb15a..3af78fe

[PATCH wayland 1/2] test-runner: print separator line after each test-case

2014-11-21 Thread Marek Chalupa
Who can read the output when it is a single piece of text? Signed-off-by: Marek Chalupa --- tests/test-runner.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test-runner.c b/tests/test-runner.c index 63b25ed..2ecb15a 100644 --- a/tests/test-runner.c +++ b/tests/test-runner.c @@ -3

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

2014-11-21 Thread Pekka Paalanen
On Wed, 19 Nov 2014 09:03:31 -0800 "Jasper St. Pierre" wrote: > On Wed, Nov 19, 2014 at 7:22 AM, Daniel Stone wrote: > > > Hi, > > > > On 19 November 2014 14:58, Derek Foreman wrote: > > > >> Since we're sort of on the topic, is there anywhere we gain anything > >> from y-x banded regions? I'

[PATCH wayland] tests: fix memory leak

2014-11-21 Thread Marek Chalupa
We didn't free the struct client that we got from client_connect() Signed-off-by: Marek Chalupa --- tests/display-test.c| 23 +-- tests/test-compositor.c | 1 + 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/tests/display-test.c b/tests/display-test.c i

[PATCH wayland] tests: split queue-test testcases

2014-11-21 Thread Marek Chalupa
All the test-cases are in one test atm. It doesn't matter for the outcome, but when it is split to more tests, the debugging and reading the output is simpler. Signed-off-by: Marek Chalupa --- tests/queue-test.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --g

[PATCH wayland] client: update documentation about threading

2014-11-21 Thread Marek Chalupa
Remove out-dated documentation and add few more words about this topic. Signed-off-by: Marek Chalupa --- src/wayland-client.c | 106 ++- 1 file changed, 87 insertions(+), 19 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c ind

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-21 Thread Pekka Paalanen
On Thu, 20 Nov 2014 10:31:18 +0200 Giulio Camuffo wrote: > 2014-11-20 10:05 GMT+02:00 Daniel Stone : > > Hi, > > > > On 19 November 2014 21:05, Bill Spitzak wrote: > >> > >> On 11/19/2014 05:08 AM, Pekka Paalanen wrote: > > > > Just like Jasper said, it is a mistake to use wl_keyboard fo