Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

On Wed, Nov 19, 2014 at 01:45:35PM +0100, Hans de Goede wrote: > Add edge-scrolling support for non multi-touch touchpads as well as for > users who prefer edge-scrolling (as long as they don't have a clickpad). > > Note the percentage to use of the width / height as scroll-edge differs from > one

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

On Wed, Nov 19, 2014 at 11:50:13AM +0100, Hans de Goede wrote: [...] > > > >> + > >> + switch (tp->model) { > >> + case MODEL_SYNAPTICS: > >> + edge_width = width * .07; > >> + edge_height = height * .07; > >> + break; > >> + case MODEL_ALPS: > >> + edge_widt

[PATCH 1/4] tests: Include "config.h" as first header

Signed-off-by: Bryce Harrington --- tests/event-test.c| 2 ++ tests/keyboard-test.c | 2 ++ tests/surface-test.c | 2 ++ tests/weston-test-client-helper.c | 2 +- tests/weston-test-runner.c| 2 ++ tests/xwayland-test.c | 4 +++- 6 files

[PATCH 4/4] tests: Use one shared xzalloc implementation

Since this is an inlined function, move it to a common header file. Signed-off-by: Bryce Harrington --- tests/presentation-test.c | 11 --- tests/weston-test-client-helper.c | 11 --- tests/weston-test-client-helper.h | 11 +++ 3 files changed, 11 insertions(+), 2

[PATCH 2/4] tests: Cleanup superfluous headers

Mostly remove headers that aren't actually needed for anything. Add stdint.h to permit dropping xf86drm.h, which is otherwise unneeded. Signed-off-by: Bryce Harrington --- tests/bad-buffer-test.c| 3 --- tests/buffer-count-test.c | 7 ++- tests/button-test.c| 1 + tests/presenta

[PATCH 3/4] tests: Move ARRAY_LENGTH to a shared header for reuse

Signed-off-by: Bryce Harrington --- tests/presentation-test.c | 2 -- tests/weston-test-runner.h | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/presentation-test.c b/tests/presentation-test.c index b99e93d..f97e5b3 100644 --- a/tests/presentation-test.c +++ b/test

[PATCH v1 weston 02/11] compositor-headless: allow rendering with pixman

From: Derek Foreman Allow the headless backend to render into an off screen buffer with pixman. Signed-off-by: Bryce Harrington --- src/compositor-headless.c | 57 +++ 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/src/compositor-head

[PATCH v1 weston 09/11] tests: Add support for comparing output against reference images

Steal Cairo's files_equal() routine to do byte comparison of the rendered files. Note that since the clock time will change run to run we can only compare against the first frame (which will be black). Signed-off-by: Bryce Harrington --- tests/fadein-test.c | 31 ++

[PATCH v1 weston 07/11] tests: Add a fadein test

This also serves as a proof of concept of the screen capture functionality and as a demo for snapshot-based rendering verification. Signed-off-by: Bryce Harrington --- Makefile.am | 7 +- tests/fadein-test.c | 64 + 2 files changed

[PATCH v1 weston 05/11] tests: Allow tests to use customized command line parameters

From: Derek Foreman Tests will now return the extra command line parameters they need when run with --params Signed-off-by: Bryce Harrington --- tests/weston-test-runner.c | 8 tests/weston-tests-env | 1 + 2 files changed, 9 insertions(+) diff --git a/tests/weston-test-runner.c

[PATCH v1 weston 04/11] compositor: Document options for headless compositor

Signed-off-by: Bryce Harrington --- src/compositor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 72fe384..a4726d5 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4595,6 +4595,16 @@ usage(int error_code) "\n");

[PATCH v1 weston 00/11] Headless rendering testing

This set of patches by Derek and I implement functionality to do screenshot-based testing of wayland. The idea is to allow tests to render the desktop to memory using Pixman, apply an optional clipping mask via Cairo, and store the image to disk as a PNG file. A pixel checker routine is included

[PATCH v1 weston 03/11] compositor-headless: add support for transforms set on command line

From: Derek Foreman We now allow --transform with the headless compositor, however it still doesn't parse anything out of weston.ini Signed-off-by: Bryce Harrington --- src/compositor-headless.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/sr

[PATCH v1 weston 01/11] configure.ac: Indicate headless compositor presence in config.h

Signed-off-by: Bryce Harrington --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 934..56ee544 100644 --- a/configure.ac +++ b/configure.ac @@ -181,6 +181,9 @@ AC_ARG_ENABLE(headless-compositor, [ --enable-headless-compositor],,

[PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

From: Derek Foreman Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG files. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=83981 Signed-off-by: Bryce Harrington --- Makefile.am | 4 +-- pr

[PATCH v1 weston 11/11] tests: Construct the filename external to wl_test_record_screenshot

We need to use the output filename when we do a comparison with the appropriate reference image, so move the filename construction to the caller of record_screenshot() instead. Doing this also requires externalizing the output iteration loop since we want the output number to be recorded in the fi

Re: Wayland and Weston in Patchwork

On 11/19/2014 07:30 AM, Daniel Stone wrote: I don't think there's any reason to be as precious with Patchwork access as we are with others. We need all the help with triage we can get, all the changes are cosmetic and logged, and if anyone screws around with it and misrepresents mailing list con

Re: [PATCH weston] dnd: reset the mouse cursor after adding a new item

On 11/19/2014 07:16 AM, Derek Foreman wrote: I'm pretty sure the mouse may have already moved - exactly the same reason as above, this handler is getting the drop co-ords but time has passed since the drop. You are right about that. I'm not clear on how input_get_position is implemented, did

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-19 23:31 GMT+02:00 Giulio Camuffo : > 2014-11-19 23:05 GMT+02:00 Bill Spitzak : >> On 11/19/2014 05:08 AM, Pekka Paalanen wrote: >> > Just like Jasper said, it is a mistake to use wl_keyboard focus for > window focus, xdg_shell has a separate mechanism for window focus. > Window

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-19 23:05 GMT+02:00 Bill Spitzak : > On 11/19/2014 05:08 AM, Pekka Paalanen wrote: > Just like Jasper said, it is a mistake to use wl_keyboard focus for window focus, xdg_shell has a separate mechanism for window focus. Window focus is a shell concept IMO, anyway. > > > Can yo

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On 11/19/2014 05:08 AM, Pekka Paalanen wrote: Just like Jasper said, it is a mistake to use wl_keyboard focus for window focus, xdg_shell has a separate mechanism for window focus. Window focus is a shell concept IMO, anyway. Can you explain when (except to fix this bug) then "xdg_shell focus"

[PATCH weston v2] input: Use slightly less obscure logic in evdev_notify_keyboard_focus()

While the test is actually correct (for non-negative numbers), it's not at all clear and seems to be an accidental order of operations mistake. Also, add an assert() to make sure this number is never negative. Closes bug 86346 - https://bugs.freedeskto.org/show_bug.cgi?id=86346 Signed-off-by: De

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

On Wed, Nov 19, 2014 at 7:22 AM, Daniel Stone wrote: > Hi, > > On 19 November 2014 14:58, Derek Foreman wrote: > >> Since we're sort of on the topic, is there anywhere we gain anything >> from y-x banded regions? I'm wondering if it would be worthwhile to >> replace pixman's region code with so

Re: Patch for RPI crash

On Wed, Nov 19, 2014 at 02:45:24PM +0200, Pekka Paalanen wrote: > Then again, I think the rpi-renderer and especially its experimental EGL > support are just waiting to be replaced by proper kernel DRM drivers > and the Mesa VC4 driver, but that is a long way to go still. > > So if you fix the cod

Re: Wayland and Weston in Patchwork

Hi, On 19 November 2014 14:51, Pekka Paalanen wrote: > On Tue, 11 Nov 2014 18:52:35 -0800 > Bill Spitzak wrote: > > On 11/04/2014 03:14 AM, Pekka Paalanen wrote: > > > You change the patch status by clicking the patch link in the list, and > > > on the following page you should have box titled

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

Hi, On 19 November 2014 14:58, Derek Foreman wrote: > Since we're sort of on the topic, is there anywhere we gain anything > from y-x banded regions? I'm wondering if it would be worthwhile to > replace pixman's region code with something that doesn't band. I think > this would let us drop the

Re: [PATCH weston] dnd: reset the mouse cursor after adding a new item

On 18/11/14 05:08 PM, Bill Spitzak wrote: > I think the dnd client needs to handle normal mouse enter events and set > the cursor. If the server is not sending an enter right after the drop > then this is a bug, right? When dnd_drop_handler triggers (which could be before the enter event every tim

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

On 19/11/14 08:33 AM, Pekka Paalanen wrote: > On Thu, 16 Oct 2014 16:37:02 -0500 > Derek Foreman wrote: > >> Pixman uses y-x banded rectangles to represent regions. We use these >> y-x banded rectangles to generate triangle fans, resulting in more >> geometry than strictly necessary to draw the

Re: Wayland and Weston in Patchwork

On Tue, 11 Nov 2014 18:52:35 -0800 Bill Spitzak wrote: > On 11/04/2014 03:14 AM, Pekka Paalanen wrote: > > > You change the patch status by clicking the patch link in the list, and > > on the following page you should have box titled "Patch Properties" > > near the top. If you don't see that, yo

Re: [PATCH weston] backends: refactor transform string parsing

On Thu, 23 Oct 2014 12:24:18 -0500 Derek Foreman wrote: > Most of the backends do their own parsing of transform strings, so let's > put that all in the same place (compositor.c/h) > --- > src/compositor-drm.c | 30 -- > src/compositor-rpi.c | 43 -

Re: [PATCH] gitignore: adpat to scanner and protocol path changes

On Wed, 22 Oct 2014 18:44:59 +0200 Olivier Blin wrote: > Since commit 4c163b9b001bd93aaf97d7e962873a379eb90bfd, wayland-scanner > is built in top builddir instead of src, and protocol files are > generated in protocol subdir instead of src. > Protocol files generated in the new path are already p

Re: [PATCH weston] gl-renderer: compress pixman bands to simplify geometry

On Thu, 16 Oct 2014 16:37:02 -0500 Derek Foreman wrote: > Pixman uses y-x banded rectangles to represent regions. We use these > y-x banded rectangles to generate triangle fans, resulting in more > geometry than strictly necessary to draw the screen. > > This patch combines the bands to reduce

Re: [PATCH 2/2] Support for adjusting socket access rights to allow group of users to connect to the socket.

(Fixing CC lists, please use reply-to-all in the future...) On Wed, 22 Oct 2014 10:55:25 +0300 Jussi Laako wrote: > On 20.10.2014 18:13, Daniel Stone wrote: > > Each to their own; I don't think it's necessarily any more complex than > > split compositors, since at some point you have to deal wit

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

On Wed, 19 Nov 2014 14:14:34 +0100 Marek Chalupa wrote: > Hi, > > maybe I just don't understand how this should work... > > You have system compositor which spawns some other wayland compositors? > Then you can specify these (or any other) environment vars in the > compositor, the child composi

Re: [PATCH weston v2 2/2] cairo-util: fix shadows for small clients

On Wed, 29 Oct 2014 14:51:23 +0100 Marek Chalupa wrote: > If the client is small (< 128 pixels in any ward), > then the shadows overlap and create dark lines behind clients. > This is a problem mosly with pop-up menues. The lines become observable > when the menu has less than three items. The ot

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

Hi, maybe I just don't understand how this should work... You have system compositor which spawns some other wayland compositors? Then you can specify these (or any other) environment vars in the compositor, the child compositors will inherit these... On 19 November 2014 12:52, Imran Zaman wro

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On Wed, 19 Nov 2014 14:31:35 +0200 Giulio Camuffo wrote: > 2014-11-19 13:42 GMT+02:00 Pekka Paalanen : > > On Tue, 18 Nov 2014 18:54:04 +0200 > > Giulio Camuffo wrote: > > > >> 2014-11-13 13:30 GMT+02:00 Daniel Stone : > >> > Hi, > >> > > >> > On Thursday, November 13, 2014, Giulio Camuffo > >>

[PATCH libinput v2 1/3] touchpad: Move 2 finger scrolling functions to above tp_process_state()

This is purely a code move, this is a preparation patch for adding edge scrolling support. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 128 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/sr

[PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

Add edge-scrolling support for non multi-touch touchpads as well as for users who prefer edge-scrolling (as long as they don't have a clickpad). Note the percentage to use of the width / height as scroll-edge differs from one manufacturer to the next, the various per model percentages were taken f

[PATCH libinput v2 2/3] touchpad: Add code to get the touchpad model / manufacturer

This is useful to know in some cases, it is e.g. necessary to figure out which percentage of a touchpads range to use as edge for edge-scrolling. Note this is a slightly cleaned up copy of the same code in xf86-input-synaptics. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 36 +

Re: Patch for RPI crash

On Mon, 20 Oct 2014 12:36:57 +0200 Daniel Stone wrote: > Hi, > > On 9 October 2014 10:37, Yves De Muyter wrote: > > > Here is a fix for an issue that pops up here when I close a window on a > > Raspberry-pi that is using GLES2 to draw contents. > > It also reproducible with the clients/simple-

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-19 13:42 GMT+02:00 Pekka Paalanen : > On Tue, 18 Nov 2014 18:54:04 +0200 > Giulio Camuffo wrote: > >> 2014-11-13 13:30 GMT+02:00 Daniel Stone : >> > Hi, >> > >> > On Thursday, November 13, 2014, Giulio Camuffo >> > wrote: >> >> >> >> 2014-11-13 12:06 GMT+02:00 Daniel Stone : >> >> > But t

Re: [PATCH weston v0 07/11] compositor: Document options for headless compositor

Hi, This patch doesn't apply to me. Even with 3-way merge: Applying: compositor: Document options for headless compositor fatal: sha1 information is lacking or useless (src/compositor.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. The last

Re: [PATCH wayland] tests: don't print '\0' character

On Wed, 19 Nov 2014 11:58:26 +0100 Marek Chalupa wrote: > print "" (which results in no output) instead of > printing '\0' (which is not visible, but is there) > > Signed-off-by: Marek Chalupa > --- > tests/test-runner.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On Mon, 17 Nov 2014 17:54:33 +1000 Peter Hutterer wrote: > On Thu, Nov 13, 2014 at 10:06:27AM +, Daniel Stone wrote: > > Hi, > > > > On Thursday, November 13, 2014, Giulio Camuffo > > wrote: > > > > > 2014-11-13 11:18 GMT+02:00 Daniel Stone > > >: > > > > Think about the case where pressi

Re: [PATCH weston] Fix some typos in protocol files

On Sun, 16 Nov 2014 19:04:04 +0530 Seedo Eldho Paul wrote: > Signed-off-by: Seedo Eldho Paul > --- > protocol/fullscreen-shell.xml| 10 +- > protocol/input-method.xml| 2 +- > protocol/presentation_timing.xml | 4 ++-- > protocol/text.xml| 2 +- > 4 files

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

... corrected jussi email address.. BR irman On Wed, Nov 19, 2014 at 12:56 PM, Pekka Paalanen wrote: > On Wed, 15 Oct 2014 17:36:27 +0300 > Imran Zaman wrote: > >> Hi >> >> support for adjusting socket access rights to allow group of users to >> connect to the socket. >> >> This is used for nes

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On Tue, 18 Nov 2014 18:54:04 +0200 Giulio Camuffo wrote: > 2014-11-13 13:30 GMT+02:00 Daniel Stone : > > Hi, > > > > On Thursday, November 13, 2014, Giulio Camuffo > > wrote: > >> > >> 2014-11-13 12:06 GMT+02:00 Daniel Stone : > >> > But this is just a client issue, and nothing in sending the fu

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On Thu, 13 Nov 2014 09:53:56 + Daniel Stone wrote: > Hi, > > On Thursday, November 13, 2014, Daniel Stone wrote: > > > > On 13 November 2014 07:35, Pekka Paalanen > > wrote: > > > >> On Wed, 12 Nov 2014 12:06:16 -0800 > >> Bill Spitzak >> > wrote: > >> > The important point is that in bot

Re: [PATCH weston] input: Use slightly less obscure logic in evdev_notify_keyboard_focus()

On 17 November 2014 15:47, Derek Foreman wrote: > While the test is actually correct (for non-negative numbers), it's not > at all clear and seems to be an accidental order of operations mistake. > > Also, add an assert() to make sure this number is never negative. > > Closes bug 86346 - https://

[PATCH 2 wayland] tests: detect if debugger is attached

Copy function from libinput/test/litest.c is_debugger_detached() and use it in our test-runner. If debugger is attached, turn off leak checks and timeouts automatically. Revision of libinput: 028513a0a723e97941c39c4aeb17433198723913 Signed-off-by: Marek Chalupa --- tests/test-runner.c | 43

[PATCH wayland] tests: rename NO_ASSERT_LEAK_CHECK

This env variable is used for turning off the leak checks in tests. Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent with WAYLAND_TESTS_NO_TIMEOUTS. Signed-off-by: Marek Chalupa --- tests/test-runner.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test

[PATCH wayland] tests: don't print '\0' character

print "" (which results in no output) instead of printing '\0' (which is not visible, but is there) Signed-off-by: Marek Chalupa --- tests/test-runner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index a6c75a9..1373225 100644

Re: [PATCH v2 wayland] tests: add timeout

Oh, yes, sure. Thanks, Marek On 17 November 2014 16:02, Pekka Paalanen wrote: > On Wed, 12 Nov 2014 13:16:42 +0100 > Marek Chalupa wrote: > > > Add test_set_timeout() function that allows the test to > > set timeout for its completition. Any other call to the function > > re-sets the timeout t

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

On Wed, 15 Oct 2014 17:36:27 +0300 Imran Zaman wrote: > Hi > > support for adjusting socket access rights to allow group of users to > connect to the socket. > > This is used for nested compositor architectures. > - > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index ce1ec

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

Hi, On 11/11/2014 02:20 AM, Peter Hutterer wrote: > sorry for the duplicate Hans, wayland-devel got dropped of the first reply. > > On Fri, Nov 07, 2014 at 02:25:06PM +0100, Hans de Goede wrote: >> Add edge-scrolling support for non multi-touch touchpads as well as for >> users who prefer edge-sc

Re: [PATCH wayland] increase server listen queue to 8

On Wed, 15 Oct 2014 16:43:34 +0300 Imran Zaman wrote: > Hi > > This will allow more than 1 simultaneous client connections to the server > without the possibility of connection refused error. possible use case > is multiple session > compositors can connect to the system compositor simultaneousl

Re: [PATCH libinput 0/6] natural scrolling for all pointers

Hi, On 11/19/2014 08:26 AM, Peter Hutterer wrote: > > We had a request to enable natural scrolling from non-touchpad devices > (probably trackballs are the more common use-case here). This patchset does > that, it moves the feature into evdev.c and then enables it for all pointer > devices (inclu

Re: [PATCH libinput] Allow for a 0 button on button scrolling

Hi, On 11/19/2014 07:34 AM, Peter Hutterer wrote: > This effectively disables the button scrolling, but since 0 is the default > button for most devices, we should allow setting the default button. > > Signed-off-by: Peter Hutterer Good catch, I've thought about the need to add this exception m

Re: [RFC PATCH libinput] Rename scroll_mode to scroll_method

Hi, On 11/19/2014 03:31 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > > --- > would like to get some input from native english speakers here. I was > writing hooks to use the new scroll method interface and for some reason > scroll "mode" struck me as the wrong word, with "method"