Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-12 Thread Pekka Paalanen
On Wed, 12 Nov 2014 12:06:16 -0800 Bill Spitzak wrote: > The important point is that in both your and my case the client that has > just received focus sees the 'd' as being held down. The 'd' is on in > the key-down array attached to the focus-in event Correct. Apparently X apps interpret

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-12 Thread Bill Spitzak
On 11/12/2014 03:15 AM, Pekka Paalanen wrote: - In the Wayland terminal, press Ctrl, then D. The wayland terminal exits due to the shell getting EOF and quitting. The xterm gets focus. - Release Ctrl but continue holding down 'd'. The 'd' starts to repeat in the xterm. I don't get this behavi

Re: XWayland / glamor on virtual machines

2014-11-12 Thread Thomas Hellstrom
On 11/12/2014 01:27 PM, Peter Hanzel wrote: > Hello all. > > I had a similar problem with gnome-wayland (missing texts). I > rebuilded xwayland without glamor and it works now. > The remaining problem is low resolution in VMware (640x480). > > I boot to framebuffer console and use gnome-session --s

[PATCH wayland] client: remove old comment

2014-11-12 Thread Marek Chalupa
There is nothing like main thread since 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore. Signed-off-by: Marek Chalupa --- src/wayland-client.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 01629e0..41c49e9 100644 --- a/src/wayland-client.

Re: XWayland / glamor on virtual machines

2014-11-12 Thread Peter Hanzel
Hello all. I had a similar problem with gnome-wayland (missing texts). I rebuilded xwayland without glamor and it works now. The remaining problem is low resolution in VMware (640x480). I boot to framebuffer console and use gnome-session --session gnome-wayland to start it. If someone knows have

[PATCH v2 wayland] tests: add timeout

2014-11-12 Thread Marek Chalupa
Add test_set_timeout() function that allows the test to set timeout for its completition. Any other call to the function re-sets the timeout to the new value. The timeouts can be turned off (usefull when debugging) by setting evironment variable WAYLAND_TESTS_NO_TIMEOUTS. v2: rename NO_TIMEOUTS

[PATCH v2 wayland 1/2] tests: add test_usleep and test_sleep functions

2014-11-12 Thread Marek Chalupa
The former one was already used in tests, but was private. These functions can be shared across the tests, so make them public. Signed-off-by: Marek Chalupa --- tests/display-test.c | 15 --- tests/test-helpers.c | 32 tests/test-runner.h | 12 ++

[PATCH v2 wayland 2/2] tests: add timeout tests

2014-11-12 Thread Marek Chalupa
sanity tests for timeouts. v2: use test_sleep instead of sleep add few more test-cases Signed-off-by: Marek Chalupa --- tests/sanity-test.c | 67 + 1 file changed, 67 insertions(+) diff --git a/tests/sanity-test.c b/tests/sanity-test.c in

Re: [PATCH weston v2 2/2] Avoid 'g_type_init() is deprecated' warnings

2014-11-12 Thread Pekka Paalanen
On Sat, 4 Oct 2014 20:37:13 +0900 Ryo Munakata wrote: > Because of g_type_init we see the following: > clients/editor.c:1350:2: warning: ‘g_type_init’ is deprecated (declared > at /usr/include/glib-2.0/gobject/gtype.h:679) > [-Wdeprecated-declarations] > > g_type_init() has been deprecated and

Re: [PATCH wayland v3] abort if a listener function is NULL

2014-11-12 Thread Pekka Paalanen
On Wed, 1 Oct 2014 21:17:18 +0900 Ryo Munakata wrote: > Signed-off-by: Ryo Munakata > --- > src/connection.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/connection.c b/src/connection.c > index f292853..f516c85 100644 > --- a/src/connection.c > +++ b/src/connection.c > @@

Re: [PATCH weston v2 1/2] Add font entry to shell section for title fonts

2014-11-12 Thread Pekka Paalanen
On Sat, 4 Oct 2014 18:53:30 -0700 "Jasper St. Pierre" wrote: > Set a font description like "Sans" and then let Pango do the glyph > selection with fallback fonts. It hooks together with fontconfig -- it > knows well enough what font options are available. I agree with that. Ryo, will you be sen

Re: [PATCH wayland 3/4] tests: use test_set_timeout in display-test

2014-11-12 Thread Giulio Camuffo
2014-11-12 13:46 GMT+02:00 Marek Chalupa : > > > On 7 November 2014 21:26, Giulio Camuffo wrote: >> >> I'm a bit confused here... you remove the alarm() calls but not the >> signal handler or the sigaction setting. > > > The alarm worked with default action - that is kill the process. There were >

Re: [PATCH wayland 3/4] tests: use test_set_timeout in display-test

2014-11-12 Thread Marek Chalupa
On 7 November 2014 21:26, Giulio Camuffo wrote: > I'm a bit confused here... you remove the alarm() calls but not the > signal handler or the sigaction setting. The alarm worked with default action - that is kill the process. There were no signal handler or sigaction setting before. When test f

Re: [PATCH weston] xwm: find a seat for all the surface's views

2014-11-12 Thread Giulio Camuffo
2014-11-12 13:25 GMT+02:00 Pekka Paalanen : > On Sat, 4 Oct 2014 13:58:33 +0300 > Giulio Camuffo wrote: > >> This allows to move or resize a xwayland client by acting on all >> its views. > > Hmm, is this a good thing? What use cases you had in mind? I have two views for the same surface, and th

Re: [PATCH weston] xwm: find a seat for all the surface's views

2014-11-12 Thread Pekka Paalanen
On Sat, 4 Oct 2014 13:58:33 +0300 Giulio Camuffo wrote: > This allows to move or resize a xwayland client by acting on all > its views. Hmm, is this a good thing? What use cases you had in mind? Shouldn't there be a difference between move/resizeable views and other views? Like if you have an

Re: XWayland / glamor on virtual machines

2014-11-12 Thread Thomas Hellstrom
On 11/12/2014 11:57 AM, Pekka Paalanen wrote: > On Tue, 11 Nov 2014 15:52:53 +0100 > Thomas Hellstrom wrote: > >> Hi! >> >> I was just starting out to try out XWayland in fedora 21 on top of >> gnome/wayland + vmwgfx. >> Currently no text is rendered, I'm not sure whether this is a glamor bug >> o

Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-12 Thread Pekka Paalanen
On Tue, 11 Nov 2014 16:10:22 +0200 Giulio Camuffo wrote: > 2014-11-11 15:10 GMT+02:00 Pekka Paalanen : > > On Tue, 11 Nov 2014 11:23:40 +0200 > > Giulio Camuffo wrote: > > > >> weston key bindings are supposed to eat the key events, and not pass it > >> on to clients, and indeed the wl_keyboard.

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-12 Thread Pekka Paalanen
On Tue, 11 Nov 2014 22:48:04 +0200 Giulio Camuffo wrote: > 2014-11-11 22:39 GMT+02:00 Bill Spitzak : > > Better example: > > > > - Make an xterm have focus. > > > > - Make a new wayland terminal and give it focus. > > > > - In the Wayland terminal, press Ctrl, then D. The wayland terminal exits >

Re: XWayland / glamor on virtual machines

2014-11-12 Thread Pekka Paalanen
On Tue, 11 Nov 2014 15:52:53 +0100 Thomas Hellstrom wrote: > Hi! > > I was just starting out to try out XWayland in fedora 21 on top of > gnome/wayland + vmwgfx. > Currently no text is rendered, I'm not sure whether this is a glamor bug > or a vmwgfx GL bug, but in any case, I suspect that using

Re: [wayland] Remove useless semicolon.

2014-11-12 Thread Pekka Paalanen
On Wed, 12 Nov 2014 11:18:18 +0100 Marek Chalupa wrote: > Yes, this is no-op semicolon. > > Reviewed-by: Marek Chalupa > > On 12 November 2014 03:19, Carlos Olmedo Escobar > wrote: > > > Signed-off-by: Carlos Olmedo Escobar > > --- > > src/wayland-server.c | 2 +- > > 1 file changed, 1 ins

Re: [PATCH wayland 1/4] tests: add timeout

2014-11-12 Thread Marek Chalupa
On 12 November 2014 11:22, Marek Chalupa wrote: > > > On 10 November 2014 13:11, Pekka Paalanen wrote: > >> On Fri, 7 Nov 2014 21:56:48 +0200 >> Giulio Camuffo wrote: >> >> > I have a couple of comments below, otherwise it looks good. >> > >> > >> > -- >> > Giulio >> > >> > >> > 2014-09-24 15:3

Re: [PATCH wayland 2/4] tests: add timeout test

2014-11-12 Thread Marek Chalupa
Thanks, didn't notice it in man pages before... I'll use nanosleep. Thanks, Marek On 10 November 2014 13:16, Pekka Paalanen wrote: > On Fri, 7 Nov 2014 22:08:43 +0200 > Giulio Camuffo wrote: > > > Looks good, they fail as expected. > > > > Reviewed-by: Giulio Camuffo > > > > 2014-09-24 15:37

Re: [PATCH wayland 1/4] tests: add timeout

2014-11-12 Thread Marek Chalupa
On 10 November 2014 13:11, Pekka Paalanen wrote: > On Fri, 7 Nov 2014 21:56:48 +0200 > Giulio Camuffo wrote: > > > I have a couple of comments below, otherwise it looks good. > > > > > > -- > > Giulio > > > > > > 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > > > Add test_set_timeout() function th

Re: [wayland] Remove useless semicolon.

2014-11-12 Thread Marek Chalupa
Yes, this is no-op semicolon. Reviewed-by: Marek Chalupa On 12 November 2014 03:19, Carlos Olmedo Escobar wrote: > Signed-off-by: Carlos Olmedo Escobar > --- > src/wayland-server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/wayland-server.c b/src/wayland-ser

Re: [PATCH 7/9] doc: fixed reference to non-existent function

2014-11-12 Thread Marek Chalupa
Actually, this comment should be deleted, wl_display_dispatch() doesn't do anything like that since the wl_display_acquire_fd() was deleted. Or maybe better, it should be replaced with current behavior regarding threads, that is something like: "This function can not be called simultaneously from