Re: Wayland and Weston in Patchwork

2014-11-11 Thread Bill Spitzak
On 11/04/2014 03:14 AM, Pekka Paalanen wrote: You change the patch status by clicking the patch link in the list, and on the following page you should have box titled "Patch Properties" near the top. If you don't see that, you don't have permissions to change it (e.g. not logged in, or unregiste

[PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-11 Thread Bill Spitzak
Also removed \comment and used C++ comments. There does not appear to be any other way to put comments into code samples. --- src/wayland-client.c | 25 ++--- src/wayland-server.h |8 src/wayland-util.h | 30 ++ 3 files changed, 32

[PATCH 5/9] doc: removed some unnecessary nested listing from doxygen output

2014-11-11 Thread Bill Spitzak
This makes the lists of parameters slightly smaller and removes some bullets from see-also and since. --- doc/publican/doxygen-to-publican.xsl | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/do

[PATCH v2] doc: Fixes to doxygen output

2014-11-11 Thread Bill Spitzak
This supersedes the previous 8 patches. The primary change is to not use % to remove links. Also some further typos in both the docs and commit messages have been fixed. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.free

[PATCH 8/9] doc: fixed a typo

2014-11-11 Thread Bill Spitzak
--- src/wayland-client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index fb459a3..16df207 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -1212,7 +1212,7 @@ cancel_read(struct wl_display *display) * This wil

[PATCH 7/9] doc: fixed reference to non-existent function

2014-11-11 Thread Bill Spitzak
This is a guess as to what the correct reference is, please check! --- src/wayland-client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 21fc3e9..fb459a3 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -150

[PATCH 1/9] doc: make rebuilds doxygen output on code changes

2014-11-11 Thread Bill Spitzak
--- doc/publican/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index cf0f533..b30a471 100644 --- a/doc/publican/Makefile.am +++ b/doc/publican/Makefile.am @@ -82,7 +82,7 @@ en-US/ProtocolInterfaces.xml: $(top

[PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-11 Thread Bill Spitzak
These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation because it failed on missing and duplicate target id's, which this produces. --- doc/publican/Makefile.am |1 +

[PATCH 9/9] doc: Removed \ref when it refers to the subject the text is attached to

2014-11-11 Thread Bill Spitzak
This does not make a difference to doxygen output but may help other document generators not make redundant links. --- src/wayland-client.c |2 +- src/wayland-client.h | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c

[PATCH 2/9] doc: Preserve spaces

2014-11-11 Thread Bill Spitzak
Slight variation on Pekka's patch. It seems harmless to put this anywhere. --- doc/publican/doxygen-to-publican.xsl |4 1 file changed, 4 insertions(+) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/doxygen-to-publican.xsl index b6ca5f3..99193e1 100644 --- a/doc/public

[PATCH 4/9] doc: Don't print dash if doxygen brief description missing

2014-11-11 Thread Bill Spitzak
--- doc/publican/doxygen-to-publican.xsl |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/doxygen-to-publican.xsl index 7f7abe9..461cf3e 100644 --- a/doc/publican/doxygen-to-publican.xsl +++ b/doc/publican/doxygen-t

[wayland] Remove useless semicolon.

2014-11-11 Thread Carlos Olmedo Escobar
Signed-off-by: Carlos Olmedo Escobar --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 270e5c7..c40d300 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1118,7 +1118,7 @@ wl_socket_init_fo

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
2014-11-11 22:39 GMT+02:00 Bill Spitzak : > Better example: > > - Make an xterm have focus. > > - Make a new wayland terminal and give it focus. > > - In the Wayland terminal, press Ctrl, then D. The wayland terminal exits > due to the shell getting EOF and quitting. The xterm gets focus. > > - Rel

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Bill Spitzak
Better example: - Make an xterm have focus. - Make a new wayland terminal and give it focus. - In the Wayland terminal, press Ctrl, then D. The wayland terminal exits due to the shell getting EOF and quitting. The xterm gets focus. - Release Ctrl but continue holding down 'd'. The 'd' starts

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
I'm unsure whether i should reply, but let's try one last time. 2014-11-11 21:27 GMT+02:00 Bill Spitzak : > Hate to be a pain about this, but the description of the bug (with Mod+x) > can be reproduced and has nothing to do with whether the compositor shortcut > was triggered. Try Mod+y (or any ot

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Bill Spitzak
Hate to be a pain about this, but the description of the bug (with Mod+x) can be reproduced and has nothing to do with whether the compositor shortcut was triggered. Try Mod+y (or any other key not consumed by the compositor) in an xterm. You can argue about whether the 'x' or 'y' should repea

Re: [PATCH wayland-web] Updated additional dependencies for a cleaner Ubuntu 12.04 LTS system.

2014-11-11 Thread Bill Spitzak
On 11/11/2014 04:40 AM, Pekka Paalanen wrote: On Mon, 27 Oct 2014 22:05:55 -0700 Bill Spitzak wrote: On 10/27/2014 01:44 PM, Jon A. Cruz wrote: On Mon, Oct 27, 2014, at 11:39 AM, Bill Spitzak wrote: Looks good to me! I'll check if this is also needed for the 14.04 instructions. Probably i

XWayland / glamor on virtual machines

2014-11-11 Thread Thomas Hellstrom
Hi! I was just starting out to try out XWayland in fedora 21 on top of gnome/wayland + vmwgfx. Currently no text is rendered, I'm not sure whether this is a glamor bug or a vmwgfx GL bug, but in any case, I suspect that using glamor for xrender acceleration will be very slow, and something we'd li

Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
2014-11-11 15:10 GMT+02:00 Pekka Paalanen : > On Tue, 11 Nov 2014 11:23:40 +0200 > Giulio Camuffo wrote: > >> weston key bindings are supposed to eat the key events, and not pass it >> on to clients, and indeed the wl_keyboard.key event is not sent. But >> we must also not put the key in the keys

Re: [PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Pekka Paalanen
On Tue, 11 Nov 2014 11:23:40 +0200 Giulio Camuffo wrote: > weston key bindings are supposed to eat the key events, and not pass it > on to clients, and indeed the wl_keyboard.key event is not sent. But > we must also not put the key in the keys array to pass to client with > the wl_keyboard.enter

Re: [PATCH wayland-web] testing: Document how to run an individual test

2014-11-11 Thread Pekka Paalanen
On Fri, 24 Oct 2014 17:06:32 -0700 Bryce Harrington wrote: > Had to figure this all out for something else, so figured I'd document > it. Eventually we may have so many tests that running one in isolation > will be handy. > > Signed-off-by: Bryce Harrington > --- > testing.html | 43 +++

Re: [PATCH wayland-web] Updated build instructions

2014-11-11 Thread Pekka Paalanen
On Wed, 29 Oct 2014 17:23:28 -0700 Bryce Harrington wrote: > On Wed, Oct 29, 2014 at 04:10:22PM -0700, Bill Spitzak wrote: > > Based on Jon A. Cruz patch. I tested the build on my 12.04 and Linux Mint > > machines and it appears to be correct, though there are certainly no > > guarantees as the m

Re: [PATCH wayland-web] testing: Be more diverse in word choice

2014-11-11 Thread Pekka Paalanen
On Fri, 24 Oct 2014 15:52:27 -0700 Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington > --- > testing.html |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testing.html b/testing.html > index b199d82..660cee9 100644 > --- a/testing.html > +++ b/testing.html

Re: [PATCH wayland-web] Updated additional dependencies for a cleaner Ubuntu 12.04 LTS system.

2014-11-11 Thread Pekka Paalanen
On Mon, 27 Oct 2014 22:05:55 -0700 Bill Spitzak wrote: > On 10/27/2014 01:44 PM, Jon A. Cruz wrote: > > On Mon, Oct 27, 2014, at 11:39 AM, Bill Spitzak wrote: > >> Looks good to me! > >> > >> I'll check if this is also needed for the 14.04 instructions. Probably > >> it is. > > > > > > Uh oh. I t

Re: [PATCH 2/2] compositor: List only available backends in help text

2014-11-11 Thread Pekka Paalanen
On Fri, 24 Oct 2014 09:20:23 -0500 Derek Foreman wrote: > I think this series is all obviously correct too. > > Though, I suppose this one will look funny if someone manages to build > weston without any back-ends. :) > > Reviewed-by: Derek Foreman Both pushed. And one more patch to add a mi

Re: [PATCH 3/3] compositor: Fix typos in help text

2014-11-11 Thread Pekka Paalanen
On Fri, 24 Oct 2014 09:12:42 -0500 Derek Foreman wrote: > The whole series looks correct to me... > > Reviewed-by: Derek Foreman All three pushed. Thanks, pq > On 23/10/14 04:44 PM, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington > > --- > > src/compositor.c | 4 ++-- > > 1 fi

Re: [PATCH V4] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-11-11 Thread Pekka Paalanen
On Wed, 15 Oct 2014 14:51:27 +0530 Srivardhan Hebbar wrote: > Signed-off-by: Srivardhan Hebbar > --- > src/wayland-server.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index 674aeca..0fc2088 100644 >

Re: [WESTON PATCH 1/1] Weston: Fix some weston.ini.man typesetting macros

2014-11-11 Thread Pekka Paalanen
On Fri, 24 Oct 2014 09:10:55 -0500 Derek Foreman wrote: > An obvious improvement. > > Reviewed-by: Derek Foreman Indeed, pushed. Thanks, pq > On 23/10/14 09:40 PM, Frederic Plourde wrote: > > This patch fixes a couple of misuses around .TP 7 macros that wrongly > > limited right margins an

Re: [PATCH] smoke: fix valgrind invalid read errors

2014-11-11 Thread Pekka Paalanen
On Tue, 28 Oct 2014 10:50:18 + Frank Binns wrote: > There are a number of invalid read errors reported by valgrind of the > form: > ==13428== Invalid read of size 4 > ==13428==at 0x405656: advect (smoke.c:116) > ==13428==by 0x405E80: redraw_handler (smoke.c:228)

Re: [PATCH] Don't document an absent parameter.

2014-11-11 Thread Pekka Paalanen
On Thu, 30 Oct 2014 00:52:39 -0700 Bryce Harrington wrote: > Quells a doxygen warning: > > src/wayland-server.c:790: warning: argument 'None' of command @param is > not found in the argument list of wl_display::wl_display_create(void) > > Signed-off-by: Bryce Harrington > --- > src/waylan

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-11-11 Thread Pekka Paalanen
On Sun, 12 Oct 2014 18:57:31 -0700 "Jasper St. Pierre" wrote: > Committing to an xdg_surface with a NULL buffer is currently illegal in > the mutter implementation, so this simply causes the client to error and > exit. The patch is good, but I'd like to reiterate on what this actually fixes. AF

Re: [PATCH weston] input: fix access to invalid resource

2014-11-11 Thread Pekka Paalanen
On Wed, 15 Oct 2014 10:19:33 +0200 Marek Chalupa wrote: > Look OK, > > it can not hurt to add this check in any case. Yeah, I take that as Acked-by. > On 10 October 2014 22:46, Giulio Camuffo wrote: > > > the keyboard focus surface may not have a valid resource (server side > > surface or a

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Pekka Paalanen
On Tue, 11 Nov 2014 10:00:15 +0200 Giulio Camuffo wrote: > 2014-11-11 9:21 GMT+02:00 Pekka Paalanen : > > On Mon, 10 Nov 2014 22:08:40 +0200 > > Giulio Camuffo wrote: > > > >> weston key bindings are supposed to eat the key events, and not pass it > >> on to clients, and indeed the wl_keyboard.k

[PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k

[PATCH weston v4] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

2014-11-11 Thread Giulio Camuffo
2014-11-11 9:21 GMT+02:00 Pekka Paalanen : > On Mon, 10 Nov 2014 22:08:40 +0200 > Giulio Camuffo wrote: > >> weston key bindings are supposed to eat the key events, and not pass it >> on to clients, and indeed the wl_keyboard.key event is not sent. But >> we must also not put the key in the keys a