Re: [PATCH weston] compositor: make keep_buffer a bool

On Mon, 13 Oct 2014 11:21:06 -0700 Bryce Harrington wrote: > On Fri, Oct 10, 2014 at 09:36:45AM -0500, Derek Foreman wrote: > > The comments already call it bool, so let's just make it one > > LGTM > > Reviewed-by: Bryce Harrington > > --- > > src/compositor-drm.c | 4 ++-- > > src/compositor

Re: [PATCH weston v3] input: don't send to clients key events eaten by bindings

On Mon, 10 Nov 2014 22:08:40 +0200 Giulio Camuffo wrote: > weston key bindings are supposed to eat the key events, and not pass it > on to clients, and indeed the wl_keyboard.key event is not sent. But > we must also not put the key in the keys array to pass to client with > the wl_keyboard.enter

Re: [PATCH weston] compositor: stop sending spurious events on mode switch

On Mon, 10 Nov 2014 10:29:59 -0600 Derek Foreman wrote: > commit 6ae7bc982fa accidentally made weston_output_mode_switch_temporary > send done events when it shouldn't. > > Signed-off-by: Derek Foreman > --- > src/compositor.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/co

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

sorry for the duplicate Hans, wayland-devel got dropped of the first reply. On Fri, Nov 07, 2014 at 02:25:06PM +0100, Hans de Goede wrote: > Add edge-scrolling support for non multi-touch touchpads as well as for > users who prefer edge-scrolling (as long as they don't have a clickpad). > > Note

[PATCH weston v3] input: don't send to clients key events eaten by bindings

weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k

Re: [PATCH libinput v2 04/11] evdev: Add evdev_any_button_down helper function

On 11/10/2014 02:59 AM, Hans de Goede wrote: + if (libevdev_has_event_code(device->evdev, EV_KEY, button) && + hw_is_key_down(device, button)) Should hw_is_key_down do this test instead? (ie it returns false if libevdev_has_event_code would return false). It

Re: [PATCH weston v0 05/11] tests: add screenshot recording to weston-test

On 10/11/14 12:31 PM, Bill Spitzak wrote: > It is possible to call libpng directly if you want to avoid the cairo > dependency. Yup, certainly is - and you probably know how disgusting the resulting code looks. ;) If adding the cairo dependency to weston-test is a bad move I'll use libpng directl

Re: [PATCH 8/8] doc: Added % to remove some self-references from doxygen output

On 11/09/2014 02:14 PM, Peter Hutterer wrote: looks like there's a typo here ("avilable"), might be worth a follow-up patch. I'll put in a new patch with this fixed, as well as the other typo somebody noticed. That aside: not a big fan of this patch, I'd prefer to see it highlighted. The l

Re: [PATCH weston v0 05/11] tests: add screenshot recording to weston-test

It is possible to call libpng directly if you want to avoid the cairo dependency. On 11/09/2014 01:41 PM, Bryce Harrington wrote: From: Derek Foreman Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG files.

[PATCH weston] compositor: stop sending spurious events on mode switch

commit 6ae7bc982fa accidentally made weston_output_mode_switch_temporary send done events when it shouldn't. Signed-off-by: Derek Foreman --- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 9dcabe3..6a81cc7 100644 --- a/src/compos

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

On Wed, 5 Nov 2014 20:51:53 +0200 Giulio Camuffo wrote: > 2014-11-05 16:23 GMT+02:00 Pekka Paalanen : > > On Tue, 7 Oct 2014 22:30:25 +0300 > > Giulio Camuffo wrote: > > > >> weston key bindings are supposed to eat the key events, and not pass it > >> on to clients, and indeed the wl_keyboard.k

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

On Fri, 07 Nov 2014 14:25:07 -0800 Bill Spitzak wrote: > The bug is "client with keyboard focus does not have correct values for > currently-pressed keys if if the compositor consumes a key event". That is not a bug. That is the intended, correct behaviour. - pq __

Re: [PATCH v3] Added more error checks when strtol function is used

On Wed, 5 Nov 2014 17:40:18 +0200 Imran Zaman wrote: > Signed-off-by: Imran Zaman > --- > src/scanner.c| 4 +++- > src/wayland-client.c | 5 - > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/scanner.c b/src/scanner.c > index 5e5152b..fa8e0c0 100644 > --- a/

Re: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

On Thu, 6 Nov 2014 05:36:32 + "Zhang, Xiong Y" wrote: > > > > On Fri, 17 Oct 2014 12:37:37 +0300 > > Imran Zaman wrote: > > > > > In a multi-seat configuration, clients may need to filter out the > > > outputs based on the (udev) seat it is hooked to or based on the name > > > of the outpu

Re: [PATCH wayland 2/4] tests: add timeout test

On Fri, 7 Nov 2014 22:08:43 +0200 Giulio Camuffo wrote: > Looks good, they fail as expected. > > Reviewed-by: Giulio Camuffo > > 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > > sanity test if timeouts work. > > > > Signed-off-by: Marek Chalupa > > --- > > tests/sanity-test.c | 25

Re: [PATCH wayland 1/4] tests: add timeout

On Fri, 7 Nov 2014 21:56:48 +0200 Giulio Camuffo wrote: > I have a couple of comments below, otherwise it looks good. > > > -- > Giulio > > > 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > > Add test_set_timeout() function that allows the test to > > set timeout for its completition. Any other

Re: [PATCH wayland] tests: use our own XDG_RUNTIME_DIR for tests

On Fri, 7 Nov 2014 21:37:28 +0200 Giulio Camuffo wrote: > Looks good to me, and it doesn't seem to break any test. ;) > > Reviewed-by: Giulio Camuffo Yup, pushed. Thanks, pq > 2014-09-24 15:07 GMT+03:00 Marek Chalupa : > > Use $XDG_RUNTIME_DIR/wayland-tests for tests. This way we won't be

Re: [PATCH weston] compositor: check version before calling wl_output_send_scale()

On Wed, 5 Nov 2014 13:26:57 -0600 Derek Foreman wrote: > Signed-off-by: Derek Foreman > --- > src/compositor.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index 1f6700d..9dcabe3 100644 > --- a/src/compositor.c > +++ b/

[PATCH libinput v2 05/11] evdev: Hookup scroll mode configuration

Keep the default behavior of middle button scrolling on trackpoints, this allows turning off middle button scrolling on trackpoints, as well as turning on button scrolling on trackballs. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=85535 Signed-off-by: Hans de Goede --- src/evdev.c | 16

[PATCH libinput v2 07/11] touchpad: Hookup scroll-mode configuration

Default to 2fg scrolling for now, once we have edge-scrolling we can default to edge-scrolling on touchpads which cannot detect more than 1 touch. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 60 ++--- src/evdev-mt-touchpad.h | 2 ++ 2 f

[PATCH libinput v2 09/11] test: Add trackpoint middle button scrolling disable test

Signed-off-by: Hans de Goede --- test/trackpoint.c | 40 1 file changed, 40 insertions(+) diff --git a/test/trackpoint.c b/test/trackpoint.c index eb9ddfb..2e2caba 100644 --- a/test/trackpoint.c +++ b/test/trackpoint.c @@ -60,6 +60,12 @@ test_trackpoint_s

[PATCH libinput v2 03/11] Add configuration option to select scroll mode

Add a configuration option to allow selecting between 2-finger / edge / none scrolling (for touchpads). Signed-off-by: Hans de Goede --- src/libinput-private.h | 13 src/libinput.c | 85 ++ src/libinput.h | 194 ++

[PATCH libinput v2 06/11] touchpad: s/config/config_natural/

To avoid confusion with scroll mode configuration. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 10 +- src/evdev-mt-touchpad.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 3d8f414..fc09e92 10

[PATCH libinput v2 08/11] test: s/test_2fg_scroll/test_trackpoint_scroll/

Fix copy and paste error, causing the function to test trackpoint scrolling to be named test_2fg_scroll. Signed-off-by: Hans de Goede --- test/trackpoint.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/trackpoint.c b/test/trackpoint.c index d4dfe41..eb9d

[PATCH libinput v2 11/11] test: Add button scroll test to pointer tests

Non trackpoint button scrolling is mainly intended for use with trackballs, but we can test it just as well with any relative pointer device. Signed-off-by: Hans de Goede --- test/pointer.c | 40 1 file changed, 40 insertions(+) diff --git a/test/pointer

[PATCH libinput v2 10/11] test: Add litest_button_scroll helper function

Turn test_trackpoint_scroll into a generic helper function for testing "button scrolling". Signed-off-by: Hans de Goede --- test/litest.c | 34 ++ test/litest.h | 4 test/trackpoint.c | 40 +++- 3 files changed, 45

[PATCH libinput v2 02/11] Add libinput_device_has_button function

In some cases the compositor will want to know which buttons a device has. E.g. for scrolling we want the compositor to be able to set a button to change a relative device (e.g. a trackball) into scroll mode, so that it sends scroll-axis events instead of pointer motion events. In order for the c

[PATCH libinput v2 04/11] evdev: Add evdev_any_button_down helper function

Signed-off-by: Hans de Goede --- src/evdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 9ce93fe..8ae2785 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -580,6 +580,19 @@ evdev_process_absolute(struct evdev_device *dev

[PATCH libinput v2 00/11] Scroll mode configuration

Hi All, Here is v2 of my scroll mode configuration patchset. Changes since v1: -"Add libinput_device_has_button function" -Rename libinput_device_has_key to libinput_device_has_button, make it only apply to LIBINPUT_DEVICE_CAP_POINTER -"Add configuration option to select scroll mode" -Minor c

[PATCH libinput v2 01/11] Fix libinput_device_config_send_events_get_default_mode docs

Fix libinput_device_config_send_events_get_default_mode docs referring to itself, instead make it refer to libinput_device_config_send_events_get_mode. Signed-off-by: Hans de Goede --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinpu

Re: [PATCH libinput 1/5] test: rename a parameter to litest_assert_scroll()

Hi, On 11/10/2014 03:33 AM, Peter Hutterer wrote: > This doesn't test for direction only, it tests for the minimum distance we > expect in the scroll event. Rename accordingly. > > Signed-off-by: Peter Hutterer Series looks good and is: Reviewed-by: Hans de Goede Regards, Hans > --- > tes

Re: [PATCH libinput 1/6] evdev: don't ignore REL_HWHEEL values over 1

Hi, On 11/07/2014 01:42 AM, Peter Hutterer wrote: > Matching patch for REL_WHEEL is 09a3770961aad0973, not sure why I didn't > do both at the same time. > > Signed-off-by: Peter Hutterer Series looks good and is: Reviewed-by: Hans de Goede Regards, Hans > --- > src/evdev.c | 19 +-

Re: [PATCH v3 libinput] util: introduce ratelimit helpers

Hi, On 11/06/2014 11:39 PM, Peter Hutterer wrote: > From: David Herrmann > > This adds "struct ratelimit" and "ratelimit_test()". It's a very simple > rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. > > This comes in handy to limit log-messages in possible busy loops etc..

Re: [PATCH libinput] Add pointer axis sources to the API

Hi, On 11/06/2014 06:02 AM, Peter Hutterer wrote: > For a caller to implement/provide kinetic scrolling (intertial scrolling, > fling scrolling), it needs to know how the scrolling motion was implemented, > and what to expect in the future. Add this information to the pointer axis > event. > > Th