Re: [PATCH 02/11] Add libinput_device_has_key function

On 8/11/2014 08:07 , Bill Spitzak wrote: Nevermind, it sounds like this is in *addition* to an api that lets you get the set of all keys on the device. So it is just a convenience for the (probably common) case where the caller is only testing for a particular key. if you're talking about libin

[PATCH 2/8] doc: Preserve spaces

Slight variation on Pekka's patch. It seems harmless to put this anywhere. --- doc/publican/doxygen-to-publican.xsl |4 1 file changed, 4 insertions(+) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/doxygen-to-publican.xsl index b6ca5f3..99193e1 100644 --- a/doc/public

[PATCH 3/8] doc: preserve links produced by Doxygen

These links are pretty useful for navigation, though sometimes excessive (you can turn them off by putting % before the word in the comment). I had to turn off validation because it failed on missing and duplicate target id's, which this produes. --- doc/publican/Makefile.am |1 +

[PATCH 6/8] doc: Added \code tags around sample code in doxygen comments

--- src/wayland-client.c | 25 ++--- src/wayland-server.h |4 ++-- src/wayland-util.h | 22 ++ 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index b0f77b9..b1dd46c 100644 --- a/src/wayl

[PATCH 8/8] doc: Added % to remove some self-references from doxygen output

--- src/wayland-client.c | 14 +++--- src/wayland-client.h | 14 +++--- src/wayland-server.h | 12 ++-- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 161f14e..2126430 100644 --- a/src/wayland-client.

[PATCH 4/8] doc: Don't print dash if doxygen brief description missing

--- doc/publican/doxygen-to-publican.xsl |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/doxygen-to-publican.xsl index 7f7abe9..461cf3e 100644 --- a/doc/publican/doxygen-to-publican.xsl +++ b/doc/publican/doxygen-t

[PATCH 5/8] doc: removed some unnecessary nested listing from doxygen output

This makes the lists of parameters slightly smaller and removes some bullets from see-also and since. --- doc/publican/doxygen-to-publican.xsl | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/doc/publican/doxygen-to-publican.xsl b/doc/publican/do

[PATCH 7/8] doc: fixed reference to non-existent function

This is a guess as to what the correct reference is, please check! --- src/wayland-client.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index b1dd46c..161f14e 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@ -150

[PATCH 1/8] doc: make rebuilds doxygen output on code changes

--- doc/publican/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index cf0f533..b30a471 100644 --- a/doc/publican/Makefile.am +++ b/doc/publican/Makefile.am @@ -82,7 +82,7 @@ en-US/ProtocolInterfaces.xml: $(top

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

You are right I was forgetting about the old discussion, and am getting confused as to where the bug is. IMHO the behavior when the client gets the focus currently is correct. However it is broken when the client already has the focus and the compositor gets a key. The patch you are proposing

Re: [PATCH 02/11] Add libinput_device_has_key function

Nevermind, it sounds like this is in *addition* to an api that lets you get the set of all keys on the device. So it is just a convenience for the (probably common) case where the caller is only testing for a particular key. ___ wayland-devel mailing

Re: [PATCH wayland 4/4] queue-test: put back timeout

Looks good. Reviewed-by: Giulio Camuffo 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > In 93e654061b9 we removed call to alarm() that served as timeout in this test. > Now when we have test_set_timeout() func, return the timeout back. > > Signed-off-by: Marek Chalupa > --- > tests/queue-test.c |

Re: [PATCH wayland 3/4] tests: use test_set_timeout in display-test

I'm a bit confused here... you remove the alarm() calls but not the signal handler or the sigaction setting. On the other hand, in the patch introducing test_set_timeout() you add a new SIGALRM handler... Am i missing something? -- Giulio 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > replace ca

Re: [PATCH wayland 2/4] tests: add timeout test

Looks good, they fail as expected. Reviewed-by: Giulio Camuffo 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > sanity test if timeouts work. > > Signed-off-by: Marek Chalupa > --- > tests/sanity-test.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/tests/sanit

Re: [PATCH wayland 1/4] tests: add timeout

I have a couple of comments below, otherwise it looks good. -- Giulio 2014-09-24 15:37 GMT+03:00 Marek Chalupa : > Add test_set_timeout() function that allows the test to > set timeout for its completition. Any other call to the function > re-sets the timeout to the new value. The timeouts can

Re: [PATCH wayland] tests: use our own XDG_RUNTIME_DIR for tests

Looks good to me, and it doesn't seem to break any test. ;) Reviewed-by: Giulio Camuffo 2014-09-24 15:07 GMT+03:00 Marek Chalupa : > Use $XDG_RUNTIME_DIR/wayland-tests for tests. This way we won't be > messing XDG_RUNTIME_DIR and it also fixes a bug, when socket-test > failed when another compo

[PATCH 2/2] touchpad: Add edge-scrolling support

Add edge-scrolling support for non multi-touch touchpads as well as for users who prefer edge-scrolling (as long as they don't have a clickpad). Note the percentage to use of the width / height as scroll-edge differs from one manufacturer to the next, the various per model percentages were taken f

[PATCH 1/2] touchpad: Add code to get the touchpad model / manufacturer

This is useful to know in some cases, it is e.g. necessary to figure out which percentage of a touchpads range to use as edge for edge-scrolling. Note this is a slightly cleaned up copy of the same code in xf86-input-synaptics. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 36 +

Re: [PATCH weston 1/1] compositor: Abort on bad page flip timestamps

On 07.11.2014 18:36, Pekka Paalanen wrote: If we still feel that exiting Weston on the first timestamp failure (zero or not increasing) is too harsh, we could simply log a warning and add again some heuristics on when things are too far wrong to continue. E.g. getting a single timestamp failure

Re: [PATCH weston 1/1] compositor: Abort on bad page flip timestamps

On Fri, 07 Nov 2014 07:04:16 +0100 Mario Kleiner wrote: > On 06/11/14 17:42, Pekka Paalanen wrote: > > On Thu, 06 Nov 2014 16:08:56 +0900 > > Michel Dänzer wrote: > > > >> On 06.11.2014 03:06, Frederic Plourde wrote: > >>> Many features, like animations, hardly depend on page flip timestamps > >

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

Il ven nov 7 01:57:37 2014 GMT+0200, Bill Spitzak scrive: > > It may, but that's not the point. The key was eaten by the compositor > > binding, it must not be sent to the client. > > The key is not being "sent". A map of what keys are pushed down right > now is what is sent. > > The user cert