Re: [PATCH weston 1/1] compositor: Abort on bad page flip timestamps

2014-11-05 Thread Michel Dänzer
On 06.11.2014 03:06, Frederic Plourde wrote: Many features, like animations, hardly depend on page flip timestamps to work properly, but some DRM drivers do not correctly support page flip timestamps (or not at all) and in that case, things start to go wrong. This patch adds sanity check to west

Re: [PATCH libinput v2 1/2] util: introduce ratelimit helpers

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 01:32:16PM +0100, David Herrmann wrote: > This adds "struct ratelimit" and "ratelimit_test()". It's a very simple > rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. > > This comes in handy to limit log-messages in possible busy loops etc.. > > Signed-o

RE: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-11-05 Thread Zhang, Xiong Y
> > On Fri, 17 Oct 2014 12:37:37 +0300 > Imran Zaman wrote: > > > In a multi-seat configuration, clients may need to filter out the > > outputs based on the (udev) seat it is hooked to or based on the name > > of the output. > > Since version of the output is increased, the change does not affec

Re: [PATCH libinput v3] touchpad: Fix log_bug_libinput calls on tap enable with fingers down

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 10:48:59AM +0100, Hans de Goede wrote: > Before this commit the tap code deals with enabled being set to false, > by waiting for tap.state to become IDLE, and then ignoring any events from > that point on. > > This causes a problem when enabled gets set to true again while

[PATCH libinput] Add pointer axis sources to the API

2014-11-05 Thread Peter Hutterer
For a caller to implement/provide kinetic scrolling (intertial scrolling, fling scrolling), it needs to know how the scrolling motion was implemented, and what to expect in the future. Add this information to the pointer axis event. The three scroll sources we have are: * wheels: scrolling is in d

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-05 Thread Bill Spitzak
It seems like it would be easy for the client to not repeat the key if it did not see the key-down event. I find it pretty amazing that you duplicated about the only bug that having clients do the repeat rather than the compositor solves. Any patch that removes the fact that the key is still b

Re: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-11-05 Thread Jasper St. Pierre
For future reference, wl_seat is actually more similar to the "MPX" extension for X11, which allows for multiple pointer/keyboard pairs on the same output seat. The only usecases I'm aware of for MPX are display walls and multiplayer game cabinets. On Wed, Nov 5, 2014 at 11:37 AM, Imran Zaman wro

Re: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-11-05 Thread Imran Zaman
Pekka, thanks a lot for the detailed explanation. Lets see which way we go. BR imran On Wed, Nov 5, 2014 at 6:32 PM, Pekka Paalanen wrote: > On Fri, 17 Oct 2014 12:37:37 +0300 > Imran Zaman wrote: > > > In a multi-seat configuration, clients may need to filter > > out the outputs based on the

[PATCH weston] compositor: check version before calling wl_output_send_scale()

2014-11-05 Thread Derek Foreman
Signed-off-by: Derek Foreman --- src/compositor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 1f6700d..9dcabe3 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -105,6 +105,7 @@ static void weston_mode_switch_finish(s

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-05 Thread Giulio Camuffo
2014-11-05 16:23 GMT+02:00 Pekka Paalanen : > On Tue, 7 Oct 2014 22:30:25 +0300 > Giulio Camuffo wrote: > >> weston key bindings are supposed to eat the key events, and not pass it >> on to clients, and indeed the wl_keyboard.key event is not sent. But >> we must also not put the key in the keys

[PATCH weston 1/1] compositor: Abort on bad page flip timestamps

2014-11-05 Thread Frederic Plourde
Many features, like animations, hardly depend on page flip timestamps to work properly, but some DRM drivers do not correctly support page flip timestamps (or not at all) and in that case, things start to go wrong. This patch adds sanity check to weston_output_finish_frame. By solely verifying tha

Re: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-11-05 Thread Pekka Paalanen
On Fri, 17 Oct 2014 12:37:37 +0300 Imran Zaman wrote: > In a multi-seat configuration, clients may need to filter > out the outputs based on the (udev) seat it is hooked to or > based on the name of the output. > Since version of the output is increased, the change does > not affect the current i

Re: [PATCH v1] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
pushed v3 to patchwork with the change mentioned and marked the older versions as superceeded http://patchwork.freedesktop.org/patch/36297/ BR imran On Wed, Nov 5, 2014 at 5:27 PM, Pekka Paalanen wrote: > On Tue, 4 Nov 2014 15:55:06 +0200 > Imran Zaman wrote: > > > Signed-off-by: Imran Zaman

[PATCH v3] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 4 +++- src/wayland-client.c | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..fa8e0c0 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -405,11 +405,13 @@ start_element(void

[PATCH v2] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 5 - src/wayland-client.c | 6 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..9ba34e8 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -405,9 +405,12 @@ start_element(voi

Re: [PATCH v1] Added more error checks when strtol function is used

2014-11-05 Thread Pekka Paalanen
On Tue, 4 Nov 2014 15:55:06 +0200 Imran Zaman wrote: > Signed-off-by: Imran Zaman > --- > src/scanner.c| 2 +- > src/wayland-client.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/scanner.c b/src/scanner.c > index 5e5152b..2ed9775 100644 > --- a/src/

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-11-05 Thread Imran Zaman
I have already taken off that patch from the patchwork list... and pushed a simpler version... http://lists.freedesktop.org/archives/wayland-devel/2014-November/018030.html BR imran On Wed, Nov 5, 2014 at 5:08 PM, Pekka Paalanen wrote: > On Wed, 15 Oct 2014 22:04:46 +0300 > Imran Zaman wrote:

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-11-05 Thread Pekka Paalanen
On Wed, 15 Oct 2014 22:04:46 +0300 Imran Zaman wrote: > The reason is that strtol is used at many places in weston/wayland.. > and its not covering all the error cases everywhere (i.e. its buggy).. > so its better to > encapsulate it in a function with all the input and output checks... > it can

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-05 Thread Pekka Paalanen
On Wed, 5 Nov 2014 16:23:29 +0200 Pekka Paalanen wrote: > On Tue, 7 Oct 2014 22:30:25 +0300 > Giulio Camuffo wrote: > > > weston key bindings are supposed to eat the key events, and not pass it > > on to clients, and indeed the wl_keyboard.key event is not sent. But > > we must also not put th

Re: [PATCH weston v2] input: allow to destroy bindings in their handler

2014-11-05 Thread Pekka Paalanen
On Fri, 3 Oct 2014 23:36:34 +0300 Giulio Camuffo wrote: > use wl_list_for_each_safe to iterate on the bindings list when > firing them, this way a binding can safely be destroyed in its > function handler. > --- > src/bindings.c | 24 > 1 file changed, 12 insertions(+),

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-05 Thread Pekka Paalanen
On Tue, 7 Oct 2014 22:30:25 +0300 Giulio Camuffo wrote: > weston key bindings are supposed to eat the key events, and not pass it > on to clients, and indeed the wl_keyboard.key event is not sent. But > we must also not put the key in the keys array to pass to client with > the wl_keyboard.enter

Re: [PATCH v2] connection: Fix sendmsg() on FreeBSD

2014-11-05 Thread Pekka Paalanen
On Mon, 03 Nov 2014 09:49:03 + Philip Withnall wrote: > It expects ((msg_controllen == 0) == (msg_control == NULL)), and returns > EINVAL otherwise. It can't hurt to be tidy about things on other platforms > either though. > > See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=99356#c5 >

Re: [PATCH 3/4] wayland-server: Abort if a read from a client gives 0 length

2014-11-05 Thread Pekka Paalanen
On Sat, 01 Nov 2014 17:06:29 + Philip Withnall wrote: > This happens on EOF if using a poll function such as select() or > kqueue() which doesn’t distinguish EOF events. > > Currently execution should never reach the point where recvmsg() returns > EOF (len == 0). Instead, epoll() will detec

Re: [PATCH 2/4] event-loop.c: Use correct OS abstraction function for dupfd()

2014-11-05 Thread Pekka Paalanen
On Sat, 01 Nov 2014 17:06:38 + Philip Withnall wrote: > Signed-off-by: Philip Withnall > Signed-off-by: Karsten Otto > --- > src/event-loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/event-loop.c b/src/event-loop.c > index a149db9..1f571ba 100644 > ---

[PATCH libinput v2 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-05 Thread David Herrmann
Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we will still receive SYN_DROPPED log-messages after multiple days of runtime, even though there might have been a SYN_DROPPED flood at one point in time. Signed-off-by: David Herrmann --- src/evdev.c | 18 --

Re: [PATCH 4/4] queue-test: Add another assertion

2014-11-05 Thread Pekka Paalanen
On Sat, 01 Nov 2014 17:06:46 + Philip Withnall wrote: > Ensure that the round trip succeeds. > > Signed-off-by: Philip Withnall > Signed-off-by: Karsten Otto > --- > tests/queue-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/queue-test.c b/tests/que

[PATCH libinput v2 1/2] util: introduce ratelimit helpers

2014-11-05 Thread David Herrmann
This adds "struct ratelimit" and "ratelimit_test()". It's a very simple rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. This comes in handy to limit log-messages in possible busy loops etc.. Signed-off-by: David Herrmann --- src/libinput-util.c | 48 +++

Re: [PATCH libinput 1/4] evdev: factor out resolution changing code

2014-11-05 Thread Hans de Goede
Hi, Series looks good and is: Reviewed-by: Hans de Goede Regards, Hans On 11/05/2014 05:44 AM, Peter Hutterer wrote: > No functional changes. > > Signed-off-by: Peter Hutterer > --- > src/evdev.c | 57 - > 1 file changed, 32 insertio

Re: [PATCH libinput] Change sendevents configuration to use bitmasks

2014-11-05 Thread Hans de Goede
Hi, On 11/03/2014 06:53 AM, Peter Hutterer wrote: > In the future, we should allow multiple sendevent modes set simultanously. > Change the API to use a bitmask instead of a single return value. > > Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans > --- >

Re: [PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-05 Thread Peter Hutterer
On Wed, Nov 05, 2014 at 12:30:32PM +0100, David Herrmann wrote: > On Wed, Nov 5, 2014 at 6:11 AM, Peter Hutterer > wrote: > > On Tue, Nov 04, 2014 at 09:35:37AM +0100, David Herrmann wrote: > >> This adds "struct ratelimit" and "ratelimit_test()". It's a very simple > >> rate-limit helper modeled

Re: [PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-05 Thread David Herrmann
Hi On Wed, Nov 5, 2014 at 6:11 AM, Peter Hutterer wrote: > On Tue, Nov 04, 2014 at 09:35:37AM +0100, David Herrmann wrote: >> This adds "struct ratelimit" and "ratelimit_test()". It's a very simple >> rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. >> >> This comes in handy

Re: [PATCH weston v2] compositor: Refactor weston_output_mode_switch()

2014-11-05 Thread Pekka Paalanen
On Tue, 4 Nov 2014 10:47:33 -0600 Derek Foreman wrote: > This breaks weston_output_mode_switch() into 3 functions: > weston_output_mode_set_native() > weston_output_mode_switch_to_temporary() > weston_output_mode_switch_to_native() > > Differences from previous behaviour: > SET_NATIVE didn't se

Re: [PATCH weston] compositor: Fix weston_subsurface_is_synchronized() return value.

2014-11-05 Thread Pekka Paalanen
On Tue, 04 Nov 2014 10:36:16 -0600 Derek Foreman wrote: > On 04/11/14 07:38 AM, Carlos Olmedo Escobar wrote: > > Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the > > return value of weston_subsurface_is_synchronized(). > > Ouch! Nice catch. :( > > Reviewed-by: Derek Forem

Re: Wayland and Weston in Patchwork

2014-11-05 Thread Pekka Paalanen
On Tue, 4 Nov 2014 12:22:16 -0800 Bryce Harrington wrote: > On Tue, Nov 04, 2014 at 01:14:20PM +0200, Pekka Paalanen wrote: > > Hi all, > > > > some of you already know that we now have > > http://patchwork.freedesktop.org/project/wayland/list/ > > to keep track of the patches sent to wayland-de

[PATCH libinput v3] touchpad: Fix log_bug_libinput calls on tap enable with fingers down

2014-11-05 Thread Hans de Goede
Before this commit the tap code deals with enabled being set to false, by waiting for tap.state to become IDLE, and then ignoring any events from that point on. This causes a problem when enabled gets set to true again while fingers are down, because when in IDLE no release events are expected, so