Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 03:17:36PM -0800, Bill Spitzak wrote: > I got the impression the ratelimit object was intended to be a single static > instance, not per-device. The idea is that if there is a burst of these at > once they are all from the same device, or due to some interaction between > th

Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:35:38AM +0100, David Herrmann wrote: > Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we > will still receive SYN_DROPPED log-messages after multiple days of > runtime, even though there might have been a SYN_DROPPED flood at one > point in time.

Re: [PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:35:37AM +0100, David Herrmann wrote: > This adds "struct ratelimit" and "ratelimit_test()". It's a very simple > rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. > > This comes in handy to limit log-messages in possible busy loops etc.. > > Signed-o

[PATCH libinput 4/4] test: add the MS surface touch cover device and fake-mt tests

2014-11-04 Thread Peter Hutterer
In the device description, define the interfaces for touch down/move even though we technically don't have those interfaces. Makes it easier to test. The fake-mt tests make sure the device shows up correctly and that no touch events are being sent for touch events. This device is a pointer device

[PATCH libinput 2/4] evdev: move a comment to where it belongs

2014-11-04 Thread Peter Hutterer
And s/weston/libinput/ while we're at it Signed-off-by: Peter Hutterer --- src/evdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index ecf105d..bda6af4 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1096,9 +1096,6 @@ evdev_configure_devic

[PATCH libinput 1/4] evdev: factor out resolution changing code

2014-11-04 Thread Peter Hutterer
No functional changes. Signed-off-by: Peter Hutterer --- src/evdev.c | 57 - 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 3aa87a7..ecf105d 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -103

[PATCH libinput 3/4] evdev: handle fake MT devices

2014-11-04 Thread Peter Hutterer
The kernel requires absolute axes to fit into the semantic ABS_ naming scheme but doesn't provide enough free bits unlabelled axes. Devices with many axes run into the ABS_MT range and look like MT devices when they're not. See http://www.freedesktop.org/software/libevdev/doc/1.3/group__mt.html Af

Re: [PATCH weston] cosmetic: replace boolean function return values with bool

2014-11-04 Thread Bill Spitzak
On 11/04/2014 02:48 AM, Pekka Paalanen wrote: I kind of wonder what including stdbool.h does to C++ sources using compositor.h, but if that breaks, we'll hear about it. Looks like there are attempts to make this work in gcc at least. The result is that the C++ bool, true, and false are used.

Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Bill Spitzak
I got the impression the ratelimit object was intended to be a single static instance, not per-device. The idea is that if there is a burst of these at once they are all from the same device, or due to some interaction between them, so you want to limit it all. Also it prevents an implementatio

Re: [PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:00:06AM -0600, Derek Foreman wrote: > On 03/11/14 09:51 PM, Peter Hutterer wrote: > > On Mon, Nov 03, 2014 at 11:56:59AM +0100, David Herrmann wrote: > >> Hi > >> > >> On Fri, Oct 31, 2014 at 5:33 AM, Peter Hutterer > >> wrote: > >>> On Thu, Oct 30, 2014 at 04:34:12PM -0

Re: Wayland and Weston in Patchwork

2014-11-04 Thread Bryce Harrington
On Tue, Nov 04, 2014 at 01:14:20PM +0200, Pekka Paalanen wrote: > Hi all, > > some of you already know that we now have > http://patchwork.freedesktop.org/project/wayland/list/ > to keep track of the patches sent to wayland-devel mailing list. > > Thanks to Daniel for setting that up. :-) Ditto

[PATCH weston v2] compositor: Refactor weston_output_mode_switch()

2014-11-04 Thread Derek Foreman
This breaks weston_output_mode_switch() into 3 functions: weston_output_mode_set_native() weston_output_mode_switch_to_temporary() weston_output_mode_switch_to_native() Differences from previous behaviour: SET_NATIVE didn't set current_scale (now it does) SET_TEMPORARY could set mode and scale ind

Re: [PATCH weston] compositor: Fix weston_subsurface_is_synchronized() return value.

2014-11-04 Thread Derek Foreman
On 04/11/14 07:38 AM, Carlos Olmedo Escobar wrote: > Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the > return value of weston_subsurface_is_synchronized(). Ouch! Nice catch. :( Reviewed-by: Derek Foreman > Signed-off-by: Carlos Olmedo Escobar > --- > src/compositor.c |

Re: [PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-11-04 Thread Derek Foreman
On 03/11/14 09:51 PM, Peter Hutterer wrote: > On Mon, Nov 03, 2014 at 11:56:59AM +0100, David Herrmann wrote: >> Hi >> >> On Fri, Oct 31, 2014 at 5:33 AM, Peter Hutterer >> wrote: >>> On Thu, Oct 30, 2014 at 04:34:12PM -0500, Derek Foreman wrote: The acceleration filter currently isn't partic

[PATCH v1] Added more error checks when strtol function is used

2014-11-04 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 2 +- src/wayland-client.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..2ed9775 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -407,7 +407,7 @@ start_element(void *data

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-11-04 Thread Imran Zaman
I will push new patch with minor fix to the strtol function in wayland and move this old patch (after segfault fix) to weston so that it does not end up in libwayland APIs. Consequently I changed its property in patchwork BR imran On Wed, Oct 29, 2014 at 10:27 AM, Imran Zaman wrote: > > > On We

Re: Wayland and Weston in Patchwork

2014-11-04 Thread Imran Zaman
Thats really good initiative Pekka/Daniel. Thanks. BR imran On Tue, Nov 4, 2014 at 1:14 PM, Pekka Paalanen wrote: > Hi all, > > some of you already know that we now have > http://patchwork.freedesktop.org/project/wayland/list/ > to keep track of the patches sent to wayland-devel mailing list. >

[PATCH weston] compositor: Fix weston_subsurface_is_synchronized() return value.

2014-11-04 Thread Carlos Olmedo Escobar
Commit 280e7dd918f1717c7d677676384a9cd991097741 introduced a bug in the return value of weston_subsurface_is_synchronized(). Signed-off-by: Carlos Olmedo Escobar --- src/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index ac5

Re: [PATCH weston v6 2/2] window : compare version and call appropriate destructor

2014-11-04 Thread Pekka Paalanen
On Mon, 20 Oct 2014 11:55:29 +0530 kabeer.k...@samsung.com wrote: > From: kabeer khan > > Signed-off-by: kabeer khan > --- > clients/window.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index 139c7f9..c8ed9a2

Re: [PATCH v5 1/3] Protocol : Added destructor to wl_data_device interface

2014-11-04 Thread Pekka Paalanen
On Mon, 13 Oct 2014 10:34:26 +0530 kabeer khan wrote: > Fix for Bug# 81745 > > Signed-off-by: kabeer khan > --- > protocol/wayland.xml | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 3645208..a129de2 10

Re: [PATCH weston v6 1/2] data_device : change version while initializing data_device_manager interface and data_device interface

2014-11-04 Thread Pekka Paalanen
On Mon, 20 Oct 2014 11:47:15 +0530 kabeer.k...@samsung.com wrote: > From: kabeer khan > > Signed-off-by: kabeer khan > --- > src/data-device.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/src/data-device.c b/src/data-device.c > index 75fc60c..a78ba

Re: [PATCH weston v4] Implement data_device interface destructor

2014-11-04 Thread Pekka Paalanen
On Fri, 10 Oct 2014 20:57:30 +0300 Giulio Camuffo wrote: > A could of comments below, the rest looks good to me. > > > 2014-09-23 8:21 GMT+03:00 kabeer khan : > > window : compare version and call appropriate destructor > > data-device : change version of creation of data_device_manager and >

Wayland and Weston in Patchwork

2014-11-04 Thread Pekka Paalanen
Hi all, some of you already know that we now have http://patchwork.freedesktop.org/project/wayland/list/ to keep track of the patches sent to wayland-devel mailing list. Thanks to Daniel for setting that up. :-) We initialized the patch list with my review backlog. If you are waiting for review

Re: [PATCH wayland] cosmetic: convert some function returns from int to bool

2014-11-04 Thread Pekka Paalanen
On Fri, 3 Oct 2014 14:39:59 -0500 Derek Foreman wrote: > --- > src/scanner.c | 5 +++-- > src/wayland-shm.c | 9 + > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/src/scanner.c b/src/scanner.c > index 809130b..dc113f5 100644 > --- a/src/scanner.c > +++ b/src/sca

Re: [PATCH weston] cosmetic: replace boolean function return values with bool

2014-11-04 Thread Pekka Paalanen
On Mon, 13 Oct 2014 11:41:32 -0700 Bryce Harrington wrote: > On Fri, Oct 03, 2014 at 01:13:42PM -0500, Derek Foreman wrote: > > For functions that test if something is true/valid and return a 1 > > or 0, it makes sense to switch to bool. > > I like it. Probably many other places this shows up.

Re: [PATCH] connection: Leave fd open in wl_connection_destroy

2014-11-04 Thread Pekka Paalanen
On Mon, 27 Oct 2014 09:55:46 +0100 Marek Chalupa wrote: > Hi, > > at first glance I didn't like returning fd from wl_connection_destroy, but > at the other, I did! > If you think about the connection as a buffer for the fd (and that is > really the case), > then it make sense to do something lik

Re: [PATCH libinput v2] evdev: Log evdev event queue overflows

2014-11-04 Thread David Herrmann
Hi On Tue, Nov 4, 2014 at 12:17 AM, Peter Hutterer wrote: > On Mon, Nov 03, 2014 at 11:49:12AM +0100, David Herrmann wrote: >> Hi >> >> On Wed, Oct 29, 2014 at 3:56 PM, Derek Foreman >> wrote: >> > Log a message when the kernel event queue overflows and events are dropped. >> > After 10 message

Re: [PATCH libinput 0/4] some acceleration fixes, mostly for high DPI mice

2014-11-04 Thread David Herrmann
Hi On Tue, Nov 4, 2014 at 4:51 AM, Peter Hutterer wrote: > On Mon, Nov 03, 2014 at 11:56:59AM +0100, David Herrmann wrote: >> I haven't spent much time thinking it through, but so far I'd prefer a >> solid, but basic, heuristic to guess the DPI and then use hwdb for >> anything that doesn't fit.

[PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread David Herrmann
Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we will still receive SYN_DROPPED log-messages after multiple days of runtime, even though there might have been a SYN_DROPPED flood at one point in time. Signed-off-by: David Herrmann --- src/evdev.c | 14 +++--- sr

[PATCH libinput 1/2] util: introduce ratelimit helpers

2014-11-04 Thread David Herrmann
This adds "struct ratelimit" and "ratelimit_test()". It's a very simple rate-limit helper modeled after Linux' lib/ratelimit.c by Dave Young. This comes in handy to limit log-messages in possible busy loops etc.. Signed-off-by: David Herrmann --- src/libinput-util.c | 48 +++