Re: [PATCH Weston 1/1] desktop-shell: implement autolaunch

On Thu, 23 Oct 2014 15:07:01 -0400 Frederic Plourde wrote: > +1 for refactoring in a separate patch. > by merging the change with panel_add_launcher in the same patch, it gets > *really* hard to read because of the intertwining. Yeah, please split it. Btw. it was Fred who actually sent the pat

[WESTON PATCH 1/1] Weston: Fix some weston.ini.man typesetting macros

This patch fixes a couple of misuses around .TP 7 macros that wrongly limited right margins and relative identation. --- man/weston.ini.man | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index c05a221..54a1925 100644 --- a/man/weston.i

[PATCH 2/2] compositor: List only available backends in help text

Signed-off-by: Bryce Harrington --- src/compositor.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 0175747..01614f9 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4189,9 +4189,25 @@ usage(int error_c

[PATCH 1/2] compositor: Display option help text only for enabled backends

Signed-off-by: Bryce Harrington --- src/compositor.c | 8 1 file changed, 8 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index a42bc86..0175747 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4200,6 +4200,7 @@ usage(int error_code) " --no-conf

[PATCH 2/3] compositor: Fix tabbing of help output

Signed-off-by: Bryce Harrington --- src/compositor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 81334da..6df0811 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4226,7 +4226,7 @@ usage(int error_code)

[PATCH 3/3] compositor: Fix typos in help text

Signed-off-by: Bryce Harrington --- src/compositor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 6df0811..a42bc86 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4196,7 +4196,7 @@ usage(int error_code)

[PATCH 1/3] compositor: (Whitespace-only) Indent with tabs

Signed-off-by: Bryce Harrington --- src/compositor.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index a219766..81334da 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4246,18 +4246,18 @@ usage(int err

Re: [PATCH weston] backends: don't run off the end of strings

Fair enough. The patch is useless. :) Thanks On 23/10/14 01:43 PM, Bill Spitzak wrote: > That won't run off the end of a zero or one-length string. > > If strlen() works then there is a nul byte there. The first test against > 'W' will fail because 0 != 'W', and the second test will not be run.

Re: [PATCH Weston 1/1] desktop-shell: implement autolaunch

+1 for refactoring in a separate patch. by merging the change with panel_add_launcher in the same patch, it gets *really* hard to read because of the intertwining. now, for exit() instead of using EXIT_FAILURE/SUCCESS, currently there is roughly 50 usages o

Re: [PATCH weston] backends: don't run off the end of strings

That won't run off the end of a zero or one-length string. If strlen() works then there is a nul byte there. The first test against 'W' will fail because 0 != 'W', and the second test will not be run. On 10/23/2014 10:21 AM, Derek Foreman wrote: Strings from the config parser can be of length

[PATCH weston] backends: refactor transform string parsing

Most of the backends do their own parsing of transform strings, so let's put that all in the same place (compositor.c/h) --- src/compositor-drm.c | 30 -- src/compositor-rpi.c | 43 --- src/compositor-wayland.c | 25 --

[PATCH weston] backends: don't run off the end of strings

Strings from the config parser can be of length 0, so we should check that before checking the string's bytes. The x11 backend's usage is technically safe since the null terminator is present, but I've changed it too in case someone's looking at it as a reference for new code. --- src/compositor-