[PATCH V2] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-13 Thread Srivardhan Hebbar
Signed-off-by: Srivardhan Hebbar --- src/wayland-server.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 674aeca..4a577f0 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -862,6 +862,18 @@ wl_

RE: [PATCH] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-13 Thread Srivardhan
Thanks for the comments... :) I will incorporate the comments and send the V2 of the patch soon. Thank-you, Hebbar > -Original Message- > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] > On Behalf Of Bryce Harrington > Sent: Monday, October 13, 2014 11:45 PM > T

Re: [PATCH 6/6] image demo client: Add support for color management

2014-10-13 Thread Richard Hughes
On 13 October 2014 18:40, Niels Ole Salscheider wrote: > - Attach a false-color ICC profile to the surface > +const unsigned char icc_profile[798] = Hey, looks really good. Are you using a channel-swapped test profile? If so, there are example profiles in /usr/share/color/icc/colord/SwappedRedAnd

Re: [PATCH weston] cosmetic: replace boolean function return values with bool

2014-10-13 Thread Bryce Harrington
On Fri, Oct 03, 2014 at 01:13:42PM -0500, Derek Foreman wrote: > For functions that test if something is true/valid and return a 1 > or 0, it makes sense to switch to bool. I like it. Probably many other places this shows up. Only question I have is if bool can be used for WL_EXPORT functions? b

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-13 Thread Bryce Harrington
On Sun, Oct 12, 2014 at 06:57:31PM -0700, Jasper St. Pierre wrote: > Committing to an xdg_surface with a NULL buffer is currently illegal in > the mutter implementation, so this simply causes the client to error and > exit. > > It seems the reason the client did this was so it could add its own >

Re: [PATCH weston] compositor: make keep_buffer a bool

2014-10-13 Thread Bryce Harrington
On Fri, Oct 10, 2014 at 09:36:45AM -0500, Derek Foreman wrote: > The comments already call it bool, so let's just make it one LGTM Reviewed-by: Bryce Harrington > --- > src/compositor-drm.c | 4 ++-- > src/compositor.h | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --

Re: [PATCH] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-13 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 05:24:15PM +0530, Srivardhan Hebbar wrote: > Signed-off-by: Srivardhan Hebbar > --- > src/wayland-server.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index 674aeca..0f61e6e 100644 > --- a/sr

[PATCH 2/6] Attach input profiles and build corresponding LUTs

2014-10-13 Thread Niels Ole Salscheider
This implements the functionality to attach a profile to a surface in weston. An LUT is built from the profile that can be used to transform colors from the input color space to the blending color space. An sRGB color space is assumed for all newly created outputs This patch uses the sRGB color s

[PATCH 3/6] Attach output profiles and build corresponding LUTs

2014-10-13 Thread Niels Ole Salscheider
This patch allows to attach an ICC profile to each output. Signed-off-by: Niels Ole Salscheider --- src/cms-colord.c | 4 +++- src/cms-helper.c | 16 +++- src/cms-helper.h | 3 ++- src/cms-static.c | 1 + src/compositor.c | 18 ++ src/compositor.h | 2 ++ 6 files

[PATCH 1/6] Add cms protocol

2014-10-13 Thread Niels Ole Salscheider
The cms protocol allows to attach an ICC profile to a surface. It also tells the client about the blending color space and the color spaces of all outputs. Signed-off-by: Niels Ole Salscheider --- Makefile.am | 15 +-- protocol/cms.xml | 132

[PATCH 5/6] gl-renderer: Correct colors during rendering

2014-10-13 Thread Niels Ole Salscheider
This patch ignores the borders for now. Signed-off-by: Niels Ole Salscheider --- src/gl-renderer.c | 234 -- 1 file changed, 226 insertions(+), 8 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 470f98a..4bc8b9b 100644 ---

[PATCH 6/6] image demo client: Add support for color management

2014-10-13 Thread Niels Ole Salscheider
You can now use "C" to switch between the following modes: - Assume sRGB input color space - Assume that the input color space is the blending color space - Attach a false-color ICC profile to the surface Signed-off-by: Niels Ole Salscheider --- clients/image.c | 273

[RFC PATCH v2 0/6] Initial per-surface color management

2014-10-13 Thread Niels Ole Salscheider
It has been a few months since I sent the first version of the patches adding per-surface color management (http://lists.freedesktop.org/archives/wayland-devel/2014-March/013951.html). I finally got around to addressing some of the issues of the first proposal. Color profiles are now represented b

[PATCH 4/6] gl-renderer: Add necessary shaders for color correction

2014-10-13 Thread Niels Ole Salscheider
This patch ignores the YUV variants for now. Signed-off-by: Niels Ole Salscheider --- src/gl-renderer.c | 102 ++ 1 file changed, 102 insertions(+) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index f7f29b3..470f98a 100644 --- a/src/gl-r

[PATCH] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-13 Thread Srivardhan Hebbar
Signed-off-by: Srivardhan Hebbar --- src/wayland-server.c | 20 1 file changed, 20 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 674aeca..0f61e6e 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -862,6 +862,15 @@ wl_socket_alloc(