Re: [PATCH wayland] client: add wl_proxy_get_version function

2014-10-05 Thread Rémi Denis-Courmont
Hello, Le 2014-10-06 03:29, Jason Ekstrand a écrit : Remi, While this would probably be nice, your approach isnt going to work.  Yeah, I figured that much after I submitted the patch. And then I rediscovered that the client library does not actually know the version of the project objects

Re: [RFC libwayland] Track protocol object versions inside wl_proxy.

2014-10-05 Thread Jasper St. Pierre
One of my issues is what happens for objects that have multiple parents, like wl_buffer or wl_callback. What do we do if another person wants to introduce another (like the recently proposed pointer lock extension)? We can recommend that users never use wl_callback directly and instead use their ow

Re: [PATCH 4/4] wayland-server: Abort if a read from a client gives 0 length

2014-10-05 Thread Jason Ekstrand
On Sun, Oct 5, 2014 at 2:23 PM, Karsten Otto wrote: > Am 29.09.2014 um 06:31 schrieb Jason Ekstrand : > > > > > On Sep 28, 2014 11:49 AM, "Karsten Otto" wrote: > > > > > > From: Philip Withnall > > > > > > This happens if the socket has been gracefully closed. > > > > > > [KAO: It prevents a po

Re: [RFC libwayland] Track protocol object versions inside wl_proxy.

2014-10-05 Thread Jason Ekstrand
Ping On Fri, Apr 11, 2014 at 1:36 AM, Jason Ekstrand wrote: > On Fri, Apr 11, 2014 at 2:03 AM, Pekka Paalanen > wrote: > >> On Thu, 10 Apr 2014 09:42:55 -0500 >> Jason Ekstrand wrote: >> >> > On Thu, Apr 10, 2014 at 6:37 AM, Pekka Paalanen >> wrote: >> > >> > > Hi Jason, >> > > >> > > thanks

Re: [PATCH wayland] client: add wl_proxy_get_version function

2014-10-05 Thread Jason Ekstrand
Remi, While this would probably be nice, your approach isn't going to work. The version provided in wl_interface is the version that was compiled into libwayland, not the version requested when the global was bound. In order to get this correct, it requires a bit more tracking. I did implement t

Re: [PATCH 4/4] wayland-server: Abort if a read from a client gives 0 length

2014-10-05 Thread Karsten Otto
Am 29.09.2014 um 06:31 schrieb Jason Ekstrand : > > On Sep 28, 2014 11:49 AM, "Karsten Otto" wrote: > > > > From: Philip Withnall > > > > This happens if the socket has been gracefully closed. > > > > [KAO: It prevents a potential infinite loop when using a different > > event handling mechanis

Re: [PATCH wayland] client: add wl_proxy_get_version function

2014-10-05 Thread Rémi Denis-Courmont
Nevermind, that gets the version number of the client protocol library, not the version actually instantiated for the object :-( -- Rémi Denis-Courmont http://www.remlab.net/ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://li

[PATCH] client: add wl_proxy_get_version function

2014-10-05 Thread Rémi Denis-Courmont
In some scenarii, a component will obtain a reference to a proxy object created by another component. It may then be necessary to check the interface version of the proxy object at run-time to determine if a certain interface request is supported by the proxy object. For instance, a media player G

[PATCH wayland] client: add wl_proxy_get_version function

2014-10-05 Thread Rémi Denis-Courmont
In some scenarii, a component will obtain a reference to a proxy object created by another component. It may then be necessary to check the interface version of the proxy object at run-time to determine if a certain interface request is supported by the proxy object. For instance, a media player G