Re: [PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Pekka Paalanen
On Fri, 12 Sep 2014 03:08:40 +0900 Ryo Munakata wrote: > On Thu, 11 Sep 2014 15:53:15 +0200 > Ondřej Majerech wrote: > > > When backend_init returns NULL, we goto out_signals, which wants to > > free(modules), but in this particular code path, modules hasn't been > > initialised leading to a "D

Re: [PATCH 2/2] build: use symbol versioning

2014-09-11 Thread Peter Hutterer
On Thu, Sep 11, 2014 at 11:45:24PM +0200, Jan Engelhardt wrote: > On Thursday 2014-09-11 23:28, Peter Hutterer wrote: > >> > >> This sounds like a good idea. I have not pushed it yet though because > >> I'd want to avoid adding the symbols that will be deprecated in the > >> coming release (libinp

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Pekka Paalanen
On Thu, 11 Sep 2014 09:30:30 -0500 Derek Foreman wrote: > On 11/09/14 08:22 AM, Pekka Paalanen wrote: > > On Thu, 11 Sep 2014 08:10:25 -0500 > > Derek Foreman wrote: > > > >> On 11/09/14 04:00 AM, Pekka Paalanen wrote: > >>> On Wed, 10 Sep 2014 15:37:33 -0500 > >>> Derek Foreman wrote: > >>> >

[PATCH weston] libinput-device: Don't get initial key states

2014-09-11 Thread Jonas Ådahl
Initial key state is no pressed keys, and the libinput_device_get_keys function was deprecated in libinput 0.6.0. Signed-off-by: Jonas Ådahl --- Requires libinput 0.6.0, and assumes the previous posted patch that updates the configure.ac requirement to 0.6.0 has been applied. src/libinput-devi

Re: [PATCH 2/2] build: use symbol versioning

2014-09-11 Thread Peter Hutterer
On Thu, Sep 11, 2014 at 10:55:43PM +0200, Jonas Ådahl wrote: > On Wed, Sep 10, 2014 at 01:32:25AM +0200, Jan Engelhardt wrote: > > Symbol versions provide a means by which ELF utilities can determine > > whether a program is incompatible with a too-old library version so > > that package management

[ANNOUNCE] libinput 0.6.0

2014-09-11 Thread Jonas Ådahl
A new release of libinput, 0.6, is available. This release has some API changes, namely: * libinput_device_get_keys is deprecated. Initial device state can now always be assumed to be that no keys are pressed. * libinput_device_calibrate is both changed and deprecated. Calibration of touch d

Re: [PATCH 2/2] build: use symbol versioning

2014-09-11 Thread Jonas Ådahl
On Wed, Sep 10, 2014 at 01:32:25AM +0200, Jan Engelhardt wrote: > Symbol versions provide a means by which ELF utilities can determine > whether a program is incompatible with a too-old library version so > that package management tools can autodetect version-based > dependencies and suggest upgrad

Re: [PATCH 1/2] build: symbol ck_assert_ptr_ne requires check-0.9.10

2014-09-11 Thread Jonas Ådahl
On Wed, Sep 10, 2014 at 01:32:24AM +0200, Jan Engelhardt wrote: > openSUSE 12.3 ships with check-0.9.9 and subsequently fails to build > the tests. Change the call to look for check >= 0.9.10 where that > symbol is available. Thanks, pushed. Jonas > > Signed-off-by: Jan Engelhardt > --- > con

[PATCH 4/4] queue-test: Add another assertion

2014-09-11 Thread Karsten Otto
From: Philip Withnall Date: Fri, 15 Feb 2013 12:57:23 + Ensure that the round trip succeeds. [kao: adjusted patch to current test framework style] Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- tests/queue-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 3/4] wayland-server: Abort if a read from a client gives 0 length

2014-09-11 Thread Karsten Otto
From: Philip Withnall Date: Fri, 15 Feb 2013 12:57:05 + This happens if the socket has been gracefully closed. Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/w

[PATCH 2/4] event-loop.c: Use correct OS abstraction function for dupfd()

2014-09-11 Thread Karsten Otto
From: Philip Withnall Date: Fri, 15 Feb 2013 12:56:52 + Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto --- src/event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index a149db9..1f571ba 100644 --- a/src/event-loop.c

[PATCH 1/4] connection: Fix sendmsg() on FreeBSD

2014-09-11 Thread Karsten Otto
From: Philip Withnall Date: Fri, 15 Feb 2013 12:56:16 + It expects ((msg_controllen == 0) == (msg_control == NULL)), and returns EINVAL otherwise. It can't hurt to be tidy about things on other platforms either though. See: http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/99356#reply2 Signed

Re: [PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Ryo Munakata
On Thu, 11 Sep 2014 15:53:15 +0200 Ondřej Majerech wrote: > When backend_init returns NULL, we goto out_signals, which wants to > free(modules), but in this particular code path, modules hasn't been > initialised leading to a "Double-free or corruption" error message. > Initialising modules to NU

Re: [PATCH 3/3] client: cancel read in wl_display_read_events() when last_error is set

2014-09-11 Thread Jason Ekstrand
I took a look at it too and it looks good to me --Jason On Thu, Sep 11, 2014 at 1:46 AM, Pekka Paalanen wrote: > On Wed, 10 Sep 2014 12:47:14 +0200 > Marek Chalupa wrote: > > > Calling wl_display_read_events() after an error should be equivalent > > to wl_display_cancel_read(), so that display

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Derek Foreman
On 11/09/14 08:22 AM, Pekka Paalanen wrote: > On Thu, 11 Sep 2014 08:10:25 -0500 > Derek Foreman wrote: > >> On 11/09/14 04:00 AM, Pekka Paalanen wrote: >>> On Wed, 10 Sep 2014 15:37:33 -0500 >>> Derek Foreman wrote: >>> weston_surface_update_transform() no longer exists, except in comments

[PATCH] compositor: Don't free an uninitialised pointer.

2014-09-11 Thread Ondřej Majerech
When backend_init returns NULL, we goto out_signals, which wants to free(modules), but in this particular code path, modules hasn't been initialised leading to a "Double-free or corruption" error message. Initialising modules to NULL makes the free a no-op in this scenario. Signed-off-by: Ondřej M

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Pekka Paalanen
On Thu, 11 Sep 2014 08:10:25 -0500 Derek Foreman wrote: > On 11/09/14 04:00 AM, Pekka Paalanen wrote: > > On Wed, 10 Sep 2014 15:37:33 -0500 > > Derek Foreman wrote: > > > >> weston_surface_update_transform() no longer exists, except in comments. > >> > >> Fix that. > >> --- > >> desktop-shell

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Derek Foreman
On 11/09/14 04:00 AM, Pekka Paalanen wrote: > On Wed, 10 Sep 2014 15:37:33 -0500 > Derek Foreman wrote: > >> weston_surface_update_transform() no longer exists, except in comments. >> >> Fix that. >> --- >> desktop-shell/shell.c | 2 +- >> src/compositor-drm.c | 3 +-- >> src/compositor.c

Re: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-11 Thread Pekka Paalanen
On Tue, 9 Sep 2014 10:11:51 + "Zhang, Xiong Y" wrote: > > > > Signed-off-by: Xiong Zhang > > > --- > > > clients/window.c| 26 -- > > > shared/cairo-util.h | 7 +++ > > > shared/frame.c | 49 > > > + > > >

Re: [PATCH weston] shell: fix various interactions with the minimized state

2014-09-11 Thread Pekka Paalanen
On Thu, 31 Jul 2014 15:36:40 +0200 Manuel Bachmann wrote: > This fixes the following : > - if a surface was set fullscreen, and then minimized, > the fullscreen compositor state would stay on and display > a black screen ; > - if a surface was set fullscreen, and we would then > cycle between sur

Re: [PATCH V2 3/3] image: don't print redundant error

2014-09-11 Thread Pekka Paalanen
On Tue, 19 Aug 2014 18:13:11 -0700 Bill Spitzak wrote: > This error is printed by load_image() now > --- > clients/image.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/clients/image.c b/clients/image.c > index 573117c..aee8112 100644 > --- a/clients/image.c > +++ b/clients/image.c

Re: [PATCH V2 2/3] load_image: always print a message on failure if filename is not empty

2014-09-11 Thread Pekka Paalanen
On Tue, 19 Aug 2014 18:13:10 -0700 Bill Spitzak wrote: > It was rather inconsistent before. This may help users figure out why > backgrounds and icons don't show up. A better api where the error can > be queried might be nice, but this seems sufficient for current Weston use. > --- > shared/imag

Re: [PATCH V2 1/3] parse_options: fail on more malformed options

2014-09-11 Thread Pekka Paalanen
On Tue, 19 Aug 2014 18:13:09 -0700 Bill Spitzak wrote: > Fail on trailing text after numbers, such as --width=100mm > > Fail on any text after booleans, such as --flag=false > > Also fixed reading of memory after the null terminator of a long > option with no = sign in it. > --- > shared/optio

Re: [PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-11 Thread Pekka Paalanen
On Wed, 10 Sep 2014 15:37:33 -0500 Derek Foreman wrote: > weston_surface_update_transform() no longer exists, except in comments. > > Fix that. > --- > desktop-shell/shell.c | 2 +- > src/compositor-drm.c | 3 +-- > src/compositor.c | 4 ++-- > 3 files changed, 4 insertions(+), 5 deletion

Re: [PATCH] shm: fix error in comment

2014-09-11 Thread Pekka Paalanen
On Wed, 10 Sep 2014 13:46:09 -0500 Derek Foreman wrote: > --- > src/wayland-shm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/wayland-shm.c b/src/wayland-shm.c > index 3fce678..04ba4f2 100644 > --- a/src/wayland-shm.c > +++ b/src/wayland-shm.c > @@ -372,7 +372,7

Re: [PATCH 3/3] client: cancel read in wl_display_read_events() when last_error is set

2014-09-11 Thread Pekka Paalanen
On Wed, 10 Sep 2014 12:47:14 +0200 Marek Chalupa wrote: > Calling wl_display_read_events() after an error should be equivalent > to wl_display_cancel_read(), so that display state is consistent. > > Thanks to Pekka Paalanen > for pointing that out. > > Signed-off-by: Marek Chalupa > --- > sr

Re: [PATCH weston] Partially revert "xdg-shell: Add show_window_menu request"

2014-09-11 Thread Pekka Paalanen
On Wed, 10 Sep 2014 15:18:33 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > This reverts the parts of commit 81ff075bf48c55cd07e37784e20c310fa52ed926 > that touch window.c. > > This brings the toytoolkit window context menus back, until someone > implements the xdg-shell equivalent in

Re: [PATCH wayland-web] extras: list three Wayland protocol dumping tools

2014-09-11 Thread Boyan Ding
On Thu, 2014-09-11 at 10:14 +0300, Pekka Paalanen wrote: > On Fri, 5 Sep 2014 16:22:25 +0300 > Pekka Paalanen wrote: > No replies... no-one wants their tracer advertised on the Wayland > website? :-P Sorry, I didn't notice this. > It's your projects, and even more so as I still haven't tried any

Re: [PATCH wayland-web] extras: list three Wayland protocol dumping tools

2014-09-11 Thread Pekka Paalanen
On Fri, 5 Sep 2014 16:22:25 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Cc: tomek.obreb...@gmail.com > Cc: Boyan Ding > Cc: Ismo Puustinen > Signed-off-by: Pekka Paalanen > --- > > Hi guys, > > could you check if you are happy with the descriptions I wrote and > if you want som