Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-08 Thread Pekka Paalanen
On Mon, 08 Sep 2014 11:00:37 -0700 Bill Spitzak wrote: > On 09/07/2014 11:28 PM, Pekka Paalanen wrote: > > >> I think it is safe to assume the contents of argv will not get overwritten. > >> > >> It is common to copy argv itself and modify that, but not to modify the > >> strings it points at. >

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Marek Chalupa
Hi, On 8 September 2014 20:08, Bill Spitzak wrote: > I'm probably being stupid, but I still can't figure out how it chooses the > output for a NON-maximized surface. I would think that should use exactly > the same algorithm as maximized does here? > > Each surface has assigned output it is curr

RE: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-08 Thread Zhang, Xiong Y
On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang wrote: > Signed-off-by: Xiong Zhang > --- > clients/window.c| 26 -- > shared/cairo-util.h | 7 +++ > shared/frame.c | 49 + > 3 files changed, 80 insertions(+),

Re: [PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-08 Thread Peter Hutterer
On Mon, Sep 08, 2014 at 08:16:07PM +0200, Jonas Ådahl wrote: > On Fri, Sep 05, 2014 at 11:25:25AM +1000, Peter Hutterer wrote: > > WL_CALIBRATION, introduced in weston-1.1, requires the translation component > > of the calibration matrix to be in screen coordinates. libinput does not > > have > >

[PATCH v3 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-08 Thread Peter Hutterer
WL_CALIBRATION, introduced in weston-1.1, requires the translation component of the calibration matrix to be in screen coordinates. libinput does not have access to this and it's not a very generic way to do this anyway. So with the libinput backend, WL_CALIBRATION support is currently broken (#827

Re: [PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-08 Thread Jonas Ådahl
On Fri, Sep 05, 2014 at 11:25:25AM +1000, Peter Hutterer wrote: > WL_CALIBRATION, introduced in weston-1.1, requires the translation component > of the calibration matrix to be in screen coordinates. libinput does not have > access to this and it's not a very generic way to do this anyway. So with

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Bill Spitzak
I'm probably being stupid, but I still can't figure out how it chooses the output for a NON-maximized surface. I would think that should use exactly the same algorithm as maximized does here? On 09/08/2014 03:34 AM, Marek Chalupa wrote: shsurf->output is the output that user expects the shell

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-08 Thread Bill Spitzak
Just to be clear, I have no objection to adding strdup() to all functions that return strings. I don't like adding unnecessary free() statements to the end of called-once functions such as main, especially if you also have to add labels and gotos and temporary variables to keep track of these.

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-08 Thread Bill Spitzak
On 09/07/2014 11:28 PM, Pekka Paalanen wrote: I think it is safe to assume the contents of argv will not get overwritten. It is common to copy argv itself and modify that, but not to modify the strings it points at. This would be feasible only if we can guarantee that no-one will ever need to

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-08 Thread Ryo Munakata
On Mon, 8 Sep 2014 09:28:17 +0300 Pekka Paalanen wrote: > On Sun, 07 Sep 2014 21:30:52 -0700 > Bill Spitzak wrote: > > > On 09/05/2014 10:47 PM, Ryo Munakata wrote: > > > > > > Hi, Bill. > > > > > > Thank you for reviewing. > > > > > > On Fri, 05 Sep 2014 18:08:44 -0700 > > > Bill Spitzak wrot

[PATCH weston] input: Schedule pointer sprite repaint when cursor is set

2014-09-08 Thread Jonas Ådahl
If a cursor was set with wl_pointer.set_cursor but not in combination with an action that has the side effect of damaging the region where the cursor is positioned, it would not be drawn. This patch explicitly schedules a repaint of the pointer sprite when it is set. clickdot is updated to illustr

Re: XDC2014: Call for paper

2014-09-08 Thread Martin Peres
Le 02/05/2014 00:52, Martin Peres a écrit : Hello, I have the pleasure to announce that the X.org Developer Conference 2014 will be held in Bordeaux, France from October 8th to October 10th. The venue is located in the campus of the University of Bordeaux 1, in the computer science research lab

[PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-08 Thread Marek Chalupa
shsurf->output is the output that user expects the shell surface is on. When maximizing, we don't have any explicit setting of the output like in the case of fullscreening, so set the output to the one that the surface is currently on. In the case that the surface is not mapped yet, (if it ever hap

Re: [PATCH v2 1/2] shell: update shsurf->output when it might changed

2014-09-08 Thread Marek Chalupa
Hi, On 5 September 2014 12:07, Pekka Paalanen wrote: > On Mon, 1 Sep 2014 17:20:32 +0200 > Marek Chalupa wrote: > > > When we are moving window or its state changed, update the > > output, so that configure event and maximizing/fullscreening actions > > have up-to-date information. > > > > Sig