Re: [PATCH] update protocol specification to match wire protocol

2014-09-04 Thread Boyan Ding
Hi, Actually it is not a hack, it is a very well-defined behavior (though not clearly documented at present). We'll update the documentation to reflect that. The mechanic of creating objects undergoes some change as Pekka mentioned [1] and now it's been stable and won't change anymore (I have to i

[PATCH] update protocol specification to match wire protocol

2014-09-04 Thread Paul Sbarra
I agree it's a hack, but it's also one that invalidates the protocol specification. If the wire protocol requires four arguments then the specification needs to reflect that. Currently if another tool or protocol implementation (like the gowl example previously mentioned) attempts to generate cod

RE: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-04 Thread Steve (YiLiang) Zhou
Well, that’s a history problem. What’s the shortage of running things as root? Thanks and Best Regards Steve Zhou From: magc...@gmail.com [mailto:magc...@gmail.com] On Behalf Of Jasper St. Pierre Sent: Friday, September 05, 2014 9:56 AM To: Steve (YiLiang) Zhou Cc: Pekka Paalanen; VanCuts

Re: [PATCH] client: clarify wl_display_prepare_read() semantics

2014-09-04 Thread Bill Spitzak
On 08/28/2014 08:52 AM, Pekka Paalanen wrote: The manual I could find: http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_cond_wait.html says that spurious wakeups may occur. So better keep the serial there. Yes indeed. I believe it is valid, and even common, for pthread_cond_wait to ju

Re: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-04 Thread Jasper St. Pierre
Don't run anything as root. Why does your application need to modify files under /usr/? On Thu, Sep 4, 2014 at 6:50 PM, Steve (YiLiang) Zhou wrote: > Thanks everyone, > Xwayland already worked fine, we modify the user-session to use root > login. The reason I want to start it with root is that

RE: how to make Xwayland auto start on tizen-ivi-3.0 image

2014-09-04 Thread Steve (YiLiang) Zhou
Thanks everyone, Xwayland already worked fine, we modify the user-session to use root login. The reason I want to start it with root is that our x11 app need modify a directory under /usr, app doesn't have the right. Thanks and Best Regards Steve Zhou -Original Message- From: Pekka Paalan

Re: wl_tablet draft v2

2014-09-04 Thread Bill Spitzak
On 08/27/2014 04:15 AM, Pekka Paalanen wrote: That describes the situation pretty closely, except the action is on some subset of the wl_surfaces (for instance, only on the wl_surfaces that belong to the client). What I described in the quote above was just a meaningless chain of abstract happ

[PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-04 Thread Peter Hutterer
WL_CALIBRATION, introduced in weston-1.1, requires the translation component of the calibration matrix to be in screen coordinates. libinput does not have access to this and it's not a very generic way to do this anyway. So with the libinput backend, WL_CALIBRATION support is currently broken (#827

X.Org looking for projects and mentors for the Outreach Program for Women

2014-09-04 Thread Peter Hutterer
Hi everyone, X.Org will join the Outreach Program for Women (OPW) in Round 9 (December 2014 - March 2015). The OPW is "open to anyone who was assigned female at birth and anyone who identifies as a woman, genderqueer, genderfluid, or genderfree regardless of gender presentation or assigned sex at

[PATCH] matrix-test: fix units in report

2014-09-04 Thread Derek Foreman
The matrix-test speed tests are calculated in ns but some printed the units as us --- tests/matrix-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/matrix-test.c b/tests/matrix-test.c index 7b414c9..6bf4ba3 100644 --- a/tests/matrix-test.c +++ b/tests/matrix-tes

[PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-09-04 Thread Derek Foreman
If a full screen program is fading out and a touch start happens, it will result in a NULL pointer dereference when weston_touch_set_focus tries to derefernce view->surface->resource. Instead, this patch sets the focus to NULL, which should be the same as if the program was destroyed during the to

Re: [PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-09-04 Thread Derek Foreman
On 04/09/14 06:49 AM, Pekka Paalanen wrote: > On Fri, 29 Aug 2014 13:18:54 -0500 > Derek Foreman wrote: > >> I should mention I don't have a touch capable screen and am only doing >> partial testing with a modified version of libinput. More testing would >> be nice. :) >> >> On 29/08/14 01:12 P

Re: [PATCH 1/2] clients: Maximize window when double click on title bar

2014-09-04 Thread Pekka Paalanen
On Thu, 12 Jun 2014 11:06:25 +0800 Xiong Zhang wrote: > From: Xiong Zhang > > Signed-off-by: Xiong Zhang > --- > clients/window.c| 26 +- > shared/cairo-util.h | 4 > shared/frame.c | 31 +++ > 3 files changed, 60 insertions(+

Re: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-04 Thread Pekka Paalanen
On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang wrote: > Signed-off-by: Xiong Zhang > --- > clients/window.c| 26 -- > shared/cairo-util.h | 7 +++ > shared/frame.c | 49 + > 3 files changed, 80 insertions(+),

Re: [PATCH 4/4] client: fix bug with display->reader_count < 0

2014-09-04 Thread Pekka Paalanen
On Fri, 29 Aug 2014 11:21:31 +0200 Marek Chalupa wrote: > If we will try call wl_display_read_events() again, > after we got EAGAIN from previous call, we get deadlock > as shown in test. The bug works like this: after first call > to wl_display_read_events() the display->reader_count is 0 > and

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-04 Thread Pekka Paalanen
On Fri, 29 Aug 2014 11:21:30 +0200 Marek Chalupa wrote: > When wl_display_read_events() returns with errno == EAGAIN, we > naturally try to call it again. But this next call results in deadlock. > > Signed-off-by: Marek Chalupa > --- > tests/display-test.c | 88 > +

Re: [PATCH 2/4] display-test: make use of create_thread function

2014-09-04 Thread Pekka Paalanen
On Fri, 29 Aug 2014 11:21:29 +0200 Marek Chalupa wrote: > This function is used in one test only, but its functionality can be > used in another tests to (create thread and wait until it is sleeping). > We just need to pass the starting function for the thread as an argument. > > Signed-off-by:

Re: [PATCH weston] xwm: Do not activate override redirect windows

2014-09-04 Thread Pekka Paalanen
On Sat, 30 Aug 2014 15:24:21 +0900 Ryo Munakata wrote: > On Sat, 30 Aug 2014 10:33:23 +0800 > > Hi, Boyan. > > I tested this patch with chromium and firefox running on each drm-backend and > x11-backend of weston. > And seems that both chromium and firefox work well. > This patch actually fixe

Re: [PATCH V2] Wayland: Initialize newly created wl_proxys to zero

2014-09-04 Thread Pekka Paalanen
On Sat, 30 Aug 2014 17:12:26 +0200 "Nils Chr. Brause" wrote: > Hi! > > Because the other thread got so long, I repost the improved version of > the patch for easier review: > > > From 50cdeaf09a9bd90b1957a831217319e863c4c484 Mon Sep 17 00:00:00 2001 > From: "Nils Chr. Brause" > Date: Mon, 25

Re: [PATCH] touch-input: Don't dereference NULL pointer during full screen fade

2014-09-04 Thread Pekka Paalanen
On Fri, 29 Aug 2014 13:18:54 -0500 Derek Foreman wrote: > I should mention I don't have a touch capable screen and am only doing > partial testing with a modified version of libinput. More testing would > be nice. :) > > On 29/08/14 01:12 PM, Derek Foreman wrote: > > If a full screen program i

Re: [PATCH weston] desktop-shell: implement touch popup grabs

2014-09-04 Thread Pekka Paalanen
On Thu, 4 Sep 2014 12:58:12 +0300 Pekka Paalanen wrote: > On Wed, 20 Aug 2014 11:27:10 +0200 > Jonny Lamb wrote: > > > --- > > desktop-shell/shell.c | 155 > > ++ > > 1 file changed, 143 insertions(+), 12 deletions(-) > Do you want this patch t

Re: [PATCH weston] desktop-shell: implement touch popup grabs

2014-09-04 Thread Pekka Paalanen
On Wed, 20 Aug 2014 11:27:10 +0200 Jonny Lamb wrote: > --- > desktop-shell/shell.c | 155 > ++ > 1 file changed, 143 insertions(+), 12 deletions(-) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index ec72287..db7841a 100644 > -

Re: [PATCH weston] pixman-renderer: copy_to_hw_buffer: don't leak output_region

2014-09-04 Thread Pekka Paalanen
On Thu, 4 Sep 2014 01:56:53 +0900 Ryo Munakata wrote: > This was reported by Valgrind. > > Signed-off-by: Ryo Munakata > --- > src/pixman-renderer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c > index 351f00e..2c26c3a 100644 > --- a/

Re: Wayland specification doesn't match code generation

2014-09-04 Thread Pekka Paalanen
On Wed, 3 Sep 2014 22:32:02 -0500 Paul Sbarra wrote: > I tried to start some discussion on this topic previously, but it > apparently didn't make it through the moderator, so I'm trying again having > now joined the list. > > I've recently taken an interest in the gowl >

Re: [PATCH wayland] doc: replace publican with xmlto

2014-09-04 Thread Pekka Paalanen
On Thu, 4 Sep 2014 17:32:10 +1000 Peter Hutterer wrote: > Publican isn't packaged for some distros, xmlto is a lot more common. Most of > what publican provides for us is the stylesheet anyway, so we can just use > xmlto and the publican stylesheet to get roughly the same look. > > PDF and XML g

[PATCH wayland] doc: replace publican with xmlto

2014-09-04 Thread Peter Hutterer
Publican isn't packaged for some distros, xmlto is a lot more common. Most of what publican provides for us is the stylesheet anyway, so we can just use xmlto and the publican stylesheet to get roughly the same look. PDF and XML generation has been dropped, this needs a bit more more effort than a

Re: Wayland specification doesn't match code generation

2014-09-04 Thread Pekka Paalanen
On Thu, 04 Sep 2014 12:17:12 +0800 Boyan Ding wrote: > On Wed, 2014-09-03 at 21:04 -0700, Jasper St. Pierre wrote: > > The fact that we have an undocumented hack like that in our scanner > > clearly isn't great. We need to document it. > > I totally agree. This can really confuse every beginner.