Re: [PATCH weston] xwm: Check whether the seat is NULL sometimes in weston_wm_handle_button

On Mon, 01 Sep 2014 20:07:46 +0800 Boyan Ding wrote: > On Mon, 2014-09-01 at 12:14 +0300, Pekka Paalanen wrote: > > On Fri, 29 Aug 2014 22:10:32 +0800 > > Boyan Ding wrote: > > > > > Under some certain circumstances, pointer button may have been released > > > when frame is still being resized/

Re: [PATCH weston] Add font entry to shell section for title fonts

On Tue, 2 Sep 2014 13:13:17 +0900 Ryo Munakata wrote: > On Mon, 1 Sep 2014 14:05:42 +0300 > Pekka Paalanen wrote: > > > On Thu, 28 Aug 2014 20:31:37 +0900 > > > > Hi, > > > > considering that the toytoolkit (well, shared/cairo-util.h here) uses > > cairo_show_text(), which is documented as: >

Re: [PATCH 3/3] evdev: Add middle buttton scrolling for trackpoints

On Tue, Sep 02, 2014 at 04:34:50PM +0200, Hans de Goede wrote: > Most trackpoint users want to be able to scroll using the trackpoint with > the middle button pressed, add support for this. > > Signed-off-by: Hans de Goede yes, but I'd like to wait for dmitry to merge the INPUT_PROP_POINTING_STI

Re: [PATCH 2/3] evdev: Move generic scroll code from evdev-mt-touchpad.c to evdev.c

On Tue, Sep 02, 2014 at 04:34:49PM +0200, Hans de Goede wrote: > So that it can be used for middle button trackpoint scrolling too. > > Signed-off-by: Hans de Goede > --- > src/evdev-mt-touchpad.c | 56 > +++-- > src/evdev-mt-touchpad.h | 4 > s

Re: [PATCH 1/3] litest-alps-semi-mt: Fix compiler warnings

On Tue, Sep 02, 2014 at 04:34:48PM +0200, Hans de Goede wrote: > This fixes the following (false positive) compiler warnings: > > litest-alps-semi-mt.c: In function 'alps_touch_move': > litest-alps-semi-mt.c:163:3: warning: 'b' may be used uninitialized in this > function [-Wmaybe-uninitialized]

[PATCH libinput 05/17] test: wait for events in litest_assert_button_events

Takes the onus of waiting from the caller. Signed-off-by: Peter Hutterer --- test/litest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/litest.c b/test/litest.c index 8f3784f..c3b99ef 100644 --- a/test/litest.c +++ b/test/litest.c @@ -1067,7 +1067,7 @@ litest_assert_b

[PATCH libinput 07/17] evdev: prefix the hw key/button bitmask with 'hw'

This bitmask reflects the hw state, prefix it accordingly. Signed-off-by: Peter Hutterer --- src/evdev.c | 12 ++-- src/evdev.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 721238f..71c5236 100644 --- a/src/evdev.c +++ b/src/evde

[PATCH libinput 08/17] evdev: factor out closing a device into evdev_suspend()

No functional changes, just prep work for an upcoming patch Signed-off-by: Peter Hutterer --- src/evdev.c | 13 +++-- src/evdev.h | 2 ++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 71c5236..054beb6 100644 --- a/src/evdev.c +++ b/src/e

[PATCH libinput 16/17] touchpad: hook up sendevents configuration

We may be in the middle of a software button click or a tap, so make sure we go back to the device-neutral state by unwinding. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 10 + src/evdev-mt-touchpad-tap.c | 6 +++ src/evdev-mt-touchpad.c | 91

[PATCH libinput 02/17] test: avoid erroneous devices to be passed into the test suites

The litest features overlap with the litest device specifiers, so it's easy to pass in LITEST_MOUSE where LITEST_POINTER should be passed in, and vice versa. Lacking proper type checking the best we can do here is simply move the devices into the negative range and check for that. Signed-off-by: P

[PATCH libinput 09/17] evdev: prevent double-suspending a device

Signed-off-by: Peter Hutterer --- src/evdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 054beb6..9e91ee5 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1168,16 +1168,23 @@ release_pressed_keys(struct evdev_device *device)

[PATCH libinput 14/17] evdev: drop the button count when releasing keys on remove

We previously called this function only before device removal, so failing to update the button state didn't matter. To make this function generic for the device suspend/resume, we need to keep track of the button/key count properly. If we have a key down multiple times on suspend though, log a bug

[PATCH libinput 15/17] touchpad: split handling the state into a separate function

No functional changes Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index d831b83..cd31c48 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touc

[PATCH libinput 01/17] Add a helper function for clock_gettime

Signed-off-by: Peter Hutterer --- src/evdev.c| 7 +-- src/libinput-private.h | 15 +++ src/libinput-util.h| 1 + src/timer.c| 29 - 4 files changed, 25 insertions(+), 27 deletions(-) diff --git a/src/evdev.c b/src/evdev.c

[PATCH libinput 13/17] test: add test for device suspend/resume

Signed-off-by: Peter Hutterer --- test/Makefile.am | 7 +- test/device.c| 275 +++ 2 files changed, 281 insertions(+), 1 deletion(-) create mode 100644 test/device.c diff --git a/test/Makefile.am b/test/Makefile.am index 56ed9d1..86859d8

[PATCH libinput 10/17] Add a config interface for enabling/disabling event generation from a device

Rather than adding a config interface to disable a device merely allow a caller to toggle the "send events" mode on the device. If off, the device won't send events (though further events may be received depending on the current state of the device). Default is enabled, i.e. the device sends events

[PATCH libinput 03/17] test: add litest_add_device()

For adding a litest device to an existing context. Signed-off-by: Peter Hutterer --- test/litest.c | 12 test/litest.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/test/litest.c b/test/litest.c index 2cea83c..890b7e0 100644 --- a/test/litest.c +++ b/test/litest.c @@ -564

[PATCH libinput 00/17] device enable/disable configuration

Second attempt at the ability to enable/disable a device. The big difference to v1 is that this is hooked up to a configuration option this time and made clear how it behaves in the documentation. Patches 01-07 are general cleanup patches that can go in regardless of the config option. Note that

[PATCH libinput 06/17] touchpad: fix tap-and-drag handling for timeouts

Doing a tap-and-drag gesture but just holding the finger instead of moving should trigger a timeout and still switchin into tap-and-drag. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-tap.c | 1 - test/touchpad.c | 30 ++ 2 files changed, 30 ins

[PATCH libinput 12/17] evdev: don't resume a removed device

A device may disappear and a new device may re-appear with the same device node while the original device is suspended. Prevent a device resume to open the wrong device. In a path context, a changing syspath is the only indicator we get of the device changing. In a udev context, if the device was

[PATCH libinput 17/17] test: test for release events on device suspend

Signed-off-by: Peter Hutterer --- test/device.c | 239 ++ 1 file changed, 239 insertions(+) diff --git a/test/device.c b/test/device.c index 8db69fd..cf20632 100644 --- a/test/device.c +++ b/test/device.c @@ -30,6 +30,7 @@ #include #in

[PATCH libinput 04/17] test: move assert_button_event to litest proper

Signed-off-by: Peter Hutterer --- test/litest.c | 21 test/litest.h | 3 + test/pointer.c | 19 +--- test/touchpad.c | 329 ++-- 4 files changed, 181 insertions(+), 191 deletions(-) diff --git a/test/litest.c b/test/litest.c index

[PATCH libinput 11/17] evdev: hook up a generic enable/disable interface for devices

The evdev fallback dispatch supports enabling and disabling devices. That's fairly easy to support since we don't (yet) have extra event generation within the fallback backend. Thus, we can simply close the fd and re-open it again later. Touchpads are currently excluded here, they generate extra e

[PATCH 1/3] litest-alps-semi-mt: Fix compiler warnings

This fixes the following (false positive) compiler warnings: litest-alps-semi-mt.c: In function 'alps_touch_move': litest-alps-semi-mt.c:163:3: warning: 'b' may be used uninitialized in this function [-Wmaybe-uninitialized] send_abs_mt_xy(d, r, b); ^ litest-alps-semi-mt.c:163:3: warning: 'r

[PATCH 3/3] evdev: Add middle buttton scrolling for trackpoints

Most trackpoint users want to be able to scroll using the trackpoint with the middle button pressed, add support for this. Signed-off-by: Hans de Goede --- include/linux/input.h | 1 + src/evdev.c | 55 +++ src/evdev.h | 5 +++

[PATCH 2/3] evdev: Move generic scroll code from evdev-mt-touchpad.c to evdev.c

So that it can be used for middle button trackpoint scrolling too. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 56 +++-- src/evdev-mt-touchpad.h | 4 src/evdev.c | 48 ++ src/evde

[PATCH v2 weston] xdg-shell: handle clients launched in fullscreen

When client is lauched in fullscreen, it is placed on the first output, because it is not mapped and shell_surface_set_output() therefore sets default output. Since we have no better way how to position newly created windows, (http://lists.freedesktop.org/archives/wayland-devel/2014-May/thread.htm

Re: [PATCH weston] xdg-shell: handle clients launched in fullscreen

On 2 September 2014 11:27, Pier Luigi Fiorini wrote: > 2014-09-02 11:11 GMT+02:00 Marek Chalupa : > > [cut] > > > desktop-shell/shell.c | 33 + > > 1 file changed, 33 insertions(+) > > > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > > index 9c0e72

Re: [PATCH weston] xdg-shell: handle clients launched in fullscreen

2014-09-02 11:11 GMT+02:00 Marek Chalupa : [cut] > desktop-shell/shell.c | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index 9c0e721..cc7fb4a 100644 > --- a/desktop-shell/shell.c > +++ b/desktop-shell/s

[PATCH weston] xdg-shell: handle clients launched in fullscreen

When client is lauched in fullscreen, it is placed on the first output, because it is not mapped and shell_surface_set_output() therefore sets default output. Since we have no better way how to position newly created windows, (http://lists.freedesktop.org/archives/wayland-devel/2014-May/thread.htm