Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 11:37:13 -0700 Jason Ekstrand wrote: > On Wed, Aug 27, 2014 at 1:52 AM, Giulio Camuffo > wrote: > > > 2014-08-27 11:38 GMT+03:00 Pekka Paalanen : > > > On Wed, 27 Aug 2014 11:03:04 +0300 > > > Giulio Camuffo wrote: > > > > > >> 2014-08-27 10:32 GMT+03:00 Pekka Paalanen : >

Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Jason Ekstrand
On Wed, Aug 27, 2014 at 1:52 AM, Giulio Camuffo wrote: > 2014-08-27 11:38 GMT+03:00 Pekka Paalanen : > > On Wed, 27 Aug 2014 11:03:04 +0300 > > Giulio Camuffo wrote: > > > >> 2014-08-27 10:32 GMT+03:00 Pekka Paalanen : > >> > On Tue, 26 Aug 2014 17:50:47 +0300 > >> > Giulio Camuffo wrote: > >>

Re: [PATCH weston 2/3] shell: fix race on desktop-shell exit

2014-08-27 Thread Derek Foreman
On 27/08/14 05:41 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > The desktop shell plugin registers both a wl_client destroy signal > listener, and a sigchld handler, when launching weston-desktop-shell. > However, nothing guarantees in which order do the wl_client destructor > and the sigc

Re: [PATCH weston 1/3] compositor: add weston_client_start()

2014-08-27 Thread Derek Foreman
On 27/08/14 05:41 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > weston_client_start() is a new wrapper around weston_client_launch(), > that does the process tracking on its own, and logs the process exit > status. > > When users of weston_client_start() want to know when the process exit

Re: [PATCH] xwayland: Use frame geometry for resizing shell surface

2014-08-27 Thread Ondřej Majerech
On 27/08/14 14:38, Pekka Paalanen wrote: On Mon, 25 Aug 2014 10:17:48 +0200 "Nils Chr. Brause" wrote: I also noticed this in current master. This seems to fix the problem. :) Reviewed-by: Nils Chr. Brause On Thu, Aug 21, 2014 at 2:51 AM, Ondřej Majerech wrote: We want to set the size o

Re: [PATCH] xwayland: Use frame geometry for resizing shell surface

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 15:38:58 +0300 Pekka Paalanen wrote: > On Mon, 25 Aug 2014 10:17:48 +0200 > "Nils Chr. Brause" wrote: > > > I also noticed this in current master. This seems to fix the problem. :) > > > > Reviewed-by: Nils Chr. Brause > > > > > > > > On Thu, Aug 21, 2014 at 2:51 AM, On

Re: [PATCH weston] wm: Don't subtract the margins from the configured size

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 09:38:33 -0400 "Jasper St. Pierre" wrote: > When we moved the configure event size to being based on the window > geometry, we changed the coordinates of the configure request to being > frame geometry based. Frame geometry includes titlebar and border, but > not shadow margin

Re: [PATCH weston 04/10] desktop-shell: fix invalid memory access when shell execution fails

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:46 +0200 raw...@gmail.com wrote: > From: Arnaud Vrac > > In this case wl_client_add_destroy_listener() was called with a NULL > client, which is invalid. > --- > desktop-shell/shell.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/desktop-

Re: [PATCH weston 05/10] text-backend: handle the text backend client destroy signal

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:47 +0200 raw...@gmail.com wrote: > From: Arnaud Vrac > > Mimic what was implemented for desktop-shell in 312ea4ca, to avoid a > crash on shutdown. > --- > src/text-backend.c | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a

Re: [PATCH weston 02/10] nested: compile when system egl header does not export wayland extensions

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 20:56:44 +0200 raw...@gmail.com wrote: > From: Arnaud Vrac > > --- > clients/nested.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/clients/nested.c b/clients/nested.c > index f094237..87cb06c 100644 > --- a/clients/nested.c > +++ b/clients/nested.c > @@ -45,6 +4

[PATCH weston] wm: Don't subtract the margins from the configured size

2014-08-27 Thread Jasper St. Pierre
When we moved the configure event size to being based on the window geometry, we changed the coordinates of the configure request to being frame geometry based. Frame geometry includes titlebar and border, but not shadow margins. --- xwayland/window-manager.c | 11 --- 1 file changed, 4 in

Re: [PATCH weston] Document output/scale configuration option in the weston.ini man page.

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 13:22:11 +0200 maghoff+wayl...@gmail.com wrote: > From: Magnus Hoff > > v2: Different, hopefully better, wording. This patch entirely replaces > the previous similar patch I sent. > > v3: Now including the correct patch. Please disregard the "v2" mail. > --- > man/weston.in

Re: [PATCH] desktop-shell: Replace magic constants with named ones

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 10:47:24 +0200 "Nils Chr. Brause" wrote: > This looks much more readable to me. Unnamed magic numbers are always > confusing. > > Reviewed-by: Nils Chr. Brause > > > > On Thu, Aug 21, 2014 at 3:47 PM, Ondřej Majerech > wrote: > > > Signed-off-by: Ondřej Majerech > > --

Re: [PATCH] xwayland: Use frame geometry for resizing shell surface

2014-08-27 Thread Pekka Paalanen
On Mon, 25 Aug 2014 10:17:48 +0200 "Nils Chr. Brause" wrote: > I also noticed this in current master. This seems to fix the problem. :) > > Reviewed-by: Nils Chr. Brause > > > > On Thu, Aug 21, 2014 at 2:51 AM, Ondřej Majerech > wrote: > > > We want to set the size of the entire window, no

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 13:43:13 +0200 Sjoerd Simons wrote: > On Sun, 2014-08-03 at 10:39 +0300, Pekka Paalanen wrote: > > As for wl_surface re-use after destroying a role, I have found that > > resetting a role to allow re-use is much easier and cleaner than > > not to, in Weston code. That's why I

Re: [PATCH weston] xwayland: Clean up the WM properly if X server crashes

2014-08-27 Thread Pekka Paalanen
On Thu, 19 Jun 2014 01:03:31 -0700 Dima Ryazanov wrote: > The X cleanup code uses wxs->wm to check if the WM has been created - but that > variable was never initialized. So if X crashes, the WM doesn't get destroyed, > causing a crash when it tries to repaint a window. > > Signed-off-by: Dima R

Re: [PATCH] xdg-shell: Align surface life-time rules with that of wl_shell

2014-08-27 Thread Sjoerd Simons
On Sun, 2014-08-03 at 10:39 +0300, Pekka Paalanen wrote: > On Mon, 21 Jul 2014 13:23:23 -0700 > Jason Ekstrand wrote: > > > I think the way it's handled in subsurfaces allows you to create a > > subsurface from a surface, delete the surface, and then re-use the surface > > as something else. If

Re: wl_tablet draft v2

2014-08-27 Thread Pekka Paalanen
On Wed, 20 Aug 2014 13:20:46 -0700 Bill Spitzak wrote: > On 08/20/2014 12:13 PM, Pekka Paalanen wrote: > > > What would be a use case, where you might get blinking? > > > > If the > > item is highlighted because an action with the input tool on any > > wl_surface may affect it, why remove the h

[PATCH weston v3 2/2] Implement data_device interface destructor

2014-08-27 Thread kabeer . khan
From: kabeer window: use data_device interface destructor data-device: implement data_device_release destructor Signed-off-by: kabeer --- clients/window.c | 14 ++ src/data-device.c | 14 ++ 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/clients/wi

[PATCH v3 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

2014-08-27 Thread kabeer . khan
From: kabeer Signed-off-by: kabeer --- protocol/wayland.xml | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index bb457bc..f0248f5 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -517,7 +517,7 @@

[PATCH weston 2/3] shell: fix race on desktop-shell exit

2014-08-27 Thread Pekka Paalanen
From: Pekka Paalanen The desktop shell plugin registers both a wl_client destroy signal listener, and a sigchld handler, when launching weston-desktop-shell. However, nothing guarantees in which order do the wl_client destructor and the sigchld handler run. Luckily, the sigchld handler cannot in

[PATCH weston 3/3] compositor: leave no zombie behind

2014-08-27 Thread Pekka Paalanen
From: Pekka Paalanen When SIGCHLD fires, we may have more than one zombie to be collected. Run waitpid() in a loop until no more zombies are found, and clean them all up. It looks like the SIGCHLD signalfd does not trigger again for remaining zombies, so we need the loop. This works around a cr

[PATCH weston 1/3] compositor: add weston_client_start()

2014-08-27 Thread Pekka Paalanen
From: Pekka Paalanen weston_client_start() is a new wrapper around weston_client_launch(), that does the process tracking on its own, and logs the process exit status. When users of weston_client_start() want to know when the process exits, they should hook into the wl_client destroy signal. Thi

Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Giulio Camuffo
2014-08-27 11:38 GMT+03:00 Pekka Paalanen : > On Wed, 27 Aug 2014 11:03:04 +0300 > Giulio Camuffo wrote: > >> 2014-08-27 10:32 GMT+03:00 Pekka Paalanen : >> > On Tue, 26 Aug 2014 17:50:47 +0300 >> > Giulio Camuffo wrote: >> > >> >> 2014-08-26 17:39 GMT+03:00 Jason Ekstrand : >> >> > >> >> > On Au

Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Pekka Paalanen
On Wed, 27 Aug 2014 11:03:04 +0300 Giulio Camuffo wrote: > 2014-08-27 10:32 GMT+03:00 Pekka Paalanen : > > On Tue, 26 Aug 2014 17:50:47 +0300 > > Giulio Camuffo wrote: > > > >> 2014-08-26 17:39 GMT+03:00 Jason Ekstrand : > >> > > >> > On Aug 26, 2014 1:01 AM, "Giulio Camuffo" > >> > wrote: > >

Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Giulio Camuffo
2014-08-27 10:32 GMT+03:00 Pekka Paalanen : > On Tue, 26 Aug 2014 17:50:47 +0300 > Giulio Camuffo wrote: > >> 2014-08-26 17:39 GMT+03:00 Jason Ekstrand : >> > >> > On Aug 26, 2014 1:01 AM, "Giulio Camuffo" wrote: >> >> >> >> 2014-08-26 10:24 GMT+03:00 Pekka Paalanen : >> >> > On Mon, 25 Aug 2014

Re: Wayland and Weston 1.6 alpha snapshot (1.5.91)

2014-08-27 Thread Pekka Paalanen
On Tue, 26 Aug 2014 07:00:05 -0700 Jason Ekstrand wrote: > On Aug 26, 2014 4:32 AM, "Pekka Paalanen" wrote: > > > > On Tue, 26 Aug 2014 10:36:58 +0100 > > Daniel Stone wrote: > > > > > Hi, > > > > > > On 23 August 2014 15:38, Pekka Paalanen wrote: > > > > > > > On Fri, 22 Aug 2014 10:51:19 -07

Re: [PATCH weston] xdg-shell: Make stable

2014-08-27 Thread Pekka Paalanen
On Tue, 26 Aug 2014 17:50:47 +0300 Giulio Camuffo wrote: > 2014-08-26 17:39 GMT+03:00 Jason Ekstrand : > > > > On Aug 26, 2014 1:01 AM, "Giulio Camuffo" wrote: > >> > >> 2014-08-26 10:24 GMT+03:00 Pekka Paalanen : > >> > On Mon, 25 Aug 2014 21:51:57 -0700 > >> > Jason Ekstrand wrote: > >> > >