Re: [PATCH weston] xdg-shell: Make stable

2014-08-25 Thread Pekka Paalanen
On Mon, 25 Aug 2014 11:21:33 -0700 Bill Spitzak wrote: > On 08/25/2014 04:11 AM, Pekka Paalanen wrote: > > > Let's also think about the size hints, how do they interact here, even > > if we are not adding them yet. > > > > The client creates a wl_surface, gives it content, and turns it into > >

Re: [PATCH weston] xdg-shell: Make stable

2014-08-25 Thread Jason Ekstrand
Just a couple quick comments below. I can't fin where this goes, so I'm putting it here: Why are we having compositors send an initial configure event again? Given that we have a serial, tiling compositors can just send a configure and wait until the client responds to the event. Non-tiling com

Re: [PATCH libinput 0/8] Add libinput_device_suspend() to disable devices

2014-08-25 Thread Peter Hutterer
On Mon, Aug 25, 2014 at 10:23:09AM -0700, Bill Spitzak wrote: > On 08/24/2014 05:44 PM, Peter Hutterer wrote: > > >this is *not* about palm detection. palm detection is already always enabled > >where possible and with the parameters sensible for that specific touchpad. > > > >This option is for t

[PATCH weston 09/10] keyboard: do not crash if no input panel is available

2014-08-25 Thread rawoul
From: Arnaud Vrac --- clients/keyboard.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/keyboard.c b/clients/keyboard.c index 7c11cec..750f58e 100644 --- a/clients/keyboard.c +++ b/clients/keyboard.c @@ -969,6 +969,8 @@ keyboard_create(struct output *output, struct virtual_keyboa

[PATCH weston 03/10] nested: add missing egl extension declaration

2014-08-25 Thread rawoul
From: Arnaud Vrac --- src/weston-egl-ext.h | 8 1 file changed, 8 insertions(+) diff --git a/src/weston-egl-ext.h b/src/weston-egl-ext.h index 8ddf97f..4888323 100644 --- a/src/weston-egl-ext.h +++ b/src/weston-egl-ext.h @@ -51,7 +51,15 @@ EGLAPI EGLBoolean EGLAPIENTRY eglQueryWayland

[PATCH weston 06/10] simple-egl: fix opaque and 16 bits mode options

2014-08-25 Thread rawoul
From: Arnaud Vrac In those cases we were writing to the wrong EGL config attribute. --- clients/simple-egl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/simple-egl.c b/clients/simple-egl.c index 69d28ea..33e711c 100644 --- a/clients/simple-egl.c +++ b/clients/simple-egl.c @@ -133

[PATCH weston 10/10] pixman-renderer: free shadow buffer on renderer destruction

2014-08-25 Thread rawoul
From: Arnaud Vrac --- src/pixman-renderer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index a816d02..4fdcb05 100644 --- a/src/pixman-renderer.c +++ b/src/pixman-renderer.c @@ -786,6 +786,9 @@ pixman_renderer_output_destroy(struct weston_

[PATCH weston 05/10] text-backend: handle the text backend client destroy signal

2014-08-25 Thread rawoul
From: Arnaud Vrac Mimic what was implemented for desktop-shell in 312ea4ca, to avoid a crash on shutdown. --- src/text-backend.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/text-backend.c b/src/text-backend.c index 7d2a064..dfb5dde 100644 --- a/s

[PATCH weston 00/10] simple fixes

2014-08-25 Thread rawoul
This patch series contains simple bug or compilation fixes for weston, they are pretty simple so I hope the short comments are enough. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waylan

[PATCH weston 07/10] desktop-shell: properly set background widget as opaque

2014-08-25 Thread rawoul
From: Arnaud Vrac Toytoolkit resets the opaque region which was set manually using the wayland protocol directly, so use the widget API instead. --- clients/desktop-shell.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-she

[PATCH weston 08/10] weston-test: fix build when mesa egl extensions are not defined

2014-08-25 Thread rawoul
From: Arnaud Vrac --- tests/weston-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/weston-test.c b/tests/weston-test.c index f1e45c1..5c6fd47 100644 --- a/tests/weston-test.c +++ b/tests/weston-test.c @@ -33,6 +33,7 @@ #ifdef ENABLE_EGL #include #include +#include "../src/w

[PATCH weston 02/10] nested: compile when system egl header does not export wayland extensions

2014-08-25 Thread rawoul
From: Arnaud Vrac --- clients/nested.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/nested.c b/clients/nested.c index f094237..87cb06c 100644 --- a/clients/nested.c +++ b/clients/nested.c @@ -45,6 +45,7 @@ #define WL_HIDE_DEPRECATED #include +#include "../src/weston-egl-ext.h

[PATCH weston 01/10] window: unbind egl surface and context on surface release

2014-08-25 Thread rawoul
From: Arnaud Vrac Binding null read and write surfaces to an egl context is not standard --- clients/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index 5d64022..85c25f7 100644 --- a/clients/window.c +++ b/clients/window.c @@

[PATCH weston 04/10] desktop-shell: fix invalid memory access when shell execution fails

2014-08-25 Thread rawoul
From: Arnaud Vrac In this case wl_client_add_destroy_listener() was called with a NULL client, which is invalid. --- desktop-shell/shell.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 99f3343..a023281 100644 --- a/desk

Re: [PATCH weston] xdg-shell: Make stable

2014-08-25 Thread Bill Spitzak
On 08/25/2014 04:11 AM, Pekka Paalanen wrote: Let's also think about the size hints, how do they interact here, even if we are not adding them yet. The client creates a wl_surface, gives it content, and turns it into xdg_surface, and sends size hints. The compositor as a response to get_xdg_su

Re: [PATCH libinput 0/8] Add libinput_device_suspend() to disable devices

2014-08-25 Thread Bill Spitzak
On 08/24/2014 05:44 PM, Peter Hutterer wrote: this is *not* about palm detection. palm detection is already always enabled where possible and with the parameters sensible for that specific touchpad. This option is for the optional disabling of the touchpad when an external mouse is connected. A

Re: Multiple Display Support

2014-08-25 Thread Pekka Paalanen
On Mon, 25 Aug 2014 18:36:07 +0530 Abhijit Potnis wrote: > Hello Pekka, > > Weston does detect the two connectors, log below show that : Please paste the whole log. > [22:29:40.882] Output None1, (connector 4, crtc 10) >mode 1280x800@57.4, preferred, current Looks like your ke

Re: Multiple Display Support

2014-08-25 Thread Abhijit Potnis
Hello Pekka, Weston does detect the two connectors, log below show that : [22:29:40.882] Output None1, (connector 4, crtc 10) mode 1280x800@57.4, preferred, current [22:29:40.919] Failed to initialize backlight [22:29:40.919] EDID data 'DEL', 'DELL 2007WFP', 'NF409794051L' [22:29:4

Re: Multiple Display Support

2014-08-25 Thread Abhijit Potnis
On Mon, Aug 25, 2014 at 4:59 PM, Pekka Paalanen wrote: > On Mon, 25 Aug 2014 15:04:08 +0530 > Abhijit Potnis wrote: > > > Hello , > > > > I have a doubt regarding Wayland/Weston's support for multiple displays. > I > > am of the assumption that "multiple display" means support of two or more > >

Re: Multiple Display Support

2014-08-25 Thread Pekka Paalanen
On Mon, 25 Aug 2014 15:04:08 +0530 Abhijit Potnis wrote: > Hello , > > I have a doubt regarding Wayland/Weston's support for multiple displays. I > am of the assumption that "multiple display" means support of two or more > monitors(or displays) simultaneously like a extended desktop mode and th

[PATCH weston] Document output/scale configuration option in the weston.ini man page.

2014-08-25 Thread maghoff+wayland
From: Magnus Hoff v2: Different, hopefully better, wording. This patch entirely replaces the previous similar patch I sent. v3: Now including the correct patch. Please disregard the "v2" mail. --- man/weston.ini.man | 12 1 file changed, 12 insertions(+) diff --git a/man/weston.in

Re: [PATCH weston] xdg-shell: Make stable

2014-08-25 Thread Pekka Paalanen
On Fri, 22 Aug 2014 16:48:13 -0400 "Jasper St. Pierre" wrote: > On Wed, Aug 6, 2014 at 9:39 AM, Pekka Paalanen wrote: > > > On Thu, 17 Jul 2014 17:57:45 -0400 > > "Jasper St. Pierre" wrote: > > > > Hi Jasper, > > > > I am not reviewing this patch now. Instead, I took xdg-shell.xml from > > Wes

[PATCH weston] Document output/scale configuration option in the weston.ini man page.

2014-08-25 Thread maghoff+wayland
From: Magnus Hoff v2: Different, hopefully better, wording. This patch entirely replaces the previous similar patch I sent. --- man/weston.ini.man | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/weston.ini.man b/man/weston.ini.man index 25da2b1..9bf53bb 100644 --- a/man/west

RE: Request help regarding building of weston module

2014-08-25 Thread gautam.h.kumar
Hello, Thanks a lot for the help pq It got rectified by following below steps 1] I rebuilt the Weston with option --disable-egl and it got rectified as below ./autogen.sh --prefix=$WLD --enable-libinput-backend --disable-setuid-install –disable-egl Still Thanks a lot for the help again

Multiple Display Support

2014-08-25 Thread Abhijit Potnis
Hello , I have a doubt regarding Wayland/Weston's support for multiple displays. I am of the assumption that "multiple display" means support of two or more monitors(or displays) simultaneously like a extended desktop mode and the ability to drag-and-drop windows from one display to the other. Am

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-25 Thread Nils Chr. Brause
On Tue, Aug 12, 2014 at 09:27:02AM +0200, Marek Chalupa wrote: > On 11 August 2014 18:02, Nils Chr. Brause wrote: > > > On Mon, Aug 11, 2014 at 08:36:51AM +0200, Marek Chalupa wrote: > > > > proxy->flags = 0; > > > > > > > > > > After memset, this line can be removed as well. > > > > > >

Re: [PATCH] desktop-shell: Replace magic constants with named ones

2014-08-25 Thread Nils Chr. Brause
This looks much more readable to me. Unnamed magic numbers are always confusing. Reviewed-by: Nils Chr. Brause On Thu, Aug 21, 2014 at 3:47 PM, Ondřej Majerech wrote: > Signed-off-by: Ondřej Majerech > --- > desktop-shell/shell.c | 11 +-- > 1 file changed, 9 insertions(+), 2 delet

Re: Request help regarding building of weston module

2014-08-25 Thread Pekka Paalanen
On Mon, 25 Aug 2014 07:32:10 + wrote: > Hello, > > I am trying to build the weston module and its giving below Someone has any > idea ?? > > Steps to reproduce > > 1. git clone http://anongit.freedesktop.org/git/wayland/weston.git > > 2. cd weston > > 3. ./autogen.sh --pr

Re: [PATCH] xwayland: Use frame geometry for resizing shell surface

2014-08-25 Thread Nils Chr. Brause
I also noticed this in current master. This seems to fix the problem. :) Reviewed-by: Nils Chr. Brause On Thu, Aug 21, 2014 at 2:51 AM, Ondřej Majerech wrote: > We want to set the size of the entire window, not just the input area. > This fixes the bug where resizing an X client under XWayla

Request help regarding building of weston module

2014-08-25 Thread gautam.h.kumar
Hello, I am trying to build the weston module and its giving below Someone has any idea ?? Steps to reproduce 1. git clone http://anongit.freedesktop.org/git/wayland/weston.git 2. cd weston 3. ./autogen.sh --prefix=$WLD --enable-libinput-backend –disable-setuid-install 4.