The only thing that desktop_shell_client_destroy() do is setting
shell->child.client NULL, and is also done by desktop_shell_sigchld().
Getting rid of it and the shell client's destroy_listener is safe and
avoids a handful of race conditions.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=829
On 08/22/2014 06:16 PM, Peter Hutterer wrote:
My main point is I don't think you need to distinguish enabled from
"smart" enabled. The smartness is in the device driver and could be
considered part of how it generates events, and there should be no
reason to turn it off.
only if our palm det
On 23/08/2014 06:03 , Bill Spitzak wrote:
I was imagining a trackpad that is not "smart" and somebody wants to
define a global hotkey to turn it off because they keep getting unwanted
events. The disable state would allow this to be done without rewriting
the trackpad driver.
My main point is I
That's the intent, but the patch as is introduces a new bug - now we can
have a double free somewhere else. :(
Removing the notifier from the list in the sigchld handler may be a
better solution (a quick test appears ok), but I think there's still a
tiny window where sigchld can fire just before t
On Aug 19, 2014 5:04 AM, "Pekka Paalanen" wrote:
>
> On Wed, 6 Aug 2014 19:07:50 -0400
> Stephen Chandler Paul wrote:
>
> > Hi! As some of you have been aware, I have been working on implementing
tablet
> > ssupport in libinput, the wayland protocol and weston. This patchset
adds basic
> > table
Does this fix https://bugs.freedesktop.org/show_bug.cgi?id=82957 ?
U. Artie
> -Original Message-
> From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On
> Behalf Of Derek Foreman
> Sent: Friday, August 22, 2014 2:20 PM
> To: wayland-devel@lists.freedesktop.org
When desktop-shell's sigchld handler attempts to re-launch
weston-desktop-shell it also registers a destroy notifier.
This destroy notifier may still be on another linked list - their does not
appear to be any guarantee that the destroy hander will have been called
before the cleanup callback.
So
On Wed, Aug 6, 2014 at 9:39 AM, Pekka Paalanen wrote:
> On Thu, 17 Jul 2014 17:57:45 -0400
> "Jasper St. Pierre" wrote:
>
> Hi Jasper,
>
> I am not reviewing this patch now. Instead, I took xdg-shell.xml from
> Weston master as today, and I'm giving comments on it, as you have
> declared it prac
I was imagining a trackpad that is not "smart" and somebody wants to
define a global hotkey to turn it off because they keep getting unwanted
events. The disable state would allow this to be done without rewriting
the trackpad driver.
My main point is I don't think you need to distinguish enab
On Fri, Aug 22, 2014 at 9:08 AM, Pekka Paalanen wrote:
> Hi,
>
> here is the alpha release on our road to 1.6.0:
>
> 0b0513706eee5a43d33f5e4bc9cafa5d78037db5 wayland-1.5.91.tar.xz
> 6d0f298665e0f6b11a18ab6b6ccc49ba990b4b3e wayland 1.5.91 tag
>
> 59b3f1fa9456ed9cf6b21201647ce3a96c91e03b w
As I mentioned on IRC, I don't really like adding and using an enum value
without bumping protocol version. However, the only time we ever use it is
to kill the client so the worst thing that can happen is that the client
doesn't report the error correctly. I think I'm ok with it.
--Jason Ekstran
This will be used by implementations to send out errors if clients try
to set roles on surfaces that already have roles.
---
protocol/wayland.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index bb457bc..f6eb54d 100644
--- a/protocol/wayland.xml
---
desktop-shell/shell.c | 35 ++-
src/compositor.c | 25 +++--
src/compositor.h | 6 ++
src/data-device.c | 9 -
src/input.c | 9 ++---
5 files changed, 41 insertions(+), 43 deletions(-)
diff --git a/
Hi,
here is the alpha release on our road to 1.6.0:
0b0513706eee5a43d33f5e4bc9cafa5d78037db5 wayland-1.5.91.tar.xz
6d0f298665e0f6b11a18ab6b6ccc49ba990b4b3e wayland 1.5.91 tag
59b3f1fa9456ed9cf6b21201647ce3a96c91e03b weston-1.5.91.tar.xz
652c794b5d54d4c3eb849746e1372bcb9c4d96d3 weston
On Thu, 21 Aug 2014 13:57:58 -0500
Derek Foreman wrote:
> And here's a second round with free()s for the asprintf()s.
>
>
> On 21/08/14 11:46 AM, Derek Foreman wrote:
> > This is my first attempt at a patch to allow running weston-keyboard,
> > desktop-shell and screenshooter out of the build d
From: kabeer
window: use data_device interface destructor
data-device: implement data_device_release destructor
Signed-off-by: kabeer
---
clients/window.c |2 +-
src/data-device.c |6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/clients/window.c b/clients/windo
From: kabeer
Signed-off-by: kabeer
---
protocol/wayland.xml |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index bb457bc..1d3b24f 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -517,7 +517,7 @@
Hi everyone,
If you are willing to give a talk at XDC2014 and require travel
sponsorship, please send an email to bo...@foundation.x.org (CC:
martin.pe...@free.fr) with an estimate of the travel + accommodation
cost and the abstract of your talk.
Please send us your applications as soon as p
On Fri, 22 Aug 2014 14:28:59 +0200
Marek Chalupa wrote:
> This prevents from blocking shown in one display test. Also, it
> makes sense to not proceed further in the code of the function
> when an error ocurred.
>
> v2. set errno
> put note about the errno into wl_display_prepare_read doc
>
Looks OK to me
Reviewed-by: Marek Chalupa
On 20 August 2014 11:21, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> According to
>
> http://www.gnu.org/software/automake/manual/html_node/Checking-the-Distribution.html
> the DISTCHECK_CONFIGURE_FLAGS is for the user, while
> AM_DISTCHECK_CONFI
This prevents from blocking shown in one display test. Also, it
makes sense to not proceed further in the code of the function
when an error ocurred.
v2. set errno
put note about the errno into wl_display_prepare_read doc
check for error with mutex locked
v3.
set errno to display->las
On Tue, 5 Aug 2014 11:42:01 +0200
Marek Chalupa wrote:
> In previous commit we removed unused variables. One of them was
> pthread_cond_t that was formerly used when reading from display, but
> later was (erroneously) made unused. This patch fixes this error
> and is a fix for the failing test i
On 22 August 2014 12:56, Pekka Paalanen wrote:
> On Fri, 18 Jul 2014 17:56:36 +0200
> Marek Chalupa wrote:
>
> > We won't receive any response anyway...
> >
> > This removes the last line of:
> >
> > [2230782.435] wl_display@1.error(wl_display@1, 2, "no memory")
> > wl_display@1: error 2: no mem
This prevents from blocking shown in one display test. Also, it
makes sense to not proceed further in the code of these function
when an error occurred.
v2. set errno
put note about the errno into doc
check for error with mutex locked
Signed-off-by: Marek Chalupa
---
src/wayland-client.
On 22 August 2014 13:01, Pekka Paalanen wrote:
> On Fri, 22 Aug 2014 12:52:09 +0200
> Marek Chalupa wrote:
>
> > On 22 August 2014 12:40, Pekka Paalanen wrote:
> >
> > > On Tue, 5 Aug 2014 11:43:35 +0200
> > > Marek Chalupa wrote:
> > >
> > > > This prevents from blocking shown in one display
On Fri, 22 Aug 2014 12:52:09 +0200
Marek Chalupa wrote:
> On 22 August 2014 12:40, Pekka Paalanen wrote:
>
> > On Tue, 5 Aug 2014 11:43:35 +0200
> > Marek Chalupa wrote:
> >
> > > This prevents from blocking shown in one display test. Also, it
> > > makes sense to not proceed further in the c
On Fri, 18 Jul 2014 17:56:36 +0200
Marek Chalupa wrote:
> We won't receive any response anyway...
>
> This removes the last line of:
>
> [2230782.435] wl_display@1.error(wl_display@1, 2, "no memory")
> wl_display@1: error 2: no memory
> [2230782.534] -> wl_disp...@1.sync(new id wl_callback@3)
On 22 August 2014 12:40, Pekka Paalanen wrote:
> On Tue, 5 Aug 2014 11:43:35 +0200
> Marek Chalupa wrote:
>
> > This prevents from blocking shown in one display test. Also, it
> > makes sense to not proceed further in the code of these function
> > when an error occurred.
> > ---
> > src/wayla
On Tue, 5 Aug 2014 11:43:35 +0200
Marek Chalupa wrote:
> This prevents from blocking shown in one display test. Also, it
> makes sense to not proceed further in the code of these function
> when an error occurred.
> ---
> src/wayland-client.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> d
On 22 August 2014 11:50, Pekka Paalanen wrote:
> On Fri, 22 Aug 2014 09:42:16 +0200
> Marek Chalupa wrote:
>
> > On 21 August 2014 15:15, Pekka Paalanen wrote:
> >
> > > On Wed, 25 Jun 2014 14:35:16 +0200
> > > Marek Chalupa wrote:
> > >
> > > > Test if events are going to the right queue and
This adds a function weston_keyboard_set_locks() which can be used to
change the state of the num lock and the caps locks, changing the leds too.
Only the evdev and libinput backends supports this, since it doesn't make
sense for embedded sessions.
---
v3: forgot semicolon
src/compositor.h | 10
On Thu, 21 Aug 2014 16:52:16 +0200
Marek Chalupa wrote:
> This patch introduces a set of functions that can create a display
> and clients for tests.
> On server side the user can use functions:
> display_create()
> display_destroy()
> create_client()
> display_run()
> display_resume()
On Fri, 22 Aug 2014 09:42:16 +0200
Marek Chalupa wrote:
> On 21 August 2014 15:15, Pekka Paalanen wrote:
>
> > On Wed, 25 Jun 2014 14:35:16 +0200
> > Marek Chalupa wrote:
> >
> > > Test if events are going to the right queue and if the queue
> > > is interrupted from polling when an error to t
On Tue, 19 Aug 2014 17:40:20 +0530
kabeer.k...@samsung.com wrote:
> From: "kabeer.khan"
>
> This is a fix to Bug# 81745
>
> Signed-off-by: kabeer
> ---
> protocol/wayland.xml |9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/protocol/wayland.xml b/protocol/
On Fri, 22 Aug 2014 10:13:52 +0300
Giulio Camuffo wrote:
> 2014-08-21 17:12 GMT+03:00 Pekka Paalanen :
> > On Thu, 21 Aug 2014 08:37:17 +0100
> > Daniel Stone wrote:
> >
> >> Hi,
> >> Last nitpick, sorry ...
> >>
> >> On Wednesday, August 20, 2014, Giulio Camuffo
> >> wrote:
> >> >
> >> > +
On Thu, 21 Aug 2014 17:57:30 +0300
Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> The experimental versioning has not been updated when it was supposed
> to. Let's try to be better at it now, as xdg-shell is close to have
> its first stable version.
>
> Bump the version now to bring the worl
Add a new "numlock-on" option in the [keyboard] section of weston.ini
which, if set to true, is used to enable the numlock of the keyboards
attached at startup.
---
man/weston.ini.man | 6 ++
src/compositor.c | 13 +
2 files changed, 19 insertions(+)
diff --git a/man/weston.ini
This adds a function weston_keyboard_set_locks() which can be used to
change the state of the num lock and the caps locks, changing the leds too.
Only the evdev and libinput backends supports this, since it doesn't make
sense for embedded sessions.
---
v2: -renamed weston_keyboard_set_leds() to we
On Thu, 21 Aug 2014 09:08:56 -0700
Jason Ekstrand wrote:
> That applies to the whole series, BTW
>
>
> On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand
> wrote:
>
> > LGTM
> > Reviewed-by: Jason Ekstrand
Thank you, Jason. :-)
Jasper already acked this in irc, but I would like to get an offi
On Thu, 21 Aug 2014 09:05:48 -0700
Jason Ekstrand wrote:
> On Thu, Aug 21, 2014 at 4:00 AM, Pekka Paalanen
> wrote:
>
> > On Thu, 7 Aug 2014 09:55:49 -0400
> > "Jasper St. Pierre" wrote:
> >
> > > The idea here was that once upon a time, clients could rebind
> > > wl_display to a higher versi
On 21 August 2014 15:15, Pekka Paalanen wrote:
> On Wed, 25 Jun 2014 14:35:16 +0200
> Marek Chalupa wrote:
>
> > Test if events are going to the right queue and if the queue
> > is interrupted from polling when an error to the main queue comes.
> > The last one is failing.
> > ---
> > tests/que
2014-08-21 17:12 GMT+03:00 Pekka Paalanen :
> On Thu, 21 Aug 2014 08:37:17 +0100
> Daniel Stone wrote:
>
>> Hi,
>> Last nitpick, sorry ...
>>
>> On Wednesday, August 20, 2014, Giulio Camuffo
>> wrote:
>> >
>> > + mods_depressed =
>> > xkb_state_serialize_mods(keyboard->xkb_state.state,
>> >
42 matches
Mail list logo
