On Thu, Aug 21, 2014 at 06:35:57PM -0700, Bill Spitzak wrote:
> Seems to me you only need two states: what you call disabled and what you
> are calling "smart disable".
>
> The fully disabled is so a button the hardware does not know about can
> disable the device. Or a wayland compositor could us
On Thu, Aug 21, 2014 at 9:29 PM, Bill Spitzak wrote:
> On 08/21/2014 04:30 PM, Jasper St. Pierre wrote:
>
> How do you create more than one copy of the role object in the first
>> place?
>>
>
> I thought you could create any number of wl_shell_surface objects for the
> same wl_surface.
>
No, yo
Seems to me you only need two states: what you call disabled and what
you are calling "smart disable".
The fully disabled is so a button the hardware does not know about can
disable the device. Or a wayland compositor could use a mouse being
added to disable the device.
But the "smart disabl
On 08/21/2014 04:30 PM, Jasper St. Pierre wrote:
How do you create more than one copy of the role object in the first place?
I thought you could create any number of wl_shell_surface objects for
the same wl_surface.
May also be really nasty if a former object-less role is updated
w
On Thu, Aug 21, 2014 at 09:36:57PM +0200, Jonas Ådahl wrote:
> On Wed, Aug 20, 2014 at 01:18:51PM +1000, Peter Hutterer wrote:
> > Does what it says on the box, preventing events from the device without
> > actually
> > dropping the device from the context.
> >
> > Signed-off-by: Peter Hutterer
On Thu, Aug 21, 2014 at 10:16:49PM +0200, Jonas Ådahl wrote:
> On Thu, Aug 21, 2014 at 04:18:41PM +1000, Peter Hutterer wrote:
> > replying to myself, now that I've had a bit of a think about this all.
> >
> > On Wed, Aug 20, 2014 at 01:18:48PM +1000, Peter Hutterer wrote:
> > > This patchset adds
On Thu, Aug 21, 2014 at 7:18 PM, Bill Spitzak wrote:
>
>
> On 08/21/2014 02:52 AM, Pekka Paalanen wrote:
>
> + Destroying the role object does not remove the role from the
>> + wl_surface, but it may stop the wl_surface from "playing the role".
>> + For instance, if a wl_subsurfac
On 08/21/2014 02:52 AM, Pekka Paalanen wrote:
+ Destroying the role object does not remove the role from the
+ wl_surface, but it may stop the wl_surface from "playing the role".
+ For instance, if a wl_subsurface object is destroyed, the wl_surface
+ it was created for wil
Constrain it so that both the grabbed point and the nearest point on the
edge cannot go under the panel.
A radius about the cursor does not work because if they grab the
titlebar too close to the top they can't put the window all the way up
against the edge (Unity has this bug and it triggers
On Tue, 2014-08-19 at 16:57 +0300, Pekka Paalanen wrote:
> On Tue, 19 Aug 2014 13:21:54 +0200
> Jonas Ådahl wrote:
>
> > On Tue, Aug 19, 2014 at 01:03:52PM +0300, Pekka Paalanen wrote:
> > > On Wed, 6 Aug 2014 19:07:50 -0400
> > > Stephen Chandler Paul wrote:
> > >
> > > > Hi! As some of you h
On Thu, Aug 21, 2014 at 04:18:41PM +1000, Peter Hutterer wrote:
> replying to myself, now that I've had a bit of a think about this all.
>
> On Wed, Aug 20, 2014 at 01:18:48PM +1000, Peter Hutterer wrote:
> > This patchset adds two new API hooks, libinput_device_suspend() and
> > libinput_device_r
On Wed, Aug 20, 2014 at 01:18:51PM +1000, Peter Hutterer wrote:
> Does what it says on the box, preventing events from the device without
> actually
> dropping the device from the context.
>
> Signed-off-by: Peter Hutterer
> ---
> See my notes in the coverletter. For the T440 case I specifically
On Wed, Aug 20, 2014 at 01:18:55PM +1000, Peter Hutterer wrote:
> When we're suspending a touchpad, several events triggered by timers may still
> be waiting in the background. We still need to release all buttons/keys
> immediately though so we get an uneven number of release events: one from
> re
On Wed, Aug 20, 2014 at 01:18:54PM +1000, Peter Hutterer wrote:
> We only called this function before device removal, so failing to update the
> button state didn't matter. To make this function generic for the upcoming
> device suspend/resume, we need to keep track of the button/key count properly
And here's a second round with free()s for the asprintf()s.
On 21/08/14 11:46 AM, Derek Foreman wrote:
> This is my first attempt at a patch to allow running weston-keyboard,
> desktop-shell and screenshooter out of the build directory so make check
> doesn't do funny things...
>
>
>
> ___
This is my first attempt at a patch to allow running weston-keyboard,
desktop-shell and screenshooter out of the build directory so make check
doesn't do funny things...
>From a97352451bff6398edace74defca67e18c92bb98 Mon Sep 17 00:00:00 2001
From: Derek Foreman
Date: Thu, 21 Aug 2014 11:32:38 -050
On Thu, Aug 21, 2014 at 4:00 AM, Pekka Paalanen wrote:
> On Thu, 7 Aug 2014 09:55:49 -0400
> "Jasper St. Pierre" wrote:
>
> > The idea here was that once upon a time, clients could rebind wl_display
> > to a higher version, so we offered the ability to rebind it
> > here. However, this is parti
That applies to the whole series, BTW
On Thu, Aug 21, 2014 at 9:03 AM, Jason Ekstrand
wrote:
> LGTM
> Reviewed-by: Jason Ekstrand
>
>
> On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen
> wrote:
>
>> From: Pekka Paalanen
>>
>> Define what a role is, and what restrictions there are.
>>
>> A cha
LGTM
Reviewed-by: Jason Ekstrand
On Thu, Aug 21, 2014 at 2:52 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> Define what a role is, and what restrictions there are.
>
> A change to existing behaviour is that a role cannot be changed at all
> once set. However, this is unlikely to cause
From: Pekka Paalanen
The experimental versioning has not been updated when it was supposed
to. Let's try to be better at it now, as xdg-shell is close to have its
first stable version.
Bump the version now to bring the world into the same exact version.
There may be some protocol changes still
From: Olivier Blin
The wl_event_queue cond variable has been replaced by the wl_display
reader_cond variable (commit 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305).
This cond variable is never waited for anymore, just
signaled/broadcasted, and thus can be safely removed.
The wl_display event_queue_li
Most of the code of the queue-test is covered by the test compositor,
so we can save few lines and use the test compositor instead.
I think it's also more readable.
This patch removes timeout from the test. We plan to add timeout
to all tests later, though.
v2.
rebased to master
Signed-off-by:
This patch introduces a set of functions that can create a display
and clients for tests.
On server side the user can use functions:
display_create()
display_destroy()
create_client()
display_run()
display_resume()
and on client side the user can use:
client_connect()
client_disconnec
On Thu, 21 Aug 2014 08:37:17 +0100
Daniel Stone wrote:
> Hi,
> Last nitpick, sorry ...
>
> On Wednesday, August 20, 2014, Giulio Camuffo
> wrote:
> >
> > + mods_depressed =
> > xkb_state_serialize_mods(keyboard->xkb_state.state,
> > + XKB_STAT
Hi Pekka,
On Thu, 21 Aug 2014, Pekka Paalanen wrote:
On Thu, 26 Jun 2014 16:31:43 +0100
Andrew Wedgbury wrote:
This adds a description of the screen-share command configuration key to the
weston.ini man page.
Signed-off-by: Andrew Wedgbury
---
man/weston.ini.man | 10 ++
1 file ch
On Tue, 5 Aug 2014 11:43:35 +0200
Marek Chalupa wrote:
> This prevents from blocking shown in one display test. Also, it
> makes sense to not proceed further in the code of these function
> when an error occurred.
> ---
> src/wayland-client.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> d
Signed-off-by: Ondřej Majerech
---
desktop-shell/shell.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
index e3abaad..02e180d 100644
--- a/desktop-shell/shell.c
+++ b/desktop-shell/shell.c
@@ -1884,13 +1884,20 @@ surf
On Tue, 5 Aug 2014 11:39:49 +0200
Marek Chalupa wrote:
> wl_display_read_events() can make a thread wait until some other thread
> ends reading. Normally it wakes up all threads after the reading is
> done. But there's a place when it does not get to waking up the threads
> - when an error occur
On Wed, 25 Jun 2014 14:35:16 +0200
Marek Chalupa wrote:
> Test if events are going to the right queue and if the queue
> is interrupted from polling when an error to the main queue comes.
> The last one is failing.
> ---
> tests/queue-test.c | 128
> +
On 21 August 2014 13:17, Giulio Camuffo wrote:
> 2014-08-21 15:06 GMT+03:00 Daniel Stone :
> > On 21 August 2014 08:58, Giulio Camuffo wrote:
> >> Switching VT is another matter, because all the keyboard devices are
> >> removed so the xkb state is lost, so when returning to weston's vt we
> >>
2014-08-21 15:06 GMT+03:00 Daniel Stone :
> Hi,
>
> On 21 August 2014 08:58, Giulio Camuffo wrote:
>>
>> 2014-08-21 10:34 GMT+03:00 Daniel Stone :
>> > Ugh. If you've your own kernel to hand, I'd hack it to WARN_ON(1) on LED
>> > updates, so you can track where the rogue update is coming from. My
Hi,
On 21 August 2014 08:58, Giulio Camuffo wrote:
> 2014-08-21 10:34 GMT+03:00 Daniel Stone :
> > Ugh. If you've your own kernel to hand, I'd hack it to WARN_ON(1) on LED
> > updates, so you can track where the rogue update is coming from. My
> guess is
> > that switching VT breaks it, so it mi
On Thu, 21 Aug 2014 12:07:08 +0200
Marek Chalupa wrote:
> display_thread variable is unused since
> 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305
>
> Signed-off-by: Marek Chalupa
> ---
> src/wayland-client.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/wayland-client.c b/src/wayland
On Fri, 11 Jul 2014 12:33:02 +0200
Marek Chalupa wrote:
> and post client_no_memory if is...
> ---
> tests/weston-test.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/weston-test.c b/tests/weston-test.c
> index 44875a6..cc937e5 100644
> --- a/tests/weston-test.c
> +++ b/te
On Thu, 26 Jun 2014 16:31:43 +0100
Andrew Wedgbury wrote:
> This adds a description of the screen-share command configuration key to the
> weston.ini man page.
>
> Signed-off-by: Andrew Wedgbury
> ---
> man/weston.ini.man | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/m
2014-08-21 10:31 GMT+03:00 Daniel Stone :
> Hi,
>
>
> On Wednesday, August 20, 2014, Giulio Camuffo
> wrote:
>>
>> Add a new "numlock-on" option in the [keyboard] section of weston.ini
>> which, if set to true, is used to enable the numlock of the keyboards
>> attached at startup.
>
>
> I'm fine w
On Thu, 7 Aug 2014 09:55:49 -0400
"Jasper St. Pierre" wrote:
> The idea here was that once upon a time, clients could rebind wl_display
> to a higher version, so we offered the ability to rebind it
> here. However, this is particularly broken. The existing bind
> implementation actually still ha
On Thu, 21 Aug 2014 11:42:03 +0800
Boyan Ding wrote:
> Hi,
>
> On Wed, 2014-08-20 at 17:50 +0300, Pekka Paalanen wrote:
> > Hi,
> >
> > on first glance, it looks like this completely ignores window rotation,
> > but when I briefly tested on a rotated window, it seemed work well
> > enough! :-o
Earlier, the wl_display_dispatch_pending were setting number of thread
that can dispatch events. This behaviour was removed later,
so now these lines are redundant.
Related commits:
385fe30e8b144a968aa88c6546c2ef247771b3d7
78cfa967681c965d23f6cbf76e080bbb0b564ff6
3c7e8bfbb4745315b7bcbf69fa746c3d6
display_thread variable is unused since
3c7e8bfbb4745315b7bcbf69fa746c3d6718c305
Signed-off-by: Marek Chalupa
---
src/wayland-client.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/wayland-client.c b/src/wayland-client.c
index 15a5acc..2252424 100644
--- a/src/wayland-client.c
+++ b/src
Destroy all objects that we have created
Signed-off-by: Marek Chalupa
---
tests/queue-test.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/queue-test.c b/tests/queue-test.c
index f7ebc2b..3de8924 100644
--- a/tests/queue-test.c
+++ b/tests/queue-test.c
@@ -86,6 +86,8 @@ client_t
From: Pekka Paalanen
Now that we have defined "role", use the term.
Signed-off-by: Pekka Paalanen
---
protocol/wayland.xml | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 621c64d..89f7c0e 100644
--- a/protocol/wayland.xm
From: Pekka Paalanen
Define what a role is, and what restrictions there are.
A change to existing behaviour is that a role cannot be changed at all
once set. However, this is unlikely to cause problems, as there is no
reason to re-use wl_surfaces in clients.
v2: give more concrete examples of r
From: Pekka Paalanen
Reword the conditions to make use of the definition of "role".
It is still forbidden to create more than one wl_subsurface for a
wl_surface at a time.
Signed-off-by: Pekka Paalanen
---
protocol/wayland.xml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
From: Pekka Paalanen
Now that we have defined "role", use the term.
Signed-off-by: Pekka Paalanen
---
protocol/wayland.xml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 89f7c0e..71293dd 100644
--- a/protocol/wayland.xml
From: Pekka Paalanen
Now that we have defined "role", use the term.
Signed-off-by: Pekka Paalanen
---
protocol/wayland.xml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index ddf94a3..3645208 100644
--- a/protocol/wayland.xml
On Thu, 21 Aug 2014 09:11:22 +1200
Robert Ancell wrote:
> Bill's patch looks a lot more comprehensive, I'd use that one.
Ok, thank you.
- pq
> On 21 August 2014 00:37, Pekka Paalanen wrote:
>
> > On Fri, 20 Jun 2014 15:23:59 +1200
> > Robert Ancell wrote:
> >
> > > I'm not sure if the expec
On Mon, 7 Jul 2014 12:11:08 +0800
Guangyu Zhang wrote:
> ./message-test is generated by libtool and should be ignored by git.
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index c146bac..d9d26ed 100644
> --- a/.gitignore
> +++ b/.gitignor
On Thu, 21 Aug 2014 11:05:24 +0200
Marek Chalupa wrote:
> The issues I pointed out are not anything big. I'll send a patch that
> removes wl_display_dispatch_pending from both test-cases and I noticed that
> there are more leaks it the queue-test, so I'll get rid of them all in
> another patch if
On Wed, 20 Aug 2014 10:26:48 -0400
"Jasper St. Pierre" wrote:
> On Wed, Aug 20, 2014 at 7:09 AM, Pekka Paalanen wrote:
>
> > From: Pekka Paalanen
> >
> > Define what a role is, and what restrictions there are.
> >
> > A change to existing behaviour is that a role cannot be changed at all
> > o
The issues I pointed out are not anything big. I'll send a patch that
removes wl_display_dispatch_pending from both test-cases and I noticed that
there are more leaks it the queue-test, so I'll get rid of them all in
another patch if it's OK :)
Thanks,
Marek
On 21 August 2014 10:57, Pekka Paala
On Thu, 21 Aug 2014 10:46:55 +0200
Marek Chalupa wrote:
> Hi,
>
>
> On 20 August 2014 18:29, Giulio Camuffo wrote:
>
> > ---
> > tests/queue-test.c | 62
> > ++
> > 1 file changed, 62 insertions(+)
> >
> > diff --git a/tests/queue-test.c b/
On Wed, 20 Aug 2014 19:29:10 +0300
Giulio Camuffo wrote:
> ---
> tests/queue-test.c | 62
> ++
> 1 file changed, 62 insertions(+)
>
> diff --git a/tests/queue-test.c b/tests/queue-test.c
> index a4b165d..fc8a920 100644
> --- a/tests/queue-tes
On Thu, 21 Aug 2014 00:25:36 +0900
Ryo Munakata wrote:
> Signed-off-by: Ryo Munakata
> ---
> protocol/wayland.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 2d57f69..bb457bc 100644
> --- a/protocol/wayland.xml
>
Hi,
On 20 August 2014 18:29, Giulio Camuffo wrote:
> ---
> tests/queue-test.c | 62
> ++
> 1 file changed, 62 insertions(+)
>
> diff --git a/tests/queue-test.c b/tests/queue-test.c
> index a4b165d..fc8a920 100644
> --- a/tests/queue-test.c
>
2014-08-21 10:34 GMT+03:00 Daniel Stone :
> Hi,
>
>
> On Wednesday, August 20, 2014, Giulio Camuffo
> wrote:
>>
>> When a new keyboard is found (including during startup) sync its leds
>> with the internal state of the xkb map.
>> It appears that by setting them immediately when getting the new de
Hi,
Last nitpick, sorry ...
On Wednesday, August 20, 2014, Giulio Camuffo
wrote:
>
> + mods_depressed =
> xkb_state_serialize_mods(keyboard->xkb_state.state,
> + XKB_STATE_DEPRESSED);
> + mods_latched = xkb_state_serialize_mods(keyboard->x
Hi,
On Wednesday, August 20, 2014, Giulio Camuffo
wrote:
> When a new keyboard is found (including during startup) sync its leds
> with the internal state of the xkb map.
> It appears that by setting them immediately when getting the new device
> we're racing with the kernel or something, which
Hi,
On Wednesday, August 20, 2014, Giulio Camuffo
wrote:
> Add a new "numlock-on" option in the [keyboard] section of weston.ini
> which, if set to true, is used to enable the numlock of the keyboards
> attached at startup.
>
I'm fine with this in principle, but would like to see this test if i
59 matches
Mail list logo
