Re: [PATCH libinput 0/8] Add libinput_device_suspend() to disable devices

2014-08-20 Thread Peter Hutterer
replying to myself, now that I've had a bit of a think about this all. On Wed, Aug 20, 2014 at 01:18:48PM +1000, Peter Hutterer wrote: > This patchset adds two new API hooks, libinput_device_suspend() and > libinput_device_resume() which do what it says on the box. No special event > is sent when

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Boyan Ding
Hi, On Wed, 2014-08-20 at 17:50 +0300, Pekka Paalanen wrote: > Hi, > > on first glance, it looks like this completely ignores window rotation, > but when I briefly tested on a rotated window, it seemed work well > enough! :-o > > I can't figure out why. > > Now, Boyan's patch at least tries to

[PATCH] xwayland: Use frame geometry for resizing shell surface

2014-08-20 Thread Ondřej Majerech
We want to set the size of the entire window, not just the input area. This fixes the bug where resizing an X client under XWayland would make the window snap to a smaller size, and the pointer would then stay a distance away from the frame. Signed-off-by: Ondřej Majerech --- xwayland/window-man

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Jason Ekstrand
On Wed, Aug 20, 2014 at 12:52 PM, Bill Spitzak wrote: > > > On 08/20/2014 03:06 AM, Pekka Paalanen wrote: > >> On Tue, 19 Aug 2014 13:04:54 -0700 >> Bill Spitzak wrote: >> > > Destroying the last protocol object for the role does not remove the >>> role, correct? The client can recreate a new p

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-20 Thread Robert Ancell
Bill's patch looks a lot more comprehensive, I'd use that one. Thanks, --Robert On 21 August 2014 00:37, Pekka Paalanen wrote: > On Fri, 20 Jun 2014 15:23:59 +1200 > Robert Ancell wrote: > > > I'm not sure if the expected behaviour is for: > > $ weston --shell foo.so > > to work, if so the pa

Re: wl_tablet draft v2

2014-08-20 Thread Bill Spitzak
On 08/20/2014 12:13 PM, Pekka Paalanen wrote: What would be a use case, where you might get blinking? > If the item is highlighted because an action with the input tool on any wl_surface may affect it, why remove the highlight when the input tool leaves? That describes the situation pretty

[PATCH weston 3/3] compositor: add an option to set the default numlock value

2014-08-20 Thread Giulio Camuffo
Add a new "numlock-on" option in the [keyboard] section of weston.ini which, if set to true, is used to enable the numlock of the keyboards attached at startup. --- man/weston.ini.man | 6 ++ src/compositor.c | 13 + 2 files changed, 19 insertions(+) diff --git a/man/weston.ini

[PATCH weston 2/3] compositor: add a way to change the keyboard leds

2014-08-20 Thread Giulio Camuffo
This adds a function weston_keyboard_set_leds() which can be used to change the state of the num lock and the caps lock leds. Only the evdev and libinput backends supports this, since it doesn't make sense for embedded sessions. --- src/compositor.h | 3 +++ src/input.c | 50

[PATCH weston 1/3] evdev/libinput: sync the leds of keyboards with the xkb state

2014-08-20 Thread Giulio Camuffo
When a new keyboard is found (including during startup) sync its leds with the internal state of the xkb map. It appears that by setting them immediately when getting the new device we're racing with the kernel or something, which wants to turn all the leds off, so we use a timer. --- I can't say

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Bill Spitzak
On 08/20/2014 03:06 AM, Pekka Paalanen wrote: On Tue, 19 Aug 2014 13:04:54 -0700 Bill Spitzak wrote: Destroying the last protocol object for the role does not remove the role, correct? The client can recreate a new protocol object for that role and it still works? Recreating the same role

Re: wl_tablet draft v2

2014-08-20 Thread Pekka Paalanen
On Thu, 17 Jul 2014 15:58:17 -0400 Lyude wrote: > On Thu, 2014-07-17 at 11:48 -0700, Bill Spitzak wrote: > > On 07/13/2014 12:17 PM, Lyude wrote: > > > > > - proximity_out > > > Sent whenever the tool leaves the proximity of the tablet or moves > > > out of the client surface. When the

Re: [PATCH 01/12] Fixes to parse_options

2014-08-20 Thread Bill Spitzak
On 08/20/2014 05:27 AM, Pekka Paalanen wrote: The old code basically did *(string+strlen(string)+1) if the string did not have an = sign in it, passing that pointer to the argument parser. Probably this always fails parsing without a segfault but technically it is wrong, it could segfault, or

[PATCH 1/2] client: add a public function to make a roundtrip on a custom queue

2014-08-20 Thread Giulio Camuffo
wl_display_roundtrip() works on the default queue. Add a parallel wl_display_roundtrip_queue(). --- Rebased on top of master and fixed a warning and wrong return value src/wayland-client.c | 24 +--- src/wayland-client.h | 2 ++ 2 files changed, 23 insertions(+), 3 deletions

[PATCH 2/2] tests: test the wl_display_roundtrip_queue() function

2014-08-20 Thread Giulio Camuffo
--- tests/queue-test.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/tests/queue-test.c b/tests/queue-test.c index a4b165d..fc8a920 100644 --- a/tests/queue-test.c +++ b/tests/queue-test.c @@ -158,6 +158,63 @@ client_test_multiple_queue

[PATCH] wl_surface: clarify the base of time passed in the callback of frame

2014-08-20 Thread Ryo Munakata
Signed-off-by: Ryo Munakata --- protocol/wayland.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 2d57f69..bb457bc 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -1100,7 +1100,7 @@ attempt to use it

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 15:53:21 +0200 Jonny Lamb wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=80228 > --- > desktop-shell/shell.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index e3abaad..e3241fd 100

Re: [PATCH wayland v3] protocol: define the concept of wl_surface role

2014-08-20 Thread Jasper St. Pierre
On Wed, Aug 20, 2014 at 7:09 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Define what a role is, and what restrictions there are. > > A change to existing behaviour is that a role cannot be changed at all > once set. However, this is unlikely to cause problems, as there is no > reason to

Re: [PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 15:53:20 +0200 Jonny Lamb wrote: > Now the client can let us know where the panel is using > desktop_shell.set_panel_position, we can correctly calculate where to > put new views and how big maximized views should be. > --- > desktop-shell/shell.c | 173 > +++

Re: [PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
On mer, 2014-08-20 at 16:05 +0300, Pekka Paalanen wrote: > Since 'resource' refers to a desktop_shell object, you should not use > a WL_DISPLAY_ERROR_* code, because it is in the wrong namespace. > > We will need to add an error enum into desktop_shell. I would be fine > with just one generic error

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index e3abaad..e3241fd 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1758,

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-08-20 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 173 ++ 1 file changed, 120 insertions(+),

Re: [PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 10:37:00 +0200 Jonny Lamb wrote: > Panels are always assumed to be on the top edge of the output. If this > is not the case views will be placed under the panel, wherever it is, > and maximize doesn't use the correct space allocated for views. > > By telling the server on whi

Re: [PATCH wayland v3] client: add a public function to make a roundtrip on a custom queue

2014-08-20 Thread Giulio Camuffo
2014-08-20 15:03 GMT+03:00 Pekka Paalanen : > On Mon, 14 Jul 2014 17:15:39 +0300 > Giulio Camuffo wrote: > >> wl_display_roundtrip() works on the default queue. Add a parallel >> wl_display_roundtrip_queue(). >> --- >> >> v3: fixed dispatch call in place of dispatch_queue >> documented the que

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-20 Thread Pekka Paalanen
On Fri, 20 Jun 2014 15:23:59 +1200 Robert Ancell wrote: > I'm not sure if the expected behaviour is for: > $ weston --shell foo.so > to work, if so the patch can be modified. Ah, sorry for not noticing this patch in time. What do you think of Bill's series here: http://lists.freedesktop.org/arch

Re: [PATCH v2 weston 1/2] xwm: Use cursor theme and size in weston.ini

2014-08-20 Thread Boyan Ding
On Wed, 2014-08-20 at 14:47 +0300, Pekka Paalanen wrote: > Hi, > > yeah, that's better, but I do wonder if that is actually what we want. > I see that this changes the cursors only for the decorations, but not > for the X11 apps themselves. > > So before, I think the cursors on X11 apps and decor

Re: [PATCH 01/12] Fixes to parse_options

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 12:12:28 -0700 Bill Spitzak wrote: > > On 08/19/2014 02:18 AM, Pekka Paalanen wrote: > > >> Multiple single-letter booleans in one switch allowed, ie > >> -xyz is the same as -x -y -z. For wayland modules they all have > >> to belong to the same module. > > > > This was not

RE: The road to Wayland/Weston 1.6 and 1.5.1

2014-08-20 Thread Eoff, Ullysses A
> -Original Message- > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On > Behalf Of Pekka Paalanen > Sent: Wednesday, August 20, 2014 2:49 AM > To: Eoff, Ullysses A > Cc: krh@; Jasper St. Pierre; wayland-devel@lists.freedesktop.org > Subject: Re: The road to Wayl

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
On mer, 2014-08-20 at 18:31 +0800, Boyan Ding wrote: > Well, there's been quite a few patches seeking to solve this problem. > I'm okay with any of these. Actually the ability of rotating windows in > weston makes resizing window out of screen quite easily regardless of > how you constrain pointer

Re: [PATCH wayland v3] client: add a public function to make a roundtrip on a custom queue

2014-08-20 Thread Pekka Paalanen
On Mon, 14 Jul 2014 17:15:39 +0300 Giulio Camuffo wrote: > wl_display_roundtrip() works on the default queue. Add a parallel > wl_display_roundtrip_queue(). > --- > > v3: fixed dispatch call in place of dispatch_queue > documented the queue parameter > src/wayland-client.c | 24

Re: [PATCH v2 weston 1/2] xwm: Use cursor theme and size in weston.ini

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 17:46:58 +0800 Boyan Ding wrote: > to make it consistent with native wayland apps > > v2: use the config in weston_compositor instead of reparsing weston.ini > Signed-off-by: Boyan Ding > --- > xwayland/window-manager.c | 17 + > 1 file changed, 9 insertions

Re: [PATCH weston] weston.ini.man: Add libinput section

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 21:56:12 +0200 Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > man/weston.ini.man | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/man/weston.ini.man b/man/weston.ini.man > index fbcec81..4be752b 100644 > --- a/man/weston.ini.man > +++ b/man/

[PATCH wayland v3] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
From: Pekka Paalanen Define what a role is, and what restrictions there are. A change to existing behaviour is that a role cannot be changed at all once set. However, this is unlikely to cause problems, as there is no reason to re-use wl_surfaces in clients. v2: give more concrete examples of r

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Wed, 20 Aug 2014 13:26:44 +0300 Pekka Paalanen wrote: > On Tue, 19 Aug 2014 10:16:34 -0700 > Jason Ekstrand wrote: > > > Pekka, > > I have one nitpick below. However, if we can't find a good solution, I'm > > ok with pushing as-is. > > > > Reviewed-by: Jason Ekstrand > > > > > > On Tue,

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Boyan Ding
Well, there's been quite a few patches seeking to solve this problem. I'm okay with any of these. Actually the ability of rotating windows in weston makes resizing window out of screen quite easily regardless of how you constrain pointer position but resizing it easily under the panel is really ann

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 10:16:34 -0700 Jason Ekstrand wrote: > Pekka, > I have one nitpick below. However, if we can't find a good solution, I'm > ok with pushing as-is. > > Reviewed-by: Jason Ekstrand > > > On Tue, Aug 19, 2014 at 1:41 AM, Pekka Paalanen wrote: > > > On Tue, 19 Aug 2014 10:29

Re: [PATCH weston 2/2] build: do not run xwayland test for distcheck

2014-08-20 Thread Boyan Ding
These two patches are Reviewed-by: Boyan Ding On Wed, 2014-08-20 at 12:21 +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > The Xwayland test has been broken ever since the migration to the > stand-alone Xwayland server binary. > > Disable the test, so 'make distcheck' can actually run.

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 13:04:54 -0700 Bill Spitzak wrote: > On 08/19/2014 12:29 AM, Pekka Paalanen wrote: > > > + Often, this > > + request also creates a new protocol object that represents the > > + role and adds additional functionality to wl_surface. When a > > + client want

Re: The road to Wayland/Weston 1.6 and 1.5.1

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 16:36:19 + "Eoff, Ullysses A" wrote: > > -Original Message- > > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > > Sent: Monday, August 18, 2014 4:36 AM > > To: wayland-devel@lists.freedesktop.org; krh@ > > Cc: Eoff, Ullysses A; Peter Hutterer; Jasper St. Pierre

[PATCH v2 weston 1/2] xwm: Use cursor theme and size in weston.ini

2014-08-20 Thread Boyan Ding
to make it consistent with native wayland apps v2: use the config in weston_compositor instead of reparsing weston.ini Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/xwayland/window-manager.c b/xwaylan

[PATCH weston] desktop-shell: implement touch popup grabs

2014-08-20 Thread Jonny Lamb
--- desktop-shell/shell.c | 155 ++ 1 file changed, 143 insertions(+), 12 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index ec72287..db7841a 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -223,9 +223,11

[PATCH weston 2/2] build: do not run xwayland test for distcheck

2014-08-20 Thread Pekka Paalanen
From: Pekka Paalanen The Xwayland test has been broken ever since the migration to the stand-alone Xwayland server binary. Disable the test, so 'make distcheck' can actually run. Signed-off-by: Pekka Paalanen --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH weston 1/2] build: use AM_DISTCHECK_CONFIGURE_FLAGS

2014-08-20 Thread Pekka Paalanen
From: Pekka Paalanen According to http://www.gnu.org/software/automake/manual/html_node/Checking-the-Distribution.html the DISTCHECK_CONFIGURE_FLAGS is for the user, while AM_DISTCHECK_CONFIGURE_FLAGS is the one to use in Makefile.am. Make it so. Signed-off-by: Pekka Paalanen --- Makefile.am

Re: [PATCH v2 2/2] Don't underrun the vertex array of empty polygons

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 15:59:45 +0200 Ondřej Majerech wrote: > This silences the following warning: > src/vertex-clipping.c:196:22: warning: array subscript is below array > bounds [-Warray-bounds] > ctx->prev.x = src->x[src->n - 1]; > > Signed-off-by: Ondřej Majerech > --- > src/vertex-c

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-08-20 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-08-20 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 173 ++ 1 file changed, 120 insertions(+),

[PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

2014-08-20 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 9cb81d5..b9d5f39 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -1758,

Re: [PATCH weston 1/2] Replace deprecated xkbcommon symbols with current names

2014-08-20 Thread Daniel Stone
Hi, On 19 August 2014 13:59, Ran Benita wrote: > These symbols (xkb_map_* and others) were replaced in xkbcommon with more > consistent names. See the header xkbcommon/xkbcommon-compat.h for how > the old names map to the new. > > The new names have been available since the first stable xkbcommo

Re: [PATCH 2/2] compositor: add a way to change the keyboard leds

2014-08-20 Thread Giulio Camuffo
2014-08-20 10:40 GMT+03:00 Daniel Stone : > Hi, > > On 19 August 2014 11:25, Giulio Camuffo wrote: >> >> This adds a function weston_keyboard_set_leds() which can be used >> to change the state of the num lock and the caps lock leds. >> Only the evdev backend supports this, since it doesn't make s

Re: [PATCH 2/2] compositor: add a way to change the keyboard leds

2014-08-20 Thread Daniel Stone
Hi, On 19 August 2014 11:25, Giulio Camuffo wrote: > This adds a function weston_keyboard_set_leds() which can be used > to change the state of the num lock and the caps lock leds. > Only the evdev backend supports this, since it doesn't make sense > for embedded sessions. > This is missing the

Re: [PATCH 1/2] evdev: turn off all the leds at startup

2014-08-20 Thread Daniel Stone
Hi, On 19 August 2014 11:25, Giulio Camuffo wrote: > the internal state in xkbcommon is off for all the three leds, so > make them be in sync. > This should only trigger if seat->keyboard is NULL beforehand (is the first keyboard); if not, it should inherit LED state from the other attached key

Re: [PATCH weston] configure.ac: use libinput by default

2014-08-20 Thread Pekka Paalanen
On Tue, 19 Aug 2014 19:21:42 +0200 Jonas Ådahl wrote: > On Tue, Aug 19, 2014 at 09:46:55AM -0700, Jason Ekstrand wrote: > > Reviewed-by: Jason Ekstrand > > > > Acked-by: Jonas Ådahl > > > > > On Tue, Aug 19, 2014 at 3:13 AM, Pekka Paalanen wrote: > > > > > From: Pekka Paalanen > > > > >