Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-10 Thread Pekka Paalanen
On Sun, 10 Aug 2014 15:59:08 +0200 "Nils Chr. Brause" wrote: > On Sat, Aug 9, 2014 at 3:14 PM, Pekka Paalanen wrote: > > > But I do wonder, if it ever makes sense to check user data for > > NULL, and set if it is NULL. If user_data is NULL, how can you > > ever be sure, that the wl_proxy was cr

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-10 Thread Marek Chalupa
Hi, On 10 August 2014 12:27, Nils Chr. Brause wrote: > On Sat, Aug 09, 2014 at 09:25:04AM -0400, Jasper St. Pierre wrote: > > > > I'm not a fan of this patch because it does a memset, and then a few > lines > > later, explicitly sets pointers to NULL. If you want a memset, you should > > also r

qt5 window setGeometry and move not work in wayland platform

2014-08-10 Thread Steve (YiLiang) Zhou
Dear all, My app has a mainwindow and a QDialog which is a child of mainwindow. And I want to set the app to the position 0,0. I use both setGeometry and move to 0,0. No luck , both failed. The window's position is unfixed and may appear to anywhere on the screen. My Qt version :5.2.2 Some co

Question about wl_global_create

2014-08-10 Thread Yang Andy
Hi everyone In my software,i successfully call [wl_global_create]api. But callback [wl_global_bind_func_t bind] is never called. Could anyone give me some advice? Thank you. [API] wl_global_create(struct wl_display *display, const struct wl_interface *interface, int version,

Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-10 Thread Peter Hutterer
On Sun, Aug 10, 2014 at 12:27:07PM +0200, Jonas Ådahl wrote: > On Mon, Aug 04, 2014 at 03:23:32PM +1000, Peter Hutterer wrote: > > On Sun, Jul 27, 2014 at 11:28:30PM +0200, Jonas Ådahl wrote: > > > When removing a device, its not guaranteed that all button or key > > > presses have been released, r

Re: [PATCH v2 weston] gears: fix invalid calculation of the first FPS

2014-08-10 Thread Ryo Munakata
From: Ryo Munakata To: "Nils Chr. Brause" Subject: Re: [PATCH v2 weston] gears: fix invalid calculation of the first FPS Date: Sun, 10 Aug 2014 23:51:40 +0900 X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.24; x86_64-unknown-linux-gnu) On Sun, 10 Aug 2014 16:02:35 +0200 "Nils Chr. Brause" wrote: > On Sun

[PATCH v3 weston] gears: fix invalid calculation of the first FPS

2014-08-10 Thread Ryo Munakata
At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.

Re: [PATCH v2 weston] gears: fix invalid calculation of the first FPS

2014-08-10 Thread Nils Chr. Brause
On Sun, Aug 10, 2014 at 06:26:36PM +0900, Ryo Munakata wrote: > At the calculation of the first FPS, gears has initialized last > FPS time with gettimeofday(). > But the callback_data passed in the callback of wl_surface_frame() > is the current time, in milliseconds, with an undefined base. > Beca

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-10 Thread Nils Chr. Brause
On Sat, Aug 9, 2014 at 3:14 PM, Pekka Paalanen wrote: > I see nothing wrong here, memset to zero is a usual pattern, and > wl_proxy is a complex enough type, that checking every member is > set is tedious. Therefore: > > Reviewed-by: Pekka Paalanen > Thanks! > But I do wonder, if it ever make

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-10 Thread Nils Chr. Brause
On Sat, Aug 09, 2014 at 09:25:04AM -0400, Jasper St. Pierre wrote: > > I'm not a fan of this patch because it does a memset, and then a few lines > later, explicitly sets pointers to NULL. If you want a memset, you should > also remove the explicit NULL sets. > I agree. Here a new patch: >From

Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-10 Thread Jonas Ådahl
On Mon, Aug 04, 2014 at 03:23:32PM +1000, Peter Hutterer wrote: > On Sun, Jul 27, 2014 at 11:28:30PM +0200, Jonas Ådahl wrote: > > When removing a device, its not guaranteed that all button or key > > presses have been released, resulting in an invalid seat wide button > > count. > > > > Note that

Re: [PATCH libinput 1/4] evdev: Ignore key/button release events if key was never pressed

2014-08-10 Thread Jonas Ådahl
On Mon, Aug 04, 2014 at 03:04:06PM +1000, Peter Hutterer wrote: > On Sun, Jul 27, 2014 at 11:28:28PM +0200, Jonas Ådahl wrote: > > The kernel may send a 'release' event without ever having sent a key > > 'pressed' event in case the key was pressed before libinput was > > initiated. Ignore these eve

[PATCH v2 weston] gears: fix invalid calculation of the first FPS

2014-08-10 Thread Ryo Munakata
At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.

[PATCH weston] gears: fix invalid calculation of the first FPS

2014-08-10 Thread Ryo Munakata
At the calculation of the first FPS, gears has initialized last FPS time with gettimeofday(). But the callback_data passed in the callback of wl_surface_frame() is the current time, in milliseconds, with an undefined base. Because of this subtracting last FPS time from callback_data makes no sense.