Re: Interfaces to objects

2014-08-08 Thread Bill Spitzak
This is my understanding. And this is one of the big confusing points when trying to figure out the Wayland api, but I think there are good reasons for it. The only real problem is that the auto-generated documentation is not handling this nicely: A Wayland compositor has to support the functi

[PATCH wayland 2/2] scanner: Make emit_structs more explicit

2014-08-08 Thread Jasper St. Pierre
"is_interface" is a really terrible name for the client or server variants, and instead of checking whether we were passed the requests or the events, just pass an argument through. --- src/scanner.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/sr

[PATCH wayland 1/2] scanner: Use an enum to determine the type of thing we're writing out

2014-08-08 Thread Jasper St. Pierre
--- src/scanner.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index b6c8a8d..51ecb55 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -30,6 +30,11 @@ #include "wayland-util.h" +enum side { + CLIENT, + SERVER

Re: [PATCH weston 2/4] Don't bother destroying resources after sending an error

2014-08-08 Thread Jason Ekstrand
I squished in a little note for/from myself as to why this is OK. I pushed this one and the other 3 --Jason On Thu, Aug 7, 2014 at 1:43 PM, Jasper St. Pierre wrote: > An error makes the client exit, which cleans up the resources anyway. > --- > desktop-shell/input-panel.c | 1 - > desktop-she

Re: [PATCH wayland] server: Don't expose wl_display as a global

2014-08-08 Thread Jason Ekstrand
I think this is ok. To my knowledge, no one is re-binding wl_display or even relying on that global being exposed. --Jason On Thu, Aug 7, 2014 at 6:55 AM, Jasper St. Pierre wrote: > The idea here was that once upon a time, clients could rebind wl_display > to a higher version, so we offered th

Re: Interfaces to objects

2014-08-08 Thread Jasper St. Pierre
On Tue, Jul 8, 2014 at 7:51 AM, Stephen Lee wrote: > Hey, I'm working on my own window manager and I'm having a hard time > tracking through the Weston code to see where a function is registered as > part of an interface. Right now I am looking at surfaces. I guess my > question is more related t

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-08 Thread Bill Spitzak
On 08/08/2014 12:00 AM, Pekka Paalanen wrote: Bill, you again managed to drop people from CC. Please do not do that. I am not sure what is up with Thunderbird here. The problem was that I responded to my own post. In addition it refuses to show reply-all or reply-to-list to any of my git se

[PATCH 03/12] Made weston-nested --help work

2014-08-08 Thread Bill Spitzak
--- clients/nested.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/clients/nested.c b/clients/nested.c index 2a952be..f094237 100644 --- a/clients/nested.c +++ b/clients/nested.c @@ -1115,8 +1115,11 @@ main(int argc, char *argv[]) struct display *display;

[PATCH 07/12] weston-cliptest --help works. You must use -b to run benchmark

2014-08-08 Thread Bill Spitzak
--- clients/cliptest.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/clients/cliptest.c b/clients/cliptest.c index a1928f4..51a4075 100644 --- a/clients/cliptest.c +++ b/clients/cliptest.c @@ -893,8 +893,12 @@ main(int argc, char *argv[]) struct display *d;

[PATCH 08/12] weston-dnd --help works

2014-08-08 Thread Bill Spitzak
--- clients/dnd.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/clients/dnd.c b/clients/dnd.c index 620cfff..cb13697 100644 --- a/clients/dnd.c +++ b/clients/dnd.c @@ -652,7 +652,14 @@ main(int argc, char *argv[]) { struct display *d; struct

[PATCH 11/12] weston-scaler --help works even if not run inside wayland

2014-08-08 Thread Bill Spitzak
--- clients/scaler.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/clients/scaler.c b/clients/scaler.c index 3939022..f6d45c7 100644 --- a/clients/scaler.c +++ b/clients/scaler.c @@ -274,12 +274,6 @@ main(int argc, char *argv[]) struct timeval tv;

[PATCH 12/12] load_image always prints a message on failure if filename is not empty

2014-08-08 Thread Bill Spitzak
It was rather inconsistent before. This may help users figure out why backgrounds and icons don't show up. A better api where the error can be queried might be nice, but this seems sufficient for current Weston use. --- clients/image.c |1 - shared/image-loader.c | 11 +-- 2 fi

[PATCH 04/12] Made weston-subsurfaces --help work

2014-08-08 Thread Bill Spitzak
--- clients/subsurfaces.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/subsurfaces.c b/clients/subsurfaces.c index 66a10f2..833030f 100644 --- a/clients/subsurfaces.c +++ b/clients/subsurfaces.c @@ -775,8 +775,8 @@ main(int argc, char *argv[]) struct d

[PATCH 06/12] weston-terminal --help and other command-line options

2014-08-08 Thread Bill Spitzak
Option array existed but was unused. Added --font-size. --- clients/terminal.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index eb133cd..1915c9f 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -2991,6 +2991,7 @@ terminal_r

[PATCH 05/12] Made weston-screensaver --help work

2014-08-08 Thread Bill Spitzak
--- clients/wscreensaver.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/clients/wscreensaver.c b/clients/wscreensaver.c index 47f6c8a..f75d0d8 100644 --- a/clients/wscreensaver.c +++ b/clients/wscreensaver.c @@ -310,8 +310,12 @@ int main(int argc, char *argv[])

[PATCH 10/12] weston-image --help works. Also help if no filename is given

2014-08-08 Thread Bill Spitzak
--- clients/image.c |5 + 1 file changed, 5 insertions(+) diff --git a/clients/image.c b/clients/image.c index 112b93d..573117c 100644 --- a/clients/image.c +++ b/clients/image.c @@ -412,6 +412,11 @@ main(int argc, char *argv[]) int i; int image_counter = 0; + if (

[PATCH 09/12] weston-editor --help works

2014-08-08 Thread Bill Spitzak
--- clients/editor.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 08d1203..66cba0b 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -1331,11 +1331,16 @@ main(int argc, char *argv[]) for (i = 1; i < a

[PATCH] Fixes to parse_options, help info from display

2014-08-08 Thread Bill Spitzak
These are a series of changes, you can pick and choose from them if you don't like them all. There are fixes to the parser so that "x=5mm" and "bool=false" and other constucts are errors rather than doing unintuitive things. Also I tried to get most of the weston demo programs to print some hel

[PATCH 02/12] weston-eventdemo --help works

2014-08-08 Thread Bill Spitzak
Also defaults to printing all events if you specify none. Removed incorrect "-0" switch which would turn on one of them. --- clients/eventdemo.c | 42 +- 1 file changed, 33 insertions(+), 9 deletions(-) diff --git a/clients/eventdemo.c b/clients/eventdemo

[PATCH 01/12] Fixes to parse_options

2014-08-08 Thread Bill Spitzak
Fail on malformed numbers, such as --width=100mm Fail on = after booleans, such as --flag=false Multiple single-letter booleans in one switch allowed, ie -xyz is the same as -x -y -z. For wayland modules they all have to belong to the same module. Previous version could use text after the null a

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Bill Spitzak
I posted fixes for this as well. Never heard anything. Will post them again to see. On 06/19/2014 08:22 PM, Robert Ancell wrote: On my system: $ weston --shell would use the first environment variable as the argument to --shell and $ weston --shell foo.so Would use foo.so as the argument and th

Re: [PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Robert Ancell
I'm not sure if the expected behaviour is for: $ weston --shell foo.so to work, if so the patch can be modified. On 20 June 2014 15:22, Robert Ancell wrote: > On my system: > $ weston --shell > would use the first environment variable as the argument to --shell > and > $ weston --shell foo.so >

Interfaces to objects

2014-08-08 Thread Stephen Lee
Hey, I'm working on my own window manager and I'm having a hard time tracking through the Weston code to see where a function is registered as part of an interface. Right now I am looking at surfaces. I guess my question is more related to the relation of surface and shell surface. In the main comp

[PATCH] option-parser: Don't read off the end of string options without an '='

2014-08-08 Thread Robert Ancell
On my system: $ weston --shell would use the first environment variable as the argument to --shell and $ weston --shell foo.so Would use foo.so as the argument and then parse foo.so as a new option. --- shared/option-parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shar

Re: [PATCH 2/2] compositor-drm: Add support for Tegra Jetson TK1

2014-08-08 Thread Thierry Reding
On Sat, Jun 21, 2014 at 01:37:16PM +0200, Rob Clark wrote: > On Fri, Jun 20, 2014 at 12:12 PM, James Thomas > wrote: > > Update configure.ac to add check for libdrm_tegra > > --- > > configure.ac | 18 ++ > > src/compositor-drm.c | 96 > > +

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-08 Thread Nils Chr. Brause
On 08/08/2014 07:23 PM, Marek Chalupa wrote: > Just out of curiosity, did you have some troubles because of non-setting the > proxy to zeroes? I wanted to check if I already assigned my meta data to the proxy be testing user_data against NULL. I have a workaround for this now, but I don't want any

Re: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-08 Thread Marek Chalupa
Just out of curiosity, did you have some troubles because of non-setting the proxy to zeroes? On 8 August 2014 18:31, Nils Chr. Brause wrote: > Up until now, newly created wl_proxys (with proxy_create or > wl_proxy_create_for_id) are not initialized properly after memory > allocation. The wl_di

[PATCH] wayland-client: Initialize newly created wl_proxys to zero.

2014-08-08 Thread Nils Chr. Brause
Up until now, newly created wl_proxys (with proxy_create or wl_proxy_create_for_id) are not initialized properly after memory allocation. The wl_display object in contrast is. To prevent giving uninitialized data to the user (e.g. user_data) an appropriate memset has been added. Signed-off-by: Nil

Re: [PATCH libinput] touchpad: increase top software button area to 15%

2014-08-08 Thread Hans de Goede
Hi, On 08/08/2014 05:21 AM, Peter Hutterer wrote: > We had reports that the top software button area is hard to hit for those > using the trackpoint and clicking the buttons with their thumb. > > Analysis of event recordings (3 different people) for left, right and middle > clicks shows that ther

Re: [PATCH weston] fullscreen-shell: Fix compiler warnings

2014-08-08 Thread Pekka Paalanen
On Tue, 29 Jul 2014 21:57:24 +0300 Giulio Camuffo wrote: > --- > fullscreen-shell/fullscreen-shell.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fullscreen-shell/fullscreen-shell.c > b/fullscreen-shell/fullscreen-shell.c > index a8dad8e..25932d4 100644 > --- a/

Re: [PATCH] tests: add NO_FORK option

2014-08-08 Thread Marek Chalupa
On 08/08/14 16:27, Pekka Paalanen wrote: On Wed, 6 Aug 2014 11:23:42 +0200 Marek Chalupa wrote: When WAYLAND_TEST_NO_FORK environment variable is set, then do not run the test in fork. It's convenient for debugging Signed-off-by: Marek Chalupa --- tests/test-runner.c | 9 - 1 fi

Re: [PATCH] tests: add NO_FORK option

2014-08-08 Thread Pekka Paalanen
On Wed, 6 Aug 2014 11:23:42 +0200 Marek Chalupa wrote: > When WAYLAND_TEST_NO_FORK environment variable is set, then > do not run the test in fork. It's convenient for debugging > > Signed-off-by: Marek Chalupa > --- > tests/test-runner.c | 9 - > 1 file changed, 8 insertions(+), 1 de

Re: [LookForHelp]A10S/ARM Weston-launch failed‏

2014-08-08 Thread Philippe Coval
On 08/08/2014 11:00, Yang Andy wrote: Hi Bachmann Thank you very much for your reply. I got it.I do not have DRM driver for GPU. but sunxi does provide some binaries for a20 Sorry,i have another question for help. Is there any informations that explain DRM driver and GPU driver relations

RE: [LookForHelp]A10S/ARM Weston-launch failed‏

2014-08-08 Thread Yang Andy
Hi Bachmann Thank you very much for your reply. I got it.I do not have DRM driver for GPU. Sorry,i have another question for help. Is there any informations that explain DRM driver and GPU driver relationship for weston? I want to study architecture of DRM/GPU/Weston。 Best regards. Andy Dat

Re: [LookForHelp]A10S/ARM Weston-launch failed‏

2014-08-08 Thread Philippe Coval
On 08/08/2014 09:56, Yang Andy wrote: Hi everyone I have some questions for help. When i run weston-launch command in TizeIVI, hi do you really need to work on Tizen:IVI ? because I shared an image for A20 it has weston support (fb) I could help to adapt it for A10, what kernel do you use ?

Re: [LookForHelp]A10S/ARM Weston-launch failed‏

2014-08-08 Thread Manuel Bachmann
Hi Andy, It looks like Weston is trying to use its DRM backend (which is the default) to initialize the GPU, but is not finding the device or driver. You can verify this by doing "$ ls /dev/dri/". If the folder is empty, or does not exist, it means you do not have a DRM driver for your GPU. If yo

[LookForHelp]A10S/ARM Weston-launch failed‏

2014-08-08 Thread Yang Andy
Hi everyone I have some questions for help. When i run weston-launch command in TizeIVI,it echo below error information. I investigation weston source code and find that it seems to fail to find gup device. 1.In order to setup wayland/weston in arm device,is there any necessary thing to be do

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-08 Thread Pekka Paalanen
Bill, you again managed to drop people from CC. Please do not do that. On Thu, 07 Aug 2014 12:43:17 -0700 Bill Spitzak wrote: > On 08/07/2014 07:18 AM, Jari Vetoniemi wrote: > >> What is the default value of these hints? > > I think you could get away with defaulting the minimum to be about >