Re: [PATCH libinput 1/2] tablet: Use separate tool objects for tools without serials

2014-08-06 Thread Peter Hutterer
this patch really needs a extensive commit message explaining why we keep those separate. we've discussed that on IRC, but for everyone else it needs to be in the commit msg. On Thu, Aug 07, 2014 at 12:09:22AM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul > --- > sr

[PATCH libinput 1/2] tablet: Use separate tool objects for tools without serials

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/evdev-tablet.c | 32 -- src/evdev-tablet.h | 4 +++ test/tablet.c | 79 ++ 3 files changed, 107 insertions(+), 8 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tab

[PATCH libinput 2/2] tablet: Add libinput_tool_has_axis() and tests

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/evdev-tablet.c | 42 +++ src/evdev-tablet.h | 1 + src/libinput-private.h | 1 + src/libinput.c | 7 ++ src/libinput.h | 26 +++ test/tablet.c | 68

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Jasper St. Pierre
On Wed, Aug 6, 2014 at 9:30 PM, Bill Spitzak wrote: > On 08/06/2014 05:38 PM, Jasper St. Pierre wrote: > > For the maximized or fullscreen states, the client must always submit >> window geometry that is the configured size. No exceptions. >> > > Are you sure? I know the fullscreen supports scal

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Bill Spitzak
On 08/06/2014 05:38 PM, Jasper St. Pierre wrote: For the maximized or fullscreen states, the client must always submit window geometry that is the configured size. No exceptions. Are you sure? I know the fullscreen supports scaling or centering of a smaller surface (though the client has to s

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Jasper St. Pierre
On Wed, Aug 6, 2014 at 8:28 PM, Bill Spitzak wrote: > Never mind my previous response. I just tried a bunch of programs that > implement tiling internally, and only one of them (a Mail program with very > simple set of 3 tiles) made a tile taller as it got narrower. All others > just introduce sc

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Bill Spitzak
Never mind my previous response. I just tried a bunch of programs that implement tiling internally, and only one of them (a Mail program with very simple set of 3 tiles) made a tile taller as it got narrower. All others just introduce scroll bars. Since these are programs with complete control

[PATCH weston 16/19] client: Add support for pressure, distance, and tilt into libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 45 ++--- clients/window.h | 25 + 2 files changed, 67 insertions(+), 3 deletions(-) diff --git a/clients/window.c b/clients/window.c index 7b844f8..3896b31 100644 --- a/cl

[PATCH weston 08/19] client: Add support for tool objects in libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 90 ++-- clients/window.h | 20 + 2 files changed, 108 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index 325c3f2..6001b55 100644 --- a/cl

[PATCH weston 10/19] tablet: Add support for button presses to weston

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 6 ++ src/input.c | 39 ++- src/libinput-device.c | 23 +++ 3 files changed, 67 insertions(+), 1 deletion(-) diff --git a/src/compositor.h b/src/compositor.h in

[PATCH weston 19/19] tablet: Add demo application for tablets

2014-08-06 Thread Stephen Chandler Paul
This is just a hacked version of clickdot that responds to tablet events instead of cursor events Signed-off-by: Stephen Chandler Paul --- .gitignore | 1 + Makefile.am | 8 ++ clients/tablet.c | 341 +++ 3 files changed, 350 ins

[PATCH weston 15/19] tablet: Add support for reporting pressure, distance, and tilt in weston

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 13 + src/input.c | 81 +++ src/libinput-device.c | 57 3 files changed, 146 insertions(+), 5 deletions(-) diff --git a/src/comp

[PATCH weston 06/19] client: Add tablet cursor support into libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Again, a lot of this is code that has been reused from the cursor code for pointers. Signed-off-by: Stephen Chandler Paul --- clients/window.c | 140 +-- clients/window.h | 14 +++--- 2 files changed, 144 insertions(+), 10 deletions(-) diff -

[PATCH weston 05/19] tablet: Add support for setting/changing the tablet cursor in weston

2014-08-06 Thread Stephen Chandler Paul
Most of this code is just reused from the code for the pointer cursor, with slight modifications to make it work with tablets. Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 10 src/input.c | 147 ++- 2 files changed, 15

[PATCH weston 17/19] tablet: Add tablet support to the top panel of the desktop shell

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/desktop-shell.c | 55 + 1 file changed, 55 insertions(+) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 73b2134..a27910f 100644 --- a/clients/desktop-shell.c +++ b/clients/deskt

[PATCH weston 18/19] tablet: Add binding to activate surfaces using the tablet tool

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- desktop-shell/shell.c | 14 ++ src/bindings.c| 37 + src/compositor.c | 1 + src/compositor.h | 16 src/input.c | 7 +++ 5 files changed, 75 insertions(+) d

[PATCH weston 07/19] tablet: Add support for tablet tool objects

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 16 ++ src/input.c | 86 +-- src/libinput-device.c | 72 ++ 3 files changed, 171 insertions(+), 3 deletions(-) diff --git a/s

[PATCH weston 12/19] tablet: Add support for up/down events to weston

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 8 +++ src/input.c | 65 +-- src/libinput-device.c | 7 +- 3 files changed, 77 insertions(+), 3 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index

[PATCH weston 13/19] client: Add up/down event support into libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 43 +-- clients/window.h | 14 ++ 2 files changed, 55 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index dd9b822..83459eb 100644 --- a/clients/window.

[PATCH weston 11/19] client: Add support for handling button presses to libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 24 +++- clients/window.h | 10 ++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 727e3f0..dd9b822 100644 --- a/clients/window.c +++ b/clients/window.c

[PATCH weston 09/19] client: Add support for tablet cursor motion to window frames in libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
When it comes to a window frame, a tablet tool and cursor act almost identical; they click things, drag things, etc. The tool type and extra axes don't serve any use in the context of a window frame, so tablet pointers share the frame_pointer structures used for the mouse pointer. Signed-off-by: S

[PATCH weston 14/19] tablet: Add support for moving windows around using the stylus

2014-08-06 Thread Stephen Chandler Paul
Changing the pointer to the appropriate image while moving the stylus around isn't supported yet. Signed-off-by: Stephen Chandler Paul --- clients/window.c | 27 + desktop-shell/shell.c | 268 ++ src/compositor.h | 5 + src/input.c

[PATCH weston 02/19] tablet: Add initial tablet support to weston

2014-08-06 Thread Stephen Chandler Paul
This only adds support for reporting motion events, proximity_in events (without the tool object information), proximity_out events and frame events. Signed-off-by: Stephen Chandler Paul --- src/compositor.h | 97 src/input.c | 312 +++

[PATCH weston 01/19] tablet: Add XML for wl_tablet and wl_tablet_manager

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- Makefile.am | 15 ++- protocol/wayland-tablet.xml | 310 2 files changed, 321 insertions(+), 4 deletions(-) create mode 100644 protocol/wayland-tablet.xml diff --git a/Makefile.am b/Makefile.a

[PATCH weston 00/19] Basic tablet support in Weston

2014-08-06 Thread Stephen Chandler Paul
Hi! As some of you have been aware, I have been working on implementing tablet ssupport in libinput, the wayland protocol and weston. This patchset adds basic tablet support to weston, along with support in the shell and the window manager. It should be noted that these patches rely on one of the e

[PATCH weston 03/19] client: Add support for handling motion events in toytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 201 +++ clients/window.h | 19 ++ 2 files changed, 220 insertions(+) diff --git a/clients/window.c b/clients/window.c index 85e5de8..90a2e28 100644 --- a/clients/window.c +++ b/c

[PATCH weston 04/19] client: Add support for handling proximity_in/out events in libtoytoolkit

2014-08-06 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- clients/window.c | 48 +++- clients/window.h | 12 2 files changed, 59 insertions(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 90a2e28..ab4ae85 100644 --- a/clients/windo

Re: [PATCH] tests: add NO_FORK option

2014-08-06 Thread Peter Hutterer
On Wed, Aug 06, 2014 at 11:23:42AM +0200, Marek Chalupa wrote: > When WAYLAND_TEST_NO_FORK environment variable is set, then > do not run the test in fork. It's convenient for debugging > > Signed-off-by: Marek Chalupa have a look at libinput/test/litest.c:is_debugger_attached(), you may find th

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Bill Spitzak
I can see a minimum size being useful for this, but not a maximum. Compositors are allowed to request sizes smaller than this, and cannot assume clients will not resize surfaces smaller than this. It is just advisory for layout. Compositors could assume the initial size is the minimum if it is

Re: [PATCH weston] xdg-shell: Make stable

2014-08-06 Thread Pekka Paalanen
On Thu, 17 Jul 2014 17:57:45 -0400 "Jasper St. Pierre" wrote: > We've gone through enough churn of xdg-shell that we're now feeling > confident enough to commit to this much. Let's do it. > > The major version number is bumped to 2 because unfortunately we need to > remove the use_unstable_versi

RE: Help needed regarding the "1.4.93 version of Wayland and Weston"

2014-08-06 Thread gautam.h.kumar
Hi Srivardhan ... Think it works Thanks a billion ... Replacing git:// with http:// as suggested by you worked :):) Thanks again and Br, Gautam From: Srivardhan [mailto:sri.heb...@samsung.com] Sent: Wednesday, August 06, 2014 4:24 PM To: Kumar, Gautam H.; wayland-devel@lists.freedesktop.org

RE: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Steve (YiLiang) Zhou
Thanks very much for your help ,I will try it tomorrow! Thanks and Best Regards Steve Zhou From: Giulio Camuffo [mailto:giuliocamu...@gmail.com] Sent: Wednesday, August 06, 2014 6:37 PM To: Steve (YiLiang) Zhou Cc: wayland mailing list Subject: Re: Help!! app qt4 upgrade to qt5 for waylan

RE: Help needed regarding the "1.4.93 version of Wayland and Weston"

2014-08-06 Thread Srivardhan
From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of gautam.h.ku...@accenture.com Sent: Wednesday, August 06, 2014 3:49 PM To: wayland-devel@lists.freedesktop.org Subject: Help needed regarding the "1.4.93 version of Wayland and Weston" Importance: High Hi,

Re: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Giulio Camuffo
2014-08-06 13:31 GMT+03:00 Steve (YiLiang) Zhou : > So , if I want to draw something in a qwidget in wayland , it’s impossible > to do this now? > You can do it, just not with OpenGL. > Can you give some advices if I chose “ an egl surface to draw into, with > no QWidgets on top “ ? > Well, yo

RE: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Steve (YiLiang) Zhou
So , if I want to draw something in a qwidget in wayland , it’s impossible to do this now? Can you give some advices if I chose “ an egl surface to draw into, with no QWidgets on top “ ? Thanks and Best Regards Steve Zhou From: Giulio Camuffo [mailto:giuliocamu...@gmail.com] Sent: Wedn

Re: [PATCH 1/2] server: don't leak fd on error

2014-08-06 Thread Marek Chalupa
Sorry, my bad, this will be closed by wl_socket_destroy, therefore this patch is useless. Regards, Marek On 08/06/14 12:18, Marek Chalupa wrote: close opened fd if an error occur. --- src/wayland-server.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/

Help needed regarding the "1.4.93 version of Wayland and Weston"

2014-08-06 Thread gautam.h.kumar
Hi, Request your help regarding building of the Weston module downloaded from your site. I am trying to build the Wayland and Weston components on my Linux Ubuntu 3.2.0-67 I am getting problem as highlighted below Steps to reproduce 1] I download wayland-1.4.93.tar.xz and weston-1.4.93.tar.

[PATCH 2/2] server: fix conditions for fds in wl_socket_destroy

2014-08-06 Thread Marek Chalupa
The only value that is false with the former condition is 0. On error we set fd to -1. --- src/wayland-server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index ce7bbff..c8aecb8 100644 --- a/src/wayland-server.c +++ b/src/way

[PATCH 1/2] server: don't leak fd on error

2014-08-06 Thread Marek Chalupa
close opened fd if an error occur. --- src/wayland-server.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3c162d4..ce7bbff 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1119,23 +1119,28 @@ _

Re: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Giulio Camuffo
2014-08-06 12:38 GMT+03:00 Steve (YiLiang) Zhou : > Thanks for your quick reply , I prefer to embed an OpenGL surface into > QDialog . > That is unfortunately not possible yet. The QtWayland QPA doesn't have support for wl_subsurface yet, which are needed to embed an EGL surface into an shm one

Re: [PATCH weston] desktop-shell: don't assume there's a pointer when mapping a popup

2014-08-06 Thread Jonny Lamb
On mer, 2014-08-06 at 11:50 +0200, Jonny Lamb wrote: > - if (shseat->seat->pointer->grab_serial == shsurf->popup.serial) { > + if (shseat->seat->pointer && > + shseat->seat->pointer->grab_serial == shsurf->popup.serial) { This should also be applied to the 1.5 branch (it applies cl

[PATCH weston] desktop-shell: don't assume there's a pointer when mapping a popup

2014-08-06 Thread Jonny Lamb
--- desktop-shell/shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 3c3649c..5a613f1 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -3116,7 +3116,8 @@ shell_map_popup(struct shell_surface *shsurf)

RE: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Steve (YiLiang) Zhou
Thanks for your quick reply , I prefer to embed an OpenGL surface into QDialog . Thanks and Best Regards Steve Zhou From: Giulio Camuffo [mailto:giuliocamu...@gmail.com] Sent: Wednesday, August 06, 2014 5:34 PM To: Steve (YiLiang) Zhou Cc: wayland mailing list Subject: Re: Help!! a

Re: Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Giulio Camuffo
2014-08-06 11:54 GMT+03:00 Steve (YiLiang) Zhou : > Dear all, > > I have app which was developed by qt4, and we want to port it to tizen ivi > wayland platform, so I have to update our app to qt5. > > We have a feature : drawing something based on egl on a qt window(we use > QDialog). > > Egl need

[PATCH] server: move memset after check

2014-08-06 Thread Marek Chalupa
If the malloc fails, memset would touch invalid memory. --- src/wayland-server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 75de313..3c162d4 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1150,10 +1150,1

Re: [PATCH] server: move memset after check

2014-08-06 Thread Marek Chalupa
I meant to send it normally, not in reply to the previous bug, I'll resend it. On 08/06/14 11:23, Marek Chalupa wrote: If the malloc fails, memset would touch invalid memory. --- src/wayland-server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.c b

[PATCH] server: move memset after check

2014-08-06 Thread Marek Chalupa
If the malloc fails, memset would touch invalid memory. --- src/wayland-server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 75de313..3c162d4 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1150,10 +1150,1

[PATCH] tests: add NO_FORK option

2014-08-06 Thread Marek Chalupa
When WAYLAND_TEST_NO_FORK environment variable is set, then do not run the test in fork. It's convenient for debugging Signed-off-by: Marek Chalupa --- tests/test-runner.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index

[PATCH] server: fix error handling when adding socket

2014-08-06 Thread Marek Chalupa
When some function during adding socket fails, it must clean everything it set or we can get funky errors. This patch fixes: http://lists.freedesktop.org/archives/wayland-devel/2014-August/016331.html Signed-off-by: Marek Chalupa --- src/wayland-server.c | 23 --- 1 file cha

Help!! app qt4 upgrade to qt5 for wayland , can't get the QDialog's window handle which can cast to EGLNativeWindowType

2014-08-06 Thread Steve (YiLiang) Zhou
Dear all, I have app which was developed by qt4, and we want to port it to tizen ivi wayland platform, so I have to update our app to qt5. We have a feature : drawing something based on egl on a qt window(we use QDialog). Egl need a EGLSurface and a EGLDisplay to get the feature work. EGLSurfac

Re: [PATCH] Introduce set_size_hints xdg_surface request.

2014-08-06 Thread Jari Vetoniemi
> This doesn't work in the case of tiling WMs which may want some up-front > information about window sizes so they can lay them out correctly. > Currently, we say that the maximize and fullscreen states are strictly > sized, and clients *must* submit window geometry that's equivalent to that, > so

[PATCH] tests: add tests for bug in adding socket

2014-08-06 Thread Marek Chalupa
Last set of commits introduced a bug. When adding of socket with a particular name fails, then the socket and its lockfile are deleted regardless who created the socket. /* OK */ wl_display_add_socket(display, "wayland-0"); /* this call fails and will delete the original socket */ wl_display_add_

wayland: new socket addition

2014-08-06 Thread Marek Chalupa
Hi, After the new patches for socket automatic naming the socket test, namely socket_path_overflow_server_create, fails. Probably introduced in 79b1d2039aeb77b712cf4e1bb4049ebf9c453b59. It does not set errno as expected: error: socket path "/run/user/1000/