Re: [PATCH weston 2/2] compositor: add a masking mechanism to weston_layer

2014-07-18 Thread Jason Ekstrand
One comment below. Otherwise, it looks good (though I haven't tested it yet.) Also, I'd like to decide what I think about the first patch before merging. I'll get back to you Monday or Tuesday. --Jason On Wed, Jul 9, 2014 at 12:12 PM, Giulio Camuffo wrote: > this adds a mechanism to mask the

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Bill Spitzak
On 07/18/2014 11:41 AM, Jasper St. Pierre wrote: On Fri, Jul 18, 2014 at 2:26 PM, Bill Spitzak I see no reason this can't be called "show" or "raise". The *creation* of a surface does not mean that the compositor must show it. It could add a blinking "attention needed" task bar

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Jasper St. Pierre
On Fri, Jul 18, 2014 at 2:26 PM, Bill Spitzak wrote: > On 07/18/2014 09:55 AM, Jason Ekstrand wrote: > > I really like Jasper's "present" request solution to this problem. (It >> could probably also be called "attention"). If kwin wants to implement >> that as "move to the appropriate workspace

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Bill Spitzak
On 07/18/2014 09:55 AM, Jason Ekstrand wrote: I really like Jasper's "present" request solution to this problem. (It could probably also be called "attention"). If kwin wants to implement that as "move to the appropriate workspace and unminimize, then it can do that. Otherwise, it could start

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Jason Ekstrand
On Fri, Jul 18, 2014 at 5:31 AM, nerdopolis wrote: > On Friday, July 18, 2014 08:25:33 AM Jasper St. Pierre wrote: > > The lack of an unset_minimized feature is very intentional. The *goal*, > it > > sounds like, is to present the window immediately again, but an > > unset_minimized won't do that

[PATCH wayland] client: prevent using and creating proxies after an error occured

2014-07-18 Thread Marek Chalupa
We won't receive any response anyway... This removes the last line of: [2230782.435] wl_display@1.error(wl_display@1, 2, "no memory") wl_display@1: error 2: no memory [2230782.534] -> wl_disp...@1.sync(new id wl_callback@3) and prevents from creating proxy on invalidated display object. --- sr

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread nerdopolis
On Friday, July 18, 2014 08:25:33 AM Jasper St. Pierre wrote: > The lack of an unset_minimized feature is very intentional. The *goal*, it > sounds like, is to present the window immediately again, but an > unset_minimized won't do that. What if the window is on a different > workspace, or has been

Re: [PATCH wayland 3/6] server: Split out code to initialize the socket address for a display name

2014-07-18 Thread Marek Chalupa
It depends on implementation. For x86 bind is provided by syscall ( http://lxr.free-electrons.com/source/net/socket.c#L1521) and for example for hurd on mach it's implemented in glibc ( https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/mach/hurd/bind.c;h=a42b78ac07c7a72041f07650860567b6e9547

Re: [PATCH wayland 3/6] server: Split out code to initialize the socket address for a display name

2014-07-18 Thread Jasper St. Pierre
Does the off-by-one matter? I don't think bind actually cares. On Fri, Jul 18, 2014 at 4:13 AM, Marek Chalupa wrote: > > > > On 17 July 2014 19:54, Jasper St. Pierre wrote: > >> We'll use this to autodetect a good socket to open on. >> --- >> src/wayland-server.c | 41

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Jasper St. Pierre
The lack of an unset_minimized feature is very intentional. The *goal*, it sounds like, is to present the window immediately again, but an unset_minimized won't do that. What if the window is on a different workspace, or has been simply stacked behind another set of windows? unset_minimized won't

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Manuel Bachmann
Hi everybody, and thanks Phillippe for reacting to this topic, Yes, we under Tizen are using xdg-shell for some of the great features it has, and doing the integration in applications and toolkits such Ozone-Wayland, Qt, EFL... We were recently challenged by a feature needed in the Web runtime, w

Re: Fwd: [PATCH weston] xdg-shell: Make stable

2014-07-18 Thread Philippe Coval
We've gone through enough churn of xdg-shell that we're now feeling confident enough to commit to this much. Let's do it. Ok good news, I guess you're want to gather some feedback before it lands into next release As a qtwayland developer it seems ok for us (note current master branch is align

Re: [PATCH libinput 3/3] touchpad: correct a wrong comment

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 09:01 AM, Peter Hutterer wrote: > The minimum to start 2fg scrolling is in device units, not pixels. Which is > bad on many levels, but let's correct it in the comment at least. > > Signed-off-by: Peter Hutterer > --- > src/evdev-mt-touchpad.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH libinput 2/3] test: reduce sideways-component in two-finger scroll test

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 09:01 AM, Peter Hutterer wrote: > This breaks when we have a device resolution set on the test devices, > specificially on the T440. The current tests use a delta of 1% of the device > which with the resolution set results in an effective delta of 3 - above the > scroll threshold

Re: [PATCH libinput 1/3] test: widen litest to use doubles for scaled variables

2014-07-18 Thread Hans de Goede
Hi, On 07/18/2014 09:01 AM, Peter Hutterer wrote: > Using a 0-100% range is useful but in some cases we need events with finer > than 1% granularity. > > And fix up the two-finger test that now fails. This was a bug in the test > anyway, the dx/dy supplied here was 1% of the touchpad width. Confi

[PATCH 2/4] touchpad: Don't process fake touches if they are not dirty

2014-07-18 Thread Hans de Goede
Don't process fake touches, e.g. re-adding the same position to the motion history when they are not dirty. This could trigger for example on a button press. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/evde

[PATCH 0/4] touchpad: Create fake touches for BTN_TOOL_FOO on mt-pads too

2014-07-18 Thread Hans de Goede
Hi All, Here is a patch-set to fix 3 finger tapping on mt touchpads which track only 2 fingers + 1 misc. fix. This patch-set applies on top of Peter's palm detection patch-set (not sure if there are conflicts if applied directly to master). Regards, Hans ___

[PATCH 3/4] touchpad: Create fake touches for BTN_TOOL_FOO on multi-touch pads too

2014-07-18 Thread Hans de Goede
Multi-touch pads may track less touches then they can report fingers being present through BTN_TOOL_FOO. So create fake touches for fingers reported by BTN_TOOL_FOO on multi-touch pads too (when necessary). This fixes e.g. 3 finger tap not working on the T440s. Signed-off-by: Hans de Goede ---

[PATCH 4/4] touchpad: make tp_estimate_delta return fractions

2014-07-18 Thread Hans de Goede
Force a cast of the input arguments to a double before the divide, rather then after the divide. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 1e2f58d..b88fa80 1

[PATCH 1/4] touchpad: Protect tp_begin_touch and tp_end_touch against being called twice

2014-07-18 Thread Hans de Goede
They were already protected against being called twice between syn-s, but not for being called twice before a syn arrives. This allows simplifying tp_process_fake_touch a bit. Note while at it also also flip the if condition in tp_process_fake_touch so that the if is true when the finger is down,

Re: [PATCH wayland 6/6] server: Add a simple API to find a good default display

2014-07-18 Thread Marek Chalupa
On 17 July 2014 19:54, Jasper St. Pierre wrote: > This allows compositors to easily select a good display to listen on. > --- > src/wayland-server.c | 97 > ++-- > src/wayland-server.h | 1 + > 2 files changed, 73 insertions(+), 25 deletions(-) >

Re: [PATCH wayland 5/6] server: Save the display name in the wl_socket

2014-07-18 Thread Marek Chalupa
On 17 July 2014 19:54, Jasper St. Pierre wrote: > This allows us to return the display name to the client in a new API. > --- > src/wayland-server.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/wayland-server.c b/src/wayland-server.c > index 5c0e84f..55b3e25 100644 > --- a/src

Re: [PATCH wayland 3/6] server: Split out code to initialize the socket address for a display name

2014-07-18 Thread Marek Chalupa
On 17 July 2014 19:54, Jasper St. Pierre wrote: > We'll use this to autodetect a good socket to open on. > --- > src/wayland-server.c | 41 ++--- > 1 file changed, 26 insertions(+), 15 deletions(-) > > diff --git a/src/wayland-server.c b/src/wayland-server.c >

Re: [PATCH wayland 1/6] server: Clean up socket destruction

2014-07-18 Thread Marek Chalupa
On 17 July 2014 19:54, Jasper St. Pierre wrote: > The code here is wrong, leaky, and inconsistent. We don't free, > unlink or clean up things when we should in every error path. > > Centralize the data destruction so it's easier to keep track of > and easier to bug fix. > --- > src/wayland-serve

[PATCH libinput 3/3] touchpad: correct a wrong comment

2014-07-18 Thread Peter Hutterer
The minimum to start 2fg scrolling is in device units, not pixels. Which is bad on many levels, but let's correct it in the comment at least. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/sr

[PATCH libinput 1/3] test: widen litest to use doubles for scaled variables

2014-07-18 Thread Peter Hutterer
Using a 0-100% range is useful but in some cases we need events with finer than 1% granularity. And fix up the two-finger test that now fails. This was a bug in the test anyway, the dx/dy supplied here was 1% of the touchpad width. Confined to integers this meant we only ever had the touch down, t

[PATCH libinput 0/3] test: widen to doubles

2014-07-18 Thread Peter Hutterer
These slot in before the original series of 7, with 1/7 being replaced. Cheers, Peter ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput 2/3] test: reduce sideways-component in two-finger scroll test

2014-07-18 Thread Peter Hutterer
This breaks when we have a device resolution set on the test devices, specificially on the T440. The current tests use a delta of 1% of the device which with the resolution set results in an effective delta of 3 - above the scroll threshold. Signed-off-by: Peter Hutterer --- test/touchpad.c | 10