Re: wl_tablet specification draft

2014-06-26 Thread Pekka Paalanen
On Thu, 26 Jun 2014 18:45:07 -0700 Jason Gerecke wrote: > On Thu, Jun 26, 2014 at 12:12 AM, Peter Hutterer > wrote: > > On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: > >> Hi, > >> > >> it seems you forgot to reply-to-all, so I have re-added everyone and > >> not trimmed the quo

Re: what are the wayland's APIS can get system resolution and dpi

2014-06-26 Thread Pekka Paalanen
On Fri, 27 Jun 2014 10:32:59 +0800 "Jacky (ZhiJun) Ni" wrote: > Hi all, > > Is there anyone knows the APIS which can get system resolution > and dpi? See http://wayland.freedesktop.org/docs/html/protocol-spec-interface-wl_output.html You get the physical size of the output, and are no

Re: [PATCH] Use pixman_region32_clear instead of our own empty_region

2014-06-26 Thread Pekka Paalanen
On Thu, 26 Jun 2014 11:16:12 -0700 Jason Ekstrand wrote: > This requires pixman 0.25.2 > --- > clients/nested.c | 9 + > configure.ac | 2 +- > src/compositor.c | 15 --- > src/data-device.c | 11 ++- > 4 files changed, 8 insertions(+), 29 deletions(-) > > d

Re: wl_tablet specification draft

2014-06-26 Thread Ping Cheng
On Thursday, June 26, 2014, Peter Hutterer wrote: > On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: > > Hi, > > > > it seems you forgot to reply-to-all, so I have re-added everyone and > > not trimmed the quotation. > > > > On Wed, 25 Jun 2014 18:37:08 -0400 > > Lyude > wrote: > >

[PATCH libinput] Add functions to get the device name, PID and VID

2014-06-26 Thread Peter Hutterer
Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer --- src/evdev.c| 18 ++ src/evdev.h| 9 + src/libinput.c | 18 ++ src/libinput.h | 34 ++

Re: Comments about adding tablet support to Wayland

2014-06-26 Thread Jason Gerecke
On Wed, Jun 25, 2014 at 5:50 PM, Peter Hutterer wrote: > Replying to three emails at once here to keep the thread a bit more > managable. > > On Wed, Jun 25, 2014 at 01:38:22PM -0700, Jason Gerecke wrote: >> On Wed, Jun 25, 2014 at 12:38 AM, Lyude wrote: >> > On Wed, 2014-06-25 at 11:06 +0400, Dm

what are the wayland's APIS can get system resolution and dpi

2014-06-26 Thread Jacky (ZhiJun) Ni
Hi all, Is there anyone knows the APIS which can get system resolution and dpi? Normally, I use the following APIS to get them on X11: XOpenDisplay(),DisplayWidth(),DisplayHeight(),DisplayWidthMM(),DisplayHe ightMM(),XCloseDisplay() Best Regards, Jacky Ni CONFIDENT

Re: wl_tablet specification draft

2014-06-26 Thread Jason Gerecke
On Thu, Jun 26, 2014 at 12:12 AM, Peter Hutterer wrote: > On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: >> Hi, >> >> it seems you forgot to reply-to-all, so I have re-added everyone and >> not trimmed the quotation. >> >> On Wed, 25 Jun 2014 18:37:08 -0400 >> Lyude wrote: >> >>

Re: [PATCH libinput v2 5/5] tablet: Include axes with all events

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:52PM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul Reviewed-by: Peter Hutterer with the &foo -> foo changes in the memcpy. Cheers, Peter > --- > src/evdev-tablet.c | 11 +-- > src/libinput-private.h | 7 +-- > src/

Re: [PATCH libinput 4/5] tablet: copy the axis state into the tablet event

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:51PM -0400, Stephen Chandler Paul wrote: > From: Peter Hutterer > > The tablet state updates with each event during libinput_dispatch(), but the > state in the event must reflect the state at the time of the event. > > Signed-off-by: Peter Hutterer > Signed-off-by:

Re: [PATCH libinput 4/5] tablet: copy the axis state into the tablet event

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:51PM -0400, Stephen Chandler Paul wrote: > From: Peter Hutterer > > The tablet state updates with each event during libinput_dispatch(), but the > state in the event must reflect the state at the time of the event. > > Signed-off-by: Peter Hutterer > Signed-off-by:

Re: [PATCH libinput 2/5] tablet: Remove tablet_notify_tool() and add tablet_get_tool()

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:49PM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul Having a hard time spotting what the changes are in this patch, this looks to be almost the same patch as the previous patch "[PATCH libinput 2/3] tablet: Replace tool-update with prox

Re: [PATCH libinput v3 1/5] tablet: Stop redundant proximity-out events from being reported

2014-06-26 Thread Peter Hutterer
On Fri, Jun 27, 2014 at 09:00:21AM +1000, Peter Hutterer wrote: > On Thu, Jun 26, 2014 at 06:02:48PM -0400, Stephen Chandler Paul wrote: > > Because bad distance events still trigger calls to tablet_flush(), > > tablet_flush() will see that the tablet is out of proximity and assume it's > > an > >

Re: [PATCH libinput v3 1/5] tablet: Stop redundant proximity-out events from being reported

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 06:02:48PM -0400, Stephen Chandler Paul wrote: > Because bad distance events still trigger calls to tablet_flush(), > tablet_flush() will see that the tablet is out of proximity and assume it's an > appropriate time to send a proximity-out event, even when we've already sent

[PATCH libinput v3 1/5] tablet: Stop redundant proximity-out events from being reported

2014-06-26 Thread Stephen Chandler Paul
Because bad distance events still trigger calls to tablet_flush(), tablet_flush() will see that the tablet is out of proximity and assume it's an appropriate time to send a proximity-out event, even when we've already sent one. This results in multiple proximity-out events being sent in a row inste

[PATCH libinput 4/5] tablet: copy the axis state into the tablet event

2014-06-26 Thread Stephen Chandler Paul
From: Peter Hutterer The tablet state updates with each event during libinput_dispatch(), but the state in the event must reflect the state at the time of the event. Signed-off-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul --- src/libinput.c | 5 ++-- test/tablet.c | 83 ++

[PATCH libinput v2 5/5] tablet: Include axes with all events

2014-06-26 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/evdev-tablet.c | 11 +-- src/libinput-private.h | 7 +-- src/libinput.c | 14 -- src/libinput.h | 3 --- 4 files changed, 26 insertions(+), 9 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet

[PATCH libinput v2 3/5] tablet: Include tool with all events

2014-06-26 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul Reviewed-by: Peter Hutterer --- src/evdev-tablet.c | 41 ++--- src/evdev-tablet.h | 13 ++--- src/libinput-private.h | 5 - src/libinput.c | 10 -- src/libinput.h | 19 +++---

[PATCH libinput 2/5] tablet: Remove tablet_notify_tool() and add tablet_get_tool()

2014-06-26 Thread Stephen Chandler Paul
Signed-off-by: Stephen Chandler Paul --- src/evdev-tablet.c | 50 ++ src/evdev-tablet.h | 3 ++- src/libinput-private.h | 6 +++--- src/libinput.c | 28 ++-- src/libinput.h | 27 ++---

Re: [PATCH] Use pixman_region32_clear instead of our own empty_region

2014-06-26 Thread Jasper St. Pierre
Looks good. Reviewed-by: Jasper St. Pierre On Thu, Jun 26, 2014 at 2:16 PM, Jason Ekstrand wrote: > This requires pixman 0.25.2 > --- > clients/nested.c | 9 + > configure.ac | 2 +- > src/compositor.c | 15 --- > src/data-device.c | 11 ++- > 4 files cha

[PATCH v2 1/3] Move weston_subsurface to after weston_surface

2014-06-26 Thread Jason Ekstrand
From: Jason Ekstrand It makes more sense there. Signed-off-by: Jason Ekstrand --- src/compositor.h | 102 +++ 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index eae1b20..06f8b03 100644 --

[PATCH v2 3/3] Create a weston_surface_state structure for storing pending surface state and move the surface commit logic into weston_surface_commit_state

2014-06-26 Thread Jason Ekstrand
From: Jason Ekstrand This new structure is used for both weston_surface.pending and weston_subsurface.cached. Signed-off-by: Jason Ekstrand --- src/compositor.c | 270 +++ src/compositor.h | 80 +++-- 2 files changed, 142 inserti

[PATCH v2 2/3] Move weston_frame_callback above weston_surface_create

2014-06-26 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compositor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index fa8730f..4ccae79 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -384,6 +384,11 @@ weston_view_create(struct weston_s

[PATCH] Use pixman_region32_clear instead of our own empty_region

2014-06-26 Thread Jason Ekstrand
This requires pixman 0.25.2 --- clients/nested.c | 9 + configure.ac | 2 +- src/compositor.c | 15 --- src/data-device.c | 11 ++- 4 files changed, 8 insertions(+), 29 deletions(-) diff --git a/clients/nested.c b/clients/nested.c index 44389e4..2a952be 100644

Re: Candidates for Weston 1.5 stable branch

2014-06-26 Thread Andrew Wedgbury
Hi Pekka, On Thu, 26 Jun 2014, Pekka Paalanen wrote: I agree with Jason, and I'm not picking it in this batch. I didn't even mean to do a 1.5.1 release either, just picking up some of the obviously-stable-material patches from master while I am doing that picking anyway for my own purposes. We

[PATCH weston] screen-share: Add screen-share command to weston.ini man page

2014-06-26 Thread Andrew Wedgbury
This adds a description of the screen-share command configuration key to the weston.ini man page. Signed-off-by: Andrew Wedgbury --- man/weston.ini.man | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/weston.ini.man b/man/weston.ini.man index 667f70a..86f7e37 100644 --- a/man

Re: [PATCH weston 2/2] Create a weston_surface_state structure for storing pending surface state and move the surface commit logic into weston_surface_commit_state

2014-06-26 Thread Pekka Paalanen
On Fri, 20 Jun 2014 17:25:43 -0700 Jason Ekstrand wrote: > From: Jason Ekstrand > > This new structure is used for both weston_surface.pending and > weston_subsurface.cached. > > Signed-off-by: Jason Ekstrand > --- > src/compositor.c | 151 > +++--

Re: [PATCH weston v2] shell: fix segfault in fullscreen binding

2014-06-26 Thread Pekka Paalanen
On Thu, 26 Jun 2014 10:19:32 +0800 Boyan Ding wrote: > Commit 9aa8ce69 forgot to set shsurf->fullscreen_output in > fullscreen_binding(), causing segfault when fullscreening using key > bindings. This patch fixes that. > > https://bugs.freedesktop.org/show_bug.cgi?id=79828 > Signed-off-by: Boyan

RE: Candidates for Weston 1.5 stable branch

2014-06-26 Thread Srivardhan
> -Original Message- > From: wayland-devel [mailto:wayland-devel- > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen > Sent: Thursday, June 26, 2014 12:35 PM > To: Srivardhan > Cc: 'Kristian Høgsberg'; wayland-devel@lists.freedesktop.org > Subject: Re: Candidates for Weston 1.5

Re: [PATCH libinput v2] tablet: Include axes with all events

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:39:09AM -0400, Stephen Chandler Paul wrote: > Forgot to update the documentation for libinput_event_tablet_get_axis(), fixed > > Signed-off-by: Stephen Chandler Paul I have a patch in my tree here that I want to merge before this one: This code below is buggy (as is t

[PATCH libinput] tablet: copy the axis state into the tablet event

2014-06-26 Thread Peter Hutterer
The tablet state updates with each event during libinput_dispatch(), but the state in the event must reflect the state at the time of the event. Signed-off-by: Peter Hutterer --- src/libinput.c | 4 +-- test/tablet.c | 83 ++ 2 files chan

Re: [PATCH libinput 3/5] tablet: Include tool with all events

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:31:20AM -0400, Stephen Chandler Paul wrote: [...] diff --git a/src/libinput.h b/src/libinput.h > index 49162dd..c6a361c 100644 > --- a/src/libinput.h > +++ b/src/libinput.h > @@ -918,19 +918,14 @@ libinput_event_tablet_get_y_transformed(struct > libinput_event_tablet

Re: [PATCH libinput 4/5] tablet: remove libinput_tool_(un)ref()

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:31:21AM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul sorry, this must've been a misunderstanding on IRC: I didn't mean remove those - I was referring to we don't need the ref/unref when adding the tool to the other tablet events. what we

Re: [PATCH libinput v2 2/5] tablet: Replace tool-update with proximity-in

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 02:31:19AM -0400, Stephen Chandler Paul wrote: > A proximity-in event is something we want, especially since the current > drafted > wayland spec has a proximity-in event. Adding this also makes our events more > consistent. And since we can just report the current tool in

Re: wl_tablet specification draft

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 09:48:37AM +0300, Pekka Paalanen wrote: > Hi, > > it seems you forgot to reply-to-all, so I have re-added everyone and > not trimmed the quotation. > > On Wed, 25 Jun 2014 18:37:08 -0400 > Lyude wrote: > > > On Wed, 2014-06-25 at 15:19 +0300, Pekka Paalanen wrote: > > >

Re: Candidates for Weston 1.5 stable branch

2014-06-26 Thread Pekka Paalanen
On Wed, 25 Jun 2014 09:06:55 -0700 Jason Ekstrand wrote: > On Wed, Jun 25, 2014 at 8:29 AM, Andrew Wedgbury < > andrew.wedgb...@realvnc.com> wrote: > > > Hi Pekka, > > > > Would there be any chance of including this patch of mine: > > http://lists.freedesktop.org/archives/wayland-devel/2014-May/

Re: Candidates for Weston 1.5 stable branch

2014-06-26 Thread Pekka Paalanen
On Thu, 26 Jun 2014 11:10:02 +0530 Srivardhan wrote: > > > > -Original Message- > > From: wayland-devel [mailto:wayland-devel- > > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen > > Sent: Wednesday, June 25, 2014 7:14 PM > > To: wayland-devel@lists.freedesktop.org; Kristian

Re: wl_tablet specification draft

2014-06-26 Thread Peter Hutterer
On Thu, Jun 26, 2014 at 09:23:51AM +0300, Pekka Paalanen wrote: > On Thu, 26 Jun 2014 14:14:33 +1000 > Peter Hutterer wrote: [...] > > > >good point, thanks! > > > >>> - Name: time > > > >>> Type: uint > > > >>> The time of the event with millisecond granularity. > >