Re: [PATCH weston] Require libinput 0.4.0

On Wed, Jun 25, 2014 at 02:07:36PM +1000, Peter Hutterer wrote: > No functional changes, just adjusting for API changes in libinput: > - libinput_destroy() replaced by libinput_unref() > - log functions now take a libinput context, userdata is gone > - udev seat creation is now libinput_udev_create

Re: [ANNOUNCE] libinput 0.4.0

Yeah Peter, I know how to apply a patch and no, I don't have any of them in my inbox, that's why I've asked what was wrong in my process ... right now I'm on Gmail in chrome and wayland-devel channel and zero attachment whatsoever. Best Regards On Tue, Jun 24, 2014 at 11:33 PM, Peter Hutterer w

Re: [ANNOUNCE] libinput 0.4.0

On Tue, Jun 24, 2014 at 11:25:51PM -0700, Andrea Giammarchi wrote: > 1. Thanks! :-) > > 2. how is this "git patches via email" is working for you, folks? It > happens to be in a terminal from time to time and curl -O part of a thread, > clean up patch part, and apply it ain't usually the fastest w

[PATCH libinput 1/3] tablet: Stop redundant proximity-out events from being reported

Because bad distance events still trigger calls to tablet_flush(), tablet_flush() will see that the tablet is out of proximity and assume it's an appropriate time to send a proximity-out event, even when we've already sent one. This results in multiple proximity-out events being sent in a row inste

[PATCH libinput 3/3] tablet: Fix warnings in test/tablet.c

Signed-off-by: Stephen Chandler Paul --- test/tablet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/tablet.c b/test/tablet.c index 0f0728e..105a216 100644 --- a/test/tablet.c +++ b/test/tablet.c @@ -550,7 +550,7 @@ START_TEST(pad_buttons_ignored) }

[PATCH libinput 2/3] tablet: Replace tool-update with proximity-in

A proximity-in event is something we want, especially since the current drafted wayland spec has a proximity-in event. Adding this also makes our events more consistent. And since we can just report the current tool in use with proximity-in events, we can get rid of the tool-update event. Signed-o

Re: [ANNOUNCE] libinput 0.4.0

1. Thanks! :-) 2. how is this "git patches via email" is working for you, folks? It happens to be in a terminal from time to time and curl -O part of a thread, clean up patch part, and apply it ain't usually the fastest way to try one ... how many things am I missing in this process? how do you ap

Re: [ANNOUNCE] libinput 0.4.0

On Tue, Jun 24, 2014 at 11:11:41PM -0700, Andrea Giammarchi wrote: > 1. congratulations! > > 2. I cannot build weston anymore, it complained about the RPI backend > compositor first, and now it's complaining about the udev_input_destroy, > libinput-seat, and a bounce of other stuff Patch for west

Re: [ANNOUNCE] libinput 0.4.0

1. congratulations! 2. I cannot build weston anymore, it complained about the RPI backend compositor first, and now it's complaining about the udev_input_destroy, libinput-seat, and a bounce of other stuff I'm on an Intel laptop that built weston on "pure wayland" 'till yesterday, any idea what c

Re: [PATCH weston] shell: fix segfault in fullscreen binding

On Tue, 2014-06-24 at 21:40 -0700, Jason Ekstrand wrote: > Yes we should fix this. I have one question below. Actually I'm not very sure about that either, maybe we should ask @Jasper for suggestion. > > On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote: > Commit 9aa8ce69 'shell: Don't u

Re: [PATCH weston] shell: fix segfault in fullscreen binding

Yes we should fix this. I have one question below. On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote: > Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell > implementations' forgot to set shsurf->fullscreen_optput in > fullscreen_binding(), causing weston to segfault when fullscr

[PATCH] data-device: Clean up the logic in start_drag

Previoiusly, we had a mess of logic that was repeated with one of the repeats negated. Not only was this unnecisaraly confusing, but it segfaulted and one of the negations was wrong. This cleans the whole mess up and should fix bug #79725. --- src/data-device.c | 30 -

[PATCH weston] Require libinput 0.4.0

No functional changes, just adjusting for API changes in libinput: - libinput_destroy() replaced by libinput_unref() - log functions now take a libinput context, userdata is gone - udev seat creation is now libinput_udev_create_context() and libinput_udev_assign_seat() Signed-off-by: Peter Hutte

[ANNOUNCE] libinput 0.4.0

A new release of libinput, 0.4, is available. There are a number of API breaks in this version, every user of libinput will need some changes, sorry. * The logging system now works per-context instead of per library and dropped the userdata argument. * libinput_destroy() was changed to libinput

[PATCH 0/3] weston compositor-drm.c: remove 64x64 cursor restriction

Hi, On some GPUs (like AMD Kaveri), mouse cursor gets corrupted, because 64x64 cursor size is assumed. This restriction was removed on mesa gbm, which now exports GBM_BO_USE_CURSOR. These patches depend on that gbm fix, but have a fallback for previous mesa versions. More details on bugzill

[PATCH 2/3] Init cursor size to 64x64 if drmGetCap() fails.

Signed-off-by: Alvaro Fernando García --- src/compositor-drm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 4d23b7c..3c455bf 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1310,10 +1310,14 @@ init_drm(struct drm_compos

[PATCH 1/3] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

Signed-off-by: Alvaro Fernando García --- src/compositor-drm.c | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 7d514e4..4d23b7c 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @

[PATCH 3/3] Use Mesa GBM_BO_USE_CURSOR define (which removes 64x64 restriction)

Signed-off-by: Alvaro Fernando García --- src/compositor-drm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 3c455bf..61ddea1 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1577,9 +1577,13 @@ drm_output_init_egl(struct

Re: [PATCH libinput] touchpad: Fix typo in documentation

On Tue, Jun 24, 2014 at 06:55:25PM -0400, Stephen Chandler Paul wrote: > "a a left and…"->"a left and…" > > Signed-off-by: Stephen Chandler Paul merged, thanks. Cheers, Peter > --- > src/libinput.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libinput.h b/s

wl_tablet specification draft

Hello! As you all know I've been working on adding drawing tablet support to the Wayland protocol. Now that we've added support for tablets to libinput, the next step is writing the actual protocol that will be implemented by the compositor. Following this blurb is the current draft of the tablet p

Re: [PATCH libinput 5/5] timer: Complain if a timer is set more then 5 seconds from now

On Tue, Jun 24, 2014 at 04:23:13PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede Did some minor changes before merging: * two typos fixed s/then/than/ in 2/5 and this one * adding timer->libinput as first arg to log_* in this patch, I merged it on top of the per-context log handler

Re: [PATCH libinput 1/3] Make ref count unref/ref() functions return resulting object pointer

On Wed, Jun 25, 2014 at 12:06:57AM +0200, Jonas Ådahl wrote: > In order to know if an unref() destroyed an object and to allow more > convenient use of ref(), make both functions return a pointer to the > object it was passed, or NULL if that object was destroyed. > > Signed-off-by: Jonas Ådahl >

[PATCH libinput] touchpad: Fix typo in documentation

"a a left and…"->"a left and…" Signed-off-by: Stephen Chandler Paul --- src/libinput.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.h b/src/libinput.h index b1b1124..a928b2b 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -49,7 +49,7 @@ extern "C" { *

[PATCH libinput v2 2/3] Make context reference counted

Instead of only allowing one owner keeping a libinput context alive, make context reference counted, replacing libinput_destroy() with libinput_unref() while adding another function libinput_ref(). Even though there might not be any current use cases, it doesn't mean we should hard code this usage

[PATCH libinput 1/3] Make ref count unref/ref() functions return resulting object pointer

In order to know if an unref() destroyed an object and to allow more convenient use of ref(), make both functions return a pointer to the object it was passed, or NULL if that object was destroyed. Signed-off-by: Jonas Ådahl --- See patch 2 in this series for context. Jonas src/libinput.c

[PATCH libinput v2 3/3] test: Add context reference counting test

This test relies on valgrind detecting the leak and use-after-free. Signed-off-by: Jonas Ådahl --- Changes since v1: Assert return value sanity. test/misc.c | 20 1 file changed, 20 insertions(+) diff --git a/test/misc.c b/test/misc.c index ad2e1f6..bea7e88 100644 --- a/

Re: [PATCH weston] Clients: Fix memleak issues in various clients of weston

Sorry it got lost. I just pushed it. -- Jason Ekstrand On Mon, Jun 23, 2014 at 2:00 AM, Vivek Ellur wrote: > Hi All, > > I had submitted this patch last month. It was reviewed but still not > merged. > I also checked the patch with the latest code, its working fine. Do I need > to make any fur

Re: [PATCH] xdg-shell: Fix a typo in description

Thanks, Committed. On 06/22/2014 07:51 PM, Boyan Ding wrote: Signed-off-by: Boyan Ding --- protocol/xdg-shell.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index 28add40..0327f40 100644 --- a/protocol/xdg-shell.xml +++

[PATCH libinput 2/5] touchpad: Avoid spurious motion event for scroll movement below threshold

If the user puts down to fingers to scroll, then changes his mind and lifts them, without having them moved past the initial scroll threshold in either direction, then any movement which he has done will cause a spurious scroll event when the second finger down is lifted first. The problem is that

[PATCH libinput 3/5] tp_post_twofinger_scroll: Move setting of t->is_pointer = false up a bit

There is no need to loop over the touch points twice. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 04ea93c..ced9237 100644 --- a/src/evdev-mt-touchpad.c +

[PATCH libinput 4/5] test: Prefix litest created device names with litest

And add an example xorg.conf.d .conf file for ignoring these devices under xorg. Signed-off-by: Hans de Goede --- test/50-litest.conf | 6 ++ test/litest.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 test/50-litest.conf diff --git a/test/50-litest.con

[PATCH libinput 5/5] timer: Complain if a timer is set more then 5 seconds from now

Signed-off-by: Hans de Goede --- src/timer.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/timer.c b/src/timer.c index 65fdd17..4f465f3 100644 --- a/src/timer.c +++ b/src/timer.c @@ -22,6 +22,7 @@ #include #include +#include #include #include #include @@ -6

[PATCH libinput 1/5] test: Add touchpad 2 finger scroll test

Signed-off-by: Hans de Goede --- test/touchpad.c | 78 + 1 file changed, 78 insertions(+) diff --git a/test/touchpad.c b/test/touchpad.c index 7350c21..585c1d2 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -1072,6 +1072,82 @@ START_