Re: [PATCH libinput 00/23] Revised: Tablet support in libinput

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:21PM -0400, Stephen Chandler Paul wrote: > Hello! I've done a ton of revisions and changes to the patches Carlos sent > a little while ago to add tablet support to libinput. Feel free to let me > know what you think. Thanks for all this work, much appreciated. Any pat

Re: [PATCH libinput 07/23] Emit LIBINPUT_EVENT_TABLET_PROXIMITY_OUT when tool leaves proximity

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:28PM -0400, Stephen Chandler Paul wrote: > This event is just used to notify the caller when the tool's no longer in > proximity. When an event like this occurs, everything from evdev up until the > next EV_SYN event is discarded along with any events that occured sinc

Re: [PATCH libinput] tablet: Handle button-events

2014-06-15 Thread Peter Hutterer
On Fri, Jun 13, 2014 at 04:27:49AM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul > --- > src/evdev-tablet.c | 113 > + > src/evdev-tablet.h | 12 +- > src/libinput-private.h | 5 +++ > src/libinput.c

Re: [PATCH libinput 22/23] test: Add bad-distance-events test

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:43PM -0400, Stephen Chandler Paul wrote: > There's a special distance on wacom tablets where the stylus is close enough > to > be (sort of) recongnized by the tablet, but not close enough to send any > useful > data. When the pen's in this distance, it will send a di

Re: [PATCH libinput 12/23] Sanitize distance and pressure axes before reporting their values

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:33PM -0400, Stephen Chandler Paul wrote: > This commit changes two things with the way distance and pressure axes are > reported: > 1. Distance and pressure are made mutually exclusive. When there is a distance >event and a pressure event and the tool is in contact

Re: [PATCH libinput 20/23] test: Add proximity-in-out and proximity-out-clear-buttons tests

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:41PM -0400, Stephen Chandler Paul wrote: > This tests to make sure proximity events actually work, that they don't output > cooirdinate events after they occur, and that they make sure to release all of > the buttons and clear the values of all the axes > > Based off

Re: [PATCH libinput 21/23] test: Add motion event test for tablets

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:42PM -0400, Stephen Chandler Paul wrote: > Based off the patch originally written by Carlos Garnacho > > Signed-off-by: Stephen Chandler Paul > --- > test/tablet.c | 65 > ++- > 1 file changed, 64 insertions(+

Re: "broken" weston - please define WL_SURFACE_ERROR_INVALID_TRANSFORM and WL_SURFACE_ERROR_INVALID_SCALE

2014-06-15 Thread Pekka Paalanen
On Sat, 14 Jun 2014 06:51:00 -0600 James Feeney wrote: > Hey Jonny and Pekka > > So, you know you "broke" the Weston build with that commit 2014-06-03 06:19:20 > (GMT), yes? It use to build just fine... > > --- > src/compositor.c: In function ‘surface_set_buffer_transform’: > src/compositor.c:

Re: [PATCH libinput] Emit LIBINPUT_TABLET_EVENT_TOOL_UPDATE events on tool changes

2014-06-15 Thread Peter Hutterer
On Fri, Jun 13, 2014 at 04:23:19AM -0400, Stephen Chandler Paul wrote: > V2 of this patch. There was a big change I was supposed to apply to this > before > I sent it out that completely slipped my mind until just now. This causes a > merge conflict with the patch for handling tablet buttons so I'

Re: [PATCH libinput 02/23] evdev: Add basic support for tablet devices

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:23PM -0400, Stephen Chandler Paul wrote: > These devices set the LIBINPUT_DEVICE_CAP_STYLUS flag, and emit a lot more > axis s/STYLUS/TABLET/ > information then mice and touchpads. As such, tablet events are in a whole new > group of events that is separate from eve

Re: [PATCH libinput 03/23] tools: handle TABLET_EVENT_AXIS in event-debug

2014-06-15 Thread Peter Hutterer
On Thu, Jun 12, 2014 at 11:28:24PM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul > Reviewed-by: Peter Hutterer > --- > tools/event-debug.c | 38 -- > 1 file changed, 36 insertions(+), 2 deletions(-) > > diff --git a/tools/event-de