Re: [PATCH weston] Clients: Fix memleak issues in various clients of weston

On Thu, May 15, 2014 at 06:58:16PM +0530, vivek wrote: > In many clients of weston, Display was not being destroyed so added it. > Also destroy windows, widgets which were not being destroyed. > > Signed-off-by: vivek LGTM Reviewed-by: Bryce Harrington > --- > clients/cliptest.c| 13 ++

[PATCH libinput 3/3] evdev-mt-touchpad-tap: Switch over to new timer subsystem

Signed-off-by: Hans de Goede Reviewed-by: Peter Hutterer --- src/evdev-mt-touchpad-tap.c | 76 ++--- src/evdev-mt-touchpad.c | 1 - src/evdev-mt-touchpad.h | 7 + 3 files changed, 10 insertions(+), 74 deletions(-) diff --git a/src/evdev-mt-t

[PATCH libinput 1/3] Add a timer subsystem

Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout per touch, which means that if a timeout is set for 100ms from now for touch 1, and then 50 ms later touch 2 sets a

[PATCH libinput 0/3] Add a timer subsystem series v2

Hi, Here is v2 of my timer subsystem series with all the review comments fixed. Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput 2/3] evdev-mt-touchpad-buttons: Switch over to new timer subsystem

Besides being a nice cleanup, this gives us proper per touch timeouts. Signed-off-by: Hans de Goede Reviewed-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 95 + src/evdev-mt-touchpad.c | 3 +- src/evdev-mt-touchpad.h | 9 ++--

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 05:40 AM, Peter Hutterer wrote: > On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: >> Currently we are using DIY timers in the touchpad softbutton and tap handling >> code, and at least the softbutton code gets its wrong. It uses one timer-fd >> per touchpad to set

Re: [PATCH libinput 1/3] Add a timer subsystem

Hi, On 06/05/2014 12:18 AM, Jonas Ådahl wrote: > On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: >> Currently we are using DIY timers in the touchpad softbutton and tap handling >> code, and at least the softbutton code gets its wrong. It uses one timer-fd >> per touchpad to set a t

[PATCH weston] fix SIGSEGV in Weston data_device_start_drag() during, weston-dnd

Hi, This is a trivial fix for SIGSEGV described in https://bugs.freedesktop.org/show_bug.cgi?id=79725 occurring due to null pointer dereference. Currently I do not have enough knowledge about the protocol itself to be certain if this is not a deeper bug down the line requiring an assertion he

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

Hi, On 06/04/2014 10:57 PM, Jonas Ådahl wrote: > On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: >> Hi, >> >> On 06/03/2014 07:34 AM, Peter Hutterer wrote: >>> Now that we have run-time changes of the tap.enabled state move the check >>> to the IDLE state only. Otherwise the tap mac

Re: [PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

On Tue, 3 Jun 2014 10:03:57 +0300 Pekka Paalanen wrote: > On Fri, 30 May 2014 12:08:16 +0200 > Jonny Lamb wrote: > > > --- > > protocol/wayland.xml | 15 +++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > > index 3091d83..95

Maximizing window after fullscreening it in weston desktop shell

The handling about window states has been improved recently but there still seems some problem with that. When I was running weston-stacking with yesterday's snapshot of weston (weston-stacking in 1.5.0 is much more troublesome), I found if I press m (maximize) multiple times after fullscreeni