Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-25 Thread Peter Hutterer
On Mon, May 26, 2014 at 08:21:35AM +0200, Jonas Ådahl wrote: > On Mon, May 26, 2014 at 03:34:46PM +1000, Peter Hutterer wrote: > > On Fri, May 23, 2014 at 05:27:25PM +0200, Jonas Ådahl wrote: > > > On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 05/23/

Re: [PATCH libinput] evdev: don't post a relative motion event for dx/dy 0/0

2014-05-25 Thread Peter Hutterer
On Mon, May 26, 2014 at 08:27:54AM +0200, Jonas Ådahl wrote: > On Mon, May 26, 2014 at 03:41:33PM +1000, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > src/evdev.c | 10 ++ > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/src/evdev.c b/src/evd

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-25 Thread Hans de Goede
Hi, On 05/25/2014 02:13 PM, Jonas Ådahl wrote: > On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: >> Setting tp->scroll.direction = 0 before checking tp->scroll.direction >> to see if we need to send stop scroll events for vert / horz scrolling does >> not really work well. >> >> Als

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-25 Thread Hans de Goede
Hi, On 05/25/2014 10:34 AM, Jonas Ådahl wrote: > On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: >> We pin scrolling to the initial direction, so a 2 finger scroll starting >> in the vertical direction, will from then on only generate vertical scroll >> events, and the same for hori

Re: [PATCH libinput] evdev: don't post a relative motion event for dx/dy 0/0

2014-05-25 Thread Jonas Ådahl
On Mon, May 26, 2014 at 03:41:33PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/evdev.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/evdev.c b/src/evdev.c > index fedc324..6aa0d46 100644 > --- a/src/evdev.c > +++ b/src/evdev.

Re: [PATCH wayland-web 7/7] Description of requirements not exactly right, DRI2 not needed in most cases

2014-05-25 Thread Pekka Paalanen
On Fri, 23 May 2014 18:54:39 -0700 Bill Spitzak wrote: > From: Bill Spitzak > > --- > building.html | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/building.html b/building.html > index 7f0c4b4..de721b5 100644 > --- a/building.html > +++ b/b

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-25 Thread Jonas Ådahl
On Mon, May 26, 2014 at 03:34:46PM +1000, Peter Hutterer wrote: > On Fri, May 23, 2014 at 05:27:25PM +0200, Jonas Ådahl wrote: > > On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 05/23/2014 02:57 PM, Jonas Ådahl wrote: > > > > On Fri, May 23, 2014 at 07:22:3

Re: [PATCH wayland-web 1/7] Put a box around all code samples

2014-05-25 Thread Pekka Paalanen
On Sun, 25 May 2014 13:41:08 -0700 Bill Spitzak wrote: > On 05/24/2014 12:45 AM, Pekka Paalanen wrote: > > - --with-xkb-config-root should not be needed, xkeyboard-config > >instead is. > > What is xkeyboard-config, a program I should run? > > I'm also wondering if this is redundant with th

[PATCH libinput] evdev: don't post a relative motion event for dx/dy 0/0

2014-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index fedc324..6aa0d46 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -134,10 +134,12 @@ evdev_flush_pending_event(struct evdev_device *device, ui

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-25 Thread Peter Hutterer
On Fri, May 23, 2014 at 05:27:25PM +0200, Jonas Ådahl wrote: > On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: > > Hi, > > > > On 05/23/2014 02:57 PM, Jonas Ådahl wrote: > > > On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: > > >> It might be better to reply to the p

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Fri, May 23, 2014 at 10:34:10PM -0400, Chandler Paul wrote: > On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: > > I'm almost sold on normalization since it does reduce the likelihood of > > things going wrong. We need to provide the axis resolution to convert back > > to the real data t

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Mon, May 26, 2014 at 02:27:35AM +0200, Carlos Garnacho wrote: > Hey Peter, > > On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: > > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > > Hi, > > > > > > First of all, I'm sorry I dropped the ball this long. It's great to

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Carlos Garnacho
Hey Peter, On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > Hi, > > > > First of all, I'm sorry I dropped the ball this long. It's great to see > > you've been doing some progress. > > > > On jue, 2014-05-22 at 01:17

Re: [PATCH wayland-web 1/7] Put a box around all code samples

2014-05-25 Thread Bill Spitzak
On 05/24/2014 12:45 AM, Pekka Paalanen wrote: On Fri, 23 May 2014 18:57:38 -0700 Bill Spitzak wrote: Not sure what happened here. I tested this and it came out with a header email, with all the patches as replies to it. But when I did it for real the header disappared. Header message: This is

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-25 Thread Jonas Ådahl
On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: > Setting tp->scroll.direction = 0 before checking tp->scroll.direction > to see if we need to send stop scroll events for vert / horz scrolling does > not really work well. > > Also we need to check direction with an axis mask, not th

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-25 Thread Jonas Ådahl
On Fri, May 23, 2014 at 04:06:26PM +0200, Hans de Goede wrote: > We pin scrolling to the initial direction, so a 2 finger scroll starting > in the vertical direction, will from then on only generate vertical scroll > events, and the same for horizontal. > > But if the first 2 finger motion is diag