Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Chandler Paul
On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: > I'm almost sold on normalization since it does reduce the likelihood of > things going wrong. We need to provide the axis resolution to convert back > to the real data though where needed. > > once you provide the axis resolution, it doesn

Re: [PATCH wayland-web 1/7] Put a box around all code samples

2014-05-23 Thread Bill Spitzak
Not sure what happened here. I tested this and it came out with a header email, with all the patches as replies to it. But when I did it for real the header disappared. Header message: This is v4 of this patch. It has been split into several commits, the diffs reduced by avoiding refilling para

[PATCH wayland-web 1/7] Put a box around all code samples

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak --- wayland.css |1 + 1 file changed, 1 insertion(+) diff --git a/wayland.css b/wayland.css index 7f058ba..003732d 100644 --- a/wayland.css +++ b/wayland.css @@ -8,3 +8,4 @@ a { color: #444; } a:hover { color: #888; } a:visited { color: #666; } li { margin: 10px 0px; }

[PATCH wayland-web 7/7] Description of requirements not exactly right, DRI2 not needed in most cases

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak --- building.html | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/building.html b/building.html index 7f0c4b4..de721b5 100644 --- a/building.html +++ b/building.html @@ -26,7 +26,7 @@ fails with "No package 'foo' found" - and how

[PATCH wayland-web 4/7] Added page of Ubuntu12.04 specific directions

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak --- building.html| 18 +++- ubuntu12.04.html | 280 ++ 2 files changed, 294 insertions(+), 4 deletions(-) create mode 100644 ubuntu12.04.html diff --git a/building.html b/building.html index d1eb8ba..1a054a0 100644 -

[PATCH wayland-web 5/7] Added comments about dependencies after each build instruction

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak --- building.html| 84 +++--- ubuntu12.04.html |2 +- xserver.html | 13 + 3 files changed, 75 insertions(+), 24 deletions(-) diff --git a/building.html b/building.html index 1a054a0..18de281 100644 --- a

[PATCH wayland-web 2/7] Simple updates to Weston build instructions

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak - $WLD/bin must be on the path - Put info about system-wide install in one place - Removed drm, libxkbcommon, pixman, cairo as distributed versions are usable nowadays. - Added libinput --- building.html | 162 +++-- 1

[PATCH wayland-web 6/7] Added a 'running weston' chapter

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak Moved $XDG_RUNTIME_DIR next to it. --- building.html| 81 +++--- ubuntu12.04.html |9 ++ 2 files changed, 50 insertions(+), 40 deletions(-) diff --git a/building.html b/building.html index 18de281..7f0c4b4 100644 -

[PATCH wayland-web 3/7] Fixed xserver build instructions

2014-05-23 Thread Bill Spitzak
From: Bill Spitzak - Removed xtrans as it is no different than other dependencies - Added comment from commit message about new configure line - Fix for bug in libepoxy configure --- building.html |2 +- xserver.html | 51 --- 2 files chan

Re: [PATCH weston 1/5] animation: fix move scale animation

2014-05-23 Thread Emilio Pozuelo Monfort
On 22/05/14 22:41, Jonny Lamb wrote: > Both weston_move_scale_run() and weston_slide_run() were broken in > commit 3a869019. Commit a4a6f161 fixed and explained the problem for > weston_slide_run() but weston_move_scale_run() remained broken. > > To fix weston_move_scale_run(), weston_view_animati

[PATCH weston] exposay: fix crash when navigating with the keyboard

2014-05-23 Thread Emilio Pozuelo Monfort
From: Emilio Pozuelo Monfort Commit a7592019 introduced an optimization that caused some exposay struct members to not be properly initialized, particularly cur_output, leading to crashes in some circumstances (e.g. pressing the down arrow key after going to exposay). Signed-off-by: Emilio Pozue

Re: [PATCH] Wrong bo handles can be referenced in func call, drmModeAddFB2 due to uninitialized array elements in handles[4]

2014-05-23 Thread Kim, Dongwon
Kristian, Seems that this change is needed to support the specific case Matt described while not hurting anything in the current application as well. Can you reconsider the patch, please? Thanks, DW On 4/29/14, 3:09 PM, "David Herrmann" wrote: >Hi > >On Tue, Apr 29, 2014 at 10:59 PM, Matt Rop

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-23 Thread Bill Spitzak
On 05/22/2014 09:06 AM, Bill Spitzak wrote: Cairo was included in the guide probably because distributions had varying configurations wrt. enabling GL or GLESv2 support, and because the GL/GLESv2 code was new and in development. If we drop the need for cairo-gl/glesv2, we can drop Cairo and Pixm

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Kristian Høgsberg
On Fri, May 23, 2014 at 2:31 AM, Hardening wrote: > Le 23/05/2014 09:14, Pekka Paalanen a écrit : > >> On Fri, 23 May 2014 03:04:29 -0400 >> "Jasper St. Pierre" wrote: >> >>> On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen >>> wrote: >>> > > [...] > > This is obviously correct. >>

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-23 Thread Jonas Ådahl
On Fri, May 23, 2014 at 04:03:56PM +0200, Hans de Goede wrote: > Hi, > > On 05/23/2014 02:57 PM, Jonas Ådahl wrote: > > On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: > >> It might be better to reply to the patch. This e-mail is liable to be > >> forgotten if the patches sit for

Re: [PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-23 Thread Jasper St. Pierre
Any reason you switched the order of these two if statements around? On Fri, May 23, 2014 at 10:06 AM, Hans de Goede wrote: > We pin scrolling to the initial direction, so a 2 finger scroll starting > in the vertical direction, will from then on only generate vertical scroll > events, and the s

[PATCH libinput 1/6] touchpad: Clear touches being the pointer when doing 2 finger scrolling

2014-05-23 Thread Hans de Goede
When doing 2 finger scrolling we don't want any spurious movement events after scrolling. touchpad_2fg_no_motion tests for this, but it lifts touch 0 (which is the pointer as it came down first) first, so it only catches the case where touch 1 suddenly gets promoted to being the pointer. However i

[PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-23 Thread Hans de Goede
Setting tp->scroll.direction = 0 before checking tp->scroll.direction to see if we need to send stop scroll events for vert / horz scrolling does not really work well. Also we need to check direction with an axis mask, not the axis number. While at it also add a tp_stop_scroll_events() helper fun

[PATCH libinput 6/6] touchpad: Increase 2 finger scrolling threshold

2014-05-23 Thread Hans de Goede
With the one px threshold we can easily end up accidentally locking scrolling to the wrong direction. As an added benefit a larger threshold also reduces the chance of a second finger temporarily coming down causing scrolling to start and the first finger to no longer be seen as the pointer. Sign

[PATCH libinput 5/6] touchpad: Don't allow diagonal scrolling

2014-05-23 Thread Hans de Goede
We pin scrolling to the initial direction, so a 2 finger scroll starting in the vertical direction, will from then on only generate vertical scroll events, and the same for horizontal. But if the first 2 finger motion is diagonal, then we go into a diagonal scrolling mode where we post both horizo

[PATCH libinput 3/6] touchpad: Refactor tp_post_scroll_events()

2014-05-23 Thread Hans de Goede
Put the actual scroll event posting in the straight path. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 2455c36..ed668ee 100644 --- a/src/evdev-mt-touchp

[PATCH libinput 4/6] touchpad: Stop scrolling on a button click / tap

2014-05-23 Thread Hans de Goede
On a button click / tap the scrolling event handler no longer gets called, ensure that any in progress scrolling is stopped. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-23 Thread Hans de Goede
Hi, On 05/23/2014 02:57 PM, Jonas Ådahl wrote: > On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: >> It might be better to reply to the patch. This e-mail is liable to be >> forgotten if the patches sit for very long. >> --Jason Ekstrand >> > > I did see it though and made a menta

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-23 Thread Jonas Ådahl
On Fri, May 23, 2014 at 07:22:38AM -0500, Jason Ekstrand wrote: > It might be better to reply to the patch. This e-mail is liable to be > forgotten if the patches sit for very long. > --Jason Ekstrand > I did see it though and made a mental note about it, so I will look into why it makes some te

Re: [PATCH weston] comp-wayland: use safe foreach when destroying outputs

2014-05-23 Thread Jason Ekstrand
To be honest, I don't think I looked at the other backends too much when writing the wayland backend. I guess cleaning up myself seemed like a good idea at the time. I don't think it really matters; having it in shutdown just lets backends be lazy. --Jason On Fri, May 23, 2014 at 2:03 AM, Pekka

Re: "Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-23 Thread Jason Ekstrand
It might be better to reply to the patch. This e-mail is liable to be forgotten if the patches sit for very long. --Jason Ekstrand On Fri, May 23, 2014 at 7:00 AM, Hans de Goede wrote: > Hi All, > > I've picked Jonas' 2 mouse accel patches into my local tree, and > noticed $subject. This shoul

"Add basic mouse pointer acceleration" libinput patch breaks make check

2014-05-23 Thread Hans de Goede
Hi All, I've picked Jonas' 2 mouse accel patches into my local tree, and noticed $subject. This should be fixed before these patches get merged. Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.o

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Hardening
Le 23/05/2014 09:14, Pekka Paalanen a écrit : On Fri, 23 May 2014 03:04:29 -0400 "Jasper St. Pierre" wrote: On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen wrote: [...] This is obviously correct. Can I push this, or shall we reserve the right to push to libwayland for Kristian only, ev

Re: [PATCH weston] comp-wayland: use safe foreach when destroying outputs

2014-05-23 Thread Pekka Paalanen
On Fri, 23 May 2014 10:03:00 +0300 Pekka Paalanen wrote: > On Wed, 21 May 2014 09:20:02 -0700 > "U. Artie Eoff" wrote: > > > wl_list_for_each dereference's output to increment the > > next iteration of the loop. However, output is free'd > > inside the loop resulting in a dereference to free'd

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-23 Thread Thierry Reding
On Thu, May 22, 2014 at 09:35:23AM -0700, Bill Spitzak wrote: > On 05/21/2014 03:09 PM, Thierry Reding wrote: > >On Wed, May 21, 2014 at 02:54:36PM -0700, Bill Spitzak wrote: > >>On 05/21/2014 02:16 PM, Thierry Reding wrote: > >> > >>>While I agree with the other points, I think it's perfectly cons

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Pekka Paalanen
On Fri, 23 May 2014 03:04:29 -0400 "Jasper St. Pierre" wrote: > On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen wrote: > > > On Fri, 23 May 2014 07:26:56 +0200 > > Silvan Jegen wrote: > > > > > Signed-off-by: Silvan Jegen > > > --- > > > protocol/wayland.xml | 4 ++-- > > > 1 file changed, 2

Re: [PATCH libinput 2/4] test: restore log priority after each test

2014-05-23 Thread Hans de Goede
Hi, On 05/23/2014 06:37 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > test/log.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/test/log.c b/test/log.c > index 0c5508f..b8cc767 100644 > --- a/test/log.c > +++ b/test/log.c > @@ -74,6 +74,7 @@ END_TEST

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Fri, May 23, 2014 at 01:43:10AM +0200, Carlos Garnacho wrote: [...] > You make a good point with tilt axes below. I think this at least stands > true for ABS_PRESSURE, a device with 1024 possible values doesn't > register 4x as much pressure as a device with 256 values, those are > rather the "

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Jasper St. Pierre
On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen wrote: > On Fri, 23 May 2014 07:26:56 +0200 > Silvan Jegen wrote: > > > Signed-off-by: Silvan Jegen > > --- > > protocol/wayland.xml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/protocol/wayland.xml b/protoco

Re: [PATCH weston] comp-wayland: use safe foreach when destroying outputs

2014-05-23 Thread Pekka Paalanen
On Wed, 21 May 2014 09:20:02 -0700 "U. Artie Eoff" wrote: > wl_list_for_each dereference's output to increment the > next iteration of the loop. However, output is free'd > inside the loop resulting in a dereference to free'd > memory. > > Use wl_list_for_each_safe instead, which is designed to

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Thu, May 22, 2014 at 03:37:44PM -0400, Chandler Paul wrote: > On Thu, 2014-05-22 at 11:17 -0700, Jason Gerecke wrote: > > On Wed, May 21, 2014 at 10:17 PM, Chandler Paul > > wrote: > > > Hi! Sorry this took so long to write, I've been spending a lot of my > > > time recently trying to understa