On Mon, 19 May 2014 20:31:28 -0700
Bill Spitzak wrote:
>
>
> On 05/19/2014 12:39 AM, Pekka Paalanen wrote:
> > On Fri, 16 May 2014 13:43:50 -0700
> > spit...@gmail.com wrote:
> >
> >> From: spitzak
> >>
> >> This is based on several experimental runs on two different
> >> Ubuntu 12.04 machines
Hi pq,
I apply your comment in v5.
I remove several request because it can be handled without request by
identifying it by ivi_id.
I add description more as well.
BR,
Nobuhiko
2014-04-25 18:46 に Pekka Paalanen さんは書きました:
On Mon, 17 Mar 2014 15:27:46 +0900
Nobuhiko Tanibata wrote:
The refe
Hi pq,
I applied your comments except for several ones,
+struct ivi_shell *shell = wl_resource_get_user_data(resource);
+struct ivi_shell_surface *ivisurf = NULL;
+struct weston_layout_surface *layout_surface = NULL;
+struct weston_surface *es =
wl_resource_get_user_data(surfac
Hi,
I apply review comments as v5 except following comments.
+
+struct link_layerPropertyNotification {
+layerPropertyNotificationFunc callback;
+void *userdata;
+struct wl_list link;
+};
+
+struct link_surfacePropertyNotification {
+surfacePropertyNotificationFunc callback;
+
2014-04-23 19:40 に Pekka Paalanen さんは書きました:
Hi,
it's been a long while since I have looked at this, but I got a bit of
time to come back. I hope you haven't abandoned this effort yet. :-)
I looked at the PDF from your post on March 6th, 2014, and some of my
own comments I gave at that time to r
Hi,
I removed binary from patch as review comment.
Image files can be downloaded from,
https://github.com/ntanibata/weston-ivi-shell/tree/weston-ivi-shell-1.4.93-v3/data
BR,
Nobuhiko
2014-05-20 13:30 に Nobuhiko Tanibata さんは書きました:
Signed-off-by: Nobuhiko Tanibata
---
Changes for v2:
- squash
Signed-off-by: Nobuhiko Tanibata
---
Changes for v2, v3 and v4:
- nothing. Version number aligned to the first patch
Changes for v5:
- rebase weston v1.5 branch
- remove Macros to enable ivi-application
Makefile.am | 12 ++--
clients/simple-egl.c | 70 +++
Signed-off-by: Nobuhiko Tanibata
---
Changes for v2:
- squash Makefile to this patch
Changes for v3 and v4:
- nothing. Version number aligned to the first patch
Changes for v5:
- rebase weston v1.5 branch
Makefile.am | 13 +--
ivi-shell/weston.ini.in | 91
Signed-off-by: Nobuhiko Tanibata
---
Changes for v2:
- squash Makefile to this patch
Changes for v3, v4, and v5:
- nothing. Version number aligned to the first patch
data/Makefile.am | 14 +-
data/background.png | Bin 0 -> 245579 bytes
data/fullscreen.png
This is launched from hmi-controller by launch_hmi_client_process and invoke a
client process.
The basic flow is as followed,
1/ process invoked
2/ read configuration from weston.ini.
3/ draw png file to surface according to configuration of weston.ini
4/ all parts of UI are ready. request "UI_rea
This protocol realizes following features,
- UI ready
- changing modes; tiling, side by side, full_screen, and random
- Give control a surface; workspace to be controlled by using ivi layout APIs
- Display/undisplay a surface; home contains sevaral workspaces to launch
application
Signed-off-by:
In-Vehicle Infotainment system traditionally manages surfaces with global
identification. A protocol, ivi_application, supports such a feature by
implementing a request, ivi_application::surface_creation defined in
ivi_application.xml.
The ivi-shell explicitly loads ivi-layout.so and a module to a
ivi_applicatoin extension creates ivi_surface objects tied
to a given wl_surface with a given id. The given id can be used in a
shell to identify which application is assigned to a wl_surface and
layout the surface wherever the shell wants. ivi_surface objects can
be used to receive status of wl_su
2014-04-26 01:05 に Pekka Paalanen さんは書きました:
On Fri, 25 Apr 2014 22:34:27 +0900
Nobuhiko Tanibata wrote:
2014-04-23 19:40 に Pekka Paalanen さんは書きました:
> This is looking good, mostly just some details in the wording
> to be tuned. :-)
>
> I will see if I can review more of the patches, but I would
On 05/19/2014 12:39 AM, Pekka Paalanen wrote:
On Fri, 16 May 2014 13:43:50 -0700
spit...@gmail.com wrote:
From: spitzak
This is based on several experimental runs on two different
Ubuntu 12.04 machines. Latest version includes instructions for
a recent update of Mesa (which requires llvm-3.
On 05/19/2014 12:43 AM, Pekka Paalanen wrote:
Oh, in fact there would be room for quite much of splitting here, like
the -boxing and adding $ to commands could be a separate patch,
and therefore much easier to get in while the rest may still be
discussed.
Changes are to be split into patches ba
Looks good to me.
Reviewed-By: Jason Ekstrand
On Mon, May 19, 2014 at 12:27 PM, Neil Roberts wrote:
> The wl_output.release request is now handled. It just causes the
> resource to be destroyed. This is also set as the destructor when
> zombifying the resource.
> ---
> src/compositor.c | 23
Ooh, I like this. I thought about having wayland-scanner emit more
#defines, but this works rather nicely. One question: do we want it in
wayland-util or wayland-server? Putting it in wayland-util exposes it
client-side as well.
--Jason
On Mon, May 19, 2014 at 12:26 PM, Neil Roberts wrote:
>
Yup, we need this.
Reviewed-By: Jason Ekstrand
On Mon, May 19, 2014 at 12:26 PM, Neil Roberts wrote:
> Outputs can come and go within the compositor. If we don't have a way
> for the client to destroy the resource then the resources within the
> compositor will effectively leak until the clie
One more comment
On Mon, May 19, 2014 at 3:04 PM, Jason Ekstrand wrote:
> Neil,
> Looks good except for the two comments below
> --Jason
>
>
> On Mon, May 19, 2014 at 12:23 PM, Neil Roberts wrote:
>
>> Previously when an output was unplugged the clients' resources for it
>> were left around and
Neil,
Looks good except for the two comments below
--Jason
On Mon, May 19, 2014 at 12:23 PM, Neil Roberts wrote:
> Previously when an output was unplugged the clients' resources for it
> were left around and if they were used in a request it could cause
> Weston to access invalid memory. Now wh
This adds a macro called WL_REQUEST_OPCODE which takes the name of the
struct for the interface and the name of one of its members. It then
calculates the opcode number by dividing the offsetof the member by
the size of a function pointer. This assumes the interface struct only
contains function po
The wl_output.release request is now handled. It just causes the
resource to be destroyed. This is also set as the destructor when
zombifying the resource.
---
src/compositor.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/src/compositor.c b/src/compo
Outputs can come and go within the compositor. If we don't have a way
for the client to destroy the resource then the resources within the
compositor will effectively leak until the client disconnects. This is
similar to the release event for wl_pointer.
---
protocol/wayland.xml | 8 +++-
1 fi
Previously when an output was unplugged the clients' resources for it
were left around and if they were used in a request it could cause
Weston to access invalid memory. Now when an output is unplugged the
resources for it are marked as zombies. This is done by setting a
dummy dispatcher and settin
From: Thierry Reding
This is mostly useless and can be confusing in makefiles. The pattern
rules defined in the makefile snippet are generic enough to allow the
protocol sources to reside in subdirectories.
Signed-off-by: Thierry Reding
---
wayland-scanner.m4 | 2 --
wayland-scanner.mk | 6 +++
From: Thierry Reding
The pkgdatadir variable is used to find data files installed by wayland.
If wayland is installed in a sysroot, the path to this directory needs
to be prefixed with the sysroot to make sure the proper files are found.
${pc_sysrootdir} is expanded to the value of the PKG_CONFI
From: Thierry Reding
When cross-compiling always look up the wayland-scanner binary in the
PATH. Using the value from the wayland-scanner.pc file will not work
because it will point to a binary built for the host.
While trying to find the path of the wayland-scanner makefile snippet,
check that
From: Thierry Reding
When cross-compiling, wayland-scanner cannot be used to generate files
because it is built for the host architecture. To overcome this, users
currently need to instruct the build not to create wayland-scanner and
provide a native variant in the PATH. This has the disadvantage
From: Thierry Reding
To reduce code duplication and make sure it receives at minimum amount
of testing, use the wayland-scanner makefile snippet in this package.
Signed-off-by: Thierry Reding
---
Makefile.am | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/Makefile.a
On Mon, 19 May 2014 15:11:01 +0200
Thierry Reding wrote:
> On Mon, May 19, 2014 at 01:39:24PM +0300, Pekka Paalanen wrote:
> > On Mon, 19 May 2014 11:56:39 +0200 Thierry Reding
> > wrote:
> > > On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote:
> > > > On Sun, 18 May 2014 00:39:16
On Mon, May 19, 2014 at 01:39:24PM +0300, Pekka Paalanen wrote:
> On Mon, 19 May 2014 11:56:39 +0200 Thierry Reding
> wrote:
> > On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote:
> > > On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding
> > > wrote:
[...]
> > > > I think it would fu
On Mon, 19 May 2014 11:56:39 +0200
Thierry Reding wrote:
> On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote:
> > On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding
> > wrote:
> [...]
> > > be made to behave the same way. I think a more appropriate sequence
> > > would be
On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote:
> On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding
> wrote:
[...]
> > One issue here is that if --disable-scanner is specified, then the
> > wayland-scanner binary is neither built nor installed. That doesn't
> > have
This is a fix to the bug https://bugs.freedesktop.org/show_bug.cgi?id=78688.
Signed-off-by: Srivardhan Hebbar
---
Makefile.am |6 +++---
configure.ac | 13 -
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 343adc6..a22fd8d 100644
> -Original Message-
> From: Pekka Paalanen [mailto:ppaala...@gmail.com]
> Sent: Monday, May 19, 2014 2:30 PM
> To: Thierry Reding
> Cc: Srivardhan Hebbar; wayland-devel@lists.freedesktop.org
> Subject: Re: [PATCH v3] configure.ac: Change in build system to use the
path
> from pkg-config
On Sun, 18 May 2014 00:39:16 +0200
Thierry Reding wrote:
> On Fri, May 16, 2014 at 03:43:47PM +0530, Srivardhan Hebbar wrote:
> > This is a fix to the bug https://bugs.freedesktop.org/show_bug.cgi?id=78688.
> >
> > Signed-off-by: Srivardhan Hebbar
> > ---
> > configure.ac | 14 +-
On Mon, 19 May 2014 10:39:54 +0300
Pekka Paalanen wrote:
> On Fri, 16 May 2014 13:43:50 -0700
> spit...@gmail.com wrote:
>
> > From: spitzak
> >
> > This is based on several experimental runs on two different
> > Ubuntu 12.04 machines. Latest version includes instructions for
> > a recent upda
On Fri, 16 May 2014 13:43:50 -0700
spit...@gmail.com wrote:
> From: spitzak
>
> This is based on several experimental runs on two different
> Ubuntu 12.04 machines. Latest version includes instructions for
> a recent update of Mesa (which requires llvm-3.1) and that you
> must compile Cairo to a
39 matches
Mail list logo
